Standardise Qpid concurrency utils by using classes from java.util.concurrent
-
Key: QPID-3024
URL: https://issues.apache.org/jira/browse/QPID-3024
Project: Qpid
[
https://issues.apache.org/jira/browse/QPID-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy reassigned QPID-3024:
Assignee: Andrew Kennedy
Standardise Qpid concurrency utils by using classes from
Upgrade Java test framework to JUnit 4
--
Key: QPID-3025
URL: https://issues.apache.org/jira/browse/QPID-3025
Project: Qpid
Issue Type: Improvement
Reporter: Andrew Kennedy
The ApplicationRegistry object should be a singleton
Key: QPID-3026
URL: https://issues.apache.org/jira/browse/QPID-3026
Project: Qpid
Issue Type: Improvement
Components: Java
Hi Jonathan,
I'd like to zap trailing whitespace from the source files in
our SVN repo.
Does anyone object to me doing this? Do we agree that source files
should not have trailing whitespace?
I agree - I think zapping whitespace is a good idea and would welcome
your efforts to do so.
On Mon, 2011-01-31 at 15:36 -0500, Jonathan Robie wrote:
I'd like to zap trailing whitespace from the source files in our SVN repo.
Does anyone object to me doing this?
Yes I object. This will cause spurious diffs to pretty much every C++
file, and may well cause failed merges.
The diffs will
On 01/31/2011 04:03 PM, Andrew Stitcher wrote:
The way I'd prefer to deal with this is to add a hook to the svn
checkin process (and while we're doing that ban tab characters too;
ban them because there is no way to know how many spaces they
represent universally) which would strip them out of
For the record, I like Andrew's approach better... Hook the svn commit
to check for spaces/tabs.
-Steve
-Original Message-
From: Andrew Stitcher [mailto:astitc...@redhat.com]
Sent: Monday, January 31, 2011 4:03 PM
To: dev@qpid.apache.org
Subject: Re: Zap trailing whitespace?
On Mon, 2011-01-31 at 16:38 -0500, Jonathan Robie wrote:
..
If we do the svn hook, but don't strip trailing whitespace in one
checkin, we get a lot of spurious diffs over a longer period of time,
and they aren't related to the purpose of a given check in.
I think you may be
[
https://issues.apache.org/jira/browse/QPID-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988926#comment-12988926
]
Gordon Sim commented on QPID-3009:
--
Thanks for that suggestion Jose. I've committed a
On 01/31/2011 04:43 PM, Steve Huston wrote:
For the record, I like Andrew's approach better... Hook the svn commit
to check for spaces/tabs.
OK, let me try for consensus around this:
Does anyone object to adding an svn hook that (1) strips trailing
whitespace, and (2) bans commits that
On 01/31/2011 04:53 PM, Andrew Stitcher wrote:
[I'm not against people incrementally tidying up whitespace pollution in
files that they touch beyond whatever changes they make, but I am
objecting to doing it in a massive single checkin]
OK, unless someone gripes, I think I'll keep the emacs
On Mon, 31 Jan 2011, Andrew Stitcher wrote:
[I'm not against people incrementally tidying up whitespace pollution in
files that they touch beyond whatever changes they make, but I am
objecting to doing it in a massive single checkin]
I'm not terribly fond of larding cleanups in with other
-Original Message-
From: Jonathan Robie [mailto:jonathan.ro...@redhat.com]
Sent: Monday, January 31, 2011 5:32 PM
To: dev@qpid.apache.org
Subject: Re: Zap trailing whitespace?
On 01/31/2011 04:53 PM, Andrew Stitcher wrote:
[I'm not against people incrementally tidying up
OK, let me try for consensus around this:
Does anyone object to adding an svn hook that (1) strips trailing
whitespace, and (2) bans commits that contain tabs?
I think I'd rather see the hook refuse to do the commit if there are
trailing whitespace or tabs. On the off chance that svn gets
On Mon, 2011-01-31 at 17:31 -0500, Jonathan Robie wrote:
On 01/31/2011 04:43 PM, Steve Huston wrote:
For the record, I like Andrew's approach better... Hook the svn commit
to check for spaces/tabs.
OK, let me try for consensus around this:
Does anyone object to adding an svn hook that
[
https://issues.apache.org/jira/browse/QPID-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988981#comment-12988981
]
Jose Pedro Oliveira commented on QPID-3009:
---
Gordon,
Thanks for the update. The
How many files are we talking about here?
Yes, spurious trailing-white-space diffs are bad but if there's only 20-30
files then I could live with that.
My bet is that there are way more files with embedded tabs.
I'll vote yes for a hook that flags/complains about a commit with tabs or
18 matches
Mail list logo
