[jira] [Commented] (PROTON-1293) Support username and password in electron go binding

2016-09-20 Thread Alan Conway (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507923#comment-15507923
 ] 

Alan Conway commented on PROTON-1293:
-

For SSL support in Go you should use the standard crypto.tls package to create 
a secure net.Conn. You can set the server-side username from SSL information 
with the User() connection option. To use insecure SASL mechanisms over SSL 
(e.g. PLAIN authentication) specify SASLAllowInsecure()

> Support username and password in electron go binding
> 
>
> Key: PROTON-1293
> URL: https://issues.apache.org/jira/browse/PROTON-1293
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: go-binding
>Affects Versions: 0.15.0
>Reporter: Richard Laos
>Assignee: Alan Conway
>Priority: Minor
> Fix For: 0.15.0
>
>
> It appears that the electron api does not support a username and password as 
> part of an amqp connection. However maybe the example just needs to included 
> this if it is supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1293) Support username and password in electron go binding

2016-09-20 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1293.
-
   Resolution: Fixed
Fix Version/s: 0.15.0

> Support username and password in electron go binding
> 
>
> Key: PROTON-1293
> URL: https://issues.apache.org/jira/browse/PROTON-1293
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: go-binding
>Affects Versions: 0.15.0
>Reporter: Richard Laos
>Assignee: Alan Conway
>Priority: Minor
> Fix For: 0.15.0
>
>
> It appears that the electron api does not support a username and password as 
> part of an amqp connection. However maybe the example just needs to included 
> this if it is supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1294) c++ examples: remove un-necessary 64 bit integers.

2016-09-20 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1294.
-
Resolution: Fixed

> c++ examples: remove un-necessary 64 bit integers.
> --
>
> Key: PROTON-1294
> URL: https://issues.apache.org/jira/browse/PROTON-1294
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: examples
>Affects Versions: 0.14.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Minor
> Fix For: 0.15.0
>
>
> 64 bit integers cause portability problems on some platforms (e.g. need extra 
> atomic library support on ppc 32 bit) and do not enhance the examples,
> keep them simple.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1306) Go simplified client/server example

2016-09-20 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1306.
-
Resolution: Fixed

> Go simplified client/server example
> ---
>
> Key: PROTON-1306
> URL: https://issues.apache.org/jira/browse/PROTON-1306
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: go-binding
>Affects Versions: 0.14.0
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.15.0
>
>
> Simplify the basic electron client-server use case and provide a package 
> documentation example.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1305) Go sporadic test failure in electron_test

2016-09-20 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1305.
-
Resolution: Fixed

> Go sporadic test failure in electron_test
> -
>
> Key: PROTON-1305
> URL: https://issues.apache.org/jira/browse/PROTON-1305
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: go-binding
>Affects Versions: 0.14.0
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.15.0
>
>
> Sporadic test failure in electron_test, wrong error condition.
> Reliably reproduced by:
> {code}
> . config.sh && go test qpid.apache.org/electron -run 
> TestLinkCloseInterrupt -count 100
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1306) Go simplified client/server example

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507901#comment-15507901
 ] 

ASF subversion and git services commented on PROTON-1306:
-

Commit 6134e216caf952aa031a49ab09d3e59ba71b1965 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6134e21 ]

PROTON-1306: Go container improvements and client-server example.

Added convenience ops to Container: Dial and Accept.
Added client-server documentation example.
Added Container.String(), improve other proton String() funcs.


> Go simplified client/server example
> ---
>
> Key: PROTON-1306
> URL: https://issues.apache.org/jira/browse/PROTON-1306
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: go-binding
>Affects Versions: 0.14.0
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.15.0
>
>
> Simplify the basic electron client-server use case and provide a package 
> documentation example.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1255) connection_engine support for built-in proton SSL/SASL

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507899#comment-15507899
 ] 

ASF subversion and git services commented on PROTON-1255:
-

Commit 3d9fe620758bd55afae6af76b50a2bd5d6839232 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3d9fe62 ]

PROTON-1255: connection_engine separate bind from _init

SASL/SSL properties must be set on connection and transport *before* the
pn_transport_bind() call, move it out of pn_connection_engine_init() and add
pn_connection_engine_start() that must be called before using the engine but
after security (and other) properties are set.

Updated the Go and C++ engines accordingly.


> connection_engine support for built-in proton SSL/SASL
> --
>
> Key: PROTON-1255
> URL: https://issues.apache.org/jira/browse/PROTON-1255
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding, go-binding, proton-c
>Affects Versions: 0.12.2
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Critical
> Fix For: 0.15.0
>
>
> Make sure proton's built-in SSL and SASL work fully with the connection 
> engine for all bindings that have one (C, C++, Go)
> The connection_engine also allows a secure connection to be established 
> externally. Check that we have sufficient hooks to pass external security 
> principal info to the handler via connection and transport properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1293) Support username and password in electron go binding

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507900#comment-15507900
 ] 

ASF subversion and git services commented on PROTON-1293:
-

Commit 0e37353d7410841ebb291b14e05b7dc9943cd1ce in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0e37353 ]

PROTON-1293: Go binding SASL support.

proton package
- added sasl.h to the Go proton wrapper generator.
- capitalized as "SASL" *not* "Sasl", consistent with Go conventions (e.g. URL)
- added SASL() accessor to proton.Transport.
- Engine.Run() extra dispatch and check as 
pn_connection_engine_read/write_buffer()
  can generate events that close the transport in an auth failure.
- Engine.Id()/String() use transport address to match PN_TRACE_ logs.
- Drop auto-open of engine: let user set security first.

electron package:
- new ConnectionOption: User, Password, VirtualHost, SASLAllowInsecure, 
SASLAllowedMechs
- global settings with GlobalSASLConfigDir, GobalSASLConfName
- IncomingConnection allows user to accept/reject authenticated incoming 
connections
- updated & improved documentation
- Endpoint.Sync() synchronous check of endpoint open, to verify authenticated.

Note: Password option takes []byte not string. There is no way to securely erase
a string from memory, an array can be over-written.


> Support username and password in electron go binding
> 
>
> Key: PROTON-1293
> URL: https://issues.apache.org/jira/browse/PROTON-1293
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: go-binding
>Affects Versions: 0.15.0
>Reporter: Richard Laos
>Assignee: Alan Conway
>Priority: Minor
>
> It appears that the electron api does not support a username and password as 
> part of an amqp connection. However maybe the example just needs to included 
> this if it is supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1305) Go sporadic test failure in electron_test

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507898#comment-15507898
 ] 

ASF subversion and git services commented on PROTON-1305:
-

Commit b4d0912b0d8fa7c2ff2115635dece381f5d48868 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=b4d0912 ]

PROTON-1305: Go sporadic test failure in electron_test

Reliably reproduced by:
. config.sh && go test qpid.apache.org/electron -run TestLinkCloseInterrupt 
-count 100

Fixed missing error check in receiver.ReceiveTimeout()


> Go sporadic test failure in electron_test
> -
>
> Key: PROTON-1305
> URL: https://issues.apache.org/jira/browse/PROTON-1305
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: go-binding
>Affects Versions: 0.14.0
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.15.0
>
>
> Sporadic test failure in electron_test, wrong error condition.
> Reliably reproduced by:
> {code}
> . config.sh && go test qpid.apache.org/electron -run 
> TestLinkCloseInterrupt -count 100
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-520) Remove qpidd references from dispatch system_test.py

2016-09-20 Thread Ganesh Murthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy resolved DISPATCH-520.

   Resolution: Fixed
Fix Version/s: 0.7.0

> Remove qpidd references from dispatch system_test.py
> 
>
> Key: DISPATCH-520
> URL: https://issues.apache.org/jira/browse/DISPATCH-520
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 0.7.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Minor
> Fix For: 0.7.0
>
>
> system_test.py tries to load the qpidd executable. We are not using qpidd in 
> our tests. Remove the qpidd references 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-520) Remove qpidd references from dispatch system_test.py

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507700#comment-15507700
 ] 

ASF subversion and git services commented on DISPATCH-520:
--

Commit fe826e69e38ed79c7a634af44ca9f35fed95d832 in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=fe826e6 ]

DISPATCH-520 - Removed qpidd references from system_test.py


> Remove qpidd references from dispatch system_test.py
> 
>
> Key: DISPATCH-520
> URL: https://issues.apache.org/jira/browse/DISPATCH-520
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 0.7.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Minor
>
> system_test.py tries to load the qpidd executable. We are not using qpidd in 
> our tests. Remove the qpidd references 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: Review Request 51638: handle reject and release in qpid::messaging

2016-09-20 Thread Alan Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51638/#review149722
---


Ship it!




I won't argue with that :)

- Alan Conway


On Sept. 20, 2016, 6:56 p.m., Gordon Sim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51638/
> ---
> 
> (Updated Sept. 20, 2016, 6:56 p.m.)
> 
> 
> Review request for qpid and Alan Conway.
> 
> 
> Repository: qpid-cpp
> 
> 
> Description
> ---
> 
> Introduces two new connection options (AMQP 1.0 only):
> 
> * max_delivery_count determines how many times we try to resend a 'released' 
> message. A value of 0, which is the default, retries indefinitely.
> * raise_rejected determines whether an MessageRejected exception is raised 
> when a message is 'rejected', the default is true
> 
> A message is considered 'released' if the outcome is relased, or if the 
> outcome as modified and the 'undeliverable-here' flag is not set. A message 
> is considered 'rejected' if the outcome is rejected, if the outcome is 
> modified *and* the 'undeliverable-here' flag is set, or if it was 'released' 
> but we have reached the maximum nuber of delivery attempts.
> 
> Original behaviour can be obtained by setting max_delivery_count=1 and 
> raise_rejected=false.
> 
> 
> Diffs
> -
> 
>   src/qpid/messaging/ConnectionOptions.h 6b89838 
>   src/qpid/messaging/ConnectionOptions.cpp 3095169 
>   src/qpid/messaging/amqp/ConnectionContext.cpp ff6a7be 
>   src/qpid/messaging/amqp/EncodedMessage.cpp cf60046 
>   src/qpid/messaging/amqp/SenderContext.h 467a8e0 
>   src/qpid/messaging/amqp/SenderContext.cpp fe8b4d3 
>   src/qpid/messaging/amqp/SessionContext.h 67b3c1e 
>   src/qpid/messaging/amqp/SessionContext.cpp 92bdea7 
>   src/qpid/messaging/amqp/Transaction.cpp 754b00d 
> 
> Diff: https://reviews.apache.org/r/51638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>



Re: Review Request 51638: handle reject and release in qpid::messaging

2016-09-20 Thread Alan Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51638/#review149721
---


Ship it!




I won't argue with that :)

- Alan Conway


On Sept. 20, 2016, 6:56 p.m., Gordon Sim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51638/
> ---
> 
> (Updated Sept. 20, 2016, 6:56 p.m.)
> 
> 
> Review request for qpid and Alan Conway.
> 
> 
> Repository: qpid-cpp
> 
> 
> Description
> ---
> 
> Introduces two new connection options (AMQP 1.0 only):
> 
> * max_delivery_count determines how many times we try to resend a 'released' 
> message. A value of 0, which is the default, retries indefinitely.
> * raise_rejected determines whether an MessageRejected exception is raised 
> when a message is 'rejected', the default is true
> 
> A message is considered 'released' if the outcome is relased, or if the 
> outcome as modified and the 'undeliverable-here' flag is not set. A message 
> is considered 'rejected' if the outcome is rejected, if the outcome is 
> modified *and* the 'undeliverable-here' flag is set, or if it was 'released' 
> but we have reached the maximum nuber of delivery attempts.
> 
> Original behaviour can be obtained by setting max_delivery_count=1 and 
> raise_rejected=false.
> 
> 
> Diffs
> -
> 
>   src/qpid/messaging/ConnectionOptions.h 6b89838 
>   src/qpid/messaging/ConnectionOptions.cpp 3095169 
>   src/qpid/messaging/amqp/ConnectionContext.cpp ff6a7be 
>   src/qpid/messaging/amqp/EncodedMessage.cpp cf60046 
>   src/qpid/messaging/amqp/SenderContext.h 467a8e0 
>   src/qpid/messaging/amqp/SenderContext.cpp fe8b4d3 
>   src/qpid/messaging/amqp/SessionContext.h 67b3c1e 
>   src/qpid/messaging/amqp/SessionContext.cpp 92bdea7 
>   src/qpid/messaging/amqp/Transaction.cpp 754b00d 
> 
> Diff: https://reviews.apache.org/r/51638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>



[jira] [Created] (DISPATCH-520) Remove qpidd references from dispatch system_test.py

2016-09-20 Thread Ganesh Murthy (JIRA)
Ganesh Murthy created DISPATCH-520:
--

 Summary: Remove qpidd references from dispatch system_test.py
 Key: DISPATCH-520
 URL: https://issues.apache.org/jira/browse/DISPATCH-520
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Tests
Affects Versions: 0.7.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
Priority: Minor


system_test.py tries to load the qpidd executable. We are not using qpidd in 
our tests. Remove the qpidd references 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-1306) Go simplified client/server example

2016-09-20 Thread Alan Conway (JIRA)
Alan Conway created PROTON-1306:
---

 Summary: Go simplified client/server example
 Key: PROTON-1306
 URL: https://issues.apache.org/jira/browse/PROTON-1306
 Project: Qpid Proton
  Issue Type: Improvement
  Components: go-binding
Affects Versions: 0.14.0
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.15.0


Simplify the basic electron client-server use case and provide a package 
documentation example.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-1305) Go sporadic test failure in electron_test

2016-09-20 Thread Alan Conway (JIRA)
Alan Conway created PROTON-1305:
---

 Summary: Go sporadic test failure in electron_test
 Key: PROTON-1305
 URL: https://issues.apache.org/jira/browse/PROTON-1305
 Project: Qpid Proton
  Issue Type: Bug
  Components: go-binding
Affects Versions: 0.14.0
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.15.0


Sporadic test failure in electron_test, wrong error condition.
Reliably reproduced by:
{code}
. config.sh && go test qpid.apache.org/electron -run TestLinkCloseInterrupt 
-count 100
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-8) Message:user-id must be authenticated on ingress

2016-09-20 Thread Chuck Rolke (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke resolved DISPATCH-8.

Resolution: Fixed

For this issue and the general case DISPATCH-519 fixes a credit issue and 
message free bug.

> Message:user-id must be authenticated on ingress
> 
>
> Key: DISPATCH-8
> URL: https://issues.apache.org/jira/browse/DISPATCH-8
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.1
>Reporter: Ted Ross
>Assignee: Chuck Rolke
>Priority: Critical
> Fix For: 0.7.0
>
>
> When a message is received on an ingress link (i.e. from an originating 
> endpoint) and the message has a user-id field in its properties, that user-id 
> must be authenticated.
> At first, this means that the user-id must be the same as that which was used 
> to authenticate the connection.
> There may be other means of authenticating user-ids in the future, but 
> Dispatch must not simply pass them on unchecked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-519) Rejected inbound deliveries do not handle credit or free received message

2016-09-20 Thread Chuck Rolke (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke resolved DISPATCH-519.
--
Resolution: Fixed

> Rejected inbound deliveries do not handle credit or free received message
> -
>
> Key: DISPATCH-519
> URL: https://issues.apache.org/jira/browse/DISPATCH-519
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.7.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Testing fix for DISPATCH-8 reveals that after 250 messages the traffic stops. 
> The router is not issuing any credit for the rejected message. Further, the 
> received messages are not freed.
> The same issue exists in three places.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-519) Rejected inbound deliveries do not handle credit or free received message

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507600#comment-15507600
 ] 

ASF subversion and git services commented on DISPATCH-519:
--

Commit 88aeed899bc1b27e60ddb101ca2d6a796912e588 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=88aeed8 ]

DISPATCH-519: Rejected inbound deliveries do not handle credit

Issue credit to cover the rejected message.
Free the rejected message.
Add self test to demonstrate fix. Note the magic number 250 is
how much credit the router issues.


> Rejected inbound deliveries do not handle credit or free received message
> -
>
> Key: DISPATCH-519
> URL: https://issues.apache.org/jira/browse/DISPATCH-519
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.7.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Testing fix for DISPATCH-8 reveals that after 250 messages the traffic stops. 
> The router is not issuing any credit for the rejected message. Further, the 
> received messages are not freed.
> The same issue exists in three places.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #101: DISPATCH-160 - Modified code to allow propa...

2016-09-20 Thread ganeshmurthy
GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/101

DISPATCH-160 - Modified code to allow propagation of custom message a…

…nnotations

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-160

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #101


commit 0aec28cfa73391264906e29e9ccb245812d4abdc
Author: Ganesh Murthy 
Date:   2016-09-20T13:32:28Z

DISPATCH-160 - Modified code to allow propagation of custom message 
annotations




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-160) Dispatch router does not propagate custom message annotations

2016-09-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507586#comment-15507586
 ] 

ASF GitHub Bot commented on DISPATCH-160:
-

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/101

DISPATCH-160 - Modified code to allow propagation of custom message a…

…nnotations

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-160

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #101


commit 0aec28cfa73391264906e29e9ccb245812d4abdc
Author: Ganesh Murthy 
Date:   2016-09-20T13:32:28Z

DISPATCH-160 - Modified code to allow propagation of custom message 
annotations




> Dispatch router does not propagate custom message annotations
> -
>
> Key: DISPATCH-160
> URL: https://issues.apache.org/jira/browse/DISPATCH-160
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node, Routing Engine
>Affects Versions: 0.4
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Critical
> Fix For: 0.7.0
>
>
> Steps to reproduce - 
> Create an AMQP message with a custom message annotation - 
> ma['custom-annotation'] = 'Custom_Annotation Content'
> Send this message via a dispatch router and receive this message. The 
> received message does not contain the 'custom-annotation'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (DISPATCH-519) Rejected inbound deliveries do not handle credit or free received message

2016-09-20 Thread Chuck Rolke (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke reassigned DISPATCH-519:


Assignee: Chuck Rolke

> Rejected inbound deliveries do not handle credit or free received message
> -
>
> Key: DISPATCH-519
> URL: https://issues.apache.org/jira/browse/DISPATCH-519
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.7.0
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>
> Testing fix for DISPATCH-8 reveals that after 250 messages the traffic stops. 
> The router is not issuing any credit for the rejected message. Further, the 
> received messages are not freed.
> The same issue exists in three places.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-519) Rejected inbound deliveries do not handle credit or free received message

2016-09-20 Thread Chuck Rolke (JIRA)
Chuck Rolke created DISPATCH-519:


 Summary: Rejected inbound deliveries do not handle credit or free 
received message
 Key: DISPATCH-519
 URL: https://issues.apache.org/jira/browse/DISPATCH-519
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Router Node
Affects Versions: 0.7.0
Reporter: Chuck Rolke


Testing fix for DISPATCH-8 reveals that after 250 messages the traffic stops. 
The router is not issuing any credit for the rejected message. Further, the 
received messages are not freed.

The same issue exists in three places.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: Review Request 51638: handle reject and release in qpid::messaging

2016-09-20 Thread Gordon Sim

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51638/
---

(Updated Sept. 20, 2016, 6:56 p.m.)


Review request for qpid and Alan Conway.


Changes
---

What Alan wants, Alan gets! Added time based redelivery limit.


Repository: qpid-cpp


Description
---

Introduces two new connection options (AMQP 1.0 only):

* max_delivery_count determines how many times we try to resend a 'released' 
message. A value of 0, which is the default, retries indefinitely.
* raise_rejected determines whether an MessageRejected exception is raised when 
a message is 'rejected', the default is true

A message is considered 'released' if the outcome is relased, or if the outcome 
as modified and the 'undeliverable-here' flag is not set. A message is 
considered 'rejected' if the outcome is rejected, if the outcome is modified 
*and* the 'undeliverable-here' flag is set, or if it was 'released' but we have 
reached the maximum nuber of delivery attempts.

Original behaviour can be obtained by setting max_delivery_count=1 and 
raise_rejected=false.


Diffs (updated)
-

  src/qpid/messaging/ConnectionOptions.h 6b89838 
  src/qpid/messaging/ConnectionOptions.cpp 3095169 
  src/qpid/messaging/amqp/ConnectionContext.cpp ff6a7be 
  src/qpid/messaging/amqp/EncodedMessage.cpp cf60046 
  src/qpid/messaging/amqp/SenderContext.h 467a8e0 
  src/qpid/messaging/amqp/SenderContext.cpp fe8b4d3 
  src/qpid/messaging/amqp/SessionContext.h 67b3c1e 
  src/qpid/messaging/amqp/SessionContext.cpp 92bdea7 
  src/qpid/messaging/amqp/Transaction.cpp 754b00d 

Diff: https://reviews.apache.org/r/51638/diff/


Testing
---


Thanks,

Gordon Sim



[jira] [Commented] (QPIDJMS-207) Implement the JMS 2.0 API

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507362#comment-15507362
 ] 

ASF subversion and git services commented on QPIDJMS-207:
-

Commit 4550dac6c87b8d721d1c5a22e92848a4af30e4d4 in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=4550dac ]

QPIDJMS-207 Fix MessageProducer getDeliveryDelay, add test

> Implement the JMS 2.0 API
> -
>
> Key: QPIDJMS-207
> URL: https://issues.apache.org/jira/browse/QPIDJMS-207
> Project: Qpid JMS
>  Issue Type: New Feature
>  Components: qpid-jms-client
>Affects Versions: 0.11.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-207) Implement the JMS 2.0 API

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507361#comment-15507361
 ] 

ASF subversion and git services commented on QPIDJMS-207:
-

Commit fd2bc18322b388dd38bb53a526a01ce3d7fcf149 in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=fd2bc18 ]

QPIDJMS-207 Add additional test coverage, update ConnectionMetaData


> Implement the JMS 2.0 API
> -
>
> Key: QPIDJMS-207
> URL: https://issues.apache.org/jira/browse/QPIDJMS-207
> Project: Qpid JMS
>  Issue Type: New Feature
>  Components: qpid-jms-client
>Affects Versions: 0.11.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-518) Use eventfd instead of a pipe for poll wakeup.

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507111#comment-15507111
 ] 

ASF subversion and git services commented on DISPATCH-518:
--

Commit 88e87944c212dd9314035a280cad3ddacd0e22ee in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=88e8794 ]

DISPATCH-518 - Replaced the IO driver's pipe with an eventfd for awakening the 
poll.


> Use eventfd instead of a pipe for poll wakeup.
> --
>
> Key: DISPATCH-518
> URL: https://issues.apache.org/jira/browse/DISPATCH-518
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Minor
> Fix For: 0.7.0
>
>
> To improve efficiency and performance, replace the pipe (FD-pair) used to 
> awaken the IO poll with eventfd.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-518) Use eventfd instead of a pipe for poll wakeup.

2016-09-20 Thread Ted Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-518.
---
Resolution: Fixed

> Use eventfd instead of a pipe for poll wakeup.
> --
>
> Key: DISPATCH-518
> URL: https://issues.apache.org/jira/browse/DISPATCH-518
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Minor
> Fix For: 0.7.0
>
>
> To improve efficiency and performance, replace the pipe (FD-pair) used to 
> awaken the IO poll with eventfd.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-518) Use eventfd instead of a pipe for poll wakeup.

2016-09-20 Thread Ted Ross (JIRA)
Ted Ross created DISPATCH-518:
-

 Summary: Use eventfd instead of a pipe for poll wakeup.
 Key: DISPATCH-518
 URL: https://issues.apache.org/jira/browse/DISPATCH-518
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Container
Reporter: Ted Ross
Assignee: Ted Ross
Priority: Minor
 Fix For: 0.7.0


To improve efficiency and performance, replace the pipe (FD-pair) used to 
awaken the IO poll with eventfd.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-517) Expose new link statistics on overview page

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506998#comment-15506998
 ] 

ASF subversion and git services commented on DISPATCH-517:
--

Commit 2e8d500792380b728b299fd37b61788decadd675 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=2e8d500 ]

DISPATCH-517 Expose new link statistics on console's overview page


> Expose new link statistics on overview page
> ---
>
> Key: DISPATCH-517
> URL: https://issues.apache.org/jira/browse/DISPATCH-517
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>
> The overview page has a link details grid that shows certain link fields. 
> That grid should also show the new link statistics fields: acceptedCount, 
> modifiedCount, presettledCount, rejectedCount, releasedCount.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-517) Expose new link statistics on overview page

2016-09-20 Thread Ernest Allen (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen resolved DISPATCH-517.
---
   Resolution: Fixed
Fix Version/s: 0.7.0

> Expose new link statistics on overview page
> ---
>
> Key: DISPATCH-517
> URL: https://issues.apache.org/jira/browse/DISPATCH-517
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
> Fix For: 0.7.0
>
>
> The overview page has a link details grid that shows certain link fields. 
> That grid should also show the new link statistics fields: acceptedCount, 
> modifiedCount, presettledCount, rejectedCount, releasedCount.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-517) Expose new link statistics on overview page

2016-09-20 Thread Ernest Allen (JIRA)
Ernest Allen created DISPATCH-517:
-

 Summary: Expose new link statistics on overview page
 Key: DISPATCH-517
 URL: https://issues.apache.org/jira/browse/DISPATCH-517
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Console
Reporter: Ernest Allen
Assignee: Ernest Allen


The overview page has a link details grid that shows certain link fields. That 
grid should also show the new link statistics fields: acceptedCount, 
modifiedCount, presettledCount, rejectedCount, releasedCount.
 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPIDJMS-208) Can't set custom deserialization policy on ConnectionFactory

2016-09-20 Thread Timothy Bish (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved QPIDJMS-208.
--
Resolution: Fixed

> Can't set custom deserialization policy on ConnectionFactory
> 
>
> Key: QPIDJMS-208
> URL: https://issues.apache.org/jira/browse/QPIDJMS-208
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.11.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
>Priority: Minor
> Fix For: 0.20.0
>
>
> The custom deserialization policy assigned to a ConnectionFactory is not 
> propagated to new connections created from that factory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-207) Implement the JMS 2.0 API

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506886#comment-15506886
 ] 

ASF subversion and git services commented on QPIDJMS-207:
-

Commit 6dd3d2b1d088b52685ca75a6edd7da279a2e4c78 in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=6dd3d2b ]

QPIDJMS-207 Add more test coverage

> Implement the JMS 2.0 API
> -
>
> Key: QPIDJMS-207
> URL: https://issues.apache.org/jira/browse/QPIDJMS-207
> Project: Qpid JMS
>  Issue Type: New Feature
>  Components: qpid-jms-client
>Affects Versions: 0.11.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-208) Can't set custom deserialization policy on ConnectionFactory

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506887#comment-15506887
 ] 

ASF subversion and git services commented on QPIDJMS-208:
-

Commit 1c3ff1cbba17bb1f2fe09735abd16d96c1c40339 in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=1c3ff1c ]

QPIDJMS-208 Assign the set deserialization policy to new connections.

> Can't set custom deserialization policy on ConnectionFactory
> 
>
> Key: QPIDJMS-208
> URL: https://issues.apache.org/jira/browse/QPIDJMS-208
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.11.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
>Priority: Minor
> Fix For: 0.20.0
>
>
> The custom deserialization policy assigned to a ConnectionFactory is not 
> propagated to new connections created from that factory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPIDJMS-208) Can't set custom deserialization policy on ConnectionFactory

2016-09-20 Thread Timothy Bish (JIRA)
Timothy Bish created QPIDJMS-208:


 Summary: Can't set custom deserialization policy on 
ConnectionFactory
 Key: QPIDJMS-208
 URL: https://issues.apache.org/jira/browse/QPIDJMS-208
 Project: Qpid JMS
  Issue Type: Bug
  Components: qpid-jms-client
Affects Versions: 0.11.0
Reporter: Timothy Bish
Assignee: Timothy Bish
Priority: Minor
 Fix For: 0.20.0


The custom deserialization policy assigned to a ConnectionFactory is not 
propagated to new connections created from that factory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-516) Core dump when displayname IO adapter receives message with no reply-to

2016-09-20 Thread Chuck Rolke (JIRA)
Chuck Rolke created DISPATCH-516:


 Summary: Core dump when displayname IO adapter receives message 
with no reply-to
 Key: DISPATCH-516
 URL: https://issues.apache.org/jira/browse/DISPATCH-516
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Chuck Rolke


display_name.py/receive constructs a response where the address is null. When 
that gets processed later

{noformat}
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffea292700 (LWP 2292)]
0x77bb619d in qdr_send_to_CT (core=0x9472b0, action=0x948660, 
discard=false) at /home/chug/git/qpid-dispatch/src/router_core/transfer.c:630
630 qd_address_iterator_reset_view(addr_field->iterator, 
ITER_VIEW_ADDRESS_HASH);
(gdb) bt
#0  0x77bb619d in qdr_send_to_CT (core=0x9472b0, action=0x948660, 
discard=false) at /home/chug/git/qpid-dispatch/src/router_core/transfer.c:630
#1  0x77bb0487 in router_core_thread (arg=0x9472b0) at 
/home/chug/git/qpid-dispatch/src/router_core/router_core_thread.c:71
#2  0x776f061a in start_thread () from /lib64/libpthread.so.0
#3  0x76c4f5fd in clone () from /lib64/libc.so.6
({noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-511) Remove performance problems from locks and memory allocation

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506751#comment-15506751
 ] 

ASF subversion and git services commented on DISPATCH-511:
--

Commit 5b09760d0d3637978ca3770c677e640837076727 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=5b09760 ]

DISPATCH-511 - Fixed issue with posix_memalign's return value being ignored.


> Remove performance problems from locks and memory allocation
> 
>
> Key: DISPATCH-511
> URL: https://issues.apache.org/jira/browse/DISPATCH-511
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Reporter: Ted Ross
>Assignee: Ted Ross
> Fix For: 0.7.0
>
>
> There are a number of performance issues with locks and memory pooling:
>   - Locks are not allocated on cache-line boundaries and suffer from 
> false-sharing issues.
>   - The extra lock checks (checking the acquired state) cause significant 
> overhead.  These should be removed.
>   - Pooled memory objects are not cache-line aligned and suffer from 
> false-sharing
>   - Memory pool statistics are useful but costly from a performance 
> standpoint.  These should be able to be optionally disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPIDJMS-164) Provide an OSGi bundle for the Qpid JMS client

2016-09-20 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPIDJMS-164.

   Resolution: Fixed
 Assignee: Robbie Gemmell
Fix Version/s: 0.20.0
   0.1X.Y

> Provide an OSGi bundle for the Qpid JMS client
> --
>
> Key: QPIDJMS-164
> URL: https://issues.apache.org/jira/browse/QPIDJMS-164
> Project: Qpid JMS
>  Issue Type: Improvement
>Reporter: Hiram Chirino
>Assignee: Robbie Gemmell
> Fix For: 0.1X.Y, 0.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-164) Provide an OSGi bundle for the Qpid JMS client

2016-09-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506563#comment-15506563
 ] 

ASF GitHub Bot commented on QPIDJMS-164:


Github user gemmellr commented on the issue:

https://github.com/apache/qpid-jms/pull/4
  
Thanks, merged.

We likely won't use 1.X.Y etc versions until the AMQP JMS mapping the 
client is implementing, and the implementation in general, are a bit more 
settled. It only skipped a little to 0.20.0 to allow some leeway to do more 
releases while we are working on JMS 2 support, but there were no specific 
items in mind to actually do any though before now.


> Provide an OSGi bundle for the Qpid JMS client
> --
>
> Key: QPIDJMS-164
> URL: https://issues.apache.org/jira/browse/QPIDJMS-164
> Project: Qpid JMS
>  Issue Type: Improvement
>Reporter: Hiram Chirino
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-jms issue #4: QPIDJMS-164: Provide OSGi metadata for qpid-jms-client

2016-09-20 Thread gemmellr
Github user gemmellr commented on the issue:

https://github.com/apache/qpid-jms/pull/4
  
Thanks, merged.

We likely won't use 1.X.Y etc versions until the AMQP JMS mapping the 
client is implementing, and the implementation in general, are a bit more 
settled. It only skipped a little to 0.20.0 to allow some leeway to do more 
releases while we are working on JMS 2 support, but there were no specific 
items in mind to actually do any though before now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-164) Provide an OSGi bundle for the Qpid JMS client

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506534#comment-15506534
 ] 

ASF subversion and git services commented on QPIDJMS-164:
-

Commit 17c972800170163b1cfd42a364daf0a26da63e91 in qpid-jms's branch 
refs/heads/master from [~ctron]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=17c9728 ]

QPIDJMS-164: Provide OSGi metadata for qpid-jms-client

This change adds the maven-bundle-plugin to the parent project and
activates it in the qpid-jms-client project, generating OSGi meta data
for the project.

The Bundle-SymbolicName is overridden to "org.apache.qpid.jms.client".

The DynamicPackage-Import header is set to "*" since the JMS client can
actually create instances from all kind of classes.

Signed-off-by: Jens Reimann 

> Provide an OSGi bundle for the Qpid JMS client
> --
>
> Key: QPIDJMS-164
> URL: https://issues.apache.org/jira/browse/QPIDJMS-164
> Project: Qpid JMS
>  Issue Type: Improvement
>Reporter: Hiram Chirino
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-164) Provide an OSGi bundle for the Qpid JMS client

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506535#comment-15506535
 ] 

ASF subversion and git services commented on QPIDJMS-164:
-

Commit da0f0e6e6437b2c0c6640099916ab6f142b47fb0 in qpid-jms's branch 
refs/heads/master from Robert Gemmell
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=da0f0e6 ]

QPIDJMS-164: merge change to add OSGi metadata

This closes #4


> Provide an OSGi bundle for the Qpid JMS client
> --
>
> Key: QPIDJMS-164
> URL: https://issues.apache.org/jira/browse/QPIDJMS-164
> Project: Qpid JMS
>  Issue Type: Improvement
>Reporter: Hiram Chirino
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-164) Provide an OSGi bundle for the Qpid JMS client

2016-09-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506537#comment-15506537
 ] 

ASF GitHub Bot commented on QPIDJMS-164:


Github user asfgit closed the pull request at:

https://github.com/apache/qpid-jms/pull/4


> Provide an OSGi bundle for the Qpid JMS client
> --
>
> Key: QPIDJMS-164
> URL: https://issues.apache.org/jira/browse/QPIDJMS-164
> Project: Qpid JMS
>  Issue Type: Improvement
>Reporter: Hiram Chirino
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-jms pull request #4: QPIDJMS-164: Provide OSGi metadata for qpid-jms-cl...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-jms/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7408) REST API streams compressed message content without a Content-Encoding header

2016-09-20 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-7408.
--
Resolution: Fixed

> REST API streams compressed message content without a Content-Encoding header
> -
>
> Key: QPID-7408
> URL: https://issues.apache.org/jira/browse/QPID-7408
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.30, 0.32, qpid-java-6.0, qpid-java-6.1
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7408-Extend-gunzip-output-stream-from-InflaterO.patch, 
> new-compression-tests.diff
>
>
> The Broker for Java supports compressed messages.  If I view a compressed 
> message through the management console, the Broker sends the content to the 
> client without a {{Content-Encoding}} header, so the client treats the bytes 
> as if they were uncompressed.  If the message's mime type is {{text/*}}, I 
> see seeming garbage instead of the inlined text content.  If the message's 
> mime type is something else the browser handles the content as if it were 
> uncompressed.  This could confused applications associated with the Browser.
> This could potentially hinder an operator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7408) REST API streams compressed message content without a Content-Encoding header

2016-09-20 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506412#comment-15506412
 ] 

Keith Wall commented on QPID-7408:
--

The following commit message seems to have not been added automatically by SVN:

QPID-7408: Replace GZIPOutputStreamAdapter with GunzipOutputStream 
extending InflaterOutputStream

git-svn-id: https://svn.apache.org/repos/asf/qpid/java/trunk@1761561 
13f79535-47bb-0310-9956-ffa450edef68


Alex and I worked on this change together.

> REST API streams compressed message content without a Content-Encoding header
> -
>
> Key: QPID-7408
> URL: https://issues.apache.org/jira/browse/QPID-7408
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.30, 0.32, qpid-java-6.0, qpid-java-6.1
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7408-Extend-gunzip-output-stream-from-InflaterO.patch, 
> new-compression-tests.diff
>
>
> The Broker for Java supports compressed messages.  If I view a compressed 
> message through the management console, the Broker sends the content to the 
> client without a {{Content-Encoding}} header, so the client treats the bytes 
> as if they were uncompressed.  If the message's mime type is {{text/*}}, I 
> see seeming garbage instead of the inlined text content.  If the message's 
> mime type is something else the browser handles the content as if it were 
> uncompressed.  This could confused applications associated with the Browser.
> This could potentially hinder an operator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7408) REST API streams compressed message content without a Content-Encoding header

2016-09-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506409#comment-15506409
 ] 

ASF subversion and git services commented on QPID-7408:
---

Commit 1761567 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1761567 ]

QPID-7408: Minor tidy-ups to implementation of GunzipOutputStream

> REST API streams compressed message content without a Content-Encoding header
> -
>
> Key: QPID-7408
> URL: https://issues.apache.org/jira/browse/QPID-7408
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.30, 0.32, qpid-java-6.0, qpid-java-6.1
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7408-Extend-gunzip-output-stream-from-InflaterO.patch, 
> new-compression-tests.diff
>
>
> The Broker for Java supports compressed messages.  If I view a compressed 
> message through the management console, the Broker sends the content to the 
> client without a {{Content-Encoding}} header, so the client treats the bytes 
> as if they were uncompressed.  If the message's mime type is {{text/*}}, I 
> see seeming garbage instead of the inlined text content.  If the message's 
> mime type is something else the browser handles the content as if it were 
> uncompressed.  This could confused applications associated with the Browser.
> This could potentially hinder an operator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-164) Provide an OSGi bundle for the Qpid JMS client

2016-09-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506011#comment-15506011
 ] 

ASF GitHub Bot commented on QPIDJMS-164:


Github user ctron commented on the issue:

https://github.com/apache/qpid-jms/pull/4
  
Ok. Done. I did change the title of the PR anyway, just as a note to myself.

I also just saw that it actually targets javax.jms version 2. Is there a 
chance to get this change also for JMS version 1.1?


> Provide an OSGi bundle for the Qpid JMS client
> --
>
> Key: QPIDJMS-164
> URL: https://issues.apache.org/jira/browse/QPIDJMS-164
> Project: Qpid JMS
>  Issue Type: Improvement
>Reporter: Hiram Chirino
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-jms issue #4: QPIDJMS-164: Provide OSGi metadata for qpid-jms-client

2016-09-20 Thread ctron
Github user ctron commented on the issue:

https://github.com/apache/qpid-jms/pull/4
  
Ok. Done. I did change the title of the PR anyway, just as a note to myself.

I also just saw that it actually targets javax.jms version 2. Is there a 
chance to get this change also for JMS version 1.1?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org