[jira] [Created] (PROTON-1574) WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) due to missing unlock in stop_polling()

2017-09-05 Thread Jiri Danek (JIRA)
Jiri Danek created PROTON-1574: -- Summary: WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) due to missing unlock in stop_polling() Key: PROTON-1574 URL:

[jira] [Commented] (PROTON-1540) Add options to enable Sanitizers to CMake build

2017-09-05 Thread Jiri Danek (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154836#comment-16154836 ] Jiri Danek commented on PROTON-1540: One addition. It is best to always run sanitizers with

[jira] [Commented] (PROTON-1572) CppCheck 1.8 warnings

2017-09-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154176#comment-16154176 ] ASF subversion and git services commented on PROTON-1572: - Commit

[jira] [Resolved] (PROTON-1572) CppCheck 1.8 warnings

2017-09-05 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-1572. - Resolution: Fixed Assignee: Andrew Stitcher > CppCheck 1.8 warnings >

[jira] [Updated] (PROTON-1573) Undefined behavior in some calls to memmove in Proton

2017-09-05 Thread Jiri Danek (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Danek updated PROTON-1573: --- Priority: Trivial (was: Major) > Undefined behavior in some calls to memmove in Proton >

[jira] [Created] (PROTON-1573) Undefined behavior in some calls to memmove in Proton

2017-09-05 Thread Jiri Danek (JIRA)
Jiri Danek created PROTON-1573: -- Summary: Undefined behavior in some calls to memmove in Proton Key: PROTON-1573 URL: https://issues.apache.org/jira/browse/PROTON-1573 Project: Qpid Proton

[jira] [Updated] (PROTON-1573) Undefined behavior in some calls to memmove in Proton

2017-09-05 Thread Jiri Danek (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Danek updated PROTON-1573: --- Description: Proton sometimes calls to memmove with arguments memmove(?, null, 0), that is, the

[jira] [Commented] (PROTON-1572) CppCheck 1.8 warnings

2017-09-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154448#comment-16154448 ] ASF subversion and git services commented on PROTON-1572: - Commit

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/119 I've merged this now (with an extra fix) --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional

[jira] [Commented] (PROTON-1572) CppCheck 1.8 warnings

2017-09-05 Thread Jiri Danek (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154262#comment-16154262 ] Jiri Danek commented on PROTON-1572: I think this should not be closed yet, there are (at least)

[jira] [Updated] (PROTON-1573) Undefined behavior in some calls to memmove in Proton

2017-09-05 Thread Jiri Danek (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Danek updated PROTON-1573: --- Description: Proton sometimes calls to memmove with arguments memmove(?, null, 0), that is, the

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-proton/pull/119 @michaelandrepearce I went through some of the 1566 messages I got from CppCheck 1.80 (by category, I did not look into each in detail) and it seems to me that most of ones in the Error

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-proton/pull/119 @jdanekrh cppcheck is a command line tool in fact this is how I ran it, you don't need to use an ide plugin if you don't want to. Also there are Jenkins plugin to add to a build

[jira] [Updated] (QPID-7906) [Java Broker] Broker startup script choke when environment variable QPID_OPTS contains spaces in the value of the arguments

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7906: - Priority: Minor (was: Major) > [Java Broker] Broker startup script choke when environment variable

[jira] [Updated] (QPID-7906) [Java Broker] Broker startup script choke when environment variable QPID_OPTS contains spaces in the value of the arguments

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7906: - Fix Version/s: Future > [Java Broker] Broker startup script choke when environment variable QPID_OPTS >

[jira] [Updated] (QPID-7906) [Java Broker] Broker startup script chokes when environment variable QPID_OPTS contains spaces in the value of the arguments

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7906: - Summary: [Java Broker] Broker startup script chokes when environment variable QPID_OPTS contains spaces in

[jira] [Commented] (QPID-7906) [Java Broker] Broker startup script chokes when environment variable QPID_OPTS contains spaces in the value of the arguments

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153326#comment-16153326 ] Keith Wall commented on QPID-7906: -- Not priority for v7. > [Java Broker] Broker startup script chokes

[jira] [Created] (PROTON-1571) The ssl C++ example appears leaky, proton::listener does not have a destructor

2017-09-05 Thread Jiri Danek (JIRA)
Jiri Danek created PROTON-1571: -- Summary: The ssl C++ example appears leaky, proton::listener does not have a destructor Key: PROTON-1571 URL: https://issues.apache.org/jira/browse/PROTON-1571 Project:

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/119 Do you need me to merge these changes? (I forget if you are a committer or not) --- - To unsubscribe, e-mail:

[ANNOUNCE] Apache Qpid Proton-J 0.21.0 released

2017-09-05 Thread Robbie Gemmell
The Apache Qpid (http://qpid.apache.org) community is pleased to announce the immediate availability of Apache Qpid Proton-J 0.21.0. Apache Qpid Proton-J is a messaging library for the Advanced Message Queuing Protocol 1.0 (AMQP 1.0, ISO/IEC 19464, http://www.amqp.org). It can be used in a wide

[jira] [Reopened] (QPID-7606) Generalise Queue|Exchange#alternateExchange as alternateBinding

2017-09-05 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reopened QPID-7606: -- Assignee: Alex Rudyy Reopening JIRA due to following defects introduced in UI * Alternate Binding

[jira] [Reopened] (QPID-7869) [Java Broker] Truststore improvements

2017-09-05 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reopened QPID-7869: -- Reopening of the JIRA due to issues in UI for editing of keystore/trustores * unchanged attribute values are

[GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/119#discussion_r137036761 --- Diff: proton-c/src/proactor/libuv.c --- @@ -1179,7 +1179,10 @@ pn_proactor_t *pn_proactor() { pn_proactor_t *p = (pn_proactor_t*)calloc(1,

[jira] [Assigned] (QPID-7771) Allow exchange to exchange bindings to substitute the routing key

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-7771: Assignee: Keith Wall > Allow exchange to exchange bindings to substitute the routing key >

[jira] [Updated] (QPID-7834) [Java Broker] [AMQP 1.0] Test AMQQueueDeferredOrderingTest#testMessagesSentByTwoThreadsAreDeliveredInOrder failed with profile java-bdb.1-0

2017-09-05 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-7834: - Attachment:

[jira] [Reopened] (QPID-7781) [Java Broker] 500 error whilst deleting a virtualhost.

2017-09-05 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reopened QPID-7781: -- Assignee: Alex Rudyy (was: Keith Wall) Reopening JIRA due to following issue: * Button "Add Virtual

[GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/119#discussion_r137037295 --- Diff: proton-c/src/proactor/libuv.c --- @@ -1179,7 +1179,10 @@ pn_proactor_t *pn_proactor() { pn_proactor_t *p = (pn_proactor_t*)calloc(1,

[jira] [Updated] (QPID-7771) Allow exchange to exchange bindings to substitute the routing key

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7771: - Attachment: 0001-QPID-7771-Java-Broker-Add-support-for-x-replacement-.patch > Allow exchange to exchange

[jira] [Created] (PROTON-1572) CppCheck 1.8 warnings

2017-09-05 Thread Michael Andre Pearce (JIRA)
Michael Andre Pearce created PROTON-1572: Summary: CppCheck 1.8 warnings Key: PROTON-1572 URL: https://issues.apache.org/jira/browse/PROTON-1572 Project: Qpid Proton Issue Type: Bug

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-proton/pull/119 @astitcher https://issues.apache.org/jira/browse/PROTON-1572 just created with the output of cppcheck 1.8 run we did earlier today. ---

[jira] [Commented] (PROTON-1572) CppCheck 1.8 warnings

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153941#comment-16153941 ] ASF GitHub Bot commented on PROTON-1572: Github user michaelandrepearce commented on the issue:

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-proton/pull/119 @jdanekrh which version of cppcheck you using? using 1.8 we get a few more warnings, e.g. detects header file method param names order don't match cpp implementation. e.g.

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/119 @michaelandrepearce can you paste in the JIRA report urls here then so they can be connected. --- - To unsubscribe,

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-proton/pull/119 Yeah, I need a committer to review and merge it for me. On Tue, Sep 5, 2017 at 6:19 PM, Andrew Stitcher wrote: > Do you need me to merge these

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/119 @jdanekrh ok - I'll merge and commit this - also note we need a JIRA for this too - it's not a simple typo (or something trivial) that doesn't need it - I'll create one unless

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-proton/pull/119 @astitcher there is more than just that one, i note when using 1.75 there are far less things detected that 1.8, thus the question to @jdanekrh ---

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-proton/pull/119 @michaelandrepearce I think there are two factors that reduced the number of issues found. I used CppCheck 1.79 and I invoked it from my IDE, which by default does not turn on all the

[jira] [Assigned] (PROTON-1540) Add options to enable Sanitizers to CMake build

2017-09-05 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1540: --- Assignee: Alan Conway (was: Jiri Danek) > Add options to enable Sanitizers to CMake build

[jira] [Updated] (PROTON-1572) CppCheck 1.8 warnings

2017-09-05 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1572: Fix Version/s: proton-c-0.18.0 > CppCheck 1.8 warnings > - > >

[jira] [Updated] (QPID-7212) [Java Broker, WMC] Don't transmit inherited context variables by default

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7212: - Summary: [Java Broker, WMC] Don't transmit inherited context variables by default (was: [Java Broker,

[jira] [Commented] (QPID-7212) [Java Broker, WMC] Don't transmit inherited context variables by default

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153449#comment-16153449 ] Keith Wall commented on QPID-7212: -- Clarified JIRA title to better communicate intent. > [Java Broker,

[jira] [Updated] (QPID-7212) [Java Broker, WMC] Don't transmit inherited context variables by default

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7212: - Description: Of course there needs to be a way to get the -effective values- inherited value as well.

[GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton/pull/119 NO-JIRA Fix CppCheck warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/qpid-proton jd_cppcheck Alternatively you can

[jira] [Updated] (QPID-7556) Announce support for AMQP management with a capability (or connection property for the older protocols)

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7556: - Fix Version/s: (was: qpid-java-broker-7.0.0) Future > Announce support for AMQP

[jira] [Commented] (QPID-7556) Announce support for AMQP management with a capability (or connection property for the older protocols)

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153427#comment-16153427 ] Keith Wall commented on QPID-7556: -- Removed from scope for v7. > Announce support for AMQP management

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-proton/pull/119 The Travis passed on my branch, https://travis-ci.org/jdanekrh/qpid-proton/builds/271996339 --- - To unsubscribe, e-mail:

[jira] [Assigned] (QPID-7866) [Java Broker] AMQP 1.0 publishing links do not register themselves with queues

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-7866: Assignee: Keith Wall > [Java Broker] AMQP 1.0 publishing links do not register themselves with

[jira] [Updated] (QPID-7866) [Java Broker] AMQP 1.0 publishing links do not register themselves with queues

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7866: - Status: Reviewable (was: In Progress) > [Java Broker] AMQP 1.0 publishing links do not register

[jira] [Updated] (QPID-7865) [Java Broker] Tidy-up AMQP 1.0 'Destination' classes

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7865: - Status: Reviewable (was: In Progress) > [Java Broker] Tidy-up AMQP 1.0 'Destination' classes >

[jira] [Updated] (QPID-7402) [Java Broker] https in default config

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7402: - Fix Version/s: (was: qpid-java-broker-7.0.0) Future > [Java Broker] https in

[jira] [Commented] (QPID-7402) [Java Broker] https in default config

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153426#comment-16153426 ] Keith Wall commented on QPID-7402: -- Removed from scope for v7. > [Java Broker] https in default config >

[GitHub] qpid-proton pull request #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/119#discussion_r136951249 --- Diff: proton-c/src/proactor/libuv.c --- @@ -1179,7 +1179,10 @@ pn_proactor_t *pn_proactor() { pn_proactor_t *p = (pn_proactor_t*)calloc(1,

[jira] [Assigned] (QPID-7865) [Java Broker] Tidy-up AMQP 1.0 'Destination' classes

2017-09-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-7865: Assignee: Keith Wall (was: Rob Godfrey) > [Java Broker] Tidy-up AMQP 1.0 'Destination' classes >

[jira] [Updated] (PROTON-1551) Binary vbin32 length encoded incorrectly when using the Data API

2017-09-05 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-1551: --- Summary: Binary vbin32 length encoded incorrectly when using the Data API (was: Large