[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-12-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284875#comment-16284875
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit b1127b7b933171aa8bbee4c05ba15e4c32b1dcdf in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=b1127b7 ]

QPID-6933: [System Tests] Move test for deletion of temporary queue from 
SyncPublishTest into JMS 1.1 system test TemporaryQueueTest


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-12-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284874#comment-16284874
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 4573e360c3da88072d24c12af2a464b6dc4f5538 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=4573e36 ]

QPID-6933: [System Tests] Incorporate RedeliveredMessageTest into JMS 1.1 
system test JMSHeadersAndPropertiesTest#JMSRedelivered


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-09 Thread jdanekrh 
Github user jdanekrh commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
whoa, codecov.io has gone crazy... this report above includes about 10 
recent commits to master, not just this one...

@dmitrytokarev Is committing as myself, but setting `git commit --author 
"Other person "` acceptable GitHub practice? Or doing a final 
`commit --amend` with the `--author` set? This is what I intended to do (in my 
personal project...)


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1517) SyncRequestResponse(BlockingConnection).call() fails with timeout

2017-12-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284679#comment-16284679
 ] 

ASF GitHub Bot commented on PROTON-1517:


Github user jdanekrh commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
whoa, codecov.io has gone crazy... this report above includes about 10 
recent commits to master, not just this one...

@dmitrytokarev Is committing as myself, but setting `git commit --author 
"Other person "` acceptable GitHub practice? Or doing a final 
`commit --amend` with the `--author` set? This is what I intended to do (in my 
personal project...)


> SyncRequestResponse(BlockingConnection).call() fails with timeout
> -
>
> Key: PROTON-1517
> URL: https://issues.apache.org/jira/browse/PROTON-1517
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: proton-c-0.17.0
> Environment: macOS Sierra 10.12.5
> Python 3.6.1
>Reporter: aikchar
>Assignee: Justin Ross
>  Labels: easyfix, patch
> Fix For: proton-c-0.19.0
>
>
> Send a QMFv2 message using SyncRequestResponse.call(). The response times out.
> h2. Repro
> This repro uses the example from 
> https://qpid.apache.org/releases/qpid-proton-0.17.0/proton/python/examples/sync_client.py.html.
> {noformat}
> $ python
> Python 3.6.1 (default, Apr 24 2017, 09:59:45)
> [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
> Type "help", "copyright", "credits" or "license" for more information.
> >>> address = 
> >>> 'amqps://REDACTED_USERNAME:REDACTED_PASSWORD@REDACTED_IP_ADDR:5672/qmf.default.direct'
> >>> from proton import Url
> >>> url = Url(address)
> >>>
> >>> from proton.utils import SyncRequestResponse, BlockingConnection
> >>> client = SyncRequestResponse(BlockingConnection(url, timeout=15, 
> >>> target='qmf.default.direct', sasl_enabled=True, allowed_mechs='PLAIN'), 
> >>> 'qmf.default.direct')
> >>>
> >>> content = {'_what': 'OBJECT', '_schema_id': {'_class_name': 'queue'}}
> >>> properties = {'x-amqp-0-10.app-id': 'qmf2', 'qmf.opcode': 
> >>> '_query_request', 'method': 'request'}
> >>>
> >>> from proton import Message
> >>> m = Message(reply_to=client.receiver.remote_source.address, 
> >>> address=address, body=content, properties=properties, subject='broker')
> >>> r = client.call(m)
> Traceback (most recent call last):
>   File "", line 1, in 
>   File 
> "/Users/hamza.sheikh/virtualenvs/flight-test-py36/lib/python3.6/site-packages/proton/utils.py",
>  line 400, in call
> self.connection.wait(wakeup, msg="Waiting for response")
>   File 
> "/Users/hamza.sheikh/virtualenvs/flight-test-py36/lib/python3.6/site-packages/proton/utils.py",
>  line 288, in wait
> raise Timeout(txt)
> proton.Timeout: Connection 
> amqps://REDACTED_USERNAME:REDACTED_PASSWORD@REDACTED_IP_ADDR:5672/qmf.default.direct
>  timed out: Waiting for response
> >>>
> {noformat}
> h2. Patch
> Patch is to make sure correlation_id is a string.
> {noformat}
> $ git diff
> diff --git a/proton-c/bindings/python/proton/utils.py 
> b/proton-c/bindings/python/proton/utils.py
> index 05ef80df..528ce338 100644
> --- a/proton-c/bindings/python/proton/utils.py
> +++ b/proton-c/bindings/python/proton/utils.py
> @@ -349,7 +349,7 @@ class SyncRequestResponse(IncomingMessageHandler):
>  if not self.address and not request.address:
>  raise ValueError("Request message has no address: %s" % request)
>  request.reply_to = self.reply_to
> -request.correlation_id = correlation_id = self.correlation_id.next()
> +request.correlation_id = correlation_id = 
> str(self.correlation_id.next())
>  self.sender.send(request)
>  def wakeup():
>  return self.response and (self.response.correlation_id == 
> correlation_id)
> {noformat}
> After applying the patch, the response does not time out.
> {noformat}
> $ python
> Python 3.6.1 (default, Apr 24 2017, 09:59:45)
> [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
> Type "help", "copyright", "credits" or "license" for more information.
> >>> address = 
> >>> 'amqps://REDACTED_USERNAME:REDACTED_PASSWORD@REDACTED_IP_ADDR:5672/qmf.default.direct'
> >>> from proton import Url
> >>> url = Url(address)
> >>>
> >>> from proton.utils import SyncRequestResponse, BlockingConnection
> >>> client = SyncRequestResponse(BlockingConnection(url, timeout=15, 
> >>> target='qmf.default.direct', sasl_enabled=True, allowed_mechs='PLAIN'), 
> >>> 'qmf.default.direct')
> >>>
> >>> content = {'_what': 'OBJECT', '_schema_id': {'_class_name': 'queue'}}
> >>> properties = {'x-amqp-0-10.app-id': 'qmf2', 'qmf.opcode': 
> >>> '_query_request', 'method': 'request'}
> >>>
> >>> from proton import

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-12-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284995#comment-16284995
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit fc0fd3e09a403cb5a7ac27e82471f5f4204d7132 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=fc0fd3e ]

QPID-6933: [System Tests] Remove redundant MessageProtocolConversionTest


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-12-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284996#comment-16284996
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 4ac36ca5e7169c19f5c39943d563d5253fbfe545 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=4ac36ca ]

QPID-6933: [System Tests] Move JMSReplyToTest and some tests from 
JMSDestinationTest into JMS 1.1 system tests


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1643) [FreeBSD] ruby-example-test hangs

2017-12-09 Thread Andrew Stitcher (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285073#comment-16285073
 ] 

Andrew Stitcher commented on PROTON-1643:
-

I'm still getting a hang with the ruby-old-example-test:
{noformat}
test 13
Start 13: ruby-old-example-test

13: Test command: /usr/local/bin/python 
"/home/andrew/qpid-proton/src/proton-c/env.py" "--" 
"PATH=/usr/local/libexec/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/home/andrew/bin:/home/andrew/qpid-proton/bld/proton-c/bindings/ruby:/home/andrew/qpid-proton/bld/proton-c"
 
"RUBYLIB=:/home/andrew/qpid-proton/src/proton-c/bindings/ruby/lib:/home/andrew/qpid-proton/src/proton-c/bindings/ruby/tests:/home/andrew/qpid-proton/src/proton-c/bindings/ruby/spec:/home/andrew/qpid-proton/bld/proton-c/bindings/ruby:/home/andrew/qpid-proton/bld/proton-c"
 "SASLPASSWD=/usr/local/sbin/saslpasswd2" "/usr/local/bin/ruby" 
"old_example_test.rb" "-v"
13: Test timeout computed to be: 1500
13: Run options: -v --seed 60161
13: 
13: # Running:
13: 
13: OldExampleTest#test_helloworld = 0.10 s = .
13: OldExampleTest#test_smoke = 0.17 s = .
13: OldExampleTest#test_direct_send = 0.19 s = .
13: OldExampleTest#test_send_recv = 0.20 s = .
13: OldExampleTest#test_direct_recv = 0.20 s = .
13: OldExampleTest#test_client_server = 
/home/andrew/qpid-proton/src/proton-c/bindings/ruby/lib/core/container.rb:174:in
 `initialize': Connection refused - connect(2) for "0.0.0.0" port 55035 
(Errno::ECONNREFUSED)
13: from 
/home/andrew/qpid-proton/src/proton-c/bindings/ruby/lib/core/container.rb:174:in
 `new'
13: from 
/home/andrew/qpid-proton/src/proton-c/bindings/ruby/lib/core/container.rb:174:in
 `connect'
13: from 
/home/andrew/qpid-proton/src/proton-c/bindings/ruby/lib/reactor/container.rb:41:in
 `connect'
13: from server.rb:33:in `on_start'
13: from 
/home/andrew/qpid-proton/src/proton-c/bindings/ruby/lib/core/container.rb:230:in
 `run'
13: from server.rb:75:in `'
{noformat}
These seem to be the relevant processes running:
* /usr/local/bin/ruby23 -W0 client.rb -a amqp://:63611/test_client_server   
  
* /usr/local/bin/ruby23 -W0 server.rb -a amqp://:63611/test_client_server   
  
* /usr/local/bin/ruby23 -W0 broker.rb -a :63611

When the borker process is interrupted the test completes:
{noformat}
13: 197.92 s = F
13: 
13: Finished in 198.774957s, 0.0302 runs/s, 0.0503 assertions/s.
13: 
13:   1) Failure:
13: OldExampleTest#test_client_server [old_example_test.rb:68]:
13: --- expected
13: +++ actual
13: @@ -1,8 +1 @@
13: -"-> Twas brillig, and the slithy toves
13: -<- TWAS BRILLIG, AND THE SLITHY TOVES
13: --> Did gire and gymble in the wabe.
13: -<- DID GIRE AND GYMBLE IN THE WABE.
13: --> All mimsy were the borogroves,
13: -<- ALL MIMSY WERE THE BOROGROVES,
13: --> And the mome raths outgrabe.
13: -<- AND THE MOME RATHS OUTGRABE."
13: +"-> Twas brillig, and the slithy toves"
13: 
{noformat}


> [FreeBSD] ruby-example-test hangs
> -
>
> Key: PROTON-1643
> URL: https://issues.apache.org/jira/browse/PROTON-1643
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.18.0
> Environment: FreeBSD 10.3-RELEASE-p20
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>  Labels: freebsd
> Fix For: proton-c-0.19.0
>
>
> When running ctest ruby-example-test hangs.
> If you examine the process list there is a process {{/usr/local/bin/ruby23 
> reactor/broker.rb -a :26780}} that has not exited. If you kill that process 
> the test fails but the test run carries on.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1643) [FreeBSD] ruby-example-test hangs

2017-12-09 Thread Andrew Stitcher (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PROTON-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Stitcher updated PROTON-1643:

Fix Version/s: (was: proton-c-0.19.0)
   proton-c-0.20.0

> [FreeBSD] ruby-example-test hangs
> -
>
> Key: PROTON-1643
> URL: https://issues.apache.org/jira/browse/PROTON-1643
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.18.0
> Environment: FreeBSD 10.3-RELEASE-p20
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>  Labels: freebsd
> Fix For: proton-c-0.20.0
>
>
> When running ctest ruby-example-test hangs.
> If you examine the process list there is a process {{/usr/local/bin/ruby23 
> reactor/broker.rb -a :26780}} that has not exited. If you kill that process 
> the test fails but the test run carries on.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1687) Improve efficiency of the transport output buffer

2017-12-09 Thread Andrew Stitcher (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285082#comment-16285082
 ] 

Andrew Stitcher commented on PROTON-1687:
-

The associated commit in the previous comment should avoid the specific memoves 
mentioned in pn_dispatcher_output. However there are still a lot of places 
where extra copies happen into unnecessary buffers.

> Improve efficiency of the transport output buffer
> -
>
> Key: PROTON-1687
> URL: https://issues.apache.org/jira/browse/PROTON-1687
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Ted Ross
>Assignee: Andrew Stitcher
>  Labels: perf
> Fix For: proton-c-0.19.0
>
>
> As the size of the transport output buffer grows due to production of 
> deliveries sent through pn_link_send, the amount of time that the CPU spends 
> in memmove becomes a problem.
> It appears (dispatcher.c - pn_dispatcher_output) that whenever a block of 
> data is removed from the buffer, the remainder of the data in the buffer is 
> shifted down using memmove.  If the buffer contains a large amount of data 
> (100s of megabytes), the sending process may spend several minutes doing 
> almost nothing but running memmove.
> Some data:
>   (credit window of 250, unlimited session window, 1 MB payload)
>   - 10 messages, .251 sec, 40 deliveries/sec
>   - 20 messages, 1.267s, 16 dlv/s
>   - 40 messages, 6s, 7 dlv/s
>   - 80 messages, 28s, 3 dlv/s
>   - 160 messages, 138s, ~1 dlv/s



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1651) Correct spelling errors

2017-12-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284681#comment-16284681
 ] 

ASF GitHub Bot commented on PROTON-1651:


Github user jdanekrh closed the pull request at:

https://github.com/apache/qpid-proton/pull/127


> Correct spelling errors
> ---
>
> Key: PROTON-1651
> URL: https://issues.apache.org/jira/browse/PROTON-1651
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Minor
> Fix For: proton-c-0.19.0
>
> Attachments: idea_dictionary.xml
>
>
> I've noticed some typos. I believe systematic approach in trying to get rid 
> of them is in order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #127: PROTON-1651 Fix typos found by the spellchecker

2017-12-09 Thread jdanekrh 
Github user jdanekrh commented on the issue:

https://github.com/apache/qpid-proton/pull/127
  
I am ok leaving injecter be. I still have these three suggested changes 
open (which I only mentioned in the discussion but weren't part of the PR). 
I'll mention them on a new ticket, If I ever do another spellcheck pass over 
the codebase.

> Now that we've covered the basics with the archetypical hello world app, 
let's look at some more interesting examples.

archetypal, maybe?

> decreffed

how many f's? this will require some English language skills, because 
proton has instances of f and ff both and spellcheckers recognize neither 
variant

> transport_consume(transport);// blech - testBindAfterOpen

What is blech?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1517) SyncRequestResponse(BlockingConnection).call() fails with timeout

2017-12-09 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/PROTON-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk updated PROTON-1517:
---
Flags: Patch

> SyncRequestResponse(BlockingConnection).call() fails with timeout
> -
>
> Key: PROTON-1517
> URL: https://issues.apache.org/jira/browse/PROTON-1517
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: proton-c-0.17.0
> Environment: macOS Sierra 10.12.5
> Python 3.6.1
>Reporter: aikchar
>Assignee: Justin Ross
>  Labels: easyfix, patch
> Fix For: proton-c-0.19.0
>
>
> Send a QMFv2 message using SyncRequestResponse.call(). The response times out.
> h2. Repro
> This repro uses the example from 
> https://qpid.apache.org/releases/qpid-proton-0.17.0/proton/python/examples/sync_client.py.html.
> {noformat}
> $ python
> Python 3.6.1 (default, Apr 24 2017, 09:59:45)
> [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
> Type "help", "copyright", "credits" or "license" for more information.
> >>> address = 
> >>> 'amqps://REDACTED_USERNAME:REDACTED_PASSWORD@REDACTED_IP_ADDR:5672/qmf.default.direct'
> >>> from proton import Url
> >>> url = Url(address)
> >>>
> >>> from proton.utils import SyncRequestResponse, BlockingConnection
> >>> client = SyncRequestResponse(BlockingConnection(url, timeout=15, 
> >>> target='qmf.default.direct', sasl_enabled=True, allowed_mechs='PLAIN'), 
> >>> 'qmf.default.direct')
> >>>
> >>> content = {'_what': 'OBJECT', '_schema_id': {'_class_name': 'queue'}}
> >>> properties = {'x-amqp-0-10.app-id': 'qmf2', 'qmf.opcode': 
> >>> '_query_request', 'method': 'request'}
> >>>
> >>> from proton import Message
> >>> m = Message(reply_to=client.receiver.remote_source.address, 
> >>> address=address, body=content, properties=properties, subject='broker')
> >>> r = client.call(m)
> Traceback (most recent call last):
>   File "", line 1, in 
>   File 
> "/Users/hamza.sheikh/virtualenvs/flight-test-py36/lib/python3.6/site-packages/proton/utils.py",
>  line 400, in call
> self.connection.wait(wakeup, msg="Waiting for response")
>   File 
> "/Users/hamza.sheikh/virtualenvs/flight-test-py36/lib/python3.6/site-packages/proton/utils.py",
>  line 288, in wait
> raise Timeout(txt)
> proton.Timeout: Connection 
> amqps://REDACTED_USERNAME:REDACTED_PASSWORD@REDACTED_IP_ADDR:5672/qmf.default.direct
>  timed out: Waiting for response
> >>>
> {noformat}
> h2. Patch
> Patch is to make sure correlation_id is a string.
> {noformat}
> $ git diff
> diff --git a/proton-c/bindings/python/proton/utils.py 
> b/proton-c/bindings/python/proton/utils.py
> index 05ef80df..528ce338 100644
> --- a/proton-c/bindings/python/proton/utils.py
> +++ b/proton-c/bindings/python/proton/utils.py
> @@ -349,7 +349,7 @@ class SyncRequestResponse(IncomingMessageHandler):
>  if not self.address and not request.address:
>  raise ValueError("Request message has no address: %s" % request)
>  request.reply_to = self.reply_to
> -request.correlation_id = correlation_id = self.correlation_id.next()
> +request.correlation_id = correlation_id = 
> str(self.correlation_id.next())
>  self.sender.send(request)
>  def wakeup():
>  return self.response and (self.response.correlation_id == 
> correlation_id)
> {noformat}
> After applying the patch, the response does not time out.
> {noformat}
> $ python
> Python 3.6.1 (default, Apr 24 2017, 09:59:45)
> [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
> Type "help", "copyright", "credits" or "license" for more information.
> >>> address = 
> >>> 'amqps://REDACTED_USERNAME:REDACTED_PASSWORD@REDACTED_IP_ADDR:5672/qmf.default.direct'
> >>> from proton import Url
> >>> url = Url(address)
> >>>
> >>> from proton.utils import SyncRequestResponse, BlockingConnection
> >>> client = SyncRequestResponse(BlockingConnection(url, timeout=15, 
> >>> target='qmf.default.direct', sasl_enabled=True, allowed_mechs='PLAIN'), 
> >>> 'qmf.default.direct')
> >>>
> >>> content = {'_what': 'OBJECT', '_schema_id': {'_class_name': 'queue'}}
> >>> properties = {'x-amqp-0-10.app-id': 'qmf2', 'qmf.opcode': 
> >>> '_query_request', 'method': 'request'}
> >>>
> >>> from proton import Message
> >>> m = Message(reply_to=client.receiver.remote_source.address, 
> >>> address=address, body=content, properties=properties, subject='broker')
> >>> r = client.call(m)
> >>> r.body
> [{'_create_ts': ulong(1500315523092865467), '_delete_ts': ulong(0), 
> '_object_id': {'_agent_epoch': ulong(3), '_object_name': 
> b'org.apache.qpid.broker:queue:420cb745-f3c7-4a47-ac09-0a4711f10058:1.0'}, 
> '_schema_id': {'_class_name': b'queue', '_hash': 
> UUID('84ce326e-2cbd-6899-80d7-6267d3327e0f'), '_package_name': 
>

[jira] [Commented] (PROTON-1651) Correct spelling errors

2017-12-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284680#comment-16284680
 ] 

ASF GitHub Bot commented on PROTON-1651:


Github user jdanekrh commented on the issue:

https://github.com/apache/qpid-proton/pull/127
  
I am ok leaving injecter be. I still have these three suggested changes 
open (which I only mentioned in the discussion but weren't part of the PR). 
I'll mention them on a new ticket, If I ever do another spellcheck pass over 
the codebase.

> Now that we've covered the basics with the archetypical hello world app, 
let's look at some more interesting examples.

archetypal, maybe?

> decreffed

how many f's? this will require some English language skills, because 
proton has instances of f and ff both and spellcheckers recognize neither 
variant

> transport_consume(transport);// blech - testBindAfterOpen

What is blech?


> Correct spelling errors
> ---
>
> Key: PROTON-1651
> URL: https://issues.apache.org/jira/browse/PROTON-1651
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Minor
> Fix For: proton-c-0.19.0
>
> Attachments: idea_dictionary.xml
>
>
> I've noticed some typos. I believe systematic approach in trying to get rid 
> of them is in order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-12-09 Thread jdanekrh 
Github user jdanekrh closed the pull request at:

https://github.com/apache/qpid-proton/pull/127


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-12-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285023#comment-16285023
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 89b6ea16d080883eb9839e4200d8ffbc2436aff8 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=89b6ea1 ]

QPID-6933: [System Tests] Move ObjectMessageTest into JMS 1.1 system tests


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-09 Thread dmitrytokarev 
Github user dmitrytokarev commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
@jdanekrh well it doesn't really matter how it's done as long as community 
contributions are authored and recognized. Some people may show case their 
github accounts on their resumes, so if they don't get credit for their work, 
they have nothing to showcase. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1517) SyncRequestResponse(BlockingConnection).call() fails with timeout

2017-12-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285116#comment-16285116
 ] 

ASF GitHub Bot commented on PROTON-1517:


Github user dmitrytokarev commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
@jdanekrh well it doesn't really matter how it's done as long as community 
contributions are authored and recognized. Some people may show case their 
github accounts on their resumes, so if they don't get credit for their work, 
they have nothing to showcase. 


> SyncRequestResponse(BlockingConnection).call() fails with timeout
> -
>
> Key: PROTON-1517
> URL: https://issues.apache.org/jira/browse/PROTON-1517
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: proton-c-0.17.0
> Environment: macOS Sierra 10.12.5
> Python 3.6.1
>Reporter: aikchar
>Assignee: Justin Ross
>  Labels: easyfix, patch
> Fix For: proton-c-0.19.0
>
>
> Send a QMFv2 message using SyncRequestResponse.call(). The response times out.
> h2. Repro
> This repro uses the example from 
> https://qpid.apache.org/releases/qpid-proton-0.17.0/proton/python/examples/sync_client.py.html.
> {noformat}
> $ python
> Python 3.6.1 (default, Apr 24 2017, 09:59:45)
> [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
> Type "help", "copyright", "credits" or "license" for more information.
> >>> address = 
> >>> 'amqps://REDACTED_USERNAME:REDACTED_PASSWORD@REDACTED_IP_ADDR:5672/qmf.default.direct'
> >>> from proton import Url
> >>> url = Url(address)
> >>>
> >>> from proton.utils import SyncRequestResponse, BlockingConnection
> >>> client = SyncRequestResponse(BlockingConnection(url, timeout=15, 
> >>> target='qmf.default.direct', sasl_enabled=True, allowed_mechs='PLAIN'), 
> >>> 'qmf.default.direct')
> >>>
> >>> content = {'_what': 'OBJECT', '_schema_id': {'_class_name': 'queue'}}
> >>> properties = {'x-amqp-0-10.app-id': 'qmf2', 'qmf.opcode': 
> >>> '_query_request', 'method': 'request'}
> >>>
> >>> from proton import Message
> >>> m = Message(reply_to=client.receiver.remote_source.address, 
> >>> address=address, body=content, properties=properties, subject='broker')
> >>> r = client.call(m)
> Traceback (most recent call last):
>   File "", line 1, in 
>   File 
> "/Users/hamza.sheikh/virtualenvs/flight-test-py36/lib/python3.6/site-packages/proton/utils.py",
>  line 400, in call
> self.connection.wait(wakeup, msg="Waiting for response")
>   File 
> "/Users/hamza.sheikh/virtualenvs/flight-test-py36/lib/python3.6/site-packages/proton/utils.py",
>  line 288, in wait
> raise Timeout(txt)
> proton.Timeout: Connection 
> amqps://REDACTED_USERNAME:REDACTED_PASSWORD@REDACTED_IP_ADDR:5672/qmf.default.direct
>  timed out: Waiting for response
> >>>
> {noformat}
> h2. Patch
> Patch is to make sure correlation_id is a string.
> {noformat}
> $ git diff
> diff --git a/proton-c/bindings/python/proton/utils.py 
> b/proton-c/bindings/python/proton/utils.py
> index 05ef80df..528ce338 100644
> --- a/proton-c/bindings/python/proton/utils.py
> +++ b/proton-c/bindings/python/proton/utils.py
> @@ -349,7 +349,7 @@ class SyncRequestResponse(IncomingMessageHandler):
>  if not self.address and not request.address:
>  raise ValueError("Request message has no address: %s" % request)
>  request.reply_to = self.reply_to
> -request.correlation_id = correlation_id = self.correlation_id.next()
> +request.correlation_id = correlation_id = 
> str(self.correlation_id.next())
>  self.sender.send(request)
>  def wakeup():
>  return self.response and (self.response.correlation_id == 
> correlation_id)
> {noformat}
> After applying the patch, the response does not time out.
> {noformat}
> $ python
> Python 3.6.1 (default, Apr 24 2017, 09:59:45)
> [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
> Type "help", "copyright", "credits" or "license" for more information.
> >>> address = 
> >>> 'amqps://REDACTED_USERNAME:REDACTED_PASSWORD@REDACTED_IP_ADDR:5672/qmf.default.direct'
> >>> from proton import Url
> >>> url = Url(address)
> >>>
> >>> from proton.utils import SyncRequestResponse, BlockingConnection
> >>> client = SyncRequestResponse(BlockingConnection(url, timeout=15, 
> >>> target='qmf.default.direct', sasl_enabled=True, allowed_mechs='PLAIN'), 
> >>> 'qmf.default.direct')
> >>>
> >>> content = {'_what': 'OBJECT', '_schema_id': {'_class_name': 'queue'}}
> >>> properties = {'x-amqp-0-10.app-id': 'qmf2', 'qmf.opcode': 
> >>> '_query_request', 'method': 'request'}
> >>>
> >>> from proton import Message
> >>> m = Message(reply_to=client.receiver.remote_source.address, 
> >>> address=address, body=content,