Re: [GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...

2018-09-26 Thread Alan Conway
On Wed, Sep 26, 2018 at 10:38 AM astitcher wrote: > > What is 'multiple="true" field'? There is nothing called this in the > standard is there? Alas there is, which is where the problem started. It is *yet another* way to represent a variable-length sequence of identically typed values

Re: [GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...

2018-09-26 Thread Alan Conway
On Wed, Sep 26, 2018 at 10:38 AM astitcher wrote: > Github user astitcher commented on a diff in the pull request: > > https://github.com/apache/qpid-proton/pull/159#discussion_r220587685 > > --- Diff: c/src/core/codec.c --- > @@ -529,15 +529,15 @@ int pn_data_vfill(pn_data_t *data,

[GitHub] qpid-proton issue #159: PROTON-1940: [c] normalize encoding of multiple="tru...

2018-09-26 Thread alanconway
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/159 Changes prompted by astitcher's comments: - better explanation of mulitple fields, corrected AMQP spec links - added block comment for vfill format letters - factored out

[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628992#comment-16628992 ] ASF GitHub Bot commented on PROTON-1940: Github user alanconway commented on the issue:

[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628869#comment-16628869 ] ASF GitHub Bot commented on PROTON-1940: Github user astitcher commented on a diff in the pull

[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628870#comment-16628870 ] ASF GitHub Bot commented on PROTON-1940: Github user astitcher commented on a diff in the pull

[GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...

2018-09-26 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/159#discussion_r220587685 --- Diff: c/src/core/codec.c --- @@ -529,15 +529,15 @@ int pn_data_vfill(pn_data_t *data, const char *fmt, va_list ap) case 'd':

[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629179#comment-16629179 ] ASF GitHub Bot commented on DISPATCH-1096: -- GitHub user mgoulish opened a pull request:

[GitHub] qpid-proton pull request #150: PROTON-1888: allow configuration of connectio...

2018-09-26 Thread grs
Github user grs closed the pull request at: https://github.com/apache/qpid-proton/pull/150 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1888) Allow configuration of connection details via a simple config file

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629005#comment-16629005 ] ASF GitHub Bot commented on PROTON-1888: Github user grs closed the pull request at:

[GitHub] qpid-dispatch pull request #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread mgoulish
GitHub user mgoulish opened a pull request: https://github.com/apache/qpid-dispatch/pull/384 DISPATCH-1096 - priority sheaf cleanup bug This is for the bug that Ganesh and Chuck saw while killing and restarting routers. The test succeeded 10 times each (with 0 false results) in

[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629187#comment-16629187 ] ASF GitHub Bot commented on DISPATCH-1096: -- Github user codecov-io commented on the issue:

[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/384 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/384?src=pr=h1) Report > Merging [#384](https://codecov.io/gh/apache/qpid-dispatch/pull/384?src=pr=desc) into

[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629377#comment-16629377 ] ASF GitHub Bot commented on DISPATCH-1096: -- Github user ted-ross commented on a diff in the

[GitHub] qpid-dispatch pull request #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread ted-ross
Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/384#discussion_r220714152 --- Diff: src/router_core/connections.c --- @@ -1466,8 +1470,8 @@ static void qdr_attach_link_data_CT(qdr_core_t *core, qdr_connection_t *conn, qd

[jira] [Commented] (PROTON-1941) Add WritableBuffer API for requesting space when writing complex types

2018-09-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629326#comment-16629326 ] ASF subversion and git services commented on PROTON-1941: - Commit

[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/384 This patch clears up the too-many-links for sheaf error and improves my router network stability. FOr this I approve the patch. But in tests before and after this patch my throughput

[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629348#comment-16629348 ] ASF GitHub Bot commented on DISPATCH-1096: -- Github user ChugR commented on the issue:

[jira] [Created] (DISPATCH-1130) Expose which message priority is being handled by an inter-router link

2018-09-26 Thread Ernest Allen (JIRA)
Ernest Allen created DISPATCH-1130: -- Summary: Expose which message priority is being handled by an inter-router link Key: DISPATCH-1130 URL: https://issues.apache.org/jira/browse/DISPATCH-1130

[jira] [Closed] (PROTON-1764) Slow performance seen when running Go client

2018-09-26 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway closed PROTON-1764. --- Resolution: Duplicate     > Slow performance seen when running Go client >

[jira] [Created] (PROTON-1941) Add WritableBuffer API for requesting space when writing complex types

2018-09-26 Thread Timothy Bish (JIRA)
Timothy Bish created PROTON-1941: Summary: Add WritableBuffer API for requesting space when writing complex types Key: PROTON-1941 URL: https://issues.apache.org/jira/browse/PROTON-1941 Project: Qpid

[jira] [Resolved] (PROTON-1941) Add WritableBuffer API for requesting space when writing complex types

2018-09-26 Thread Timothy Bish (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish resolved PROTON-1941. -- Resolution: Fixed > Add WritableBuffer API for requesting space when writing complex types >

[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629382#comment-16629382 ] ASF GitHub Bot commented on DISPATCH-1096: -- Github user ted-ross commented on the issue:

[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread ted-ross
Github user ted-ross commented on the issue: https://github.com/apache/qpid-dispatch/pull/384 > This patch clears up the too-many-links for sheaf error and improves my router network stability. FOr this I approve the patch. > > But in tests before and after this patch my

[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread ted-ross
Github user ted-ross commented on the issue: https://github.com/apache/qpid-dispatch/pull/384 > > This patch clears up the too-many-links for sheaf error and improves my router network stability. FOr this I approve the patch. > > But in tests before and after this patch my

[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629442#comment-16629442 ] ASF GitHub Bot commented on DISPATCH-1096: -- Github user ted-ross commented on the issue:

[jira] [Resolved] (PROTON-1888) Allow configuration of connection details via a simple config file

2018-09-26 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved PROTON-1888. Resolution: Fixed Fix Version/s: proton-c-0.26.0 > Allow configuration of connection

[jira] [Comment Edited] (PROTON-1862) Idle timeout not working on Linux

2018-09-26 Thread Ali Hadi (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627391#comment-16627391 ] Ali Hadi edited comment on PROTON-1862 at 9/26/18 8:51 AM: --- Hello, We