[jira] [Commented] (QPID-8273) [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when sending message to consumer
[
https://issues.apache.org/jira/browse/QPID-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760278#comment-16760278
]
ASF GitHub Bot commented on QPID-8273:
--
alex-rufous commented on pull request #19: QPID-8273: [Broker-J] Validate
headers
URL: https://github.com/apache/qpid-broker-j/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when
> sending message to consumer
> -
>
> Key: QPID-8273
> URL: https://issues.apache.org/jira/browse/QPID-8273
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker can crash with BufferOverflowException when sending message to
> consumer. The stack trace like the one below is reported into Qpid Broker
> logs.
> {noformat}
> (o.a.q.s.Main) - Uncaught exception, shutting down.
> java.nio.BufferOverflowException: null
> at java.nio.Buffer.nextPutIndex(Buffer.java:527)
> at java.nio.DirectByteBuffer.putLong(DirectByteBuffer.java:797)
> at
> org.apache.qpid.bytebuffer.QpidByteBuffer.putLong(QpidByteBuffer.java:500)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:293)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:471)
> at
> org.apache.qpid.framing.ContentHeaderBody.writePayload(ContentHeaderBody.java:100)
> at org.apache.qpid.framing.AMQFrame.writePayload(AMQFrame.java:69)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl$CompositeAMQBodyBlock.writePayload(ProtocolOutputConverterImpl.java:542)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl.writeFrame(AMQPConnection_0_8Impl.java:382)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeFrame(ProtocolOutputConverterImpl.java:501)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDeliveryUnchanged(ProtocolOutputConverterImpl.java:227)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:138)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:95)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeDeliver(ProtocolOutputConverterImpl.java:72)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$WriteDeliverMethod.deliverToClient(AMQPConnection_0_8Impl.java:1275)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.sendToClient(ConsumerTarget_0_8.java:452)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$AckConsumer.doSend(ConsumerTarget_0_8.java:274)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.sendNextMessage(AbstractConsumerTarget.java:327)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.processPending(AbstractConsumerTarget.java:99)
> at
> org.apache.qpid.server.protocol.v0_8.AMQChannel.processPending(AMQChannel.java:3797)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$ProcessPendingIterator$1.run(AMQPConnection_0_8Impl.java:1447)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.processPending(NonBlockingConnection.java:375)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:279)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:130)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:563)
> at
>
[jira] [Commented] (QPID-8273) [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when sending message to consumer
[
https://issues.apache.org/jira/browse/QPID-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760280#comment-16760280
]
ASF GitHub Bot commented on QPID-8273:
--
alex-rufous commented on pull request #20: QPID-8273: [Broker-J] Recalculate
encoded size of malformed field table
URL: https://github.com/apache/qpid-broker-j/pull/20
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when
> sending message to consumer
> -
>
> Key: QPID-8273
> URL: https://issues.apache.org/jira/browse/QPID-8273
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker can crash with BufferOverflowException when sending message to
> consumer. The stack trace like the one below is reported into Qpid Broker
> logs.
> {noformat}
> (o.a.q.s.Main) - Uncaught exception, shutting down.
> java.nio.BufferOverflowException: null
> at java.nio.Buffer.nextPutIndex(Buffer.java:527)
> at java.nio.DirectByteBuffer.putLong(DirectByteBuffer.java:797)
> at
> org.apache.qpid.bytebuffer.QpidByteBuffer.putLong(QpidByteBuffer.java:500)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:293)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:471)
> at
> org.apache.qpid.framing.ContentHeaderBody.writePayload(ContentHeaderBody.java:100)
> at org.apache.qpid.framing.AMQFrame.writePayload(AMQFrame.java:69)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl$CompositeAMQBodyBlock.writePayload(ProtocolOutputConverterImpl.java:542)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl.writeFrame(AMQPConnection_0_8Impl.java:382)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeFrame(ProtocolOutputConverterImpl.java:501)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDeliveryUnchanged(ProtocolOutputConverterImpl.java:227)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:138)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:95)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeDeliver(ProtocolOutputConverterImpl.java:72)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$WriteDeliverMethod.deliverToClient(AMQPConnection_0_8Impl.java:1275)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.sendToClient(ConsumerTarget_0_8.java:452)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$AckConsumer.doSend(ConsumerTarget_0_8.java:274)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.sendNextMessage(AbstractConsumerTarget.java:327)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.processPending(AbstractConsumerTarget.java:99)
> at
> org.apache.qpid.server.protocol.v0_8.AMQChannel.processPending(AMQChannel.java:3797)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$ProcessPendingIterator$1.run(AMQPConnection_0_8Impl.java:1447)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.processPending(NonBlockingConnection.java:375)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:279)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:130)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:563)
>
[GitHub] alex-rufous opened a new pull request #20: QPID-8273: [Broker-J] Recalculate encoded size of malformed field table
alex-rufous opened a new pull request #20: QPID-8273: [Broker-J] Recalculate encoded size of malformed field table URL: https://github.com/apache/qpid-broker-j/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] alex-rufous opened a new pull request #19: QPID-8273: [Broker-J] Validate headers
alex-rufous opened a new pull request #19: QPID-8273: [Broker-J] Validate headers URL: https://github.com/apache/qpid-broker-j/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] alex-rufous opened a new pull request #18: QPID-8273: [Broker-J] Preserve encoded form of malformed field table on clean-up
alex-rufous opened a new pull request #18: QPID-8273: [Broker-J] Preserve encoded form of malformed field table on clean-up URL: https://github.com/apache/qpid-broker-j/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8273) [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when sending message to consumer
[
https://issues.apache.org/jira/browse/QPID-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760277#comment-16760277
]
ASF GitHub Bot commented on QPID-8273:
--
alex-rufous commented on pull request #18: QPID-8273: [Broker-J] Preserve
encoded form of malformed field table on clean-up
URL: https://github.com/apache/qpid-broker-j/pull/18
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when
> sending message to consumer
> -
>
> Key: QPID-8273
> URL: https://issues.apache.org/jira/browse/QPID-8273
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker can crash with BufferOverflowException when sending message to
> consumer. The stack trace like the one below is reported into Qpid Broker
> logs.
> {noformat}
> (o.a.q.s.Main) - Uncaught exception, shutting down.
> java.nio.BufferOverflowException: null
> at java.nio.Buffer.nextPutIndex(Buffer.java:527)
> at java.nio.DirectByteBuffer.putLong(DirectByteBuffer.java:797)
> at
> org.apache.qpid.bytebuffer.QpidByteBuffer.putLong(QpidByteBuffer.java:500)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:293)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:471)
> at
> org.apache.qpid.framing.ContentHeaderBody.writePayload(ContentHeaderBody.java:100)
> at org.apache.qpid.framing.AMQFrame.writePayload(AMQFrame.java:69)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl$CompositeAMQBodyBlock.writePayload(ProtocolOutputConverterImpl.java:542)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl.writeFrame(AMQPConnection_0_8Impl.java:382)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeFrame(ProtocolOutputConverterImpl.java:501)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDeliveryUnchanged(ProtocolOutputConverterImpl.java:227)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:138)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:95)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeDeliver(ProtocolOutputConverterImpl.java:72)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$WriteDeliverMethod.deliverToClient(AMQPConnection_0_8Impl.java:1275)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.sendToClient(ConsumerTarget_0_8.java:452)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$AckConsumer.doSend(ConsumerTarget_0_8.java:274)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.sendNextMessage(AbstractConsumerTarget.java:327)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.processPending(AbstractConsumerTarget.java:99)
> at
> org.apache.qpid.server.protocol.v0_8.AMQChannel.processPending(AMQChannel.java:3797)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$ProcessPendingIterator$1.run(AMQPConnection_0_8Impl.java:1447)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.processPending(NonBlockingConnection.java:375)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:279)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:130)
> at
>
[jira] [Updated] (DISPATCH-1262) GCC 8.2 format-truncation error in router/src/main.c
[
https://issues.apache.org/jira/browse/DISPATCH-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-1262:
-
Description:
When {{-DUSE_SANITIZERS=ON}}, this (in RelWithDebug build) results in
{{-fsanitize=undefined -O2}} options being passed to GCC (as well as others,
but these seem relevant).
GCC then fails the compilation
{code}
[ 98%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o
cd /home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router &&
/nix/store/wxq0gf50466p7aiddmiiwlxm1cs6mhbn-gcc-wrapper-8.2.0/bin/cc
-I/home/jdanek/Work/repos/qpid-dispatch/include
-I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/include
-I/home/jdanek/Work/repos/qpid-proton/build/install/include
-I/nix/store/l95nkqp7bdimqnz9ixay1aahljzsz7vc-python-2.7.15/include/python2.7
-I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router
-fsanitize=address -fsanitize=leak -fsanitize=undefined -O2 -g -DNDEBUG -g
-fno-omit-frame-pointer -Werror -Wall -Wpedantic -std=gnu99 -pthread -o
CMakeFiles/qdrouterd.dir/src/main.c.o -c
/home/jdanek/Work/repos/qpid-dispatch/router/src/main.c
{code}
{code}
/home/jdanek/Work/repos/qpid-dispatch/router/src/main.c: In function
‘daemon_process’:
/home/jdanek/Work/repos/qpid-dispatch/router/src/main.c:209:58: error: ‘%s’
directive argument is null [-Werror=format-truncation=]
snprintf(config_path_full, cpf_len, "%s%s%s",
^~
cc1: all warnings being treated as errors
{code}
I believe that GCC should much improve diagnostic messages, if it intends to
search for dataflows like this, because the error does not give context.
It is IMO legit, just super unlikely thing to happen, though.
was:
When {{-DUSE_SANITIZERS=ON}}, this (in RelWithDebug build) results in
{{-fsanitize=ubsan -O2}} options being passed to GCC (as well as others, but
these seem relevant).
GCC then fails the compilation
{code}
[ 98%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o
cd /home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router &&
/nix/store/wxq0gf50466p7aiddmiiwlxm1cs6mhbn-gcc-wrapper-8.2.0/bin/cc
-I/home/jdanek/Work/repos/qpid-dispatch/include
-I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/include
-I/home/jdanek/Work/repos/qpid-proton/build/install/include
-I/nix/store/l95nkqp7bdimqnz9ixay1aahljzsz7vc-python-2.7.15/include/python2.7
-I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router
-fsanitize=address -fsanitize=leak -fsanitize=undefined -O2 -g -DNDEBUG -g
-fno-omit-frame-pointer -Werror -Wall -Wpedantic -std=gnu99 -pthread -o
CMakeFiles/qdrouterd.dir/src/main.c.o -c
/home/jdanek/Work/repos/qpid-dispatch/router/src/main.c
{code}
{code}
/home/jdanek/Work/repos/qpid-dispatch/router/src/main.c: In function
‘daemon_process’:
/home/jdanek/Work/repos/qpid-dispatch/router/src/main.c:209:58: error: ‘%s’
directive argument is null [-Werror=format-truncation=]
snprintf(config_path_full, cpf_len, "%s%s%s",
^~
cc1: all warnings being treated as errors
{code}
I believe that GCC should much improve diagnostic messages, if it intends to
search for dataflows like this, because the error does not give context.
It is IMO legit, just super unlikely thing to happen, though.
> GCC 8.2 format-truncation error in router/src/main.c
>
>
> Key: DISPATCH-1262
> URL: https://issues.apache.org/jira/browse/DISPATCH-1262
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: Backlog
> Environment: Fedora 29 or anything with GCC 8.2, when the mentioned
> flags are used.
>Reporter: Jiri Daněk
>Priority: Major
>
> When {{-DUSE_SANITIZERS=ON}}, this (in RelWithDebug build) results in
> {{-fsanitize=undefined -O2}} options being passed to GCC (as well as others,
> but these seem relevant).
> GCC then fails the compilation
> {code}
> [ 98%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o
> cd /home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router &&
> /nix/store/wxq0gf50466p7aiddmiiwlxm1cs6mhbn-gcc-wrapper-8.2.0/bin/cc
> -I/home/jdanek/Work/repos/qpid-dispatch/include
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/include
> -I/home/jdanek/Work/repos/qpid-proton/build/install/include
> -I/nix/store/l95nkqp7bdimqnz9ixay1aahljzsz7vc-python-2.7.15/include/python2.7
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router
> -fsanitize=address -fsanitize=leak -fsanitize=undefined -O2 -g -DNDEBUG -g
> -fno-omit-frame-pointer -Werror -Wall -Wpedantic -std=gnu99 -pthread -o
>
[jira] [Updated] (QPID-7192) [Broker-J] BDB HA Virtual Host Node does not restart successfully if JE environment has locally committed transactions requiring rollback
[
https://issues.apache.org/jira/browse/QPID-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-7192:
-
Summary: [Broker-J] BDB HA Virtual Host Node does not restart successfully
if JE environment has locally committed transactions requiring rollback (was:
[Java Broker] BDB HA Virtual Host Node does not restart successfully if JE
environment has locally committed transactions requiring rollback)
> [Broker-J] BDB HA Virtual Host Node does not restart successfully if JE
> environment has locally committed transactions requiring rollback
> -
>
> Key: QPID-7192
> URL: https://issues.apache.org/jira/browse/QPID-7192
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.1, qpid-java-broker-7.1.0,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
> Attachments: QPID-7192-wip.diff
>
>
> Start-up of BDB HA VHN fails in the following scenario:
> 1) When Transaction on Master node is in process of commit and the replicas
> BDB HA VHNs are stopped at the same time, the transaction is aborted with
> InsufficientReplicasException
> 2) BDB HA VHN for replicas are restarted and the Replica environment detects
> a transaction requiring rollback from previous commit. The rollback
> transaction causes restart of JE Environment.
> 3) BDB HA VHN for impacted replica continues activation and performs an
> intruder protection checks but Environment is restarting which results in
> exception "ConnectionScopedRuntimeException: Environment is restarting". The
> exception puts BDB HA VHN into ERRORED state. JE environment re-join the
> group successfully but BDB HA VHN is not aware about it, as
> StateChangeListener is not set and BDB HA VHN does not receive notifications
> about state transitions
> A manual operator intervention is required to recover from the issue: BDB HA
> VHN needs to be started up again by invoking state change operation from Web
> Management Console or REST API.
>
> Here are JE Exceptions reported on Replica side on transaction rollback:
> {noformat}
> BROKER-20 WARN [DETACHED
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2)]
> o.a.q.s.s.b.r.ReplicatedEnvironmentFacade
> test:nodetestInFlightTransactionsWhilstMajorityIsLost10004 has transaction(s)
> ahead of the current master. These must be discarded to allow this node to
> rejoin the group. This condition is normally caused by the use of weak
> durability options.
> BROKER-20 DEBUG [DETACHED
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2)]
> o.a.q.s.s.b.r.ReplicatedEnvironmentFacade Environment restarting due to
> exception (JE 5.0.104)
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2):/tmp/qpid-work-org.apache.qpid.server.store.berkeleydb.replication.MultiNodeTest.testInFlightTransactionsWhilstMajorityIsLost-20-6184300293922905690/test/config
> Node
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2):/tmp/qpid-work-org.apache.qpid.server.store.berkeleydb.replication.MultiNodeTest.testInFlightTransactionsWhilstMajorityIsLost-20-6184300293922905690/test/config
> must rollback 3 commits to the earliest point indicated by transaction
> id=-142 time=2016-04-08 00:16:16.384 vlsn=356 lsn=0x0/0x8332 in order to
> rejoin the replication group. All existing ReplicatedEnvironment handles must
> be closed and reinstantiated. Log files were truncated to file 0x0, offset
> 0x33469, vlsn 353 HARD_RECOVERY: Rolled back past transaction commit or
> abort. Must run recovery by re-opening Environment handles Environment is
> invalid and must be closed.
> com.sleepycat.je.rep.RollbackException: (JE 5.0.104)
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2):/tmp/qpid-work-org.apache.qpid.server.store.berkeleydb.replication.MultiNodeTest.testInFlightTransactionsWhilstMajorityIsLost-20-6184300293922905690/test/config
> Node
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2):/tmp/qpid-work-org.apache.qpid.server.store.berkeleydb.replication.MultiNodeTest.testInFlightTransactionsWhilstMajorityIsLost-20-6184300293922905690/test/config
> must rollback 3 commits to the earliest point indicated by transaction
> id=-142 time=2016-04-08 00:16:16.384 vlsn=356 lsn=0x0/0x8332 in order to
> rejoin the replication group. All existing ReplicatedEnvironment handles must
> be closed and reinstantiated. Log files were truncated to file 0x0, offset
> 0x33469, vlsn 353 HARD_RECOVERY: Rolled back past transaction commit or
> abort. Must run recovery by re-opening Environment handles Environment is
> invalid and must be closed.
> at
>
[jira] [Closed] (QPID-8252) [Broker-J][BDB HA] Start-up of BDB HA Virtual Host Node can hang sporadically
[
https://issues.apache.org/jira/browse/QPID-8252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy closed QPID-8252.
Resolution: Duplicate
Duplicate of QPID-8274
> [Broker-J][BDB HA] Start-up of BDB HA Virtual Host Node can hang sporadically
> --
>
> Key: QPID-8252
> URL: https://issues.apache.org/jira/browse/QPID-8252
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2,
> qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-6.1.7,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
> Attachments: qpid-broker.log.txt
>
>
> Start-up of BDB HA Virtual Host Node can hang sporadically with issuing the
> following entries into broker logs:
> {noformat}
> 2018-08-24 19:02:16,249 WARN [Broker-Config]
> (o.a.q.s.s.b.r.ReplicatedEnvironmentFacade) - Slow replicated environment
> creation for tdome_prod:qpid1_B. Will continue to wait for further 135000ms.
> for environment creation to complete.
> 2018-08-24 19:04:31,265 ERROR [Broker-Config]
> (o.a.q.s.m.AbstractConfiguredObject) - Failed to open object with name
> 'qpid1_B'. Object will be put into ERROR state.
> java.lang.RuntimeException: JE replicated environment creation took too long
> (permitted time 18ms)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironmentInSeparateThread(ReplicatedEnvironmentFacade.java:1577)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironment(ReplicatedEnvironmentFacade.java:1521)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.(ReplicatedEnvironmentFacade.java:287)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeFactory.createEnvironmentFacade(ReplicatedEnvironmentFacadeFactory.java:130)
> at
> org.apache.qpid.server.store.berkeleydb.BDBConfigurationStore.init(BDBConfigurationStore.java:122)
> at
> org.apache.qpid.server.virtualhostnode.berkeleydb.BDBHAVirtualHostNodeImpl.activate(BDBHAVirtualHostNodeImpl.java:338)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2635)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:360)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2634)
> at
> com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1237)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$ImmediateIfSameThreadExecutor.execute(TaskExecutorImpl.java:400)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.execute(TaskExecutorImpl.java:183)
> at
> com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:911)
> at
> com.google.common.util.concurrent.AbstractFuture.addListener(AbstractFuture.java:645)
> at
> com.google.common.util.concurrent.AbstractFuture$TrustedFuture.addListener(AbstractFuture.java:101)
> at
> com.google.common.util.concurrent.Futures.addCallback(Futures.java:1209)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.addFutureCallback(AbstractConfiguredObject.java:2629)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.doAttainState(AbstractConfiguredObject.java:1063)
> at
>
[jira] [Commented] (DISPATCH-995) gcc 8.1 format-truncation errors
[
https://issues.apache.org/jira/browse/DISPATCH-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759766#comment-16759766
]
Jiri Daněk commented on DISPATCH-995:
-
This was fixed in DISPATCH-1011: Improve user name substitution token logic and
code (on May 31st 2018).
Apparently, Coverity has bigger screaming power than GCC. Too bad Coverity Scan
service is down right now...
This ticket can be IMO closed.
> gcc 8.1 format-truncation errors
>
>
> Key: DISPATCH-995
> URL: https://issues.apache.org/jira/browse/DISPATCH-995
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
> Environment: * Distribution Archlinux
> * GCC 8.1.0
> * LIBWEBSOCKETS 2.4.2
> * Python 2.7.15
> * Qpid Proton HEAD (94dfe1bf)
> * Qpid Dispatch HEAD (fe1f711e2)
>Reporter: Dominik Lenoch
>Priority: Major
>
> When attempting to build with gcc 8.1.0, I get several warnings-turned-errors
> about format-truncation:
> {code:java}
> cmake .. \
> -DPYTHON_EXECUTABLE=/usr/bin/python2.7 \
> -DPYTHON_INCLUDE_DIR=/usr/include/python2.7/ \
> -DPYTHON_LIBRARY=/lib/libpython2.7.so \
> -DCMAKE_INSTALL_PREFIX=/usr \
> -DUSE_LIBWEBSOCKETS=ON \
> -DBUILD_DOCS=OFF \
> -DUSE_VALGRIND=OFF \
> -DUSE_SANITIZERS=OFF \
> -DUSE_TSAN=OFF
> -- Build type is "RelWithDebInfo" (has debug symbols)
> -- The C compiler identification is GNU 8.1.0
> -- Check for working C compiler: /usr/bin/cc
> -- Check for working C compiler: /usr/bin/cc -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Found PythonInterp: /usr/bin/python2.7 (found version "2.7.15")
> -- Found PythonLibs: /lib/libpython2.7.so (found version "2.7.15")
> -- Found Proton:
> optimized;/usr/lib/libqpid-proton.so;debug;/usr/lib/libqpid-proton.so (found
> version "0.23.0")
> -- Found LIBWEBSOCKETS: 2.4.2
> -- Found VALGRIND: /usr/bin/valgrind
> -- Performing Test HAS_PEDANTIC_FLAG
> -- Performing Test HAS_PEDANTIC_FLAG - Success
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /tmp/qpid-dispatch/build
> cmake --build .
> [ 1%] Generating schema_enum.h, schema_enum.c
> Scanning dependencies of target qpid-dispatch
> [ 2%] Building C object src/CMakeFiles/qpid-dispatch.dir/amqp.c.o
> [ 4%] Building C object src/CMakeFiles/qpid-dispatch.dir/bitmask.c.o
> [ 5%] Building C object src/CMakeFiles/qpid-dispatch.dir/buffer.c.o
> [ 6%] Building C object src/CMakeFiles/qpid-dispatch.dir/error.c.o
> [ 8%] Building C object src/CMakeFiles/qpid-dispatch.dir/compose.c.o
> [ 9%] Building C object
> src/CMakeFiles/qpid-dispatch.dir/connection_manager.c.o
> [ 11%] Building C object src/CMakeFiles/qpid-dispatch.dir/container.c.o
> [ 12%] Building C object src/CMakeFiles/qpid-dispatch.dir/dispatch.c.o
> [ 13%] Building C object src/CMakeFiles/qpid-dispatch.dir/entity.c.o
> [ 15%] Building C object src/CMakeFiles/qpid-dispatch.dir/entity_cache.c.o
> [ 16%] Building C object src/CMakeFiles/qpid-dispatch.dir/failoverlist.c.o
> [ 18%] Building C object src/CMakeFiles/qpid-dispatch.dir/hash.c.o
> [ 19%] Building C object src/CMakeFiles/qpid-dispatch.dir/iovec.c.o
> [ 20%] Building C object src/CMakeFiles/qpid-dispatch.dir/iterator.c.o
> [ 22%] Building C object src/CMakeFiles/qpid-dispatch.dir/log.c.o
> [ 23%] Building C object src/CMakeFiles/qpid-dispatch.dir/message.c.o
> [ 25%] Building C object src/CMakeFiles/qpid-dispatch.dir/parse.c.o
> [ 26%] Building C object src/CMakeFiles/qpid-dispatch.dir/parse_tree.c.o
> [ 27%] Building C object src/CMakeFiles/qpid-dispatch.dir/policy.c.o
> /tmp/qpid-dispatch/src/policy.c: In function
> ‘_qd_policy_link_user_name_subst’:
> /tmp/qpid-dispatch/src/policy.c:532:9: error: ‘strncpy’ output truncated
> copying between 0 and 7 bytes from a string of length 7
> [-Werror=stringop-truncation]
> strncpy(obuf, duser, copysize);
> ^~
> /tmp/qpid-dispatch/src/policy.c: In function ‘_qd_policy_approve_link_name’:
> /tmp/qpid-dispatch/src/policy.c:575:5: error: ‘strncpy’ output truncated
> before terminating nul copying as many bytes from a string as its length
> [-Werror=stringop-truncation]
> strncpy(pa, allowed, a_len);
> ^~~
> /tmp/qpid-dispatch/src/policy.c:560:20: note: length computed here
> size_t a_len = strlen(allowed);
> ^~~
> /tmp/qpid-dispatch/src/policy.c:575:5: error: ‘strncpy’ output truncated
> before terminating nul copying as many bytes from a string as its length
> [-Werror=stringop-truncation]
> strncpy(pa, allowed, a_len);
> ^~~
> /tmp/qpid-dispatch/src/policy.c:560:20: note: length computed here
> size_t a_len = strlen(allowed);
> ^~~
> cc1: all warnings being treated as errors
> make[2]: ***
[GitHub] jdanekrh opened a new pull request #447: NO-JIRA: remove unused declaration of _qd_policy_link_user_name_subst
jdanekrh opened a new pull request #447: NO-JIRA: remove unused declaration of _qd_policy_link_user_name_subst URL: https://github.com/apache/qpid-dispatch/pull/447 Relates to DISPATCH-1009, DISPATCH-1011 which removed the implementation. CC @ChugR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1262) GCC 8.2 format-truncation error in router/src/main.c
[
https://issues.apache.org/jira/browse/DISPATCH-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759794#comment-16759794
]
ASF GitHub Bot commented on DISPATCH-1262:
--
jdanekrh commented on pull request #448: DISPATCH-1262: fix GCC 8.2
format-truncation error in router/src/main.c
URL: https://github.com/apache/qpid-dispatch/pull/448
Gcc warns because `getcwd` on Linux may allocate and return new buffer,
so don't ignore the returned value. And cur_path may in theory be null
going in if previous `calloc` failed.
It is unlikely we would end up with cur_path = NULL as parameter to `%s`
in a formatting string later below, but it is possible, given very
careful timing and sufficiently malicious user, I think.
Change is made to silence GCC warning, so that ``-fsanitize=undefined`
compiles.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GCC 8.2 format-truncation error in router/src/main.c
>
>
> Key: DISPATCH-1262
> URL: https://issues.apache.org/jira/browse/DISPATCH-1262
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: Backlog
> Environment: Fedora 29 or anything with GCC 8.2, when the mentioned
> flags are used.
>Reporter: Jiri Daněk
>Priority: Major
>
> When {{-DUSE_SANITIZERS=ON}}, this (in RelWithDebug build) results in
> {{-fsanitize=undefined -O2}} options being passed to GCC (as well as others,
> but these seem relevant).
> GCC then fails the compilation
> {code}
> [ 98%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o
> cd /home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router &&
> /nix/store/wxq0gf50466p7aiddmiiwlxm1cs6mhbn-gcc-wrapper-8.2.0/bin/cc
> -I/home/jdanek/Work/repos/qpid-dispatch/include
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/include
> -I/home/jdanek/Work/repos/qpid-proton/build/install/include
> -I/nix/store/l95nkqp7bdimqnz9ixay1aahljzsz7vc-python-2.7.15/include/python2.7
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router
> -fsanitize=address -fsanitize=leak -fsanitize=undefined -O2 -g -DNDEBUG -g
> -fno-omit-frame-pointer -Werror -Wall -Wpedantic -std=gnu99 -pthread -o
> CMakeFiles/qdrouterd.dir/src/main.c.o -c
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c
> {code}
> {code}
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c: In function
> ‘daemon_process’:
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c:209:58: error: ‘%s’
> directive argument is null [-Werror=format-truncation=]
> snprintf(config_path_full, cpf_len, "%s%s%s",
> ^~
> cc1: all warnings being treated as errors
> {code}
> I believe that GCC should much improve diagnostic messages, if it intends to
> search for dataflows like this, because the error does not give context.
> It is IMO legit, just super unlikely thing to happen, though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] jdanekrh opened a new pull request #448: DISPATCH-1262: fix GCC 8.2 format-truncation error in router/src/main.c
jdanekrh opened a new pull request #448: DISPATCH-1262: fix GCC 8.2 format-truncation error in router/src/main.c URL: https://github.com/apache/qpid-dispatch/pull/448 Gcc warns because `getcwd` on Linux may allocate and return new buffer, so don't ignore the returned value. And cur_path may in theory be null going in if previous `calloc` failed. It is unlikely we would end up with cur_path = NULL as parameter to `%s` in a formatting string later below, but it is possible, given very careful timing and sufficiently malicious user, I think. Change is made to silence GCC warning, so that ``-fsanitize=undefined` compiles. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1009) _qd_policy_link_user_name_subst can return an unterminated string
[
https://issues.apache.org/jira/browse/DISPATCH-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759768#comment-16759768
]
Jiri Daněk commented on DISPATCH-1009:
--
[~chug] In {{src/policy_internal.h}} there is declaration for
{{_qd_policy_link_user_name_subst}}, but nothing calls it, and the body has
since been deleted. I'll send a NO-JIRA PR to remove the declaration.
> _qd_policy_link_user_name_subst can return an unterminated string
> -
>
> Key: DISPATCH-1009
> URL: https://issues.apache.org/jira/browse/DISPATCH-1009
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.0.1
>Reporter: Alan Conway
>Assignee: Chuck Rolke
>Priority: Major
>
> On fedora 28 the gcc 8.1.1 compiler gives this warning-as-error:
> /home/aconway/dispatch/src/policy.c: In function
> '_qd_policy_link_user_name_subst':
> /home/aconway/dispatch/src/policy.c:541:9: error: 'strncpy' output may be
> truncated copying between 0 and 8 bytes from a string of length 7
> [-Werror=stringop-truncation]
> strncpy(obuf, duser, copysize);
> ^~
> cc1: all warnings being treated as errors
>
> The error is correct: the function is using strncpy to copy a string into a
> space that may be too small for it, resulting in an un-terminated string.
> I fixed some similar issues already but I'm confused by what's going on here:
> it looks like we are searching for the uname parameter and replacing it with
> "${user}" which seems backwards.
> The function would be simpler and clearer if it used snprintf rather than
> successive strncpy, i.e.
> n = snprintf(obuf, osize, "%s%s%s", leading, duser, trailing);
> but the problem of properly handling the error if the resulting string is too
> big for obuf remains.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1262) GCC 8.2 format-truncation error in router/src/main.c
Jiri Daněk created DISPATCH-1262:
Summary: GCC 8.2 format-truncation error in router/src/main.c
Key: DISPATCH-1262
URL: https://issues.apache.org/jira/browse/DISPATCH-1262
Project: Qpid Dispatch
Issue Type: Bug
Affects Versions: Backlog
Environment: Fedora 29 or anything with GCC 8.2, when the mentioned
flags are used.
Reporter: Jiri Daněk
When {{-DUSE_SANITIZERS=ON}}, this (in RelWithDebug build) results in
{{-fsanitize=ubsan -O2}} options being passed to GCC (as well as others, but
these seem relevant).
GCC then fails the compilation
{code}
[ 98%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o
cd /home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router &&
/nix/store/wxq0gf50466p7aiddmiiwlxm1cs6mhbn-gcc-wrapper-8.2.0/bin/cc
-I/home/jdanek/Work/repos/qpid-dispatch/include
-I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/include
-I/home/jdanek/Work/repos/qpid-proton/build/install/include
-I/nix/store/l95nkqp7bdimqnz9ixay1aahljzsz7vc-python-2.7.15/include/python2.7
-I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router
-fsanitize=address -fsanitize=leak -fsanitize=undefined -O2 -g -DNDEBUG -g
-fno-omit-frame-pointer -Werror -Wall -Wpedantic -std=gnu99 -pthread -o
CMakeFiles/qdrouterd.dir/src/main.c.o -c
/home/jdanek/Work/repos/qpid-dispatch/router/src/main.c
{code}
{code}
/home/jdanek/Work/repos/qpid-dispatch/router/src/main.c: In function
‘daemon_process’:
/home/jdanek/Work/repos/qpid-dispatch/router/src/main.c:209:58: error: ‘%s’
directive argument is null [-Werror=format-truncation=]
snprintf(config_path_full, cpf_len, "%s%s%s",
^~
cc1: all warnings being treated as errors
{code}
I believe that GCC should much improve diagnostic messages, if it intends to
search for dataflows like this, because the error does not give context.
It is IMO legit, just super unlikely thing to happen, though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1246) Address Proxy module leaks qdrc_endpoint_t on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759940#comment-16759940 ] ASF subversion and git services commented on DISPATCH-1246: --- Commit 5ef146d159457892ddcdcca533487733c1ab4987 in qpid-dispatch's branch refs/heads/master from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=5ef146d ] DISPATCH-1246: clean up core link endpoints on shutdown This patch makes the following changes: o) the do_cleanup callback is always invoked then the core link endpoint is released. The callback is normally called right after second detach occurs, but it can also be called when the link is freed without cleanly detaching. o) moved the module finalization after the cleanup of links and endpoints on router shutdown. This ensures that all core link endpoints used by the modules are cleaned up before the finalization occurs. o) if the link has been lost (e.g. connection closed) then the detach link endpoint callback will not be called. The do_cleanup callback will be called instead. This closes #445 > Address Proxy module leaks qdrc_endpoint_t on shutdown > -- > > Key: DISPATCH-1246 > URL: https://issues.apache.org/jira/browse/DISPATCH-1246 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.5.0 >Reporter: Ken Giusti >Assignee: Chuck Rolke >Priority: Minor > Fix For: 1.6.0 > > > Running the system_tests_edge_router under valgrind: > ==21590== 657 (256 direct, 401 indirect) bytes in 4 blocks are definitely > lost in loss record 2,886 of 3,532 > ==21590==at 0x4C3147C: memalign (vg_replace_malloc.c:908) > ==21590==by 0x4C31589: posix_memalign (vg_replace_malloc.c:1072) > ==21590==by 0x4EA12FF: qd_alloc (alloc_pool.c:181) > ==21590==by 0x4E83086: qdrc_endpoint_create_link_CT > (core_link_endpoint.c:70) > ==21590==by 0x4E92C2C: on_conn_event (addr_proxy.c:237) > ==21590==by 0x4E92C2C: on_conn_event (addr_proxy.c:199) > ==21590==by 0x4E82E28: qdrc_event_conn_raise (core_events.c:90) > ==21590==by 0x4E82E28: qdrc_event_conn_raise (core_events.c:90) > ==21590==by 0x4E8123F: qdr_connection_opened_CT (connections.c:1147) > ==21590==by 0x4E8C916: router_core_thread (router_core_thread.c:124) > ==21590==by 0x5511593: start_thread (in /usr/lib64/libpthread-2.27.so) > ==21590==by 0x62A6F4E: clone (in /usr/lib64/libc-2.27.so) > ==21590== > Appears that the endpoint allocated here in addr_proxy.c: > // > // Attach a receiving link for edge address tracking updates. > // > ap->tracking_endpoint = > qdrc_endpoint_create_link_CT(ap->core, conn, QD_INCOMING, > > qdr_terminus_normal(QD_TERMINUS_EDGE_ADDRESS_TRACKING), > qdr_terminus(0), > >endpoint_descriptor, ap); > is not released when the router is shutdown -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1246) Address Proxy module leaks qdrc_endpoint_t on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759941#comment-16759941 ] ASF GitHub Bot commented on DISPATCH-1246: -- asfgit commented on pull request #445: DISPATCH-1246: clean up core link endpoints on shutdown URL: https://github.com/apache/qpid-dispatch/pull/445 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Address Proxy module leaks qdrc_endpoint_t on shutdown > -- > > Key: DISPATCH-1246 > URL: https://issues.apache.org/jira/browse/DISPATCH-1246 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.5.0 >Reporter: Ken Giusti >Assignee: Chuck Rolke >Priority: Minor > Fix For: 1.6.0 > > > Running the system_tests_edge_router under valgrind: > ==21590== 657 (256 direct, 401 indirect) bytes in 4 blocks are definitely > lost in loss record 2,886 of 3,532 > ==21590==at 0x4C3147C: memalign (vg_replace_malloc.c:908) > ==21590==by 0x4C31589: posix_memalign (vg_replace_malloc.c:1072) > ==21590==by 0x4EA12FF: qd_alloc (alloc_pool.c:181) > ==21590==by 0x4E83086: qdrc_endpoint_create_link_CT > (core_link_endpoint.c:70) > ==21590==by 0x4E92C2C: on_conn_event (addr_proxy.c:237) > ==21590==by 0x4E92C2C: on_conn_event (addr_proxy.c:199) > ==21590==by 0x4E82E28: qdrc_event_conn_raise (core_events.c:90) > ==21590==by 0x4E82E28: qdrc_event_conn_raise (core_events.c:90) > ==21590==by 0x4E8123F: qdr_connection_opened_CT (connections.c:1147) > ==21590==by 0x4E8C916: router_core_thread (router_core_thread.c:124) > ==21590==by 0x5511593: start_thread (in /usr/lib64/libpthread-2.27.so) > ==21590==by 0x62A6F4E: clone (in /usr/lib64/libc-2.27.so) > ==21590== > Appears that the endpoint allocated here in addr_proxy.c: > // > // Attach a receiving link for edge address tracking updates. > // > ap->tracking_endpoint = > qdrc_endpoint_create_link_CT(ap->core, conn, QD_INCOMING, > > qdr_terminus_normal(QD_TERMINUS_EDGE_ADDRESS_TRACKING), > qdr_terminus(0), > >endpoint_descriptor, ap); > is not released when the router is shutdown -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] asfgit closed pull request #445: DISPATCH-1246: clean up core link endpoints on shutdown
asfgit closed pull request #445: DISPATCH-1246: clean up core link endpoints on shutdown URL: https://github.com/apache/qpid-dispatch/pull/445 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1011) Policy username substitution fails to match certain user names
[
https://issues.apache.org/jira/browse/DISPATCH-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759923#comment-16759923
]
ASF subversion and git services commented on DISPATCH-1011:
---
Commit 0f7ab6d623b90cc57d99c1a4b42090c48cd4ac28 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=0f7ab6d ]
NO-JIRA: remove unused declaration of _qd_policy_link_user_name_subst
Relates to DISPATCH-1009, DISPATCH-1011 which removed the implementation.
> Policy username substitution fails to match certain user names
> --
>
> Key: DISPATCH-1011
> URL: https://issues.apache.org/jira/browse/DISPATCH-1011
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.0.1
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>Priority: Major
> Fix For: 1.2.0
>
>
> If a username is a substring of a policy rule's static text then the username
> substitution fails. For example:
> {{ if (!_qd_policy_approve_link_name("em", "temp-${user}", "temp-em"))}}
> {{ return "proposed link 'temp-em' should match allowed links with
> ${user} but does not";}}
> Since the username *em* is found in the fixed text of *temp-* then the
> substitution logic goes awry and the match fails. Thanks to aconway for
> making this observation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1009) _qd_policy_link_user_name_subst can return an unterminated string
[
https://issues.apache.org/jira/browse/DISPATCH-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759922#comment-16759922
]
ASF subversion and git services commented on DISPATCH-1009:
---
Commit 0f7ab6d623b90cc57d99c1a4b42090c48cd4ac28 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=0f7ab6d ]
NO-JIRA: remove unused declaration of _qd_policy_link_user_name_subst
Relates to DISPATCH-1009, DISPATCH-1011 which removed the implementation.
> _qd_policy_link_user_name_subst can return an unterminated string
> -
>
> Key: DISPATCH-1009
> URL: https://issues.apache.org/jira/browse/DISPATCH-1009
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.0.1
>Reporter: Alan Conway
>Assignee: Chuck Rolke
>Priority: Major
>
> On fedora 28 the gcc 8.1.1 compiler gives this warning-as-error:
> /home/aconway/dispatch/src/policy.c: In function
> '_qd_policy_link_user_name_subst':
> /home/aconway/dispatch/src/policy.c:541:9: error: 'strncpy' output may be
> truncated copying between 0 and 8 bytes from a string of length 7
> [-Werror=stringop-truncation]
> strncpy(obuf, duser, copysize);
> ^~
> cc1: all warnings being treated as errors
>
> The error is correct: the function is using strncpy to copy a string into a
> space that may be too small for it, resulting in an un-terminated string.
> I fixed some similar issues already but I'm confused by what's going on here:
> it looks like we are searching for the uname parameter and replacing it with
> "${user}" which seems backwards.
> The function would be simpler and clearer if it used snprintf rather than
> successive strncpy, i.e.
> n = snprintf(obuf, osize, "%s%s%s", leading, duser, trailing);
> but the problem of properly handling the error if the resulting string is too
> big for obuf remains.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] asfgit merged pull request #447: NO-JIRA: remove unused declaration of _qd_policy_link_user_name_subst
asfgit merged pull request #447: NO-JIRA: remove unused declaration of _qd_policy_link_user_name_subst URL: https://github.com/apache/qpid-dispatch/pull/447 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1262) GCC 8.2 format-truncation error in router/src/main.c
[
https://issues.apache.org/jira/browse/DISPATCH-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1262.
-
Resolution: Fixed
Fix Version/s: 1.6.0
> GCC 8.2 format-truncation error in router/src/main.c
>
>
> Key: DISPATCH-1262
> URL: https://issues.apache.org/jira/browse/DISPATCH-1262
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: Backlog
> Environment: Fedora 29 or anything with GCC 8.2, when the mentioned
> flags are used.
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.6.0
>
>
> When {{-DUSE_SANITIZERS=ON}}, this (in RelWithDebug build) results in
> {{-fsanitize=undefined -O2}} options being passed to GCC (as well as others,
> but these seem relevant).
> GCC then fails the compilation
> {code}
> [ 98%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o
> cd /home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router &&
> /nix/store/wxq0gf50466p7aiddmiiwlxm1cs6mhbn-gcc-wrapper-8.2.0/bin/cc
> -I/home/jdanek/Work/repos/qpid-dispatch/include
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/include
> -I/home/jdanek/Work/repos/qpid-proton/build/install/include
> -I/nix/store/l95nkqp7bdimqnz9ixay1aahljzsz7vc-python-2.7.15/include/python2.7
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router
> -fsanitize=address -fsanitize=leak -fsanitize=undefined -O2 -g -DNDEBUG -g
> -fno-omit-frame-pointer -Werror -Wall -Wpedantic -std=gnu99 -pthread -o
> CMakeFiles/qdrouterd.dir/src/main.c.o -c
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c
> {code}
> {code}
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c: In function
> ‘daemon_process’:
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c:209:58: error: ‘%s’
> directive argument is null [-Werror=format-truncation=]
> snprintf(config_path_full, cpf_len, "%s%s%s",
> ^~
> cc1: all warnings being treated as errors
> {code}
> I believe that GCC should much improve diagnostic messages, if it intends to
> search for dataflows like this, because the error does not give context.
> It is IMO legit, just super unlikely thing to happen, though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] asfgit closed pull request #448: DISPATCH-1262: fix GCC 8.2 format-truncation error in router/src/main.c
asfgit closed pull request #448: DISPATCH-1262: fix GCC 8.2 format-truncation error in router/src/main.c URL: https://github.com/apache/qpid-dispatch/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] ChugR commented on issue #445: DISPATCH-1246: clean up core link endpoints on shutdown
ChugR commented on issue #445: DISPATCH-1246: clean up core link endpoints on shutdown URL: https://github.com/apache/qpid-dispatch/pull/445#issuecomment-460275963 +1 I have not seen stray core link endpoints on this branch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1246) Address Proxy module leaks qdrc_endpoint_t on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759894#comment-16759894 ] ASF GitHub Bot commented on DISPATCH-1246: -- ChugR commented on issue #445: DISPATCH-1246: clean up core link endpoints on shutdown URL: https://github.com/apache/qpid-dispatch/pull/445#issuecomment-460275963 +1 I have not seen stray core link endpoints on this branch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Address Proxy module leaks qdrc_endpoint_t on shutdown > -- > > Key: DISPATCH-1246 > URL: https://issues.apache.org/jira/browse/DISPATCH-1246 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.5.0 >Reporter: Ken Giusti >Assignee: Chuck Rolke >Priority: Minor > Fix For: 1.6.0 > > > Running the system_tests_edge_router under valgrind: > ==21590== 657 (256 direct, 401 indirect) bytes in 4 blocks are definitely > lost in loss record 2,886 of 3,532 > ==21590==at 0x4C3147C: memalign (vg_replace_malloc.c:908) > ==21590==by 0x4C31589: posix_memalign (vg_replace_malloc.c:1072) > ==21590==by 0x4EA12FF: qd_alloc (alloc_pool.c:181) > ==21590==by 0x4E83086: qdrc_endpoint_create_link_CT > (core_link_endpoint.c:70) > ==21590==by 0x4E92C2C: on_conn_event (addr_proxy.c:237) > ==21590==by 0x4E92C2C: on_conn_event (addr_proxy.c:199) > ==21590==by 0x4E82E28: qdrc_event_conn_raise (core_events.c:90) > ==21590==by 0x4E82E28: qdrc_event_conn_raise (core_events.c:90) > ==21590==by 0x4E8123F: qdr_connection_opened_CT (connections.c:1147) > ==21590==by 0x4E8C916: router_core_thread (router_core_thread.c:124) > ==21590==by 0x5511593: start_thread (in /usr/lib64/libpthread-2.27.so) > ==21590==by 0x62A6F4E: clone (in /usr/lib64/libc-2.27.so) > ==21590== > Appears that the endpoint allocated here in addr_proxy.c: > // > // Attach a receiving link for edge address tracking updates. > // > ap->tracking_endpoint = > qdrc_endpoint_create_link_CT(ap->core, conn, QD_INCOMING, > > qdr_terminus_normal(QD_TERMINUS_EDGE_ADDRESS_TRACKING), > qdr_terminus(0), > >endpoint_descriptor, ap); > is not released when the router is shutdown -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1262) GCC 8.2 format-truncation error in router/src/main.c
[
https://issues.apache.org/jira/browse/DISPATCH-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759885#comment-16759885
]
ASF GitHub Bot commented on DISPATCH-1262:
--
asfgit commented on pull request #448: DISPATCH-1262: fix GCC 8.2
format-truncation error in router/src/main.c
URL: https://github.com/apache/qpid-dispatch/pull/448
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GCC 8.2 format-truncation error in router/src/main.c
>
>
> Key: DISPATCH-1262
> URL: https://issues.apache.org/jira/browse/DISPATCH-1262
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: Backlog
> Environment: Fedora 29 or anything with GCC 8.2, when the mentioned
> flags are used.
>Reporter: Jiri Daněk
>Priority: Major
>
> When {{-DUSE_SANITIZERS=ON}}, this (in RelWithDebug build) results in
> {{-fsanitize=undefined -O2}} options being passed to GCC (as well as others,
> but these seem relevant).
> GCC then fails the compilation
> {code}
> [ 98%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o
> cd /home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router &&
> /nix/store/wxq0gf50466p7aiddmiiwlxm1cs6mhbn-gcc-wrapper-8.2.0/bin/cc
> -I/home/jdanek/Work/repos/qpid-dispatch/include
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/include
> -I/home/jdanek/Work/repos/qpid-proton/build/install/include
> -I/nix/store/l95nkqp7bdimqnz9ixay1aahljzsz7vc-python-2.7.15/include/python2.7
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router
> -fsanitize=address -fsanitize=leak -fsanitize=undefined -O2 -g -DNDEBUG -g
> -fno-omit-frame-pointer -Werror -Wall -Wpedantic -std=gnu99 -pthread -o
> CMakeFiles/qdrouterd.dir/src/main.c.o -c
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c
> {code}
> {code}
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c: In function
> ‘daemon_process’:
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c:209:58: error: ‘%s’
> directive argument is null [-Werror=format-truncation=]
> snprintf(config_path_full, cpf_len, "%s%s%s",
> ^~
> cc1: all warnings being treated as errors
> {code}
> I believe that GCC should much improve diagnostic messages, if it intends to
> search for dataflows like this, because the error does not give context.
> It is IMO legit, just super unlikely thing to happen, though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1262) GCC 8.2 format-truncation error in router/src/main.c
[
https://issues.apache.org/jira/browse/DISPATCH-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759884#comment-16759884
]
ASF subversion and git services commented on DISPATCH-1262:
---
Commit ca7d3461462f1ca749046a544e6bc0294164a1b1 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=ca7d346 ]
DISPATCH-1262: fix GCC 8.2 format-truncation error in router/src/main.c
Gcc warns because `getcwd` on Linux may allocate and return new buffer,
so don't ignore the returned value. And cur_path may in theory be null
going in if previous `calloc` failed.
It is unlikely we would end up with cur_path = NULL as parameter to `%s`
in a formatting string later below, but it is possible, given very
careful timing and sufficiently malicious user, I think.
Change is made to silence GCC warning, so that ``-fsanitize=undefined` compiles.
This closes #448.
> GCC 8.2 format-truncation error in router/src/main.c
>
>
> Key: DISPATCH-1262
> URL: https://issues.apache.org/jira/browse/DISPATCH-1262
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: Backlog
> Environment: Fedora 29 or anything with GCC 8.2, when the mentioned
> flags are used.
>Reporter: Jiri Daněk
>Priority: Major
>
> When {{-DUSE_SANITIZERS=ON}}, this (in RelWithDebug build) results in
> {{-fsanitize=undefined -O2}} options being passed to GCC (as well as others,
> but these seem relevant).
> GCC then fails the compilation
> {code}
> [ 98%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o
> cd /home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router &&
> /nix/store/wxq0gf50466p7aiddmiiwlxm1cs6mhbn-gcc-wrapper-8.2.0/bin/cc
> -I/home/jdanek/Work/repos/qpid-dispatch/include
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/include
> -I/home/jdanek/Work/repos/qpid-proton/build/install/include
> -I/nix/store/l95nkqp7bdimqnz9ixay1aahljzsz7vc-python-2.7.15/include/python2.7
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router
> -fsanitize=address -fsanitize=leak -fsanitize=undefined -O2 -g -DNDEBUG -g
> -fno-omit-frame-pointer -Werror -Wall -Wpedantic -std=gnu99 -pthread -o
> CMakeFiles/qdrouterd.dir/src/main.c.o -c
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c
> {code}
> {code}
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c: In function
> ‘daemon_process’:
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c:209:58: error: ‘%s’
> directive argument is null [-Werror=format-truncation=]
> snprintf(config_path_full, cpf_len, "%s%s%s",
> ^~
> cc1: all warnings being treated as errors
> {code}
> I believe that GCC should much improve diagnostic messages, if it intends to
> search for dataflows like this, because the error does not give context.
> It is IMO legit, just super unlikely thing to happen, though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] jdanekrh commented on issue #448: DISPATCH-1262: fix GCC 8.2 format-truncation error in router/src/main.c
jdanekrh commented on issue #448: DISPATCH-1262: fix GCC 8.2 format-truncation error in router/src/main.c URL: https://github.com/apache/qpid-dispatch/pull/448#issuecomment-460274425 @ganeshmurthy thanks for looking into this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1262) GCC 8.2 format-truncation error in router/src/main.c
[
https://issues.apache.org/jira/browse/DISPATCH-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759888#comment-16759888
]
ASF GitHub Bot commented on DISPATCH-1262:
--
jdanekrh commented on issue #448: DISPATCH-1262: fix GCC 8.2 format-truncation
error in router/src/main.c
URL: https://github.com/apache/qpid-dispatch/pull/448#issuecomment-460274425
@ganeshmurthy thanks for looking into this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GCC 8.2 format-truncation error in router/src/main.c
>
>
> Key: DISPATCH-1262
> URL: https://issues.apache.org/jira/browse/DISPATCH-1262
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: Backlog
> Environment: Fedora 29 or anything with GCC 8.2, when the mentioned
> flags are used.
>Reporter: Jiri Daněk
>Priority: Major
>
> When {{-DUSE_SANITIZERS=ON}}, this (in RelWithDebug build) results in
> {{-fsanitize=undefined -O2}} options being passed to GCC (as well as others,
> but these seem relevant).
> GCC then fails the compilation
> {code}
> [ 98%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o
> cd /home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router &&
> /nix/store/wxq0gf50466p7aiddmiiwlxm1cs6mhbn-gcc-wrapper-8.2.0/bin/cc
> -I/home/jdanek/Work/repos/qpid-dispatch/include
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/include
> -I/home/jdanek/Work/repos/qpid-proton/build/install/include
> -I/nix/store/l95nkqp7bdimqnz9ixay1aahljzsz7vc-python-2.7.15/include/python2.7
> -I/home/jdanek/Work/repos/qpid-dispatch/cmake-build-relwithdebinfo/router
> -fsanitize=address -fsanitize=leak -fsanitize=undefined -O2 -g -DNDEBUG -g
> -fno-omit-frame-pointer -Werror -Wall -Wpedantic -std=gnu99 -pthread -o
> CMakeFiles/qdrouterd.dir/src/main.c.o -c
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c
> {code}
> {code}
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c: In function
> ‘daemon_process’:
> /home/jdanek/Work/repos/qpid-dispatch/router/src/main.c:209:58: error: ‘%s’
> directive argument is null [-Werror=format-truncation=]
> snprintf(config_path_full, cpf_len, "%s%s%s",
> ^~
> cc1: all warnings being treated as errors
> {code}
> I believe that GCC should much improve diagnostic messages, if it intends to
> search for dataflows like this, because the error does not give context.
> It is IMO legit, just super unlikely thing to happen, though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1264) Test delivery_abort fails occasionally; python 3, zombie routers left running
[
https://issues.apache.org/jira/browse/DISPATCH-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chuck Rolke updated DISPATCH-1264:
--
Environment:
Fedora 29, 4.20.3-200.fc29.x86_64
Python 3.7.2
> Test delivery_abort fails occasionally; python 3, zombie routers left running
> -
>
> Key: DISPATCH-1264
> URL: https://issues.apache.org/jira/browse/DISPATCH-1264
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.5.0
> Environment: Fedora 29, 4.20.3-200.fc29.x86_64
> Python 3.7.2
>
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>Priority: Major
>
> Delivery abort test fails about half the time. When it fails it leaves two
> routers running.
> Sometimes it passes:
> {{test 40}}
> {{ Start 40: system_tests_delivery_abort}}
> {{40: Test command: /bin/python
> "/home/chug/git/qpid-dispatch/build/tests/run.py" "unit2" "-v"
> "system_tests_delivery_abort"}}
> {{40: Test timeout computed to be: 1500}}
> {{40: test_01_message_route_truncated_one_router
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_02_message_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_03_link_route_truncated_one_router
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_04_link_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_05_message_route_abort_one_router
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_06_message_route_abort_two_routers
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_07_multicast_truncate_one_router
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: }}
> {{40: --}}
> {{40: Ran 7 tests in 4.364s}}
> {{40: }}
> {{40: OK}}
> {{1/1 Test #40: system_tests_delivery_abort .. Passed 4.62 sec}}
>
> Other times if fails:
> {{test 40}}
> {{ Start 40: system_tests_delivery_abort}}
> {{40: Test command: /bin/python
> "/home/chug/git/qpid-dispatch/build/tests/run.py" "unit2" "-v"
> "system_tests_delivery_abort"}}
> {{40: Test timeout computed to be: 1500}}
> {{40: test_01_message_route_truncated_one_router
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_02_message_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_03_link_route_truncated_one_router
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_04_link_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_05_message_route_abort_one_router
> (system_tests_delivery_abort.RouterTest) ... ok}}
> {{40: test_06_message_route_abort_two_routers
> (system_tests_delivery_abort.RouterTest) ...}}
> {{ python3: /home/chug/git/qpid-proton/c/src/core/engine.c:691:}}
> {{ pni_add_work: Assertion `!delivery->local.settled' failed.}}
> {{1/1 Test #40: system_tests_delivery_abort ..***Exception: Child aborted
> 5.57 sec}}
> {{0% tests passed, 1 tests failed out of 1}}
> {{Total Test time (real) = 5.57 sec}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1264) Test delivery_abort fails occasionally; python 3, zombie routers left running
Chuck Rolke created DISPATCH-1264:
-
Summary: Test delivery_abort fails occasionally; python 3, zombie
routers left running
Key: DISPATCH-1264
URL: https://issues.apache.org/jira/browse/DISPATCH-1264
Project: Qpid Dispatch
Issue Type: Bug
Components: Tests
Affects Versions: 1.5.0
Reporter: Chuck Rolke
Assignee: Chuck Rolke
Delivery abort test fails about half the time. When it fails it leaves two
routers running.
Sometimes it passes:
{{test 40}}
{{ Start 40: system_tests_delivery_abort}}
{{40: Test command: /bin/python
"/home/chug/git/qpid-dispatch/build/tests/run.py" "unit2" "-v"
"system_tests_delivery_abort"}}
{{40: Test timeout computed to be: 1500}}
{{40: test_01_message_route_truncated_one_router
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_02_message_route_truncated_two_routers
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_03_link_route_truncated_one_router
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_04_link_route_truncated_two_routers
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_05_message_route_abort_one_router
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_06_message_route_abort_two_routers
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_07_multicast_truncate_one_router
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: }}
{{40: --}}
{{40: Ran 7 tests in 4.364s}}
{{40: }}
{{40: OK}}
{{1/1 Test #40: system_tests_delivery_abort .. Passed 4.62 sec}}
Other times if fails:
{{test 40}}
{{ Start 40: system_tests_delivery_abort}}
{{40: Test command: /bin/python
"/home/chug/git/qpid-dispatch/build/tests/run.py" "unit2" "-v"
"system_tests_delivery_abort"}}
{{40: Test timeout computed to be: 1500}}
{{40: test_01_message_route_truncated_one_router
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_02_message_route_truncated_two_routers
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_03_link_route_truncated_one_router
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_04_link_route_truncated_two_routers
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_05_message_route_abort_one_router
(system_tests_delivery_abort.RouterTest) ... ok}}
{{40: test_06_message_route_abort_two_routers
(system_tests_delivery_abort.RouterTest) ...}}
{{ python3: /home/chug/git/qpid-proton/c/src/core/engine.c:691:}}
{{ pni_add_work: Assertion `!delivery->local.settled' failed.}}
{{1/1 Test #40: system_tests_delivery_abort ..***Exception: Child aborted
5.57 sec}}
{{0% tests passed, 1 tests failed out of 1}}
{{Total Test time (real) = 5.57 sec}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1261) Builds failing on CentOS7
[ https://issues.apache.org/jira/browse/DISPATCH-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1261. Resolution: Fixed CentOS7 build is succeeding as of Feb 4, 2019 > Builds failing on CentOS7 > - > > Key: DISPATCH-1261 > URL: https://issues.apache.org/jira/browse/DISPATCH-1261 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > For the last couple of days, Dispatch has not built succussfully on > CentOS7 on the QIT CI machine[1]. The error first appeared on Jan 18. It > appears to be a gulp issue. It works on Fedora, so it may be a > difference between CentOS7 and Fedora 28. > > [1] [http://rhm-x3550-05.rhm.lab.eng.bos.redhat.com:8080/job/Build_Dispatch/] > > 11:13:45 [11:13:45] Using gulpfile > ~/workspace/Build_Dispatch/build/console/gulpfile.js > 11:13:46 [11:13:46] Starting 'build'... > 11:13:46 [11:13:46] Starting 'clean'... > 11:13:46 [11:13:46] Finished 'clean' after 11 ms > 11:13:46 [11:13:46] Starting 'lint'... > 11:13:46 [11:13:46] Finished 'lint' after 40 ms > 11:13:46 [11:13:46] Starting 'vendor_styles'... > 11:13:46 [11:13:46] Starting 'vendor_scripts'... > 11:13:46 [11:13:46] Starting 'styles'... > 11:13:46 [11:13:46] 'vendor_scripts' errored after 58 ms > 11:13:46 [11:13:46] Error: File not found with singular glob: > > /var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/d3-time/build/d3-time.min.js > > (if this was purposeful, use `allowEmpty` option) > 11:13:46 at Glob. > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob-stream/readable.js:84:17) > 11:13:46 at Glob.g (events.js:292:16) > 11:13:46 at emitOne (events.js:96:13) > 11:13:46 at Glob.emit (events.js:188:7) > 11:13:46 at Glob._finish > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:197:8) > 11:13:46 at done > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:182:14) > 11:13:46 at Glob._processSimple2 > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:688:12) > 11:13:46 at > > /var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:676:10 > 11:13:46 at Glob._stat2 > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:772:12) > 11:13:46 at lstatcb_ > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:764:12) > 11:13:46 [11:13:46] 'build' errored after 115 ms > 11:13:46 [11:13:46] The following tasks did not complete: vendor_styles, > styles > 11:13:46 [11:13:46] Did you forget to signal async completion? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1261) Builds failing on CentOS7
[ https://issues.apache.org/jira/browse/DISPATCH-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1261: Fix Version/s: 1.6.0 > Builds failing on CentOS7 > - > > Key: DISPATCH-1261 > URL: https://issues.apache.org/jira/browse/DISPATCH-1261 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > For the last couple of days, Dispatch has not built succussfully on > CentOS7 on the QIT CI machine[1]. The error first appeared on Jan 18. It > appears to be a gulp issue. It works on Fedora, so it may be a > difference between CentOS7 and Fedora 28. > > [1] [http://rhm-x3550-05.rhm.lab.eng.bos.redhat.com:8080/job/Build_Dispatch/] > > 11:13:45 [11:13:45] Using gulpfile > ~/workspace/Build_Dispatch/build/console/gulpfile.js > 11:13:46 [11:13:46] Starting 'build'... > 11:13:46 [11:13:46] Starting 'clean'... > 11:13:46 [11:13:46] Finished 'clean' after 11 ms > 11:13:46 [11:13:46] Starting 'lint'... > 11:13:46 [11:13:46] Finished 'lint' after 40 ms > 11:13:46 [11:13:46] Starting 'vendor_styles'... > 11:13:46 [11:13:46] Starting 'vendor_scripts'... > 11:13:46 [11:13:46] Starting 'styles'... > 11:13:46 [11:13:46] 'vendor_scripts' errored after 58 ms > 11:13:46 [11:13:46] Error: File not found with singular glob: > > /var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/d3-time/build/d3-time.min.js > > (if this was purposeful, use `allowEmpty` option) > 11:13:46 at Glob. > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob-stream/readable.js:84:17) > 11:13:46 at Glob.g (events.js:292:16) > 11:13:46 at emitOne (events.js:96:13) > 11:13:46 at Glob.emit (events.js:188:7) > 11:13:46 at Glob._finish > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:197:8) > 11:13:46 at done > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:182:14) > 11:13:46 at Glob._processSimple2 > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:688:12) > 11:13:46 at > > /var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:676:10 > 11:13:46 at Glob._stat2 > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:772:12) > 11:13:46 at lstatcb_ > > (/var/lib/jenkins/workspace/Build_Dispatch/build/console/node_modules/glob/glob.js:764:12) > 11:13:46 [11:13:46] 'build' errored after 115 ms > 11:13:46 [11:13:46] The following tasks did not complete: vendor_styles, > styles > 11:13:46 [11:13:46] Did you forget to signal async completion? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1263) Symbol for sender/receiver is incorrect on console's topology page
[ https://issues.apache.org/jira/browse/DISPATCH-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1263. Resolution: Fixed > Symbol for sender/receiver is incorrect on console's topology page > -- > > Key: DISPATCH-1263 > URL: https://issues.apache.org/jira/browse/DISPATCH-1263 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Minor > > The symbol for a client that has both inbound and outbound links to a router > is incorrect. > That symbol should have both green and yellow halves. Instead, it is solid > white. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1263) Symbol for sender/receiver is incorrect on console's topology page
Ernest Allen created DISPATCH-1263: -- Summary: Symbol for sender/receiver is incorrect on console's topology page Key: DISPATCH-1263 URL: https://issues.apache.org/jira/browse/DISPATCH-1263 Project: Qpid Dispatch Issue Type: Bug Components: Console Affects Versions: 1.5.0 Reporter: Ernest Allen Assignee: Ernest Allen The symbol for a client that has both inbound and outbound links to a router is incorrect. That symbol should have both green and yellow halves. Instead, it is solid white. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[Issue] QPID PROTON with ruby 2.4.1
Hello, I am trying to use Qpid Proton 0.26.0 with the corresponding gem to exchange with Azure Eventhub. However, when using the method .receive on a Receiver, I have the following error: * Qpid::Proton::LinkError Exception: [-5]: #http://www.domoscio.com/> www.domoscio.com --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus
[jira] [Created] (QPID-8277) [Broker-J] Release Qpid Broker-J 7.1.1
Alex Rudyy created QPID-8277: Summary: [Broker-J] Release Qpid Broker-J 7.1.1 Key: QPID-8277 URL: https://issues.apache.org/jira/browse/QPID-8277 Project: Qpid Issue Type: Task Components: Broker-J Reporter: Alex Rudyy Fix For: qpid-java-broker-7.1.1 Release Qpid Broker-J following instructions provided at [https://cwiki.apache.org/confluence/display/qpid/Releasing+Qpid+Broker-J] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8273) [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when sending message to consumer
[
https://issues.apache.org/jira/browse/QPID-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8273:
-
Issue Type: Bug (was: Improvement)
> [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when
> sending message to consumer
> -
>
> Key: QPID-8273
> URL: https://issues.apache.org/jira/browse/QPID-8273
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker can crash with BufferOverflowException when sending message to
> consumer. The stack trace like the one below is reported into Qpid Broker
> logs.
> {noformat}
> (o.a.q.s.Main) - Uncaught exception, shutting down.
> java.nio.BufferOverflowException: null
> at java.nio.Buffer.nextPutIndex(Buffer.java:527)
> at java.nio.DirectByteBuffer.putLong(DirectByteBuffer.java:797)
> at
> org.apache.qpid.bytebuffer.QpidByteBuffer.putLong(QpidByteBuffer.java:500)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:293)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:471)
> at
> org.apache.qpid.framing.ContentHeaderBody.writePayload(ContentHeaderBody.java:100)
> at org.apache.qpid.framing.AMQFrame.writePayload(AMQFrame.java:69)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl$CompositeAMQBodyBlock.writePayload(ProtocolOutputConverterImpl.java:542)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl.writeFrame(AMQPConnection_0_8Impl.java:382)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeFrame(ProtocolOutputConverterImpl.java:501)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDeliveryUnchanged(ProtocolOutputConverterImpl.java:227)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:138)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:95)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeDeliver(ProtocolOutputConverterImpl.java:72)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$WriteDeliverMethod.deliverToClient(AMQPConnection_0_8Impl.java:1275)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.sendToClient(ConsumerTarget_0_8.java:452)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$AckConsumer.doSend(ConsumerTarget_0_8.java:274)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.sendNextMessage(AbstractConsumerTarget.java:327)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.processPending(AbstractConsumerTarget.java:99)
> at
> org.apache.qpid.server.protocol.v0_8.AMQChannel.processPending(AMQChannel.java:3797)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$ProcessPendingIterator$1.run(AMQPConnection_0_8Impl.java:1447)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.processPending(NonBlockingConnection.java:375)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:279)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:130)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:563)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.run(SelectorThread.java:551)
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:521)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
[jira] [Updated] (QPID-8274) [Broker-J][BDB HA] Broker can fail to become active when BDB HA virtual host times out to join the group
[
https://issues.apache.org/jira/browse/QPID-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8274:
-
Issue Type: Bug (was: Task)
> [Broker-J][BDB HA] Broker can fail to become active when BDB HA virtual host
> times out to join the group
>
>
> Key: QPID-8274
> URL: https://issues.apache.org/jira/browse/QPID-8274
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker containing a BDB HA Virtual Host node (belonging to the cluster
> consisting of several nodes) can fail to start when BDB HA Virtual Host node
> times out to join the group. The broker cannot complete activation and
> transit into an ACTIVE state.
> The stack traces like bellow are reported on BDB HA VHN timeout:
> {noformat}
> ERROR [Broker-Config] (o.a.q.s.m.AbstractConfiguredObject) - Failed to open
> object with name 'node2'. Object will be put into ERROR state.
> java.lang.RuntimeException: JE replicated environment creation took too long
> (permitted time 18ms)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironmentInSeparateThread(ReplicatedEnvironmentFacade.java:1577)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironment(ReplicatedEnvironmentFacade.java:1521)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.(ReplicatedEnvironmentFacade.java:287)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeFactory.createEnvironmentFacade(ReplicatedEnvironmentFacadeFactory.java:130)
> at
> org.apache.qpid.server.store.berkeleydb.BDBConfigurationStore.init(BDBConfigurationStore.java:122)
> at
> org.apache.qpid.server.virtualhostnode.berkeleydb.BDBHAVirtualHostNodeImpl.activate(BDBHAVirtualHostNodeImpl.java:338)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2635)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:360)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2634)
> at
> com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1237)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$ImmediateIfSameThreadExecutor.execute(TaskExecutorImpl.java:400)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.execute(TaskExecutorImpl.java:183)
> at
> com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:911)
> at
> com.google.common.util.concurrent.AbstractFuture.addListener(AbstractFuture.java:645)
> at
> com.google.common.util.concurrent.AbstractFuture$TrustedFuture.addListener(AbstractFuture.java:101)
> at
> com.google.common.util.concurrent.Futures.addCallback(Futures.java:1209)
> at
>
[jira] [Updated] (QPID-8252) [Broker-J][BDB HA] Start-up of BDB HA Virtual Host Node can hang sporadically
[
https://issues.apache.org/jira/browse/QPID-8252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8252:
-
Affects Version/s: qpid-java-broker-7.0.2
qpid-java-broker-7.0.0
qpid-java-broker-7.0.1
qpid-java-6.1.7
qpid-java-broker-7.1.0
qpid-java-broker-7.0.4
qpid-java-broker-7.0.5
qpid-java-broker-7.0.6
Fix Version/s: qpid-java-broker-7.1.1
qpid-java-broker-7.0.7
Summary: [Broker-J][BDB HA] Start-up of BDB HA Virtual Host Node
can hang sporadically (was: [Java Broker][BDB HA] Start-up of BDB HA Virtual
Host Node can hang sporadically )
> [Broker-J][BDB HA] Start-up of BDB HA Virtual Host Node can hang sporadically
> --
>
> Key: QPID-8252
> URL: https://issues.apache.org/jira/browse/QPID-8252
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2,
> qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-6.1.7,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
> Attachments: qpid-broker.log.txt
>
>
> Start-up of BDB HA Virtual Host Node can hang sporadically with issuing the
> following entries into broker logs:
> {noformat}
> 2018-08-24 19:02:16,249 WARN [Broker-Config]
> (o.a.q.s.s.b.r.ReplicatedEnvironmentFacade) - Slow replicated environment
> creation for tdome_prod:qpid1_B. Will continue to wait for further 135000ms.
> for environment creation to complete.
> 2018-08-24 19:04:31,265 ERROR [Broker-Config]
> (o.a.q.s.m.AbstractConfiguredObject) - Failed to open object with name
> 'qpid1_B'. Object will be put into ERROR state.
> java.lang.RuntimeException: JE replicated environment creation took too long
> (permitted time 18ms)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironmentInSeparateThread(ReplicatedEnvironmentFacade.java:1577)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironment(ReplicatedEnvironmentFacade.java:1521)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.(ReplicatedEnvironmentFacade.java:287)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeFactory.createEnvironmentFacade(ReplicatedEnvironmentFacadeFactory.java:130)
> at
> org.apache.qpid.server.store.berkeleydb.BDBConfigurationStore.init(BDBConfigurationStore.java:122)
> at
> org.apache.qpid.server.virtualhostnode.berkeleydb.BDBHAVirtualHostNodeImpl.activate(BDBHAVirtualHostNodeImpl.java:338)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2635)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:360)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2634)
> at
> com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1237)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl$ImmediateIfSameThreadExecutor.execute(TaskExecutorImpl.java:400)
> at
> org.apache.qpid.server.configuration.updater.TaskExecutorImpl.execute(TaskExecutorImpl.java:183)
> at
> com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:911)
> at
>
[jira] [Closed] (PROTON-1999) [c] Crash in pn_connection_finalize
[
https://issues.apache.org/jira/browse/PROTON-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell closed PROTON-1999.
--
Resolution: Invalid
> [c] Crash in pn_connection_finalize
> ---
>
> Key: PROTON-1999
> URL: https://issues.apache.org/jira/browse/PROTON-1999
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding, proton-c
> Environment: Linux 64-bits (Ubuntu 16.04 and Oracle Linux 7.4)
>Reporter: Olivier Delbeke
>Assignee: Cliff Jansen
>Priority: Major
> Attachments: call_stack.txt, example2.cpp, log.txt, main.cpp,
> run_qpid-broker.sh
>
>
> Here is my situation : I have several proton::containers (~20).
> Each one has its own proton::messaging_handler, and handles one
> proton::connection to a local qpid-broker (everything runs on the same Linux
> machine).
> 20 x ( one container with one handler with one connection with one link)
> Some containers/connections/handlers work in send mode ; they have one link
> that is a proton::sender.
> Some containers/connections/handlers work in receive mode ; they have one
> link that is a proton::receiver. Each time they receive an input message,
> they do some processing on it, and finally add a "sender->send()" task to the
> work queue of some sender handlers ( by calling work_queue()->add( [=] \{
> sender->send(msg); } as shown in the multi-threading examples).
> This works fine for some time (tens of thousands of messages, several minutes
> or hours), but eventually crashes, either with a SEGFAULT (when the
> qpid-proton lib is compiled in release mode) or with an assert (in debug
> mode), in qpid-proton/c/src/core/engine.c line 483,
> assert(!conn->transport->referenced) in function pn_connection_finalize().
> The proton logs (activated with export PN_TRACE_FRM=1) do not show anything
> abnormal (no loss of connection, no rejection of messages, no timeouts, ...).
> As the connection is not closed, I wonder why pn_connection_finalize() would
> be called in the first place.
> I joined the logs and the call trace.
> Happens on 0.26.0 but also reproduced with the latest master (Jan 28, 2019).
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8273) [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when sending message to consumer
[
https://issues.apache.org/jira/browse/QPID-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8273:
-
Affects Version/s: qpid-java-6.1.6
qpid-java-broker-7.0.3
qpid-java-broker-7.0.2
qpid-java-6.0
qpid-java-6.0.1
qpid-java-6.0.2
qpid-java-6.0.3
qpid-java-6.0.4
qpid-java-6.0.5
qpid-java-6.1
qpid-java-6.0.6
qpid-java-6.1.1
qpid-java-6.1.2
qpid-java-6.0.7
qpid-java-6.1.3
qpid-java-6.0.8
qpid-java-6.1.4
qpid-java-broker-7.0.0
qpid-java-6.1.5
qpid-java-broker-7.0.1
qpid-java-broker-7.1.0
qpid-java-broker-7.0.4
qpid-java-broker-7.0.5
qpid-java-broker-7.0.6
Fix Version/s: qpid-java-broker-7.1.1
qpid-java-broker-7.0.7
> [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when
> sending message to consumer
> -
>
> Key: QPID-8273
> URL: https://issues.apache.org/jira/browse/QPID-8273
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker can crash with BufferOverflowException when sending message to
> consumer. The stack trace like the one below is reported into Qpid Broker
> logs.
> {noformat}
> (o.a.q.s.Main) - Uncaught exception, shutting down.
> java.nio.BufferOverflowException: null
> at java.nio.Buffer.nextPutIndex(Buffer.java:527)
> at java.nio.DirectByteBuffer.putLong(DirectByteBuffer.java:797)
> at
> org.apache.qpid.bytebuffer.QpidByteBuffer.putLong(QpidByteBuffer.java:500)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:293)
> at
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:471)
> at
> org.apache.qpid.framing.ContentHeaderBody.writePayload(ContentHeaderBody.java:100)
> at org.apache.qpid.framing.AMQFrame.writePayload(AMQFrame.java:69)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl$CompositeAMQBodyBlock.writePayload(ProtocolOutputConverterImpl.java:542)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl.writeFrame(AMQPConnection_0_8Impl.java:382)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeFrame(ProtocolOutputConverterImpl.java:501)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDeliveryUnchanged(ProtocolOutputConverterImpl.java:227)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:138)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:95)
> at
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeDeliver(ProtocolOutputConverterImpl.java:72)
> at
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$WriteDeliverMethod.deliverToClient(AMQPConnection_0_8Impl.java:1275)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.sendToClient(ConsumerTarget_0_8.java:452)
> at
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$AckConsumer.doSend(ConsumerTarget_0_8.java:274)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.sendNextMessage(AbstractConsumerTarget.java:327)
> at
> org.apache.qpid.server.consumer.AbstractConsumerTarget.processPending(AbstractConsumerTarget.java:99)
> at
> org.apache.qpid.server.protocol.v0_8.AMQChannel.processPending(AMQChannel.java:3797)
> at
>
[jira] [Updated] (PROTON-1999) [c] Crash in pn_connection_finalize
[
https://issues.apache.org/jira/browse/PROTON-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated PROTON-1999:
---
Affects Version/s: (was: proton-c-0.26.0)
> [c] Crash in pn_connection_finalize
> ---
>
> Key: PROTON-1999
> URL: https://issues.apache.org/jira/browse/PROTON-1999
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding, proton-c
> Environment: Linux 64-bits (Ubuntu 16.04 and Oracle Linux 7.4)
>Reporter: Olivier Delbeke
>Assignee: Cliff Jansen
>Priority: Major
> Attachments: call_stack.txt, example2.cpp, log.txt, main.cpp,
> run_qpid-broker.sh
>
>
> Here is my situation : I have several proton::containers (~20).
> Each one has its own proton::messaging_handler, and handles one
> proton::connection to a local qpid-broker (everything runs on the same Linux
> machine).
> 20 x ( one container with one handler with one connection with one link)
> Some containers/connections/handlers work in send mode ; they have one link
> that is a proton::sender.
> Some containers/connections/handlers work in receive mode ; they have one
> link that is a proton::receiver. Each time they receive an input message,
> they do some processing on it, and finally add a "sender->send()" task to the
> work queue of some sender handlers ( by calling work_queue()->add( [=] \{
> sender->send(msg); } as shown in the multi-threading examples).
> This works fine for some time (tens of thousands of messages, several minutes
> or hours), but eventually crashes, either with a SEGFAULT (when the
> qpid-proton lib is compiled in release mode) or with an assert (in debug
> mode), in qpid-proton/c/src/core/engine.c line 483,
> assert(!conn->transport->referenced) in function pn_connection_finalize().
> The proton logs (activated with export PN_TRACE_FRM=1) do not show anything
> abnormal (no loss of connection, no rejection of messages, no timeouts, ...).
> As the connection is not closed, I wonder why pn_connection_finalize() would
> be called in the first place.
> I joined the logs and the call trace.
> Happens on 0.26.0 but also reproduced with the latest master (Jan 28, 2019).
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8274) [Broker-J][BDB HA] Broker can fail to become active when BDB HA virtual host times out to join the group
[
https://issues.apache.org/jira/browse/QPID-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8274:
-
Affects Version/s: qpid-java-6.1.6
qpid-java-broker-7.0.3
qpid-java-broker-7.0.2
qpid-java-6.0
qpid-java-6.0.1
qpid-java-6.0.2
qpid-java-6.0.3
qpid-java-6.0.4
qpid-java-6.0.5
qpid-java-6.1
qpid-java-6.0.6
qpid-java-6.1.1
qpid-java-6.1.2
qpid-java-6.0.7
qpid-java-6.1.3
qpid-java-6.0.8
qpid-java-6.1.4
qpid-java-broker-7.0.0
qpid-java-6.1.5
qpid-java-broker-7.0.1
qpid-java-broker-7.1.0
qpid-java-broker-7.0.4
qpid-java-broker-7.0.5
Fix Version/s: qpid-java-broker-7.1.1
> [Broker-J][BDB HA] Broker can fail to become active when BDB HA virtual host
> times out to join the group
>
>
> Key: QPID-8274
> URL: https://issues.apache.org/jira/browse/QPID-8274
> Project: Qpid
> Issue Type: Task
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7,
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker containing a BDB HA Virtual Host node (belonging to the cluster
> consisting of several nodes) can fail to start when BDB HA Virtual Host node
> times out to join the group. The broker cannot complete activation and
> transit into an ACTIVE state.
> The stack traces like bellow are reported on BDB HA VHN timeout:
> {noformat}
> ERROR [Broker-Config] (o.a.q.s.m.AbstractConfiguredObject) - Failed to open
> object with name 'node2'. Object will be put into ERROR state.
> java.lang.RuntimeException: JE replicated environment creation took too long
> (permitted time 18ms)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironmentInSeparateThread(ReplicatedEnvironmentFacade.java:1577)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironment(ReplicatedEnvironmentFacade.java:1521)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.(ReplicatedEnvironmentFacade.java:287)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeFactory.createEnvironmentFacade(ReplicatedEnvironmentFacadeFactory.java:130)
> at
> org.apache.qpid.server.store.berkeleydb.BDBConfigurationStore.init(BDBConfigurationStore.java:122)
> at
> org.apache.qpid.server.virtualhostnode.berkeleydb.BDBHAVirtualHostNodeImpl.activate(BDBHAVirtualHostNodeImpl.java:338)
> at
> org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1524)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1503)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1070)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$8.onSuccess(AbstractConfiguredObject.java:1064)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2639)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2635)
> at java.security.AccessController.doPrivileged(Native Method)
> at
[jira] [Updated] (QPID-7192) [Java Broker] BDB HA Virtual Host Node does not restart successfully if JE environment has locally committed transactions requiring rollback
[
https://issues.apache.org/jira/browse/QPID-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-7192:
-
Affects Version/s: qpid-java-broker-7.1.0
qpid-java-broker-7.0.6
Fix Version/s: qpid-java-broker-7.1.1
qpid-java-broker-7.0.7
> [Java Broker] BDB HA Virtual Host Node does not restart successfully if JE
> environment has locally committed transactions requiring rollback
>
>
> Key: QPID-7192
> URL: https://issues.apache.org/jira/browse/QPID-7192
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.1, qpid-java-broker-7.1.0,
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
> Attachments: QPID-7192-wip.diff
>
>
> Start-up of BDB HA VHN fails in the following scenario:
> 1) When Transaction on Master node is in process of commit and the replicas
> BDB HA VHNs are stopped at the same time, the transaction is aborted with
> InsufficientReplicasException
> 2) BDB HA VHN for replicas are restarted and the Replica environment detects
> a transaction requiring rollback from previous commit. The rollback
> transaction causes restart of JE Environment.
> 3) BDB HA VHN for impacted replica continues activation and performs an
> intruder protection checks but Environment is restarting which results in
> exception "ConnectionScopedRuntimeException: Environment is restarting". The
> exception puts BDB HA VHN into ERRORED state. JE environment re-join the
> group successfully but BDB HA VHN is not aware about it, as
> StateChangeListener is not set and BDB HA VHN does not receive notifications
> about state transitions
> A manual operator intervention is required to recover from the issue: BDB HA
> VHN needs to be started up again by invoking state change operation from Web
> Management Console or REST API.
>
> Here are JE Exceptions reported on Replica side on transaction rollback:
> {noformat}
> BROKER-20 WARN [DETACHED
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2)]
> o.a.q.s.s.b.r.ReplicatedEnvironmentFacade
> test:nodetestInFlightTransactionsWhilstMajorityIsLost10004 has transaction(s)
> ahead of the current master. These must be discarded to allow this node to
> rejoin the group. This condition is normally caused by the use of weak
> durability options.
> BROKER-20 DEBUG [DETACHED
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2)]
> o.a.q.s.s.b.r.ReplicatedEnvironmentFacade Environment restarting due to
> exception (JE 5.0.104)
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2):/tmp/qpid-work-org.apache.qpid.server.store.berkeleydb.replication.MultiNodeTest.testInFlightTransactionsWhilstMajorityIsLost-20-6184300293922905690/test/config
> Node
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2):/tmp/qpid-work-org.apache.qpid.server.store.berkeleydb.replication.MultiNodeTest.testInFlightTransactionsWhilstMajorityIsLost-20-6184300293922905690/test/config
> must rollback 3 commits to the earliest point indicated by transaction
> id=-142 time=2016-04-08 00:16:16.384 vlsn=356 lsn=0x0/0x8332 in order to
> rejoin the replication group. All existing ReplicatedEnvironment handles must
> be closed and reinstantiated. Log files were truncated to file 0x0, offset
> 0x33469, vlsn 353 HARD_RECOVERY: Rolled back past transaction commit or
> abort. Must run recovery by re-opening Environment handles Environment is
> invalid and must be closed.
> com.sleepycat.je.rep.RollbackException: (JE 5.0.104)
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2):/tmp/qpid-work-org.apache.qpid.server.store.berkeleydb.replication.MultiNodeTest.testInFlightTransactionsWhilstMajorityIsLost-20-6184300293922905690/test/config
> Node
> nodetestInFlightTransactionsWhilstMajorityIsLost10004(2):/tmp/qpid-work-org.apache.qpid.server.store.berkeleydb.replication.MultiNodeTest.testInFlightTransactionsWhilstMajorityIsLost-20-6184300293922905690/test/config
> must rollback 3 commits to the earliest point indicated by transaction
> id=-142 time=2016-04-08 00:16:16.384 vlsn=356 lsn=0x0/0x8332 in order to
> rejoin the replication group. All existing ReplicatedEnvironment handles must
> be closed and reinstantiated. Log files were truncated to file 0x0, offset
> 0x33469, vlsn 353 HARD_RECOVERY: Rolled back past transaction commit or
> abort. Must run recovery by re-opening Environment handles Environment is
> invalid and must be closed.
> at
> com.sleepycat.je.rep.stream.ReplicaFeederSyncup.setupHardRecovery(ReplicaFeederSyncup.java:650)
>
