---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5894/#review9053
---
Ship it!
Ship It!
- Gordon Sim
On July 10, 2012, 8:26 p.m., Alan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5895/#review9054
---
Ship it!
Ship It!
- Gordon Sim
On July 10, 2012, 7:53 p.m., Alan
[
https://issues.apache.org/jira/browse/QPID-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411402#comment-13411402
]
Robbie Gemmell commented on QPID-3999:
--
[
https://issues.apache.org/jira/browse/QPID-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411402#comment-13411402
]
Robbie Gemmell edited comment on QPID-3999 at 7/11/12 11:25 AM:
[
https://issues.apache.org/jira/browse/QPID-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411402#comment-13411402
]
Robbie Gemmell edited comment on QPID-3999 at 7/11/12 11:35 AM:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5794/#review9055
---
Hi Rajith,
The suggested code changes looks reasonable for me.
I
Hi Justin,
Could you please consider inclusions of trunk commits
http://svn.apache.org/viewvc?view=revisionrevision=1360120
and
http://svn.apache.org/viewvc?view=revisionrevision=1360121
into 0.18 ?
These 2 commits are low risk bug fixes and improvements for recently
added into Java Broker REST
[
https://issues.apache.org/jira/browse/QPID-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411430#comment-13411430
]
Michal Zerola commented on QPID-3914:
-
Hi, what was the decision taken on the above
[
https://issues.apache.org/jira/browse/QPID-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411500#comment-13411500
]
Steve Huston commented on QPID-3914:
Hi Michal... apparently noone has had free time to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5836/#review9057
---
trunk/qpid/cpp/src/qpid/acl/AclData.h
Chuck Rolke created QPID-4129:
-
Summary: C++ Broker failed client authentication in multi-node
cluster causes connection leak
Key: QPID-4129
URL: https://issues.apache.org/jira/browse/QPID-4129
Project:
Alan Conway created QPID-4130:
-
Summary: Remove use of intrusive_ptr::reset in ha/Primary.cpp, not
supported by older boost versions.
Key: QPID-4130
URL: https://issues.apache.org/jira/browse/QPID-4130
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5794/#review9058
---
I don't see any obvious issues with the patch, though I must admit to
[
https://issues.apache.org/jira/browse/QPID-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411606#comment-13411606
]
Alan Conway commented on QPID-4128:
---
Fixed on trunk
[
https://issues.apache.org/jira/browse/QPID-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411614#comment-13411614
]
Alan Conway commented on QPID-4128:
---
Mixed 2 issues by mistake on same JIRA, but both
On July 11, 2012, 11:42 a.m., Oleksandr Rudyy wrote:
Hi Rajith,
The suggested code changes looks reasonable for me.
I could not find any issue with the suggested solution.
The only thing I would like to ask is to add some tests to cover the
changes.
For example, I used the
On July 11, 2012, 3 p.m., Robbie Gemmell wrote:
I don't see any obvious issues with the patch, though I must admit to still
being reluctant to change exception handling in the client this late into
0.18 development given it has presumably been this way since time began. As
the
Request for inclusion into 0.18:
QPID-4129 C++ Broker failed client authentication in multi-node cluster causes
connection leak
Fix is http://svn.apache.org/viewvc?view=revisionrevision=1360214
- Original Message -
From: Justin Ross jr...@redhat.com
To: dev@qpid.apache.org
Sent:
[
https://issues.apache.org/jira/browse/QPID-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway resolved QPID-4118.
---
Resolution: Fixed
r1360228 | aconway | 2012-07-11 11:26:36 -0400 (Wed, 11 Jul 2012) | 9 lines
[
https://issues.apache.org/jira/browse/QPID-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411649#comment-13411649
]
Alan Conway commented on QPID-4118:
---
Reviewd by gsim https://reviews.apache.org/r/5894/
[
https://issues.apache.org/jira/browse/QPID-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411650#comment-13411650
]
Alan Conway edited comment on QPID-4118 at 7/11/12 3:57 PM:
[
https://issues.apache.org/jira/browse/QPID-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411658#comment-13411658
]
Alan Conway commented on QPID-4128:
---
Merged to 0.18
r1360228 | aconway | 2012-07-11
[
https://issues.apache.org/jira/browse/QPID-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway updated QPID-4128:
--
Comment: was deleted
(was: Mixed 2 issues by mistake on same JIRA, but both are trivial 1 line
fixes:
[
https://issues.apache.org/jira/browse/QPID-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway updated QPID-4128:
--
Comment: was deleted
(was: Fixed on trunk
[
https://issues.apache.org/jira/browse/QPID-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411660#comment-13411660
]
Alan Conway commented on QPID-4128:
---
Reviewed by gsim https://reviews.apache.org/r/5069/
[
https://issues.apache.org/jira/browse/QPID-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway resolved QPID-4128.
---
Resolution: Fixed
HA should not use amq.failover for replication links
On July 11, 2012, 3 p.m., Robbie Gemmell wrote:
I don't see any obvious issues with the patch, though I must admit to still
being reluctant to change exception handling in the client this late into
0.18 development given it has presumably been this way since time began. As
the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5890/#review9062
---
Ship it!
Not terribly familar with all the logic here yet, but the
On July 11, 2012, 3 p.m., Robbie Gemmell wrote:
I don't see any obvious issues with the patch, though I must admit to still
being reluctant to change exception handling in the client this late into
0.18 development given it has presumably been this way since time began. As
the
On 07/11/2012 05:16 AM, Paul Colby wrote:
I don't want to hijack the original topic, but since it //might// be
relevant, the messages I'm seeing are like:
qpidd[32238]: 2012-07-08 23:02:43 error Channel exception: session-busy:
Session already attached:
[
https://issues.apache.org/jira/browse/QPID-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411856#comment-13411856
]
Alan Conway commented on QPID-4126:
---
Reviewed by gsim
[
https://issues.apache.org/jira/browse/QPID-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411858#comment-13411858
]
Alan Conway commented on QPID-4126:
---
Fixed on trunk r1359872
HA primary
[
https://issues.apache.org/jira/browse/QPID-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway resolved QPID-4126.
---
Resolution: Fixed
Fix Version/s: 0.18
HA primary times out expected backups.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5833/#review9080
---
Ship it!
Ship It!
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp
[
https://issues.apache.org/jira/browse/QPID-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411926#comment-13411926
]
Justin Ross commented on QPID-4126:
---
Reviewed by Gordon. Approved for 0.18.
[
https://issues.apache.org/jira/browse/QPID-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411932#comment-13411932
]
Steve Huston commented on QPID-4130:
I have verified that with the fix, ha now builds
[
https://issues.apache.org/jira/browse/QPID-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411953#comment-13411953
]
Justin Ross commented on QPID-4128:
---
Reviewed by Gordon. Approved for 0.18.
Hi, Alex. Approved for 0.18.
Justin
- Original Message -
From: Oleksandr Rudyy oru...@gmail.com
To: dev@qpid.apache.org
Sent: Wednesday, July 11, 2012 8:12:31 AM
Subject: 0.18 inclusion request
Hi Justin,
Could you please consider inclusions of trunk commits
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616/
---
(Updated July 12, 2012, 2:38 a.m.)
Review request for qpid, Alan Conway, Gordon
39 matches
Mail list logo