Maven build?

2012-07-23 Thread Joseph Ottinger
I was wondering if it'd be valuable to convert the build for proton to maven. It's not a rocket surgery conversion - it involves moving files and just a touch of configuration - but at the same time, there're a lot of benefits. For better or for worse, there're two dominant build systems in Java;

[jira] [Resolved] (QPID-4158) HA transition to CATCHUP status too early.

2012-07-23 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved QPID-4158. --- Resolution: Fixed HA transition to CATCHUP status too early.

[jira] [Resolved] (QPID-4156) HA close window for clients to connect before HA broker is initialized

2012-07-23 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved QPID-4156. --- Resolution: Fixed HA close window for clients to connect before HA broker is initialized

0.18 draft release notes

2012-07-23 Thread Justin Ross
Here's a preview of the 0.18 release notes. If you'd like to change the content, you can either edit the jira content or send me any additional notes you'd like me to include. http://people.apache.org/~jross/release_notes_0.18.html Thanks, Justin

Re: proton: motivation and strategy

2012-07-23 Thread Carl Trieloff
On 07/20/2012 04:03 PM, William Henry wrote: So to the folks that make decisions on this list: Is AMQP more important than legacy Qpid? Is proton about AMQP 1.0 or about legacy Qpid? Nice summary, a.) I would say Proton is about making it easy for anyone to use AMQP 1.0 b.) In so doing it

Re: Maven build?

2012-07-23 Thread Steve Huston
Forgive my naiveté wrt Maven, but Qpid C++ currently uses cmake (and autoconf, but that's got a limited lifespan). It would be nice to limit the number of build systems we need to maintain. I know proton is not Qpid, but the knowledge and setups needed is one more thing C++ devs would need to take

Re: Maven build?

2012-07-23 Thread Joseph Ottinger
What do you mean? I don't know what the proton devs would need to do to support cmake -- the deliverables would be the same regardless of the build system, or can be made to be identical. On Mon, Jul 23, 2012 at 11:20 AM, Steve Huston shus...@riverace.com wrote: Forgive my naiveté wrt Maven, but

[jira] [Created] (QPID-4163) Deadlock between LinkRegistry and TimerTask locks

2012-07-23 Thread Alan Conway (JIRA)
Alan Conway created QPID-4163: - Summary: Deadlock between LinkRegistry and TimerTask locks Key: QPID-4163 URL: https://issues.apache.org/jira/browse/QPID-4163 Project: Qpid Issue Type: Bug

[jira] [Updated] (QPID-4163) Deadlock between LinkRegistry and TimerTask locks

2012-07-23 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway updated QPID-4163: -- Attachment: ha-timer-hang.pstack Stack trace of hung broker Deadlock between

Re: Maven build?

2012-07-23 Thread Andrew Stitcher
On Mon, 2012-07-23 at 11:26 -0400, Joseph Ottinger wrote: What do you mean? I don't know what the proton devs would need to do to support cmake -- the deliverables would be the same regardless of the build system, or can be made to be identical. I think you are talking at cross purposes here.

Re: Maven build?

2012-07-23 Thread Steve Huston
Exactly. Thank you, Andrew. On 7/23/12 11:40 AM, Andrew Stitcher astitc...@redhat.com wrote: On Mon, 2012-07-23 at 11:26 -0400, Joseph Ottinger wrote: What do you mean? I don't know what the proton devs would need to do to support cmake -- the deliverables would be the same regardless of the

Re: Maven build?

2012-07-23 Thread Rafael Schloming
On Mon, 2012-07-23 at 15:20 +, Steve Huston wrote: Forgive my naiveté wrt Maven, but Qpid C++ currently uses cmake (and autoconf, but that's got a limited lifespan). It would be nice to limit the number of build systems we need to maintain. I know proton is not Qpid, but the knowledge and

Re: Maven build?

2012-07-23 Thread Steve Huston
(In my best Rosanna Roasanna-danna imitation) Oh - never mind. Thanks, -Steve On 7/23/12 11:45 AM, Rafael Schloming rafa...@redhat.com wrote: On Mon, 2012-07-23 at 15:20 +, Steve Huston wrote: Forgive my naiveté wrt Maven, but Qpid C++ currently uses cmake (and autoconf, but that's got a

Re: Maven build?

2012-07-23 Thread Joseph Ottinger
Well, my thought wasn't necessarily to replace cmake for the non-Java parts - Maven is *capable* of doing non-Java-based builds, but isn't necessarily idiomatic. I'd think using Maven for C++ builds would be a little pathological, honestly - doable but not necessarily profitable. For Java, it'd

Review Request: QPID-4163: Deadlock between LinkRegistry and TimerTask locks

2012-07-23 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6092/ --- Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross. Description

Re: Review Request: QPID-4163: Deadlock between LinkRegistry and TimerTask locks

2012-07-23 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6092/#review9358 --- Ship it! These look good to me, but I'm not so familiar with the

Re: Review Request: QPID-4163: Deadlock between LinkRegistry and TimerTask locks

2012-07-23 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6092/#review9359 --- Ship it! Ship It! - Gordon Sim On July 23, 2012, 3:54 p.m., Alan

Re: Maven build?

2012-07-23 Thread Hiram Chirino
+1 Please have the java code use maven, or at least use the maven directory layouts. That way upstream folks can easily slap on a maven build on top if they want to. On Mon, Jul 23, 2012 at 11:52 AM, Joseph Ottinger j...@enigmastation.comwrote: Well, my thought wasn't necessarily to replace

[jira] [Created] (QPID-4164) Management moveMessage/copyMessage functions fail to properly move/copy the message if the message has been loaded from the store at Broker startup

2012-07-23 Thread Keith Wall (JIRA)
Keith Wall created QPID-4164: Summary: Management moveMessage/copyMessage functions fail to properly move/copy the message if the message has been loaded from the store at Broker startup Key: QPID-4164 URL:

Re: Maven build?

2012-07-23 Thread Rafael Schloming
We don't actually try to build all the source code with a single build system. In the interests of being as friendly as possible to various different user communities, we have multiple points in the tree that can be viewed as top level entry points: The proton/proton-c directory is the top level

Re: Maven build?

2012-07-23 Thread Rafael Schloming
On Mon, 2012-07-23 at 12:04 -0400, Rafael Schloming wrote: The proton/proton-j directory is the top level entry point for Java and it's laid out pretty much as any Java developer would expect. (At least that is the idea modulo ant vs maven.) If you only care about the Java code you can check

Review Request: QPID-4159: HA Missing messages in failover test.

2012-07-23 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6093/ --- Review request for qpid and Gordon Sim. Description --- QueueGuard was

[jira] [Commented] (QPID-4163) Deadlock between LinkRegistry and TimerTask locks

2012-07-23 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420742#comment-13420742 ] Alan Conway commented on QPID-4163: --- Code review of fix:

[jira] [Comment Edited] (QPID-4163) Deadlock between LinkRegistry and TimerTask locks

2012-07-23 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420742#comment-13420742 ] Alan Conway edited comment on QPID-4163 at 7/23/12 4:16 PM:

[jira] [Commented] (QPID-4159) HA missing messages in failover test.

2012-07-23 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420748#comment-13420748 ] Alan Conway commented on QPID-4159: --- Fix for review: https://reviews.apache.org/r/6093/

More HA fixes for 0.18

2012-07-23 Thread Alan Conway
I've got 2 more fixes for 0.18 https://issues.apache.org/jira/browse/QPID-4159 https://issues.apache.org/jira/browse/QPID-4163 Both have patches in reviewboard. - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For

Re: Maven build?

2012-07-23 Thread Joseph Ottinger
Well, a lot of Java coders pretend Java doesn't exist, so that was okay too. To be clear: personally, I'm happy with cmake being used for C, etc.; I think idiom is important. Using the maven directory structures is a no-brainer at the very least. Using Maven has other benefits beyond the

[jira] [Commented] (QPID-4163) Deadlock between LinkRegistry and TimerTask locks

2012-07-23 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420769#comment-13420769 ] Justin Ross commented on QPID-4163: --- Reviewed by Gordon and Andrew. Approved for 0.18.

Re: Maven build?

2012-07-23 Thread Oleksandr Rudyy
Hi, I completely support Joseph's proposal to use maven as building system for j-poton module. Kind Regards, Alex - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail:

Re: Maven build?

2012-07-23 Thread Rajith Attapattu
I personally prefer the simple ant based system. The last time Qpid used maven it was horrible :) .. it downloaded the entire universe into my computer. We also had trouble doing repeatable builds. Now I don't know if it was due to the way Maven was used or if it was an issue with Maven itself.

Re: Maven build?

2012-07-23 Thread Joseph Ottinger
Well, I have no problem maintaining the maven build, if that's the path chosen. The download the universe thing can be a concern - but that's an artifact of the build being what it is. Maven itself is pretty small; it has a set of plugins for most of its actual operations, so when you tell it to

Re: Maven build?

2012-07-23 Thread Robbie Gemmell
I think its safe to say Maven is a lot more mature now than it was back then, and is much more widely used. The issues that existed then certainly don't seem to bother the massive numbers of large projects using it today. Given how popular it is with other developers as a build system and as a

Re: Maven build?

2012-07-23 Thread Weston M. Price
On Jul 23, 2012, at 3:22 PM, Robbie Gemmell wrote: I think its safe to say Maven is a lot more mature now than it was back then, and is much more widely used. The issues that existed then certainly don't seem to bother the massive numbers of large projects using it today. Given how popular

Re: Maven build?

2012-07-23 Thread Robbie Gemmell
I wouldn't particularly be in favour of Ant+Ivy for proton. I did that for the main Qpid java stuff because it allowed a long overdue clean up of our repo and didn't involve changing the entire build system (if it had, I woudn't have done it), but if I was starting afresh I'd be using Maven for

Re: Maven build?

2012-07-23 Thread Joseph Ottinger
Well, what I'll do then is convert proton's build to maven and submit that as a patch attached to an issue, then I'll look into what it would take to get qpid-java's build to maven, too. If those diffs pass inspection, good. If not, we can fix them or ignore them as desired. On Monday, July 23,

[jira] [Commented] (QPID-4163) Deadlock between LinkRegistry and TimerTask locks

2012-07-23 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420977#comment-13420977 ] Alan Conway commented on QPID-4163: --- Comitted to trunk r1364805

[jira] [Commented] (QPID-4159) HA missing messages in failover test.

2012-07-23 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420979#comment-13420979 ] Alan Conway commented on QPID-4159: --- Comitted to trunk 1364804 HA

Re: 0.18 release update - RC1 is available

2012-07-23 Thread Oleksandr Rudyy
Hi Justin, I tested RC1 builds of Java Client, Java Broker, Management Console and could not find any issues with these builds. Test details: Using RC1 client successfully run Hello, Spout and Drains examples against Java and C++ Brokers (both RC1). Run RC1 build of Management Console against