[jira] [Commented] (QPID-4707) [AMQP 1.0] provide means of setting more fields in a 1.0 formatted message

[ https://issues.apache.org/jira/browse/QPID-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675259#comment-13675259 ] Gordon Sim commented on QPID-4707: -- ...qpid::data perhaps (?) > [AMQP 1.0

Re: AMQP 1.0 JMS client - supplementary coding standards

Thanks for the responses. I hadn't appreciated the strength of feeling against using external dependencies. I disagree that using the commons-lang helper classes would yield code that's more likely to contain errors, and also believe they yield more readable code than the auto-generated version.

[jira] [Commented] (QPID-4707) [AMQP 1.0] provide means of setting more fields in a 1.0 formatted message

[ https://issues.apache.org/jira/browse/QPID-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674678#comment-13674678 ] Gordon Sim commented on QPID-4707: -- I agree that there is nothing that ties MapHandler (or

[jira] [Commented] (QPID-4854) max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway)

[ https://issues.apache.org/jira/browse/QPID-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674657#comment-13674657 ] ASF subversion and git services commented on QPID-4854: --- Commit 14895

Re: AMQP 1.0 JMS client - supplementary coding standards

On Tue, Jun 4, 2013 at 1:04 PM, Rob Godfrey wrote: > On 4 June 2013 18:54, Rajith Attapattu wrote: > > > I'm strongly against using dependencies for the JMS client unless it's > > unavoidable. > > We can make exception for slf4j, but even then my preference is to use > JDK > > logging. > > > > I

[jira] [Commented] (QPID-4707) [AMQP 1.0] provide means of setting more fields in a 1.0 formatted message

[ https://issues.apache.org/jira/browse/QPID-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674604#comment-13674604 ] Andrew Stitcher commented on QPID-4707: --- Ah, I assumed that qpid::amqp was specific t

[jira] [Commented] (QPID-4707) [AMQP 1.0] provide means of setting more fields in a 1.0 formatted message

[ https://issues.apache.org/jira/browse/QPID-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674595#comment-13674595 ] Gordon Sim commented on QPID-4707: -- The qpid::amqp code is not part of 1.0 specific librar

[jira] [Commented] (QPID-4707) [AMQP 1.0] provide means of setting more fields in a 1.0 formatted message

[ https://issues.apache.org/jira/browse/QPID-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674585#comment-13674585 ] Andrew Stitcher commented on QPID-4707: --- I'm not sure that moving the MapHandler inte

Re: Review Request: C++ code spring cleaning - mostly removing unused stuff, and tidying up some of the interfaces

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11628/ --- (Updated June 4, 2013, 5:09 p.m.) Review request for qpid, Alan Conway, Gordon

[jira] [Resolved] (QPID-4707) [AMQP 1.0] provide means of setting more fields in a 1.0 formatted message

[ https://issues.apache.org/jira/browse/QPID-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-4707. -- Resolution: Fixed > [AMQP 1.0] provide means of setting more fields in a 1.0 formatted message > ---

[jira] [Commented] (QPID-4707) [AMQP 1.0] provide means of setting more fields in a 1.0 formatted message

[ https://issues.apache.org/jira/browse/QPID-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674567#comment-13674567 ] ASF subversion and git services commented on QPID-4707: --- Commit 14895

Re: AMQP 1.0 JMS client - supplementary coding standards

On 4 June 2013 18:54, Rajith Attapattu wrote: > I'm strongly against using dependencies for the JMS client unless it's > unavoidable. > We can make exception for slf4j, but even then my preference is to use JDK > logging. > If only JDK logging weren't so horrible :-) > We've had several issue

Re: AMQP 1.0 JMS client - supplementary coding standards

I'm strongly against using dependencies for the JMS client unless it's unavoidable. We can make exception for slf4j, but even then my preference is to use JDK logging. We've had several issues dealing with dependencies in the past. Increasingly our client is being used in various containers like A

Re: AMQP 1.0 JMS client - supplementary coding standards

On 4 June 2013 18:37, Phil Harvey wrote: > Ah, I expected a swift response about this. Luckily I'd already donned my > tin hat :-) > > On 4 June 2013 17:16, Rob Godfrey wrote: > > > I'm not really a big fan of enforcing commons lang for toString - > > sometimes you want/need to have a specific

Re: AMQP 1.0 JMS client - supplementary coding standards

Ah, I expected a swift response about this. Luckily I'd already donned my tin hat :-) On 4 June 2013 17:16, Rob Godfrey wrote: > I'm not really a big fan of enforcing commons lang for toString - > sometimes you want/need to have a specific string representation of an > object. Indeed - that'

Re: AMQP 1.0 JMS client - supplementary coding standards

I'm not really a big fan of enforcing commons lang for toString - sometimes you want/need to have a specific string representation of an object. Similarly I think we should be intelligent in defining equals and hashCode() methods. What I'd actually prefer to say is that every object should defin

AMQP 1.0 JMS client - supplementary coding standards

Given that the AMQP 1.0 JMS Client sub-project is starting from a clean slate, this is an opportunity to define some Java coding standards that are somewhat tighter than our existing ones [1]. I've therefore created a wiki page for supplementary standards [2] that only apply to this project. I re

[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674488#comment-13674488 ] Andrew Stitcher commented on QPID-4905: --- Separating broker::Connection and broker::Co

[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674484#comment-13674484 ] Andrew Stitcher commented on QPID-4905: --- The interface sys::Timeout is not really use

[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674482#comment-13674482 ] Andrew Stitcher commented on QPID-4905: --- In broker::Connection, broker::ConnectionHan

[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674478#comment-13674478 ] Andrew Stitcher commented on QPID-4905: --- In broker::ConnectionState setOutputHandler(

[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674479#comment-13674479 ] Andrew Stitcher commented on QPID-4905: --- In broker::Connection eachSessionHandler() i

[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674472#comment-13674472 ] Andrew Stitcher commented on QPID-4905: --- the federationLink bool member of broker::Co

[jira] [Updated] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated QPID-4905: -- Description: There is quite a lot of code in the Qpid C++ code base that is vestigial (like you

[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674469#comment-13674469 ] Andrew Stitcher commented on QPID-4905: --- framing::OutputHandler has a comment: bq.

[jira] [Comment Edited] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674469#comment-13674469 ] Andrew Stitcher edited comment on QPID-4905 at 6/4/13 3:09 PM: --

[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674466#comment-13674466 ] Andrew Stitcher commented on QPID-4905: --- client::Connector interface has 2 unused mem

[jira] [Commented] (QPID-4854) max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway)

[ https://issues.apache.org/jira/browse/QPID-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1367#comment-1367 ] Andrew Stitcher commented on QPID-4854: --- Gordon's comment above made me think of an a

[jira] [Resolved] (QPID-4021) Badly behaved clients can still clog up the broker

[ https://issues.apache.org/jira/browse/QPID-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved QPID-4021. --- Resolution: Fixed Fix Version/s: 0.23 > Badly behaved clients can still clog up the

[jira] [Commented] (QPID-4021) Badly behaved clients can still clog up the broker

[ https://issues.apache.org/jira/browse/QPID-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674447#comment-13674447 ] Andrew Stitcher commented on QPID-4021: --- With the fix for QPID-4854 the trunk code (f

[jira] [Resolved] (QPID-4854) max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway)

[ https://issues.apache.org/jira/browse/QPID-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved QPID-4854. --- Resolution: Fixed Fix Version/s: (was: Future) 0.23 > max-ne

[jira] [Created] (QPID-4907) qpid-tool displays duplicate entries for objects managed by the broker.

Ken Giusti created QPID-4907: Summary: qpid-tool displays duplicate entries for objects managed by the broker. Key: QPID-4907 URL: https://issues.apache.org/jira/browse/QPID-4907 Project: Qpid I

[jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674437#comment-13674437 ] ASF subversion and git services commented on QPID-4905: --- Commit 14894

[jira] [Commented] (QPID-4854) max-negotiate-time feature breaks AMQP 1.0 (and arguably doesn't achieve the desired objective anyway)

[ https://issues.apache.org/jira/browse/QPID-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674438#comment-13674438 ] ASF subversion and git services commented on QPID-4854: --- Commit 14894

[jira] [Updated] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code

[ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated QPID-4905: -- Description: There is quite a lot of code in the Qpid C++ code base that is vestigial (like you

[jira] [Assigned] (QPID-3914) SSL Client Authentication support for the Windows C++ client

[ https://issues.apache.org/jira/browse/QPID-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross reassigned QPID-3914: -- Assignee: Cliff Jansen > SSL Client Authentication support for the Windows C++ client >

[jira] [Commented] (QPID-4837) JDBC store should use connection pooler

[ https://issues.apache.org/jira/browse/QPID-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674317#comment-13674317 ] Michal Zerola commented on QPID-4837: - Hi guys, I assume you are quite busy with a new

[jira] [Updated] (QPID-4903) python client deletes subscription queue even if it was declared to not be exclusive

[ https://issues.apache.org/jira/browse/QPID-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-4903: - Component/s: (was: C++ Broker) Summary: python client deletes subscription queue even if it was

[jira] [Updated] (QPID-4903) address x-declare not follow AMQP

[ https://issues.apache.org/jira/browse/QPID-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-4903: -- Component/s: (was: Proton) C++ Broker > address x-declare not follow AMQP > ---