[jira] [Commented] (PROTON-1275) [proton-j] [reactor] socket connection interrupt causes unhandled IllegalArgumentException

2016-08-25 Thread James Birdsall (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438208#comment-15438208 ] James Birdsall commented on PROTON-1275: I got a chance to pull down your change and try it out

[jira] [Commented] (PROTON-1291) calling close again on a closed endpoints marks it modified and emits the related event again

2016-08-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437808#comment-15437808 ] ASF subversion and git services commented on PROTON-1291: - Commit

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437561#comment-15437561 ] ASF GitHub Bot commented on PROTON-1224: Github user JemDay commented on the issue:

[GitHub] qpid-proton issue #79: PROTON-1224: support newer BouncyCastle versions

2016-08-25 Thread JemDay
Github user JemDay commented on the issue: https://github.com/apache/qpid-proton/pull/79 Robbie Thanks, i've taken a quick look and nothing leaps out at me, i'll try pulling this down and checking locally. I will try and get to this today but it might stretch to tomorrow.

[jira] [Comment Edited] (QPID-7400) Allow Proton 0.14 to be used without warning

2016-08-25 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437468#comment-15437468 ] Justin Ross edited comment on QPID-7400 at 8/25/16 7:05 PM: Reviewed by me.

[jira] [Commented] (QPID-7400) Allow Proton 0.14 to be used without warning

2016-08-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437470#comment-15437470 ] ASF subversion and git services commented on QPID-7400: --- Commit

[jira] [Commented] (QPID-7400) Allow Proton 0.14 to be used without warning

2016-08-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437441#comment-15437441 ] ASF subversion and git services commented on QPID-7400: --- Commit

[jira] [Created] (QPID-7400) Allow Proton 0.14 to be used without warning

2016-08-25 Thread Andrew Stitcher (JIRA)
Andrew Stitcher created QPID-7400: - Summary: Allow Proton 0.14 to be used without warning Key: QPID-7400 URL: https://issues.apache.org/jira/browse/QPID-7400 Project: Qpid Issue Type:

[jira] [Created] (PROTON-1291) calling close again on a closed endpoints marks it modified and emits the related event again

2016-08-25 Thread Robbie Gemmell (JIRA)
Robbie Gemmell created PROTON-1291: -- Summary: calling close again on a closed endpoints marks it modified and emits the related event again Key: PROTON-1291 URL: https://issues.apache.org/jira/browse/PROTON-1291

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437094#comment-15437094 ] ASF GitHub Bot commented on PROTON-1224: Github user gemmellr commented on the issue:

[GitHub] qpid-proton issue #79: PROTON-1224: support newer BouncyCastle versions

2016-08-25 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton/pull/79 @JemDay I've made some updates to your patch, if youd like to give things a look over and try out and let me know how you get on that would be good, then I can merge it (might squash things

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437082#comment-15437082 ] ASF GitHub Bot commented on PROTON-1224: GitHub user gemmellr opened a pull request:

[GitHub] qpid-proton pull request #79: PROTON-1224: support newer BouncyCastle versio...

2016-08-25 Thread gemmellr
GitHub user gemmellr opened a pull request: https://github.com/apache/qpid-proton/pull/79 PROTON-1224: support newer BouncyCastle versions Update based on PR #78 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (QPIDJMS-201) Consumer handling of no drain response can unsubscribe a durable subscription

2016-08-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPIDJMS-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436989#comment-15436989 ] ASF subversion and git services commented on QPIDJMS-201: - Commit

[jira] [Resolved] (QPID-6982) [Java Broker] Refactor VirtualHost to remove unnecessary methods

2016-08-25 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-6982. -- Resolution: Fixed > [Java Broker] Refactor VirtualHost to remove unnecessary methods >

[jira] [Commented] (QPID-6982) [Java Broker] Refactor VirtualHost to remove unnecessary methods

2016-08-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436823#comment-15436823 ] ASF subversion and git services commented on QPID-6982: --- Commit 1757680 from

[jira] [Reopened] (QPID-6982) [Java Broker] Refactor VirtualHost to remove unnecessary methods

2016-08-25 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reopened QPID-6982: -- The change introduced in commit under revision [r1748537|https://svn.apache.org/r1748537] caused

Re: Review Request 51336: PROTON-1287: c++: missing empty() method on message_id, annotation_key

2016-08-25 Thread Gordon Sim
> On Aug. 23, 2016, 4:50 p.m., Andrew Stitcher wrote: > > proton-c/bindings/cpp/include/proton/message_id.hpp, line 45 > > > > > > This is an actual API change (even if it is a correct one). > > > > Can

[jira] [Resolved] (QPID-7346) [Java Broker] Improve Principals to record their origin

2016-08-25 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-7346. -- Resolution: Fixed Changes look good to me. > [Java Broker] Improve Principals to record their origin >

[jira] [Resolved] (QPID-7352) [Java Broker] Principal serialisation

2016-08-25 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-7352. -- Resolution: Fixed Assignee: (was: Alex Rudyy) Latest changes have been reviewed with no

Re: Review Request 51336: PROTON-1287: c++: missing empty() method on message_id, annotation_key

2016-08-25 Thread Alan Conway
> On Aug. 23, 2016, 4:50 p.m., Andrew Stitcher wrote: > > proton-c/bindings/cpp/include/proton/message_id.hpp, line 45 > > > > > > This is an actual API change (even if it is a correct one). > > > > Can