[jira] [Updated] (QPID-7471) [Java Broker] MessageConverter should respect mimeType

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7471:
-
Issue Type: Improvement  (was: Task)

> [Java Broker] MessageConverter should respect mimeType
> --
>
> Key: QPID-7471
> URL: https://issues.apache.org/jira/browse/QPID-7471
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Lorenz Quack
>Assignee: Keith Wall
> Fix For: qpid-java-6.2
>
>
> When converting from ManageableMessage to InternalMessage the mimeType gets 
> lost



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7479) [Java Broker] Memory estimation formula fails to account for objects that comprise a persistent messages

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7479:
-
Description: Memory estimation formula fails to account for objects that 
comprise a persistent messages.  It should also assume a TLS message, as TLS 
messages use an additional buffer for the application data.  (was: Memory 
estimation formula fails to account for objects that comprise a persistent 
messages.)

> [Java Broker] Memory estimation formula fails to account for objects that 
> comprise a persistent messages
> 
>
> Key: QPID-7479
> URL: https://issues.apache.org/jira/browse/QPID-7479
> Project: Qpid
>  Issue Type: Bug
>  Components: Documentation, Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> Memory estimation formula fails to account for objects that comprise a 
> persistent messages.  It should also assume a TLS message, as TLS messages 
> use an additional buffer for the application data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7470) [Java Broker] Address javax.xml.bind.DatatypeConverter shortcomings

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7470:
-
Fix Version/s: quid-java-6.0.6

> [Java Broker] Address javax.xml.bind.DatatypeConverter shortcomings
> ---
>
> Key: QPID-7470
> URL: https://issues.apache.org/jira/browse/QPID-7470
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Reporter: Lorenz Quack
> Fix For: qpid-java-6.1, qpid-java-6.2, quid-java-6.0.6
>
>
> javax.xml.bind.DatatypeConverterImpl#parseBase64Binary has shortcomings that 
> we should address.  It does not (as the java docs suggest) throw 
> IllegalArgumentException when the argument contains characters outside the 
> valid base64 value space. Instead it will skip invalid characters in the 
> (7-bit) ASCII range and throw a ArrayIndexOutOfBoundsException on non-ASCII 
> characters.
> We should guard against these cases. Maybe by wrapping 
> javax.xml.bind.DatatypeConverterImpl in our own class and doing input 
> validation there.
> See also (https://bugs.openjdk.java.net/browse/JDK-8168456)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7470) [Java Broker] Address javax.xml.bind.DatatypeConverter shortcomings

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7470:
-
Fix Version/s: qpid-java-6.2
   qpid-java-6.1

> [Java Broker] Address javax.xml.bind.DatatypeConverter shortcomings
> ---
>
> Key: QPID-7470
> URL: https://issues.apache.org/jira/browse/QPID-7470
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Reporter: Lorenz Quack
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> javax.xml.bind.DatatypeConverterImpl#parseBase64Binary has shortcomings that 
> we should address.  It does not (as the java docs suggest) throw 
> IllegalArgumentException when the argument contains characters outside the 
> valid base64 value space. Instead it will skip invalid characters in the 
> (7-bit) ASCII range and throw a ArrayIndexOutOfBoundsException on non-ASCII 
> characters.
> We should guard against these cases. Maybe by wrapping 
> javax.xml.bind.DatatypeConverterImpl in our own class and doing input 
> validation there.
> See also (https://bugs.openjdk.java.net/browse/JDK-8168456)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1337) [proton-j] Add methods and Sender and Receiver that allow for alternate buffer types

2016-10-31 Thread Timothy Bish (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved PROTON-1337.
--
Resolution: Fixed

> [proton-j] Add methods and Sender and Receiver that allow for alternate 
> buffer types
> 
>
> Key: PROTON-1337
> URL: https://issues.apache.org/jira/browse/PROTON-1337
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.15.0
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.16.0
>
>
> The current send and recv method in Sender and Receiver (as well as in 
> DeliveryImpl) operate on byte array types.  Depending on the application the 
> code might actually be using some other byte buffering scheme such as 
> ByteBuffer etc.  We can easily provide additional methods that operate on a 
> generic ReadableBuffer and WritableBuffer type that we define so that these 
> applications can operate more efficiently.  
> We already define WritableBuffer, the ReadableBuffer would like quite the 
> same.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (PROTON-1336) [Proton-c 0.14.0][Visual Studio 2013] Failing ssl unit test only in Debug mode

2016-10-31 Thread Adel Boutros (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1336:
-
Description: 
check full details here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Failing-ssl-unit-test-only-in-Debug-mode-td7652076.html

Suggested patch by Cliff is tested and working

{code}
--- proton/proton-c/src/windows/io.c2016-08-16 06:02:21 -0700 
+++ new/proton-c/src/windows/io.c2016-10-19 16:19:21 -0700 
@@ -90,8 +90,11 @@ 
 void pn_io_finalize(void *obj) 
 { 
   pn_io_t *io = (pn_io_t *) obj; 
-  pn_error_free(io->error); 
+  pn_selector_t *sel = io->iocp->selector; 
   pn_free(io->iocp); 
+  if (sel) 
+pn_decref(sel); 
+  pn_error_free(io->error); 
   WSACleanup(); 
 } 

@@ -366,8 +369,10 @@ 

 pn_selector_t *pn_io_selector(pn_io_t *io) 
 { 
-  if (io->iocp->selector == NULL) 
+  if (io->iocp->selector == NULL) { 
 io->iocp->selector = pni_selector_create(io->iocp); 
+pn_incref(io->iocp->selector); 
+  } 
   return io->iocp->selector; 
 } 
{code}

  was:
check full details here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Failing-ssl-unit-test-only-in-Debug-mode-td7652076.html

Suggested patch by Cliff is tested and working

--- proton/proton-c/src/windows/io.c2016-08-16 06:02:21 -0700 
+++ new/proton-c/src/windows/io.c2016-10-19 16:19:21 -0700 
@@ -90,8 +90,11 @@ 
 void pn_io_finalize(void *obj) 
 { 
   pn_io_t *io = (pn_io_t *) obj; 
-  pn_error_free(io->error); 
+  pn_selector_t *sel = io->iocp->selector; 
   pn_free(io->iocp); 
+  if (sel) 
+pn_decref(sel); 
+  pn_error_free(io->error); 
   WSACleanup(); 
 } 

@@ -366,8 +369,10 @@ 

 pn_selector_t *pn_io_selector(pn_io_t *io) 
 { 
-  if (io->iocp->selector == NULL) 
+  if (io->iocp->selector == NULL) { 
 io->iocp->selector = pni_selector_create(io->iocp); 
+pn_incref(io->iocp->selector); 
+  } 
   return io->iocp->selector; 
 } 


> [Proton-c 0.14.0][Visual Studio 2013] Failing ssl unit test only in Debug mode
> --
>
> Key: PROTON-1336
> URL: https://issues.apache.org/jira/browse/PROTON-1336
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.14.0
>Reporter: Adel Boutros
>
> check full details here: 
> http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Failing-ssl-unit-test-only-in-Debug-mode-td7652076.html
> Suggested patch by Cliff is tested and working
> {code}
> --- proton/proton-c/src/windows/io.c2016-08-16 06:02:21 -0700 
> +++ new/proton-c/src/windows/io.c2016-10-19 16:19:21 -0700 
> @@ -90,8 +90,11 @@ 
>  void pn_io_finalize(void *obj) 
>  { 
>pn_io_t *io = (pn_io_t *) obj; 
> -  pn_error_free(io->error); 
> +  pn_selector_t *sel = io->iocp->selector; 
>pn_free(io->iocp); 
> +  if (sel) 
> +pn_decref(sel); 
> +  pn_error_free(io->error); 
>WSACleanup(); 
>  } 
> @@ -366,8 +369,10 @@ 
>  pn_selector_t *pn_io_selector(pn_io_t *io) 
>  { 
> -  if (io->iocp->selector == NULL) 
> +  if (io->iocp->selector == NULL) { 
>  io->iocp->selector = pni_selector_create(io->iocp); 
> +pn_incref(io->iocp->selector); 
> +  } 
>return io->iocp->selector; 
>  } 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7480) Incorrect error message when editing "number of connection threads" of a virtual host

2016-10-31 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622782#comment-15622782
 ] 

Keith Wall commented on QPID-7480:
--

Change looks reasonable to me, merged to branch.

> Incorrect error message when editing "number of connection threads" of a 
> virtual host
> -
>
> Key: QPID-7480
> URL: https://issues.apache.org/jira/browse/QPID-7480
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Trivial
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The sense of the error message "Number of Selectors %d on VirtualHost %s must 
> be greater than the connection pool size %d" is the wrong way around.The 
> logic is correct, only the message is wrong,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7480) Incorrect error message when editing "number of connection threads" of a virtual host

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622779#comment-15622779
 ] 

ASF subversion and git services commented on QPID-7480:
---

Commit 1767336 from [~k-wall] in branch 'java/branches/6.1.x'
[ https://svn.apache.org/r1767336 ]

QPID-7480: Correct exception message

Merge from trunk with command:

svn merge -c 1767329  ^/qpid/java/trunk

> Incorrect error message when editing "number of connection threads" of a 
> virtual host
> -
>
> Key: QPID-7480
> URL: https://issues.apache.org/jira/browse/QPID-7480
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Trivial
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The sense of the error message "Number of Selectors %d on VirtualHost %s must 
> be greater than the connection pool size %d" is the wrong way around.The 
> logic is correct, only the message is wrong,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7480) Incorrect error message when editing "number of connection threads" of a virtual host

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-7480.
--
Resolution: Fixed

> Incorrect error message when editing "number of connection threads" of a 
> virtual host
> -
>
> Key: QPID-7480
> URL: https://issues.apache.org/jira/browse/QPID-7480
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Trivial
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The sense of the error message "Number of Selectors %d on VirtualHost %s must 
> be greater than the connection pool size %d" is the wrong way around.The 
> logic is correct, only the message is wrong,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPIDJMS-217) Remove unecessary copy of the body if an inbound BytesMessage

2016-10-31 Thread Timothy Bish (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPIDJMS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved QPIDJMS-217.
--
Resolution: Fixed

> Remove unecessary copy of the body if an inbound BytesMessage
> -
>
> Key: QPIDJMS-217
> URL: https://issues.apache.org/jira/browse/QPIDJMS-217
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.11.1
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.20.0
>
>
> Inbound BytesMessage instances are copied on dispatch including a deep copy 
> of the body of the message which is not needed as this value is immutable on 
> the received messages, once reset from read-only to writeable a new buffer is 
> always allocated and replaces the message's original content.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-217) Remove unecessary copy of the body if an inbound BytesMessage

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPIDJMS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622768#comment-15622768
 ] 

ASF subversion and git services commented on QPIDJMS-217:
-

Commit ec04b3cb0767606c33c2257f1154ea1e627f79a7 in qpid-jms's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=ec04b3c ]

QPIDJMS-217 Remove unnecessary copy of message payload

Don't deep copy the body of BytesMessage's on dispatch.

> Remove unecessary copy of the body if an inbound BytesMessage
> -
>
> Key: QPIDJMS-217
> URL: https://issues.apache.org/jira/browse/QPIDJMS-217
> Project: Qpid JMS
>  Issue Type: Improvement
>  Components: qpid-jms-client
>Affects Versions: 0.11.1
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 0.20.0
>
>
> Inbound BytesMessage instances are copied on dispatch including a deep copy 
> of the body of the message which is not needed as this value is immutable on 
> the received messages, once reset from read-only to writeable a new buffer is 
> always allocated and replaces the message's original content.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7352) [Java Broker] Principal serialisation

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622764#comment-15622764
 ] 

ASF subversion and git services commented on QPID-7352:
---

Commit 1767334 from [~k-wall] in branch 'java/branches/6.1.x'
[ https://svn.apache.org/r1767334 ]

QPID-7352: [Java Broker] Make parsing of GenericPrincipal more lenient and 
allow dashes in originType

Merged from trunk with command:

svn merge -c 1767332 ^/qpid/java/trunk

> [Java Broker] Principal serialisation
> -
>
> Key: QPID-7352
> URL: https://issues.apache.org/jira/browse/QPID-7352
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7352-Java-Broker-Make-parsing-of-GenericPrincip.patch
>
>
> Implement a Jackson serialiser for Principals and add a corresponding 
> {{AttributeValueConverter}} that takes the serialised form any produces 
> Generic Principals. The serialised form is to include the reference to the 
> AuthenticationProvider (name and type). Group Providers need the 
> corresponding change.
> Update the preference store and preference store recoverer to store the 
> principal's serialised form for {{owner}} and {{visibilityList}}, and recover 
> generic principal objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7352) [Java Broker] Principal serialisation

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-7352.
--
Resolution: Fixed

> [Java Broker] Principal serialisation
> -
>
> Key: QPID-7352
> URL: https://issues.apache.org/jira/browse/QPID-7352
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7352-Java-Broker-Make-parsing-of-GenericPrincip.patch
>
>
> Implement a Jackson serialiser for Principals and add a corresponding 
> {{AttributeValueConverter}} that takes the serialised form any produces 
> Generic Principals. The serialised form is to include the reference to the 
> AuthenticationProvider (name and type). Group Providers need the 
> corresponding change.
> Update the preference store and preference store recoverer to store the 
> principal's serialised form for {{owner}} and {{visibilityList}}, and recover 
> generic principal objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7352) [Java Broker] Principal serialisation

2016-10-31 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622759#comment-15622759
 ] 

Keith Wall commented on QPID-7352:
--

Change looks reasonable to me.

> [Java Broker] Principal serialisation
> -
>
> Key: QPID-7352
> URL: https://issues.apache.org/jira/browse/QPID-7352
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7352-Java-Broker-Make-parsing-of-GenericPrincip.patch
>
>
> Implement a Jackson serialiser for Principals and add a corresponding 
> {{AttributeValueConverter}} that takes the serialised form any produces 
> Generic Principals. The serialised form is to include the reference to the 
> AuthenticationProvider (name and type). Group Providers need the 
> corresponding change.
> Update the preference store and preference store recoverer to store the 
> principal's serialised form for {{owner}} and {{visibilityList}}, and recover 
> generic principal objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPIDJMS-217) Remove unecessary copy of the body if an inbound BytesMessage

2016-10-31 Thread Timothy Bish (JIRA)
Timothy Bish created QPIDJMS-217:


 Summary: Remove unecessary copy of the body if an inbound 
BytesMessage
 Key: QPIDJMS-217
 URL: https://issues.apache.org/jira/browse/QPIDJMS-217
 Project: Qpid JMS
  Issue Type: Improvement
  Components: qpid-jms-client
Affects Versions: 0.11.1
Reporter: Timothy Bish
Assignee: Timothy Bish
 Fix For: 0.20.0


Inbound BytesMessage instances are copied on dispatch including a deep copy of 
the body of the message which is not needed as this value is immutable on the 
received messages, once reset from read-only to writeable a new buffer is 
always allocated and replaces the message's original content.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7474) [Java Broker] Guard against NPE in StatisticsReportingTask

2016-10-31 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy resolved QPID-7474.
--
   Resolution: Fixed
Fix Version/s: qpid-java-6.1

> [Java Broker] Guard against NPE in StatisticsReportingTask
> --
>
> Key: QPID-7474
> URL: https://issues.apache.org/jira/browse/QPID-7474
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.4, qpid-java-6.1
>Reporter: Lorenz Quack
> Fix For: qpid-java-6.1
>
>
> Currently when statistics gathering is enabled on the broker it iterates over 
> all virtual hosts and accesses their EventLogger. Some VirtualHosts (e.g., 
> BDBHAReplicaVirtualHost or RedirectingVirtualHost) do not have an EventLogger 
> and will return null causing a NullPointerException in the 
> StatisticsReportingTask that will be logged with a stacktrace and prevents 
> other VHs from reporting their statistics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #108: Fix memory leaks

2016-10-31 Thread dskarbek
GitHub user dskarbek opened a pull request:

https://github.com/apache/qpid-dispatch/pull/108

Fix memory leaks

Just getting my feet wet really.  Fix a few little things.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dskarbek/qpid-dispatch master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #108


commit 405bd63ab7015ad3b794fe67d596c7e4cd7a7876
Author: Daniel Skarbek 
Date:   2016-10-27T23:12:52Z

Fix memory leak in dispatch

router_id is being reassigned without freeing the prior string.  Made a 
setter method that ensures
that the prior pointer is freed.  Did the same for router_area as well to 
keep the design parallel.

commit aeb8f41872b9749c5d20d576b030b0af012c18a8
Author: Daniel Skarbek 
Date:   2016-10-28T00:05:28Z

Fix memory leaks

Add more clean-up of router core object.  Several members were simply being 
leaked.

commit faeca6faca91df634ef4425caa7103e99e52b910
Author: Daniel Skarbek 
Date:   2016-10-28T18:43:25Z

Cleanup in hash.c

Code was not using DEQ_NEXT() to access the next pointer

qd_hash_insert_const() was passing "error" as the "exists" indicator.  This 
is semantically incorrect and has
the effect of returning QD_ERROR_NOT_FOUND when the entry already exists 
after actually over-writting with the
new item.

qd_hash_retrieve_prefix_const() was missing the qd_iterator_hash_segments() 
call.

factor out qd_hash_internal_remove_item() to consolidate the remove logic.  
Also, reuse the retrieve logic
inside the remove method

commit 46960384b4af10b4640025d37bbbaa3d0d5c4187
Author: Daniel Skarbek 
Date:   2016-10-28T20:42:23Z

Fix memory leak of core addrs

Decompose addr removal and free logic and use when freeing the core




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7474) [Java Broker] Guard against NPE in StatisticsReportingTask

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622750#comment-15622750
 ] 

ASF subversion and git services commented on QPID-7474:
---

Commit 1767331 from oru...@apache.org in branch 'java/branches/6.1.x'
[ https://svn.apache.org/r1767331 ]

QPID-7474 : Only virtual hosts capable of processing messages should implement 
StatisticsGatherer

merged from trunk with:
svn merge -c 1766796  ^/qpid/java/trunk

> [Java Broker] Guard against NPE in StatisticsReportingTask
> --
>
> Key: QPID-7474
> URL: https://issues.apache.org/jira/browse/QPID-7474
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.4, qpid-java-6.1
>Reporter: Lorenz Quack
>
> Currently when statistics gathering is enabled on the broker it iterates over 
> all virtual hosts and accesses their EventLogger. Some VirtualHosts (e.g., 
> BDBHAReplicaVirtualHost or RedirectingVirtualHost) do not have an EventLogger 
> and will return null causing a NullPointerException in the 
> StatisticsReportingTask that will be logged with a stacktrace and prevents 
> other VHs from reporting their statistics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7352) [Java Broker] Principal serialisation

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622751#comment-15622751
 ] 

ASF subversion and git services commented on QPID-7352:
---

Commit 1767332 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1767332 ]

QPID-7352: [Java Broker] Make parsing of GenericPrincipal more lenient and 
allow dashes in originType

> [Java Broker] Principal serialisation
> -
>
> Key: QPID-7352
> URL: https://issues.apache.org/jira/browse/QPID-7352
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7352-Java-Broker-Make-parsing-of-GenericPrincip.patch
>
>
> Implement a Jackson serialiser for Principals and add a corresponding 
> {{AttributeValueConverter}} that takes the serialised form any produces 
> Generic Principals. The serialised form is to include the reference to the 
> AuthenticationProvider (name and type). Group Providers need the 
> corresponding change.
> Update the preference store and preference store recoverer to store the 
> principal's serialised form for {{owner}} and {{visibilityList}}, and recover 
> generic principal objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7474) [Java Broker] Guard against NPE in StatisticsReportingTask

2016-10-31 Thread Alex Rudyy (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622739#comment-15622739
 ] 

Alex Rudyy commented on QPID-7474:
--

The implemented changes look good to me. We should port them into 6.1

> [Java Broker] Guard against NPE in StatisticsReportingTask
> --
>
> Key: QPID-7474
> URL: https://issues.apache.org/jira/browse/QPID-7474
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.4, qpid-java-6.1
>Reporter: Lorenz Quack
>
> Currently when statistics gathering is enabled on the broker it iterates over 
> all virtual hosts and accesses their EventLogger. Some VirtualHosts (e.g., 
> BDBHAReplicaVirtualHost or RedirectingVirtualHost) do not have an EventLogger 
> and will return null causing a NullPointerException in the 
> StatisticsReportingTask that will be logged with a stacktrace and prevents 
> other VHs from reporting their statistics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-7485) [Java Broker] File based authentication providers should not allow changing of password file to non-existing file

2016-10-31 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-7485:


Assignee: Alex Rudyy

> [Java Broker] File based authentication providers should not allow changing 
> of password file to non-existing file
> -
>
> Key: QPID-7485
> URL: https://issues.apache.org/jira/browse/QPID-7485
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, 
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1, 
> qpid-java-6.2
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>
> Whilst editing password based authentication provider (plain or base64) and 
> setting path to a non existing file, the operation fails with 422 but the 
> configuration is updated and sub-sequent user modification operation (add 
> user/delete user/etc) fails as password file does not exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7485) [Java Broker] File based authentication providers should not allow changing of password file to non-existing file

2016-10-31 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-7485:
-
Status: Reviewable  (was: In Progress)

> [Java Broker] File based authentication providers should not allow changing 
> of password file to non-existing file
> -
>
> Key: QPID-7485
> URL: https://issues.apache.org/jira/browse/QPID-7485
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, 
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1, 
> qpid-java-6.2
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>
> Whilst editing password based authentication provider (plain or base64) and 
> setting path to a non existing file, the operation fails with 422 but the 
> configuration is updated and sub-sequent user modification operation (add 
> user/delete user/etc) fails as password file does not exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-7480) Incorrect error message when editing "number of connection threads" of a virtual host

2016-10-31 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-7480:


Assignee: Alex Rudyy

> Incorrect error message when editing "number of connection threads" of a 
> virtual host
> -
>
> Key: QPID-7480
> URL: https://issues.apache.org/jira/browse/QPID-7480
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Trivial
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The sense of the error message "Number of Selectors %d on VirtualHost %s must 
> be greater than the connection pool size %d" is the wrong way around.The 
> logic is correct, only the message is wrong,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7480) Incorrect error message when editing "number of connection threads" of a virtual host

2016-10-31 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-7480:
-
Status: Reviewable  (was: In Progress)

> Incorrect error message when editing "number of connection threads" of a 
> virtual host
> -
>
> Key: QPID-7480
> URL: https://issues.apache.org/jira/browse/QPID-7480
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Trivial
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The sense of the error message "Number of Selectors %d on VirtualHost %s must 
> be greater than the connection pool size %d" is the wrong way around.The 
> logic is correct, only the message is wrong,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7480) Incorrect error message when editing "number of connection threads" of a virtual host

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622719#comment-15622719
 ] 

ASF subversion and git services commented on QPID-7480:
---

Commit 1767329 from oru...@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1767329 ]

QPID-7480: Correct exception message

> Incorrect error message when editing "number of connection threads" of a 
> virtual host
> -
>
> Key: QPID-7480
> URL: https://issues.apache.org/jira/browse/QPID-7480
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Keith Wall
>Priority: Trivial
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The sense of the error message "Number of Selectors %d on VirtualHost %s must 
> be greater than the connection pool size %d" is the wrong way around.The 
> logic is correct, only the message is wrong,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7483) [Java Broker, WMC] Address minor UI issues

2016-10-31 Thread Alex Rudyy (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622684#comment-15622684
 ] 

Alex Rudyy commented on QPID-7483:
--

Point 8 (Creating a Base64MD5PasswordFile AuthProvider pointing to a non 
existing file creates it. however editing and point it to a non existing file 
fails with 422 but the config seems to have been updated regardless with 
subsequent changes (e.g. adding user) failing.) is not a UI issue.  I committed 
a fix for this issue as part of QPID-7485

> [Java Broker, WMC] Address minor UI issues
> --
>
> Key: QPID-7483
> URL: https://issues.apache.org/jira/browse/QPID-7483
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Lorenz Quack
>
> During testing the following minor UI issues were discovered:
> In no particular order (numbering just for easier referencing):
> # Logging in occasionally fails with a 417 error response especially when the 
> browsers developer tools are open. This is probably due to a timeout in 
> SaslServlet (default 3000 ms).
> # In view and edit of Broker: "Statistics reporting period enabled" shoud 
> actually be "Statistics reporting reset enabled"
> # The memory log viewer grid in "Auto Refresh" mode has the "jumping page" 
> problem
> # The BrokerLogbackSocket seems to have a default port (6000) but it needs to 
> be entered regardless.
> # When using BrokerLogbackSocket and nothing is connected to it it waits 
> 100ms for each log event to time out. When using DEBUG this brings the broker 
> to a crawl (e.g., broker startup ~ 4 minutes). I could imagine this also 
> being a problem when logging over a network. Could this also be a problem for 
> other loggers (e.g. Syslog?)
> # When changing "Number of connection threads" to 1 on a VirtualHost the 
> following error is reported: "422 - Number of Selectors 8 on VirtualHost 
> bdb_bdb must be greater than the connection pool size 1. Please correct the 
> problem and retry your operation." which does not make sense. I think it 
> should say the connection pool size must be greater than the selectors not 
> the other way around.
> # Add Port dialogue does not have a scroll bar in case it does not completely 
> fit onto the screen. If the dialogue box resizes (e.g., by closing the 
> Developer Tools pane in IE) only the original part of the dialogue box has a 
> solid background. the newly exposed part is transparent.
> # Creating a Base64MD5PasswordFile AuthProvider pointing to a non existing 
> file creates it. however editing and point it to a non existing file fails 
> with 422 but the config seems to have been updated regardless with subsequent 
> changes (e.g. adding user) failing.
> # add dialogue for SimpleLDAP AuthenticationProvider is wonky
> # deletion of TrustStore displays the trust store name in the confirmation 
> dialogue as 'undefined'.
> # In the UI for FileGroupProvider the path field is editable but on the 
> broker it is not resulting in 422 errors. Either we should allow editing on 
> the broker or disallow it in the UI.
> # add dialogue of AclFile type is wonky
> # RuleBased ACL has no useful UI
> # If the add Queue dialogue has a scrollbar the lower part (the one you have 
> to scroll to) is transparent. This applies to all addQueue dialogues.
> # dialogue layout gets messed up when dialogue has to display a scrollbar
> # clicking on any of a widgets "menu icons" (i.e., collapse pane, edit, goto, 
> or close) will also trigger a drag.
> # dashboard browser has empty row where the query browser displays the query 
> type.
> # the text elements in question/notification/warning-yellow.svg are not 
> centred correctly in IE. In chrome and FF only the warning-yellow.svg seems 
> of centre.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7483) [Java Broker, WMC] Address minor UI issues

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622679#comment-15622679
 ] 

ASF subversion and git services commented on QPID-7483:
---

Commit 1767326 from oru...@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1767326 ]

QPID-7483: Fix broken layout in IE for dialog adding 
SimpleLdapAuthenticationProvider

> [Java Broker, WMC] Address minor UI issues
> --
>
> Key: QPID-7483
> URL: https://issues.apache.org/jira/browse/QPID-7483
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Lorenz Quack
>
> During testing the following minor UI issues were discovered:
> In no particular order (numbering just for easier referencing):
> # Logging in occasionally fails with a 417 error response especially when the 
> browsers developer tools are open. This is probably due to a timeout in 
> SaslServlet (default 3000 ms).
> # In view and edit of Broker: "Statistics reporting period enabled" shoud 
> actually be "Statistics reporting reset enabled"
> # The memory log viewer grid in "Auto Refresh" mode has the "jumping page" 
> problem
> # The BrokerLogbackSocket seems to have a default port (6000) but it needs to 
> be entered regardless.
> # When using BrokerLogbackSocket and nothing is connected to it it waits 
> 100ms for each log event to time out. When using DEBUG this brings the broker 
> to a crawl (e.g., broker startup ~ 4 minutes). I could imagine this also 
> being a problem when logging over a network. Could this also be a problem for 
> other loggers (e.g. Syslog?)
> # When changing "Number of connection threads" to 1 on a VirtualHost the 
> following error is reported: "422 - Number of Selectors 8 on VirtualHost 
> bdb_bdb must be greater than the connection pool size 1. Please correct the 
> problem and retry your operation." which does not make sense. I think it 
> should say the connection pool size must be greater than the selectors not 
> the other way around.
> # Add Port dialogue does not have a scroll bar in case it does not completely 
> fit onto the screen. If the dialogue box resizes (e.g., by closing the 
> Developer Tools pane in IE) only the original part of the dialogue box has a 
> solid background. the newly exposed part is transparent.
> # Creating a Base64MD5PasswordFile AuthProvider pointing to a non existing 
> file creates it. however editing and point it to a non existing file fails 
> with 422 but the config seems to have been updated regardless with subsequent 
> changes (e.g. adding user) failing.
> # add dialogue for SimpleLDAP AuthenticationProvider is wonky
> # deletion of TrustStore displays the trust store name in the confirmation 
> dialogue as 'undefined'.
> # In the UI for FileGroupProvider the path field is editable but on the 
> broker it is not resulting in 422 errors. Either we should allow editing on 
> the broker or disallow it in the UI.
> # add dialogue of AclFile type is wonky
> # RuleBased ACL has no useful UI
> # If the add Queue dialogue has a scrollbar the lower part (the one you have 
> to scroll to) is transparent. This applies to all addQueue dialogues.
> # dialogue layout gets messed up when dialogue has to display a scrollbar
> # clicking on any of a widgets "menu icons" (i.e., collapse pane, edit, goto, 
> or close) will also trigger a drag.
> # dashboard browser has empty row where the query browser displays the query 
> type.
> # the text elements in question/notification/warning-yellow.svg are not 
> centred correctly in IE. In chrome and FF only the warning-yellow.svg seems 
> of centre.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7485) [Java Broker] File based authentication providers should not allow changing of password file to non-existing file

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622653#comment-15622653
 ] 

ASF subversion and git services commented on QPID-7485:
---

Commit 1767325 from oru...@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1767325 ]

QPID-7485: [Java Broker] File based authentication providers should not allow 
changing of password file to non-existing file

> [Java Broker] File based authentication providers should not allow changing 
> of password file to non-existing file
> -
>
> Key: QPID-7485
> URL: https://issues.apache.org/jira/browse/QPID-7485
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, 
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1, 
> qpid-java-6.2
>Reporter: Alex Rudyy
>
> Whilst editing password based authentication provider (plain or base64) and 
> setting path to a non existing file, the operation fails with 422 but the 
> configuration is updated and sub-sequent user modification operation (add 
> user/delete user/etc) fails as password file does not exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7485) [Java Broker] File based authentication providers should not allow changing of password file to non-existing file

2016-10-31 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-7485:
-
Summary: [Java Broker] File based authentication providers should not allow 
changing of password file to non-existing file  (was: [Java Broker] File based 
authentication providers should not allow changing of password to non-existing 
file)

> [Java Broker] File based authentication providers should not allow changing 
> of password file to non-existing file
> -
>
> Key: QPID-7485
> URL: https://issues.apache.org/jira/browse/QPID-7485
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, 
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1, 
> qpid-java-6.2
>Reporter: Alex Rudyy
>
> Whilst editing password based authentication provider (plain or base64) and 
> setting path to a non existing file, the operation fails with 422 but the 
> configuration is updated and sub-sequent user modification operation (add 
> user/delete user/etc) fails as password file does not exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-7485) [Java Broker] File based authentication providers should not allow changing of password to non-existing file

2016-10-31 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-7485:


 Summary: [Java Broker] File based authentication providers should 
not allow changing of password to non-existing file
 Key: QPID-7485
 URL: https://issues.apache.org/jira/browse/QPID-7485
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: qpid-java-6.0.4, qpid-java-6.0.3, qpid-java-6.0.2, 
qpid-java-6.0.1, qpid-java-6.0, qpid-java-6.0.5, qpid-java-6.1, qpid-java-6.2
Reporter: Alex Rudyy


Whilst editing password based authentication provider (plain or base64) and 
setting path to a non existing file, the operation fails with 422 but the 
configuration is updated and sub-sequent user modification operation (add 
user/delete user/etc) fails as password file does not exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7352) [Java Broker] Principal serialisation

2016-10-31 Thread Lorenz Quack (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lorenz Quack updated QPID-7352:
---
Attachment: 0001-QPID-7352-Java-Broker-Make-parsing-of-GenericPrincip.patch

> [Java Broker] Principal serialisation
> -
>
> Key: QPID-7352
> URL: https://issues.apache.org/jira/browse/QPID-7352
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
> Fix For: qpid-java-6.1
>
> Attachments: 
> 0001-QPID-7352-Java-Broker-Make-parsing-of-GenericPrincip.patch
>
>
> Implement a Jackson serialiser for Principals and add a corresponding 
> {{AttributeValueConverter}} that takes the serialised form any produces 
> Generic Principals. The serialised form is to include the reference to the 
> AuthenticationProvider (name and type). Group Providers need the 
> corresponding change.
> Update the preference store and preference store recoverer to store the 
> principal's serialised form for {{owner}} and {{visibilityList}}, and recover 
> generic principal objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622528#comment-15622528
 ] 

ASF subversion and git services commented on QPID-7481:
---

Commit 1767313 from [~k-wall] in branch 'java/branches/6.1.x'
[ https://svn.apache.org/r1767313 ]

QPID-7481: Fix screen labels associated with statistics gathering

Merged from trunk with command:

svn merge -c 1767268,1767310 ^/qpid/java/trunk

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7478) Add managed operation to reset statistics

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-7478.
--
Resolution: Fixed

> Add managed operation to reset statistics
> -
>
> Key: QPID-7478
> URL: https://issues.apache.org/jira/browse/QPID-7478
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> As an operator, until the removal of the JMX management interface, I could 
> reset the statistics of the Broker, or Virtualhost.   With the removal of the 
> JMX management interface this ability has been lost.
> Implement resetStatistics as a ManagedOperation instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7478) Add managed operation to reset statistics

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622536#comment-15622536
 ] 

ASF subversion and git services commented on QPID-7478:
---

Commit 1767316 from [~k-wall] in branch 'java/branches/6.1.x'
[ https://svn.apache.org/r1767316 ]

QPID-7478: Add managed operation to reset statistics of the broker and the 
virtualhost

Merged from trunk with command:

svn merge -c 1767267  ^/qpid/java/trunk

> Add managed operation to reset statistics
> -
>
> Key: QPID-7478
> URL: https://issues.apache.org/jira/browse/QPID-7478
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> As an operator, until the removal of the JMX management interface, I could 
> reset the statistics of the Broker, or Virtualhost.   With the removal of the 
> JMX management interface this ability has been lost.
> Implement resetStatistics as a ManagedOperation instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Comment Edited] (QPID-7478) Add managed operation to reset statistics

2016-10-31 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622501#comment-15622501
 ] 

Keith Wall edited comment on QPID-7478 at 10/31/16 3:51 PM:


Not all Vitualhosts gather statistics, so the operation would be inappropriate 
there.  We said the we'll introduce a intermediate interface, but not for v6.1 
(QPID-7484).


was (Author: k-wall):
Not all Vitualhosts gather statistics, so the operation would be inappropriate 
there.  We said the we'll introduce a intermediate interface, but not for v6.1.

> Add managed operation to reset statistics
> -
>
> Key: QPID-7478
> URL: https://issues.apache.org/jira/browse/QPID-7478
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> As an operator, until the removal of the JMX management interface, I could 
> reset the statistics of the Broker, or Virtualhost.   With the removal of the 
> JMX management interface this ability has been lost.
> Implement resetStatistics as a ManagedOperation instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-7481.
--
Resolution: Fixed

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-7484) Factor out a StandardVirtualHost interface

2016-10-31 Thread Keith Wall (JIRA)
Keith Wall created QPID-7484:


 Summary: Factor out a StandardVirtualHost interface
 Key: QPID-7484
 URL: https://issues.apache.org/jira/browse/QPID-7484
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Keith Wall
 Fix For: Future


The standard vrtualhosts should share a common interface (analogue to 
NonStandardVirtualhost).  Statistics/dead lettering etc should be concerns only 
of the standard virtual hosts.   This refactoring should clean up the 
implementations of the non-standard virtual hosts and remove many empty 
methods..   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Comment Edited] (QPID-7478) Add managed operation to reset statistics

2016-10-31 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622501#comment-15622501
 ] 

Keith Wall edited comment on QPID-7478 at 10/31/16 3:41 PM:


Not all Vitualhosts gather statistics, so the operation would be inappropriate 
there.  We said the we'll introduce a intermediate interface, but not for v6.1.


was (Author: k-wall):
Not all Vitualhostgs gather statistics.  We said the we'll introduce a 
intermediate interface, but not for v6.1.

> Add managed operation to reset statistics
> -
>
> Key: QPID-7478
> URL: https://issues.apache.org/jira/browse/QPID-7478
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> As an operator, until the removal of the JMX management interface, I could 
> reset the statistics of the Broker, or Virtualhost.   With the removal of the 
> JMX management interface this ability has been lost.
> Implement resetStatistics as a ManagedOperation instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7478) Add managed operation to reset statistics

2016-10-31 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622501#comment-15622501
 ] 

Keith Wall commented on QPID-7478:
--

Not all Vitualhostgs gather statistics.  We said the we'll introduce a 
intermediate interface, but not for v6.1.

> Add managed operation to reset statistics
> -
>
> Key: QPID-7478
> URL: https://issues.apache.org/jira/browse/QPID-7478
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> As an operator, until the removal of the JMX management interface, I could 
> reset the statistics of the Broker, or Virtualhost.   With the removal of the 
> JMX management interface this ability has been lost.
> Implement resetStatistics as a ManagedOperation instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622490#comment-15622490
 ] 

ASF subversion and git services commented on QPID-7481:
---

Commit 1767310 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1767310 ]

QPID-7481: Address review comments from oru...@apache.org

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7482) Heartbeat screen label uses wrong units

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-7482.
--
Resolution: Fixed

> Heartbeat screen label uses wrong units
> ---
>
> Key: QPID-7482
> URL: https://issues.apache.org/jira/browse/QPID-7482
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> On the Broker tab within the Web Management Console, the heartbeat delay 
> field claims milliseconds, when in actual fact, the units are seconds.  The 
> units are correct on the edit dialogue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7482) Heartbeat screen label uses wrong units

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7482:
-
Fix Version/s: qpid-java-6.1

> Heartbeat screen label uses wrong units
> ---
>
> Key: QPID-7482
> URL: https://issues.apache.org/jira/browse/QPID-7482
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> On the Broker tab within the Web Management Console, the heartbeat delay 
> field claims milliseconds, when in actual fact, the units are seconds.  The 
> units are correct on the edit dialogue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-554) Topology nodes and links are too far apart when there are a large number of routers

2016-10-31 Thread Ernest Allen (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen resolved DISPATCH-554.
---
   Resolution: Fixed
Fix Version/s: 0.8.0

> Topology nodes and links are too far apart when there are a large number of 
> routers 
> 
>
> Key: DISPATCH-554
> URL: https://issues.apache.org/jira/browse/DISPATCH-554
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
> Fix For: 0.8.0
>
>
> The router and client circles are too far apart on the topology page when 
> there are a large number of routers. This causes the circles to bunch up 
> around the edges of the graph rectangle.
> The "charge" and "linkDistance" attributes of the force graph need to be 
> adjusted based on the number of nodes (routers) in the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7482) Heartbeat screen label uses wrong units

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622450#comment-15622450
 ] 

ASF subversion and git services commented on QPID-7482:
---

Commit 1767303 from [~k-wall] in branch 'java/branches/6.1.x'
[ https://svn.apache.org/r1767303 ]

QPID-7482: Fix screen labels for heartbeat delay

Merged from trunk with command:

svn merge -c 1767275 ^/qpid/java/trunk

> Heartbeat screen label uses wrong units
> ---
>
> Key: QPID-7482
> URL: https://issues.apache.org/jira/browse/QPID-7482
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.2
>
>
> On the Broker tab within the Web Management Console, the heartbeat delay 
> field claims milliseconds, when in actual fact, the units are seconds.  The 
> units are correct on the edit dialogue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-7483) [Java Broker, WMC] Address minor UI issues

2016-10-31 Thread Lorenz Quack (JIRA)
Lorenz Quack created QPID-7483:
--

 Summary: [Java Broker, WMC] Address minor UI issues
 Key: QPID-7483
 URL: https://issues.apache.org/jira/browse/QPID-7483
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Reporter: Lorenz Quack


During testing the following minor UI issues were discovered:
In no particular order (numbering just for easier referencing):
# Logging in occasionally fails with a 417 error response especially when the 
browsers developer tools are open. This is probably due to a timeout in 
SaslServlet (default 3000 ms).
# In view and edit of Broker: "Statistics reporting period enabled" shoud 
actually be "Statistics reporting reset enabled"
# The memory log viewer grid in "Auto Refresh" mode has the "jumping page" 
problem
# The BrokerLogbackSocket seems to have a default port (6000) but it needs to 
be entered regardless.
# When using BrokerLogbackSocket and nothing is connected to it it waits 100ms 
for each log event to time out. When using DEBUG this brings the broker to a 
crawl (e.g., broker startup ~ 4 minutes). I could imagine this also being a 
problem when logging over a network. Could this also be a problem for other 
loggers (e.g. Syslog?)
# When changing "Number of connection threads" to 1 on a VirtualHost the 
following error is reported: "422 - Number of Selectors 8 on VirtualHost 
bdb_bdb must be greater than the connection pool size 1. Please correct the 
problem and retry your operation." which does not make sense. I think it should 
say the connection pool size must be greater than the selectors not the other 
way around.
# Add Port dialogue does not have a scroll bar in case it does not completely 
fit onto the screen. If the dialogue box resizes (e.g., by closing the 
Developer Tools pane in IE) only the original part of the dialogue box has a 
solid background. the newly exposed part is transparent.
# Creating a Base64MD5PasswordFile AuthProvider pointing to a non existing file 
creates it. however editing and point it to a non existing file fails with 422 
but the config seems to have been updated regardless with subsequent changes 
(e.g. adding user) failing.
# add dialogue for SimpleLDAP AuthenticationProvider is wonky
# deletion of TrustStore displays the trust store name in the confirmation 
dialogue as 'undefined'.
# In the UI for FileGroupProvider the path field is editable but on the broker 
it is not resulting in 422 errors. Either we should allow editing on the broker 
or disallow it in the UI.
# add dialogue of AclFile type is wonky
# RuleBased ACL has no useful UI
# If the add Queue dialogue has a scrollbar the lower part (the one you have to 
scroll to) is transparent. This applies to all addQueue dialogues.
# dialogue layout gets messed up when dialogue has to display a scrollbar
# clicking on any of a widgets "menu icons" (i.e., collapse pane, edit, goto, 
or close) will also trigger a drag.
# dashboard browser has empty row where the query browser displays the query 
type.
# the text elements in question/notification/warning-yellow.svg are not centred 
correctly in IE. In chrome and FF only the warning-yellow.svg seems of centre.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7478) Add managed operation to reset statistics

2016-10-31 Thread Alex Rudyy (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622323#comment-15622323
 ] 

Alex Rudyy commented on QPID-7478:
--

Keith,
Here are my review comments:
* Why _resetStatistics_ is not declared on VirtualHost interface?
* The description messages for  _resetStatistics_ is misleading as it says  
that _"Resets statistics on this object and all child objects"_ whilst on 
Broker it resets statistics on VirtualHost children and on VirtualHosts it 
resets statistics on Connections. Would it be better to say something like  
_"Resets statistics on this object and its statistics gathering children"_ ?

> Add managed operation to reset statistics
> -
>
> Key: QPID-7478
> URL: https://issues.apache.org/jira/browse/QPID-7478
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> As an operator, until the removal of the JMX management interface, I could 
> reset the statistics of the Broker, or Virtualhost.   With the removal of the 
> JMX management interface this ability has been lost.
> Implement resetStatistics as a ManagedOperation instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (DISPATCH-429) Empty string passed to getElementById()

2016-10-31 Thread Ernest Allen (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen closed DISPATCH-429.
-
Resolution: Won't Fix
  Assignee: Ernest Allen

Since this a benign error message and it is apparently caused by a 3rd party 
library, I'm closing this as won't fix in the console. 

> Empty string passed to getElementById()
> ---
>
> Key: DISPATCH-429
> URL: https://issues.apache.org/jira/browse/DISPATCH-429
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Console
>Affects Versions: 0.6.1
>Reporter: Jiri Danek
>Assignee: Ernest Allen
>Priority: Minor
> Attachments: emptystringpassed.png, singlerouter.png
>
>
> Clicking at table rows in the console, e.g. the "Router.A" row on the page 
> that appears after successful login onto router using default configuration 
> (plus a console section, naturally) results in {{Empty string passed to 
> getElementById()}} error in the browser JS console (displayed with 
> Ctrl+Shift+C in Chromium)
> This error seems to be completely harmless regarding functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-543) Initial load of topology page fetches too much information

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622256#comment-15622256
 ] 

ASF subversion and git services commented on DISPATCH-543:
--

Commit 89cd55e871649bf2f3979ac8028f3503d73f63d2 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=89cd55e ]

DISPATCH-543 Delay fetch of router.links until after topology is drawn


> Initial load of topology page fetches too much information
> --
>
> Key: DISPATCH-543
> URL: https://issues.apache.org/jira/browse/DISPATCH-543
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>
> As the topology graph is created, several entities for each router are 
> fetched:
> - .connection
> - .router.link
> -  .router
> - .router.node
> For large numbers of routers this takes a while.
> Break up the creation of the topology graph. The routers and their 
> connections to other routers can be generated using only .connection 
> information. 
> .router-link is used:
> - to draw the small client circles. After the initial graph is drawn, go back 
> and fetch the .router.link info for any router that has connections that are 
> not "inter-router". 
> - to display the popup when a client is clicked. This can quickly be fetched 
> for the individual router when one of it's clients is clicked.
> - to display the cross-section popup. This can be fetched when needed.
> .router.node is used to generate the highlight line between routers. This 
> entity can be fetched when needed.
> .router is used when adding a new node. This can be fetched when needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-544) Add ability to hide the info panel on the left of the topology page

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622255#comment-15622255
 ] 

ASF subversion and git services commented on DISPATCH-544:
--

Commit 72bb33e642ebebec33d40863b4c28f837fc9d673 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=72bb33e ]

DISPATCH-544 Clean up css of hide/show left panel buttons for Firefox


> Add ability to hide the info panel on the left of the topology page
> ---
>
> Key: DISPATCH-544
> URL: https://issues.apache.org/jira/browse/DISPATCH-544
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Minor
>
> When there are a large number of routers we can use all the page area to 
> display the topology graph. However, the left side of the page is dedicated 
> to the panel that displays info about the router or link that the mouse is 
> hovering over.
> Add a way to hide and re-show the info panel. When the panel is hidden, the 
> graph should expand to the full page. 
> Also, save and restore the state of the panel. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread Alex Rudyy (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622264#comment-15622264
 ] 

Alex Rudyy commented on QPID-7481:
--

I am curious whether description for statisticsReportingPeriod should include a 
time unit for clarity. For example, it can be changed to "Period in seconds 
with which statistics are reported to the log"

The rest of changes look good
 

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-544) Add ability to hide the info panel on the left of the topology page

2016-10-31 Thread Ernest Allen (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen resolved DISPATCH-544.
---
   Resolution: Fixed
Fix Version/s: 0.8.0

> Add ability to hide the info panel on the left of the topology page
> ---
>
> Key: DISPATCH-544
> URL: https://issues.apache.org/jira/browse/DISPATCH-544
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Minor
> Fix For: 0.8.0
>
>
> When there are a large number of routers we can use all the page area to 
> display the topology graph. However, the left side of the page is dedicated 
> to the panel that displays info about the router or link that the mouse is 
> hovering over.
> Add a way to hide and re-show the info panel. When the panel is hidden, the 
> graph should expand to the full page. 
> Also, save and restore the state of the panel. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-546) Crosssection popup position is incorrect

2016-10-31 Thread Ernest Allen (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen resolved DISPATCH-546.
---
   Resolution: Fixed
Fix Version/s: 0.8.0

> Crosssection popup position is incorrect
> 
>
> Key: DISPATCH-546
> URL: https://issues.apache.org/jira/browse/DISPATCH-546
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Minor
> Fix For: 0.8.0
>
>
> When you click on a link between to routers on the topology page, a diagram 
> that represents a cross section of a connection is displayed.
> The animation that shows and hides the cross section starts and ends in the 
> wrong place.
> In addition, the text on the cross section is being cropped and can be 
> illegible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-546) Crosssection popup position is incorrect

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622253#comment-15622253
 ] 

ASF subversion and git services commented on DISPATCH-546:
--

Commit 75e449ec07a0596211369ca8386747371ff5ece2 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=75e449e ]

DISPATCH-546 Fixed crosssection popup position and contents


> Crosssection popup position is incorrect
> 
>
> Key: DISPATCH-546
> URL: https://issues.apache.org/jira/browse/DISPATCH-546
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Minor
>
> When you click on a link between to routers on the topology page, a diagram 
> that represents a cross section of a connection is displayed.
> The animation that shows and hides the cross section starts and ends in the 
> wrong place.
> In addition, the text on the cross section is being cropped and can be 
> illegible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-544) Add ability to hide the info panel on the left of the topology page

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622254#comment-15622254
 ] 

ASF subversion and git services commented on DISPATCH-544:
--

Commit bcfc2dc1818cc99f586d0418440102dacfa5b3f7 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=bcfc2dc ]

DISPATCH-544 Add ability to hide/show the left panel on topology page


> Add ability to hide the info panel on the left of the topology page
> ---
>
> Key: DISPATCH-544
> URL: https://issues.apache.org/jira/browse/DISPATCH-544
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Minor
>
> When there are a large number of routers we can use all the page area to 
> display the topology graph. However, the left side of the page is dedicated 
> to the panel that displays info about the router or link that the mouse is 
> hovering over.
> Add a way to hide and re-show the info panel. When the panel is hidden, the 
> graph should expand to the full page. 
> Also, save and restore the state of the panel. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-554) Topology nodes and links are too far apart when there are a large number of routers

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622257#comment-15622257
 ] 

ASF subversion and git services commented on DISPATCH-554:
--

Commit 58bcc2bd423cbc31bd64d5a73c73558244bda0e0 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=58bcc2b ]

DISPATCH-554 Adjust the topology graph based on the number of nodes


> Topology nodes and links are too far apart when there are a large number of 
> routers 
> 
>
> Key: DISPATCH-554
> URL: https://issues.apache.org/jira/browse/DISPATCH-554
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>
> The router and client circles are too far apart on the topology page when 
> there are a large number of routers. This causes the circles to bunch up 
> around the edges of the graph rectangle.
> The "charge" and "linkDistance" attributes of the force graph need to be 
> adjusted based on the number of nodes (routers) in the network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-536) Circular buffer overflow errors occur when there are a large number of routers

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622252#comment-15622252
 ] 

ASF subversion and git services commented on DISPATCH-536:
--

Commit a4993ee6034c9d53e8d66f5dd5b542a38c163907 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=a4993ee ]

DISPATCH-536 Queued management calls on the overview page


> Circular buffer overflow errors occur when there are a large number of routers
> --
>
> Key: DISPATCH-536
> URL: https://issues.apache.org/jira/browse/DISPATCH-536
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Console
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>
> As the number of routers increases, the number of management calls that are 
> sent each poll cycle increases. This can cause buffer errors in rhea.
> - Don't allow a large number of management calls to be made without returning 
> control to the browser.
> Another problem with a large number of routers is that the pages may render 
> before all the router information is ready. This can cause javascript errors. 
> - Don't render the page until all router info is available. However, dong so 
> may cause a noticeable delay where a blank page is shown. A loading 
> message/animation may be necessary.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7482) Heartbeat screen label uses wrong units

2016-10-31 Thread Alex Rudyy (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622150#comment-15622150
 ] 

Alex Rudyy commented on QPID-7482:
--

The changes look reasonable to me.
We should port them into 6.1.x for inclusion into 6.1.0 RC2 build

> Heartbeat screen label uses wrong units
> ---
>
> Key: QPID-7482
> URL: https://issues.apache.org/jira/browse/QPID-7482
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.2
>
>
> On the Broker tab within the Web Management Console, the heartbeat delay 
> field claims milliseconds, when in actual fact, the units are seconds.  The 
> units are correct on the edit dialogue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7478) Add managed operation to reset statistics

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7478:
-
Status: Reviewable  (was: In Progress)

> Add managed operation to reset statistics
> -
>
> Key: QPID-7478
> URL: https://issues.apache.org/jira/browse/QPID-7478
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> As an operator, until the removal of the JMX management interface, I could 
> reset the statistics of the Broker, or Virtualhost.   With the removal of the 
> JMX management interface this ability has been lost.
> Implement resetStatistics as a ManagedOperation instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7482) Heartbeat screen label uses wrong units

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7482:
-
Status: Reviewable  (was: In Progress)

> Heartbeat screen label uses wrong units
> ---
>
> Key: QPID-7482
> URL: https://issues.apache.org/jira/browse/QPID-7482
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.2
>
>
> On the Broker tab within the Web Management Console, the heartbeat delay 
> field claims milliseconds, when in actual fact, the units are seconds.  The 
> units are correct on the edit dialogue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-7478) Add managed operation to reset statistics

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall reassigned QPID-7478:


Assignee: Keith Wall

> Add managed operation to reset statistics
> -
>
> Key: QPID-7478
> URL: https://issues.apache.org/jira/browse/QPID-7478
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> As an operator, until the removal of the JMX management interface, I could 
> reset the statistics of the Broker, or Virtualhost.   With the removal of the 
> JMX management interface this ability has been lost.
> Implement resetStatistics as a ManagedOperation instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-7482) Heartbeat screen label uses wrong units

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall reassigned QPID-7482:


Assignee: Keith Wall

> Heartbeat screen label uses wrong units
> ---
>
> Key: QPID-7482
> URL: https://issues.apache.org/jira/browse/QPID-7482
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.2
>
>
> On the Broker tab within the Web Management Console, the heartbeat delay 
> field claims milliseconds, when in actual fact, the units are seconds.  The 
> units are correct on the edit dialogue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622123#comment-15622123
 ] 

Keith Wall commented on QPID-7481:
--

Suggest we include in 6.1 too.

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7481:
-
Fix Version/s: qpid-java-6.1

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7481:
-
Status: Reviewable  (was: In Progress)

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall reassigned QPID-7481:


Assignee: Keith Wall

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7482) Heartbeat screen label uses wrong units

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622115#comment-15622115
 ] 

ASF subversion and git services commented on QPID-7482:
---

Commit 1767275 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1767275 ]

QPID-7482: Fix screen labels for heartbeat delay

> Heartbeat screen label uses wrong units
> ---
>
> Key: QPID-7482
> URL: https://issues.apache.org/jira/browse/QPID-7482
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.2
>
>
> On the Broker tab within the Web Management Console, the heartbeat delay 
> field claims milliseconds, when in actual fact, the units are seconds.  The 
> units are correct on the edit dialogue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-7482) Heartbeat screen label uses wrong units

2016-10-31 Thread Keith Wall (JIRA)
Keith Wall created QPID-7482:


 Summary: Heartbeat screen label uses wrong units
 Key: QPID-7482
 URL: https://issues.apache.org/jira/browse/QPID-7482
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: qpid-java-6.0, 0.32, qpid-java-6.0.5
Reporter: Keith Wall
Priority: Minor
 Fix For: qpid-java-6.2


On the Broker tab within the Web Management Console, the heartbeat delay field 
claims milliseconds, when in actual fact, the units are seconds.  The units are 
correct on the edit dialogue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622091#comment-15622091
 ] 

ASF subversion and git services commented on QPID-7481:
---

Commit 1767268 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1767268 ]

QPID-7481: Fix screen labels associated with statistics gathering

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7478) Add managed operation to reset statistics

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622090#comment-15622090
 ] 

ASF subversion and git services commented on QPID-7478:
---

Commit 1767267 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1767267 ]

QPID-7478: Add managed operation to reset statistics of the broker and the 
virtualhost

> Add managed operation to reset statistics
> -
>
> Key: QPID-7478
> URL: https://issues.apache.org/jira/browse/QPID-7478
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> As an operator, until the removal of the JMX management interface, I could 
> reset the statistics of the Broker, or Virtualhost.   With the removal of the 
> JMX management interface this ability has been lost.
> Implement resetStatistics as a ManagedOperation instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7481) Statistics gathering screen label uses wrong unit

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7481:
-
Summary: Statistics gathering screen label uses wrong unit  (was: 
Statistics gathering label uses wrong unit)

> Statistics gathering screen label uses wrong unit
> -
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-7481) Statistics gathering label uses wrong unit

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-7481:
-
Fix Version/s: qpid-java-6.2

> Statistics gathering label uses wrong unit
> --
>
> Key: QPID-7481
> URL: https://issues.apache.org/jira/browse/QPID-7481
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.5
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.2
>
>
> The on screen label within the WMC for the Statistics reporting period claims 
> the units are milliseconds, when un actual fact, the units are seconds.  Also 
> the label "Statistics reporting period enabled" is wrong.  It should say 
> "Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-7481) Statistics gathering label uses wrong unit

2016-10-31 Thread Keith Wall (JIRA)
Keith Wall created QPID-7481:


 Summary: Statistics gathering label uses wrong unit
 Key: QPID-7481
 URL: https://issues.apache.org/jira/browse/QPID-7481
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: qpid-java-6.0, 0.32, qpid-java-6.0.5
Reporter: Keith Wall
Priority: Minor


The on screen label within the WMC for the Statistics reporting period claims 
the units are milliseconds, when un actual fact, the units are seconds.  Also 
the label "Statistics reporting period enabled" is wrong.  It should say 
"Statistics reporting reset enabled"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Comment Edited] (QPID-7433) Add minimal maven module to invoke TCK

2016-10-31 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621921#comment-15621921
 ] 

Keith Wall edited comment on QPID-7433 at 10/31/16 11:29 AM:
-

Changes look reasonable to me.  As we only drive testing from the trunk, there 
is no point back porting these changes.


was (Author: k-wall):
Changes look reasonable to me.

> Add minimal maven module to invoke TCK
> --
>
> Key: QPID-7433
> URL: https://issues.apache.org/jira/browse/QPID-7433
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Tests
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
> Attachments: 0001-wip-working.patch
>
>
> Add a miminal  maven module to the Java build, rather like the Joram one, 
> that allows the TCK to be run against the Qpid JMS client and the legacy 
> client too against a pre-running Broker.   The TCK is proprietary.  The 
> caller will need to provide the TCK himself. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7433) Add minimal maven module to invoke TCK

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-7433.
--
Resolution: Fixed

Changes look reasonable to me.

> Add minimal maven module to invoke TCK
> --
>
> Key: QPID-7433
> URL: https://issues.apache.org/jira/browse/QPID-7433
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker, Java Tests
>Reporter: Keith Wall
>Assignee: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
> Attachments: 0001-wip-working.patch
>
>
> Add a miminal  maven module to the Java build, rather like the Joram one, 
> that allows the TCK to be run against the Qpid JMS client and the legacy 
> client too against a pre-running Broker.   The TCK is proprietary.  The 
> caller will need to provide the TCK himself. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7460) [Java Broker] Improve performance of the Json Config store with large numbers of object

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621913#comment-15621913
 ] 

ASF subversion and git services commented on QPID-7460:
---

Commit 1767252 from [~k-wall] in branch 'java/branches/6.1.x'
[ https://svn.apache.org/r1767252 ]

QPID-7460: [Java Broker] Replace concrete class names (HashMap) with interface 
(Map). No functional change.

Merged from trunk with command:
svn merge -c 1767251 ^/qpid/java/trunk

> [Java Broker] Improve performance of the Json Config store with large numbers 
> of object
> ---
>
> Key: QPID-7460
> URL: https://issues.apache.org/jira/browse/QPID-7460
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Rob Godfrey
>Assignee: Keith Wall
> Fix For: qpid-java-6.1
>
>
> When there are a large number of configured objects to store, the Json config 
> store shows very poor performance



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7460) [Java Broker] Improve performance of the Json Config store with large numbers of object

2016-10-31 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621907#comment-15621907
 ] 

Keith Wall commented on QPID-7460:
--

Changes, functionally, look reasonable to me.  I did not test the performance 
gain.

> [Java Broker] Improve performance of the Json Config store with large numbers 
> of object
> ---
>
> Key: QPID-7460
> URL: https://issues.apache.org/jira/browse/QPID-7460
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Rob Godfrey
>Assignee: Keith Wall
> Fix For: qpid-java-6.1
>
>
> When there are a large number of configured objects to store, the Json config 
> store shows very poor performance



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-7460) [Java Broker] Improve performance of the Json Config store with large numbers of object

2016-10-31 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-7460.
--
Resolution: Fixed

> [Java Broker] Improve performance of the Json Config store with large numbers 
> of object
> ---
>
> Key: QPID-7460
> URL: https://issues.apache.org/jira/browse/QPID-7460
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Rob Godfrey
>Assignee: Keith Wall
> Fix For: qpid-java-6.1
>
>
> When there are a large number of configured objects to store, the Json config 
> store shows very poor performance



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-7460) [Java Broker] Improve performance of the Json Config store with large numbers of object

2016-10-31 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621905#comment-15621905
 ] 

ASF subversion and git services commented on QPID-7460:
---

Commit 1767251 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1767251 ]

QPID-7460: [Java Broker] Replace concrete class names (HashMap) with interface 
(Map).  No functional change.

> [Java Broker] Improve performance of the Json Config store with large numbers 
> of object
> ---
>
> Key: QPID-7460
> URL: https://issues.apache.org/jira/browse/QPID-7460
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Rob Godfrey
>Assignee: Keith Wall
> Fix For: qpid-java-6.1
>
>
> When there are a large number of configured objects to store, the Json config 
> store shows very poor performance



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: A java listener Using qpid-amqp-1.0 stops listening to the service bus without giving any exception

2016-10-31 Thread Keith W
Hi Naresh

>From your link it looks like you are using the older
'qpid-amqp-1-0-client-jms' AMQP 1.0 JMS client.  Development work on
this client ceased quite some time ago.   Development focus is now on
https://qpid.apache.org/components/jms/. This too is a AMQP 1.0
complete JMS client.  Try switching to this client and see if your
problem persists.  The documentation/examples should help (same link).

If for some reason you cannot switch to the supported client, you
could try following these instructions to enable logging.  This might
help you understand why your listener is stopping.  I'd also suggest
taking some thread dumps too.

http://mail-archives.apache.org/mod_mbox/qpid-users/201402.mbox/%3CCACsaS94QyZbYrScWNtChgk=gn3ojdzgsl5sk5rrnvoj9izj...@mail.gmail.com%3E

Hope this helps.

On 28 October 2016 at 07:10, Naresh Kumar Goswami
 wrote:
> Hi Team,
>
> I have created a java topic listener application for a Azure Service bus 
> topic. I am running this application on Azure Web app service with default 
> tomcat configuration in . After running for a while it stops listening to the 
> service without giving any exception in application logs or in the tomcat's 
> catalina logs. The other applications in the tomcat is running fine.
>
> Can you tell me what can be the possible reason for this?
>
> I have implemented my listener application by using the following link's help:
>
> https://azure.microsoft.com/en-in/documentation/articles/service-bus-java-how-to-use-jms-api-amqp/
>
> I am using QPID-AMPQ 1.0.
>
> Let me know if you need any other inputs.
>
> Regards,
> Naresh

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org