[jira] [Commented] (DISPATCH-851) Update CMakeLists.txt to build new Dispatch Router Book
[
https://issues.apache.org/jira/browse/DISPATCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525846#comment-16525846
]
ASF subversion and git services commented on DISPATCH-851:
--
Commit 0f8fb609e8668738f422549ee8eb866c96e38377 in qpid-dispatch's branch
refs/heads/master from [~jr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=0f8fb60 ]
DISPATCH-851: Correct the cmake logic for adding book targets based on the
presence of asciidoctor; add asciidoctor to the documented deps and CI config
> Update CMakeLists.txt to build new Dispatch Router Book
> ---
>
> Key: DISPATCH-851
> URL: https://issues.apache.org/jira/browse/DISPATCH-851
> Project: Qpid Dispatch
> Issue Type: Sub-task
> Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Justin Ross
>Priority: Major
> Fix For: 1.2.0
>
>
> 1. CMakeLists.txt should build the new Dispatch Router book, currently
> located in /doc/new-book/.
> 2. The doc/ directory should support multiple books. For example:
> {code}
> /doc/books/ref-guide
>
> /doc/books/user-guide
> {code}
> The ref-guide would be for automatically-generated reference material such as
> management schema and possibly man pages. The user-guide would be for
> manually-created content (i.e. the Dispatch Router Book).
> 3. The new book should be built using AsciiDoctor instead of AsciiDoc Python
> (additional info here:
> http://asciidoctor.org/docs/user-manual/#migrating-from-asciidoc-python).
> Note: For copying the book dir images, note that the images are now located
> in /doc/new-book/images/. Before, they were located in /doc/book/.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1056) Build fails making docs on python-3-only fedora 28
[
https://issues.apache.org/jira/browse/DISPATCH-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross reassigned DISPATCH-1056:
-
Assignee: Justin Ross
> Build fails making docs on python-3-only fedora 28
> --
>
> Key: DISPATCH-1056
> URL: https://issues.apache.org/jira/browse/DISPATCH-1056
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Chuck Rolke
>Assignee: Justin Ross
>Priority: Major
>
> The build failed originally when asciidoc and asciidoctor were not installed.
> After installing them the build still fail. Proton is build and installed at
> a shared install prefix: /opt/local
> {{Scanning dependencies of target qdrouterd}}
> {{[ 91%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o}}
> {{[ 93%] Linking C executable qdrouterd}}
> {{[ 93%] Built target qdrouterd}}
> {{Scanning dependencies of target doc_gen}}
> {{[ 95%] Generating qdrouterd_help.adoc}}
> {{[ 96%] Generating qdrouterd.conf.5.adoc}}
> {{[100%] Generating qdmanage_help.adoc}}
> {{[100%] Generating qdstat_help.adoc}}
> {{Traceback (most recent call last):}}
> {{ File "/home/root/git/qpid-dispatch/tools/qdmanage", line 29, in }}
> {{ from qpid_dispatch.management.client import Node, Url}}
> {{ File
> "/home/root/git/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 30, in }}
> {{ import proton}}
> {{ImportError: No module named proton}}
> {{Traceback (most recent call last):}}
> {{ File "/home/root/git/qpid-dispatch/build/run.py", line 123, in }}
> {{ run_path(sys.argv[0], run_name="__main__")}}
> {{ File "/home/root/git/qpid-dispatch/build/run.py", line 107, in run_path}}
> {{ runpy.run_path(file_path, run_name=run_name)}}
> {{ File "/usr/lib64/python2.7/runpy.py", line 252, in run_path}}
> {{ return _run_module_code(code, init_globals, run_name, path_name)}}
> {{ File "/usr/lib64/python2.7/runpy.py", line 82, in _run_module_code}}
> {{ mod_name, mod_fname, mod_loader, pkg_name)}}
> {{ File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code}}
> {{ exec code in run_globals}}
> {{ File "/home/root/git/qpid-dispatch/docs/man/help2txt.py", line 68, in
> }}
> {{ main(sys.argv)}}
> {{ File "/home/root/git/qpid-dispatch/docs/man/help2txt.py", line 65, in
> main}}
> {{ print(help2txt(check_output(program)))}}
> {{ File "/usr/lib64/python2.7/subprocess.py", line 223, in check_output}}
> {{ raise CalledProcessError(retcode, cmd, output=output)}}
> {{subprocess.CalledProcessError: Command
> '['/home/root/git/qpid-dispatch/tools/qdmanage', '--help']' returned non-zero
> exit status 1}}
> {{make[2]: *** [docs/man/CMakeFiles/doc_gen.dir/build.make:83:
> docs/man/qdmanage_help.adoc] Error 1}}
> {{make[2]: *** Deleting file 'docs/man/qdmanage_help.adoc'}}
> {{make[2]: *** Waiting for unfinished jobs}}
> {{Traceback (most recent call last):}}
> {{ File "/home/root/git/qpid-dispatch/tools/qdstat", line 35, in }}
> {{ from qpid_dispatch.management.client import Url, Node, Entity}}
> {{ File
> "/home/root/git/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 30, in }}
> {{ import proton}}
> {{ImportError: No module named proton}}
> {{Traceback (most recent call last):}}
> {{ File "/home/root/git/qpid-dispatch/build/run.py", line 123, in }}
> {{ run_path(sys.argv[0], run_name="__main__")}}
> {{ File "/home/root/git/qpid-dispatch/build/run.py", line 107, in run_path}}
> {{ runpy.run_path(file_path, run_name=run_name)}}
> {{ File "/usr/lib64/python2.7/runpy.py", line 252, in run_path}}
> {{ return _run_module_code(code, init_globals, run_name, path_name)}}
> {{ File "/usr/lib64/python2.7/runpy.py", line 82, in _run_module_code}}
> {{ mod_name, mod_fname, mod_loader, pkg_name)}}
> {{ File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code}}
> {{ exec code in run_globals}}
> {{ File "/home/root/git/qpid-dispatch/docs/man/help2txt.py", line 68, in
> }}
> {{ main(sys.argv)}}
> {{ File "/home/root/git/qpid-dispatch/docs/man/help2txt.py", line 65, in
> main}}
> {{ print(help2txt(check_output(program)))}}
> {{ File "/usr/lib64/python2.7/subprocess.py", line 223, in check_output}}
> {{ raise CalledProcessError(retcode, cmd, output=output)}}
> {{subprocess.CalledProcessError: Command
> '['/home/root/git/qpid-dispatch/tools/qdstat', '--help']' returned non-zero
> exit status 1}}
> {{make[2]: *** [docs/man/CMakeFiles/doc_gen.dir/build.make:91:
> docs/man/qdstat_help.adoc] Error 1}}
> {{make[2]: *** Deleting file 'docs/man/qdstat_help.adoc'}}
> {{make[1]: *** [CMakeFiles/Makefile2:385:
> docs/man/CMakeFiles/doc_gen.dir/all] Error 2}}
> {{make: *** [Makefile:141: all] Error 2}}
>
--
This message was sent by Atlassian JIRA
[jira] [Resolved] (DISPATCH-1020) Detach expiring links with closed=true when peer connectivity lost
[
https://issues.apache.org/jira/browse/DISPATCH-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gordon Sim resolved DISPATCH-1020.
--
Resolution: Fixed
> Detach expiring links with closed=true when peer connectivity lost
> --
>
> Key: DISPATCH-1020
> URL: https://issues.apache.org/jira/browse/DISPATCH-1020
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.2.0
>
>
> Currently, Dispatch responds to the loss of an underlying connection to a
> peer by detaching the links established over that connection in the following
> way.
> {noformat}
> @detach(22) [handle=0, closed=false, error=@error(29)
> [condition=:"qd:routed-link-lost", description="Connectivity to the peer
> container was lost”]]
> {noformat}
> As is makes no sense for link defined to expire to attached again, it would
> be an improvement to the dispatch's behaviour if those links were detached
> with {{closed=true}}. This would aid the timely clean-up of resources
> elsewhere in the AMQP network.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1020) Detach expiring links with closed=true when peer connectivity lost
[
https://issues.apache.org/jira/browse/DISPATCH-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525674#comment-16525674
]
ASF subversion and git services commented on DISPATCH-1020:
---
Commit 723b73585bec70f009f5409bf29cd1edceaa167d in qpid-dispatch's branch
refs/heads/master from Gordon Sim
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=723b735 ]
DISPATCH-1020: set close on link lost based on whether terminus would survive
disconnect
> Detach expiring links with closed=true when peer connectivity lost
> --
>
> Key: DISPATCH-1020
> URL: https://issues.apache.org/jira/browse/DISPATCH-1020
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.2.0
>
>
> Currently, Dispatch responds to the loss of an underlying connection to a
> peer by detaching the links established over that connection in the following
> way.
> {noformat}
> @detach(22) [handle=0, closed=false, error=@error(29)
> [condition=:"qd:routed-link-lost", description="Connectivity to the peer
> container was lost”]]
> {noformat}
> As is makes no sense for link defined to expire to attached again, it would
> be an improvement to the dispatch's behaviour if those links were detached
> with {{closed=true}}. This would aid the timely clean-up of resources
> elsewhere in the AMQP network.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1056) Build fails making docs on python-3-only fedora 28
Chuck Rolke created DISPATCH-1056:
-
Summary: Build fails making docs on python-3-only fedora 28
Key: DISPATCH-1056
URL: https://issues.apache.org/jira/browse/DISPATCH-1056
Project: Qpid Dispatch
Issue Type: Bug
Components: Documentation
Affects Versions: 1.1.0
Reporter: Chuck Rolke
The build failed originally when asciidoc and asciidoctor were not installed.
After installing them the build still fail. Proton is build and installed at a
shared install prefix: /opt/local
{{Scanning dependencies of target qdrouterd}}
{{[ 91%] Building C object router/CMakeFiles/qdrouterd.dir/src/main.c.o}}
{{[ 93%] Linking C executable qdrouterd}}
{{[ 93%] Built target qdrouterd}}
{{Scanning dependencies of target doc_gen}}
{{[ 95%] Generating qdrouterd_help.adoc}}
{{[ 96%] Generating qdrouterd.conf.5.adoc}}
{{[100%] Generating qdmanage_help.adoc}}
{{[100%] Generating qdstat_help.adoc}}
{{Traceback (most recent call last):}}
{{ File "/home/root/git/qpid-dispatch/tools/qdmanage", line 29, in }}
{{ from qpid_dispatch.management.client import Node, Url}}
{{ File
"/home/root/git/qpid-dispatch/python/qpid_dispatch/management/client.py", line
30, in }}
{{ import proton}}
{{ImportError: No module named proton}}
{{Traceback (most recent call last):}}
{{ File "/home/root/git/qpid-dispatch/build/run.py", line 123, in }}
{{ run_path(sys.argv[0], run_name="__main__")}}
{{ File "/home/root/git/qpid-dispatch/build/run.py", line 107, in run_path}}
{{ runpy.run_path(file_path, run_name=run_name)}}
{{ File "/usr/lib64/python2.7/runpy.py", line 252, in run_path}}
{{ return _run_module_code(code, init_globals, run_name, path_name)}}
{{ File "/usr/lib64/python2.7/runpy.py", line 82, in _run_module_code}}
{{ mod_name, mod_fname, mod_loader, pkg_name)}}
{{ File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code}}
{{ exec code in run_globals}}
{{ File "/home/root/git/qpid-dispatch/docs/man/help2txt.py", line 68, in
}}
{{ main(sys.argv)}}
{{ File "/home/root/git/qpid-dispatch/docs/man/help2txt.py", line 65, in main}}
{{ print(help2txt(check_output(program)))}}
{{ File "/usr/lib64/python2.7/subprocess.py", line 223, in check_output}}
{{ raise CalledProcessError(retcode, cmd, output=output)}}
{{subprocess.CalledProcessError: Command
'['/home/root/git/qpid-dispatch/tools/qdmanage', '--help']' returned non-zero
exit status 1}}
{{make[2]: *** [docs/man/CMakeFiles/doc_gen.dir/build.make:83:
docs/man/qdmanage_help.adoc] Error 1}}
{{make[2]: *** Deleting file 'docs/man/qdmanage_help.adoc'}}
{{make[2]: *** Waiting for unfinished jobs}}
{{Traceback (most recent call last):}}
{{ File "/home/root/git/qpid-dispatch/tools/qdstat", line 35, in }}
{{ from qpid_dispatch.management.client import Url, Node, Entity}}
{{ File
"/home/root/git/qpid-dispatch/python/qpid_dispatch/management/client.py", line
30, in }}
{{ import proton}}
{{ImportError: No module named proton}}
{{Traceback (most recent call last):}}
{{ File "/home/root/git/qpid-dispatch/build/run.py", line 123, in }}
{{ run_path(sys.argv[0], run_name="__main__")}}
{{ File "/home/root/git/qpid-dispatch/build/run.py", line 107, in run_path}}
{{ runpy.run_path(file_path, run_name=run_name)}}
{{ File "/usr/lib64/python2.7/runpy.py", line 252, in run_path}}
{{ return _run_module_code(code, init_globals, run_name, path_name)}}
{{ File "/usr/lib64/python2.7/runpy.py", line 82, in _run_module_code}}
{{ mod_name, mod_fname, mod_loader, pkg_name)}}
{{ File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code}}
{{ exec code in run_globals}}
{{ File "/home/root/git/qpid-dispatch/docs/man/help2txt.py", line 68, in
}}
{{ main(sys.argv)}}
{{ File "/home/root/git/qpid-dispatch/docs/man/help2txt.py", line 65, in main}}
{{ print(help2txt(check_output(program)))}}
{{ File "/usr/lib64/python2.7/subprocess.py", line 223, in check_output}}
{{ raise CalledProcessError(retcode, cmd, output=output)}}
{{subprocess.CalledProcessError: Command
'['/home/root/git/qpid-dispatch/tools/qdstat', '--help']' returned non-zero
exit status 1}}
{{make[2]: *** [docs/man/CMakeFiles/doc_gen.dir/build.make:91:
docs/man/qdstat_help.adoc] Error 1}}
{{make[2]: *** Deleting file 'docs/man/qdstat_help.adoc'}}
{{make[1]: *** [CMakeFiles/Makefile2:385: docs/man/CMakeFiles/doc_gen.dir/all]
Error 2}}
{{make: *** [Makefile:141: all] Error 2}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #335: Dispatch 1046 rev2
GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-dispatch/pull/335 Dispatch 1046 rev2 Had to change the way we pass args to the host address parse tree api under python3 c_char_p is a bytes type under python3. Passing and returning a unicode string causes it to fail. Had to manually convert between the two. Also need to save a copy of the pattern in the tree as a payload. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kgiusti/dispatch DISPATCH-1046-REV2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/335.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #335 commit 61f4402807d833ad0c889b7d33fcde8cfdd268f9 Author: Kenneth Giusti Date: 2018-06-25T16:05:12Z DISPATCH-1046: in python3 exceptions no longer have a '.message' attribute commit 184a62a31049e8a29437bbd3d36e5fec9934fe50 Author: Kenneth Giusti Date: 2018-06-26T19:28:04Z DISPATCH-1046: fix vhost address pattern handling in python3 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1876) expose newer encode/decode operations through the Message interface
[ https://issues.apache.org/jira/browse/PROTON-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525530#comment-16525530 ] ASF subversion and git services commented on PROTON-1876: - Commit 32cc5120f3c22be5111c09b6143c9f4395c2d4eb in qpid-proton-j's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton-j.git;h=32cc512 ] PROTON-1876 Expose the encode / decode methods using buffers Expose the encode and decode methods that use WritableBuffer and ReadableBuffer on the Message interface to allow clients to use newer no-copy variants of the API easier. > expose newer encode/decode operations through the Message interface > --- > > Key: PROTON-1876 > URL: https://issues.apache.org/jira/browse/PROTON-1876 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Reporter: Robbie Gemmell >Priority: Minor > Fix For: proton-j-0.28.0 > > > The MessageImpl has some newer encode/decode operations that allow for > efficiencies over the originals, in terms of reducing buffer copying etc. > These should be exposed through the Message interface as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-980) Allow address translation on link routes
[ https://issues.apache.org/jira/browse/DISPATCH-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved DISPATCH-980. - Resolution: Fixed > Allow address translation on link routes > > > Key: DISPATCH-980 > URL: https://issues.apache.org/jira/browse/DISPATCH-980 > Project: Qpid Dispatch > Issue Type: New Feature >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.2.0 > > > With auto-links there is an externalAddr field that allows the node on the > route-container to have a different name than that the clients see through > the router. This is very useful. It would be nice to have a similar feature > for link-routes also. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-980) Allow address translation on link routes
[ https://issues.apache.org/jira/browse/DISPATCH-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525511#comment-16525511 ] ASF subversion and git services commented on DISPATCH-980: -- Commit 532ebae51a455fba340e9625d71ea62cc64be8f2 in qpid-dispatch's branch refs/heads/master from Gordon Sim [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=532ebae ] DISPATCH-980: add fields to specify prefix to be inserted into- or removed from- remote address on link routes > Allow address translation on link routes > > > Key: DISPATCH-980 > URL: https://issues.apache.org/jira/browse/DISPATCH-980 > Project: Qpid Dispatch > Issue Type: New Feature >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.2.0 > > > With auto-links there is an externalAddr field that allows the node on the > route-container to have a different name than that the clients see through > the router. This is very useful. It would be nice to have a similar feature > for link-routes also. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1054) Add console test to make test
[ https://issues.apache.org/jira/browse/DISPATCH-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525510#comment-16525510 ] ASF GitHub Bot commented on DISPATCH-1054: -- Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/333 > Add console test to make test > - > > Key: DISPATCH-1054 > URL: https://issues.apache.org/jira/browse/DISPATCH-1054 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.1.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Minor > > Currently the console tests can only be run manually from the > console/stand-alone directory. > Add a CMake system test to run the console tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #333: DISPATCH-1054 add console tests to cmake
Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/333 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1054) Add console test to make test
[ https://issues.apache.org/jira/browse/DISPATCH-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525506#comment-16525506 ] ASF subversion and git services commented on DISPATCH-1054: --- Commit fcbbb5989540aa5dfab893cd72ce31f48f5776fc in qpid-dispatch's branch refs/heads/master from [~eallen] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=fcbbb59 ] DISPATCH-1054 Add console test to cmake system_tests > Add console test to make test > - > > Key: DISPATCH-1054 > URL: https://issues.apache.org/jira/browse/DISPATCH-1054 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.1.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Minor > > Currently the console tests can only be run manually from the > console/stand-alone directory. > Add a CMake system test to run the console tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1045) Sometimes close connetion after releasing partial multi-frame messsage
[
https://issues.apache.org/jira/browse/DISPATCH-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525497#comment-16525497
]
ASF GitHub Bot commented on DISPATCH-1045:
--
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/328#discussion_r198613623
--- Diff: src/router_node.c ---
@@ -312,12 +307,30 @@ static void AMQP_rx_handler(void* context, qd_link_t
*link)
pn_link_name(pn_link));
}
+//
+// The entire message has been received and we are ready to
consume the delivery by calling pn_link_advance().
+//
+pn_link_advance(pn_link);
+
+//
+// The entire message has been received but this message needs to
be discarded
+//
+if (qd_message_is_discard(msg)) {
+pn_delivery_update(pnd, qdr_delivery_disposition(delivery));
--- End diff --
Agreed. I have pushed up a new commit to remedy your comment. Please take a
quick look. Thanks.
> Sometimes close connetion after releasing partial multi-frame messsage
> --
>
> Key: DISPATCH-1045
> URL: https://issues.apache.org/jira/browse/DISPATCH-1045
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.1.0
>Reporter: Alan Conway
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.2.0
>
>
> Since DISPATCH-1012 the router releases undeliverable deliveries.
> In the case of a multi-frame delivery, it is possible for dispatch to release
> it before the entire delivery has been received. Presently dispatch settles
> such deliveries and advances its link. That means that if another transfer
> for the same delivery arrives, dispatch regards it as a new message with an
> invalid delivery-id and closes the connection. Since the release is
> asynchronous, there's no way for the client to avoid this possibility.
> Worth checking the spec but I suspect we should be dropping the extra data
> rather than closing the connection. Need to investigate how this would work
> in proton - I think we'd update the delivery without settling it and then
> wait for the remote to settle before finally throwing it away.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #328: DISPATCH-1045 - Release the delivery only a...
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/328#discussion_r198613623
--- Diff: src/router_node.c ---
@@ -312,12 +307,30 @@ static void AMQP_rx_handler(void* context, qd_link_t
*link)
pn_link_name(pn_link));
}
+//
+// The entire message has been received and we are ready to
consume the delivery by calling pn_link_advance().
+//
+pn_link_advance(pn_link);
+
+//
+// The entire message has been received but this message needs to
be discarded
+//
+if (qd_message_is_discard(msg)) {
+pn_delivery_update(pnd, qdr_delivery_disposition(delivery));
--- End diff --
Agreed. I have pushed up a new commit to remedy your comment. Please take a
quick look. Thanks.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1055) Flow credit not propagated over link route after drain cycle
[ https://issues.apache.org/jira/browse/DISPATCH-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke updated DISPATCH-1055: -- Attachment: D-2004-direct.html > Flow credit not propagated over link route after drain cycle > > > Key: DISPATCH-1055 > URL: https://issues.apache.org/jira/browse/DISPATCH-1055 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.1.0 >Reporter: Chuck Rolke >Priority: Major > Attachments: D-2004-direct.html, D-2004-routed.html > > > A transaction test based on activemq-artemis TransactionTest reveals a credit > propagation bug. The original case and reproducer code is at > [https://issues.jboss.org/browse/ENTMQIC-2004] > > Attached are two traces of the test running direct and routed. I think this > is a router bug. > * In the direct case (D-2004-direct.html) look at Frames 101-103. Frame 101 > starts a drain cycle and Frame 102 complete the drain cycle. The the client > in Frame 103 immediately sends the receiver 1000 more credits. > * In the routed case (D-2004-routed.html) the same sequence is Frames 90-94. > Frame 90 (client->router) and Frame 91 (router->broker) start the drain > cycle. Frame 92 (broker->router) and Frame 93 (router->client) complete the > drain cycle. Then in Frame 94 the client sends 1000 more credits but the > router never sends the credits to the broker. That is the bug. > After Frame 94, where the router does not send any receiver credits to the > broker, the broker is unable to send any received messages to the receiver > and everything freezes until the test times out. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1055) Flow credit not propagated over link route after drain cycle
[ https://issues.apache.org/jira/browse/DISPATCH-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke updated DISPATCH-1055: -- Attachment: D-2004-routed.html > Flow credit not propagated over link route after drain cycle > > > Key: DISPATCH-1055 > URL: https://issues.apache.org/jira/browse/DISPATCH-1055 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.1.0 >Reporter: Chuck Rolke >Priority: Major > Attachments: D-2004-direct.html, D-2004-routed.html > > > A transaction test based on activemq-artemis TransactionTest reveals a credit > propagation bug. The original case and reproducer code is at > [https://issues.jboss.org/browse/ENTMQIC-2004] > > Attached are two traces of the test running direct and routed. I think this > is a router bug. > * In the direct case (D-2004-direct.html) look at Frames 101-103. Frame 101 > starts a drain cycle and Frame 102 complete the drain cycle. The the client > in Frame 103 immediately sends the receiver 1000 more credits. > * In the routed case (D-2004-routed.html) the same sequence is Frames 90-94. > Frame 90 (client->router) and Frame 91 (router->broker) start the drain > cycle. Frame 92 (broker->router) and Frame 93 (router->client) complete the > drain cycle. Then in Frame 94 the client sends 1000 more credits but the > router never sends the credits to the broker. That is the bug. > After Frame 94, where the router does not send any receiver credits to the > broker, the broker is unable to send any received messages to the receiver > and everything freezes until the test times out. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1055) Flow credit not propagated over link route after drain cycle
Chuck Rolke created DISPATCH-1055: - Summary: Flow credit not propagated over link route after drain cycle Key: DISPATCH-1055 URL: https://issues.apache.org/jira/browse/DISPATCH-1055 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.1.0 Reporter: Chuck Rolke A transaction test based on activemq-artemis TransactionTest reveals a credit propagation bug. The original case and reproducer code is at [https://issues.jboss.org/browse/ENTMQIC-2004] Attached are two traces of the test running direct and routed. I think this is a router bug. * In the direct case (D-2004-direct.html) look at Frames 101-103. Frame 101 starts a drain cycle and Frame 102 complete the drain cycle. The the client in Frame 103 immediately sends the receiver 1000 more credits. * In the routed case (D-2004-routed.html) the same sequence is Frames 90-94. Frame 90 (client->router) and Frame 91 (router->broker) start the drain cycle. Frame 92 (broker->router) and Frame 93 (router->client) complete the drain cycle. Then in Frame 94 the client sends 1000 more credits but the router never sends the credits to the broker. That is the bug. After Frame 94, where the router does not send any receiver credits to the broker, the broker is unable to send any received messages to the receiver and everything freezes until the test times out. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #334: Dispatch 1046 - fix policy handling in python3 env...
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/334 This patch fixes the c_char_p in py3 and improves interfaces with some const additions. The patch also repairs some incorrect handling of policy's parse tree. It looks like there were resource leaks when the trees were deleted. I don't think that was just a py3 issue. This PR looks OK to me. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1045) Sometimes close connetion after releasing partial multi-frame messsage
[
https://issues.apache.org/jira/browse/DISPATCH-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525462#comment-16525462
]
ASF GitHub Bot commented on DISPATCH-1045:
--
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/328#discussion_r198605509
--- Diff: src/router_node.c ---
@@ -312,12 +307,30 @@ static void AMQP_rx_handler(void* context, qd_link_t
*link)
pn_link_name(pn_link));
}
+//
+// The entire message has been received and we are ready to
consume the delivery by calling pn_link_advance().
+//
+pn_link_advance(pn_link);
+
+//
+// The entire message has been received but this message needs to
be discarded
+//
+if (qd_message_is_discard(msg)) {
+pn_delivery_update(pnd, qdr_delivery_disposition(delivery));
--- End diff --
Is the delivery disposition _always_ set when discard is set? What if the
disposition was not set? I think the pn_delivery_update should not be called
in this case.
> Sometimes close connetion after releasing partial multi-frame messsage
> --
>
> Key: DISPATCH-1045
> URL: https://issues.apache.org/jira/browse/DISPATCH-1045
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.1.0
>Reporter: Alan Conway
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.2.0
>
>
> Since DISPATCH-1012 the router releases undeliverable deliveries.
> In the case of a multi-frame delivery, it is possible for dispatch to release
> it before the entire delivery has been received. Presently dispatch settles
> such deliveries and advances its link. That means that if another transfer
> for the same delivery arrives, dispatch regards it as a new message with an
> invalid delivery-id and closes the connection. Since the release is
> asynchronous, there's no way for the client to avoid this possibility.
> Worth checking the spec but I suspect we should be dropping the extra data
> rather than closing the connection. Need to investigate how this would work
> in proton - I think we'd update the delivery without settling it and then
> wait for the remote to settle before finally throwing it away.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #328: DISPATCH-1045 - Release the delivery only a...
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/328#discussion_r198605509
--- Diff: src/router_node.c ---
@@ -312,12 +307,30 @@ static void AMQP_rx_handler(void* context, qd_link_t
*link)
pn_link_name(pn_link));
}
+//
+// The entire message has been received and we are ready to
consume the delivery by calling pn_link_advance().
+//
+pn_link_advance(pn_link);
+
+//
+// The entire message has been received but this message needs to
be discarded
+//
+if (qd_message_is_discard(msg)) {
+pn_delivery_update(pnd, qdr_delivery_disposition(delivery));
--- End diff --
Is the delivery disposition _always_ set when discard is set? What if the
disposition was not set? I think the pn_delivery_update should not be called
in this case.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1054) Add console test to make test
[ https://issues.apache.org/jira/browse/DISPATCH-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525437#comment-16525437 ] ASF GitHub Bot commented on DISPATCH-1054: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/333 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=h1) Report > Merging [#333](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/e60d6a99772994f5304cd28fa5ebd9021f5313af?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=tree) ```diff @@Coverage Diff @@ ## master #333 +/- ## == - Coverage 86.55% 86.53% -0.02% == Files 69 69 Lines 1548715489 +2 == Hits1340413404 - Misses 2083 2085 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `98.88% <0%> (-0.38%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `85.85% <0%> (-0.19%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.01% <0%> (-0.12%)` | :arrow_down: | | [src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=) | `83.28% <0%> (+0.29%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.79% <0%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=footer). Last update [e60d6a9...5ff4744](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Add console test to make test > - > > Key: DISPATCH-1054 > URL: https://issues.apache.org/jira/browse/DISPATCH-1054 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.1.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Minor > > Currently the console tests can only be run manually from the > console/stand-alone directory. > Add a CMake system test to run the console tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #333: DISPATCH-1054 add console tests to cmake
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/333 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=h1) Report > Merging [#333](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/e60d6a99772994f5304cd28fa5ebd9021f5313af?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=tree) ```diff @@Coverage Diff @@ ## master #333 +/- ## == - Coverage 86.55% 86.53% -0.02% == Files 69 69 Lines 1548715489 +2 == Hits1340413404 - Misses 2083 2085 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=tree) | Coverage Π| | |---|---|---| | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `98.88% <0%> (-0.38%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `85.85% <0%> (-0.19%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.01% <0%> (-0.12%)` | :arrow_down: | | [src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=) | `83.28% <0%> (+0.29%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/333/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.79% <0%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=footer). Last update [e60d6a9...5ff4744](https://codecov.io/gh/apache/qpid-dispatch/pull/333?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1054) Add console test to make test
[ https://issues.apache.org/jira/browse/DISPATCH-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525362#comment-16525362 ] ASF GitHub Bot commented on DISPATCH-1054: -- GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/333 DISPATCH-1054 add console tests to cmake testing to see if make test successfully runs console tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch DISPATCH-1054-add-console-test-to-cmake Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/333.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #333 commit 5ff474442854babced6a94aa8eb0821532c6ba5a Author: Ernest Allen Date: 2018-06-27T18:09:21Z DISPATCH-1054 add console tests to cmake > Add console test to make test > - > > Key: DISPATCH-1054 > URL: https://issues.apache.org/jira/browse/DISPATCH-1054 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.1.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Minor > > Currently the console tests can only be run manually from the > console/stand-alone directory. > Add a CMake system test to run the console tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1054) Add console test to make test
Ernest Allen created DISPATCH-1054: -- Summary: Add console test to make test Key: DISPATCH-1054 URL: https://issues.apache.org/jira/browse/DISPATCH-1054 Project: Qpid Dispatch Issue Type: Improvement Components: Console Affects Versions: 1.1.0 Reporter: Ernest Allen Assignee: Ernest Allen Currently the console tests can only be run manually from the console/stand-alone directory. Add a CMake system test to run the console tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #326: Logging
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/326#discussion_r198583346
--- Diff: src/server.c ---
@@ -651,8 +651,9 @@ static void on_connection_bound(qd_server_t *server,
pn_event_t *e) {
pn_sasl_set_allow_insecure_mechs(sasl,
config->allowInsecureAuthentication);
sys_mutex_unlock(ctx->server->lock);
-qd_log(ctx->server->log_source, QD_LOG_INFO, "Accepted connection
to %s from %s",
- name, ctx->rhost_port);
+qd_log(ctx->server->log_source, QD_LOG_INFO,
--- End diff --
There appear to be more arguments than format directives in this call.
Why did you remove the information about the remote host?
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1053) Allow deliveries to be constrained to router-control links by address state
[ https://issues.apache.org/jira/browse/DISPATCH-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1053. Resolution: Fixed > Allow deliveries to be constrained to router-control links by address state > --- > > Key: DISPATCH-1053 > URL: https://issues.apache.org/jira/browse/DISPATCH-1053 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Minor > Fix For: 1.2.0 > > > Add a boolean flag to the address record called 'router_control_only' that, > when set, constrains deliveries to that address to only be received via a > router-control link. Use this constraint on the built-in addresses used for > inter-router control messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1053) Allow deliveries to be constrained to router-control links by address state
Ted Ross created DISPATCH-1053: -- Summary: Allow deliveries to be constrained to router-control links by address state Key: DISPATCH-1053 URL: https://issues.apache.org/jira/browse/DISPATCH-1053 Project: Qpid Dispatch Issue Type: Improvement Components: Router Node Reporter: Ted Ross Assignee: Ted Ross Fix For: 1.2.0 Add a boolean flag to the address record called 'router_control_only' that, when set, constrains deliveries to that address to only be received via a router-control link. Use this constraint on the built-in addresses used for inter-router control messages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1876) expose newer encode/decode operations through the Message interface
Robbie Gemmell created PROTON-1876: -- Summary: expose newer encode/decode operations through the Message interface Key: PROTON-1876 URL: https://issues.apache.org/jira/browse/PROTON-1876 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Robbie Gemmell Fix For: proton-j-0.28.0 The MessageImpl has some newer encode/decode operations that allow for efficiencies over the originals, in terms of reducing buffer copying etc. These should be exposed through the Message interface as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1052) minor lock leak in policy code
Ken Giusti created DISPATCH-1052: Summary: minor lock leak in policy code Key: DISPATCH-1052 URL: https://issues.apache.org/jira/browse/DISPATCH-1052 Project: Qpid Dispatch Issue Type: Bug Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.2.0 running ctest -VV -R tests_policy with -DUSE_VALGRIND=True: 21: ==17833== 64 bytes in 1 blocks are definitely lost in loss record 1,080 of 3,621 21: ==17833==at 0x4C2ED47: memalign (vg_replace_malloc.c:857) 21: ==17833==by 0x4C2EE45: posix_memalign (vg_replace_malloc.c:1020) 21: ==17833==by 0x4E706B8: sys_mutex (threading.c:40) 21: ==17833==by 0x4E6C9E8: qd_policy (policy.c:100) 21: ==17833==by 0x4E62B01: qd_dispatch_prepare (dispatch.c:302) 21: ==17833==by 0x10FCAD1D: ffi_call_unix64 (unix64.S:76) 21: ==17833==by 0x10FCA68E: ffi_call (ffi64.c:525) 21: ==17833==by 0x10DB79C4: _call_function_pointer (callproc.c:841) 21: ==17833==by 0x10DB79C4: _ctypes_callproc (callproc.c:1184) 21: ==17833==by 0x10DB168D: PyCFuncPtr_call (_ctypes.c:4077) 21: ==17833==by 0x5BBFBE2: PyObject_Call (abstract.c:2547) 21: ==17833==by 0x5C81991: do_call (ceval.c:4666) 21: ==17833==by 0x5C81991: call_function (ceval.c:4471) 21: ==17833==by 0x5C81991: PyEval_EvalFrameEx (ceval.c:3083) 21: ==17833==by 0x5C86987: PyEval_EvalCodeEx (ceval.c:3681) 21: ==17833== 21: -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8214) Reduce the table names size in the JDBC configuration store to fit Oracle's 30 characters limitation
Olivier VERMEULEN created QPID-8214: --- Summary: Reduce the table names size in the JDBC configuration store to fit Oracle's 30 characters limitation Key: QPID-8214 URL: https://issues.apache.org/jira/browse/QPID-8214 Project: Qpid Issue Type: Improvement Components: Broker-J Affects Versions: qpid-java-broker-7.0.4 Reporter: Olivier VERMEULEN 'QPID_CONFIGURED_OBJECT_HIERARCHY' is already 32 characters long. And we should also take into account that users can specify a table name prefix. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
GitHub user overmeulen opened a pull request: https://github.com/apache/qpid-broker-j/pull/9 [QPID-8208] Fix Sybase support for the link-store You can merge this pull request into a Git repository by running: $ git pull https://github.com/overmeulen/qpid-broker-j bugfix/QPID-8208 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-broker-j/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 664c066f00c1c4bb4d381629441d999453735fca Author: overmeulen Date: 2018-06-27T11:57:19Z [QPID-8208] Fix Sybase support for the link-store --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8208) [Broker-J] Improve handling of unexpected exceptions on establishing LDAP connections in SimpleLDAPAuthenticationProvider
[
https://issues.apache.org/jira/browse/QPID-8208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524960#comment-16524960
]
ASF GitHub Bot commented on QPID-8208:
--
GitHub user overmeulen opened a pull request:
https://github.com/apache/qpid-broker-j/pull/9
[QPID-8208] Fix Sybase support for the link-store
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/overmeulen/qpid-broker-j bugfix/QPID-8208
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-broker-j/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
commit 664c066f00c1c4bb4d381629441d999453735fca
Author: overmeulen
Date: 2018-06-27T11:57:19Z
[QPID-8208] Fix Sybase support for the link-store
> [Broker-J] Improve handling of unexpected exceptions on establishing LDAP
> connections in SimpleLDAPAuthenticationProvider
> --
>
> Key: QPID-8208
> URL: https://issues.apache.org/jira/browse/QPID-8208
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, 0.32, qpid-java-6.0, qpid-java-6.0.1,
> qpid-java-6.0.2, qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5,
> qpid-java-6.1, qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2,
> qpid-java-6.0.7, qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4,
> qpid-java-broker-7.0.0, qpid-java-6.1.5, qpid-java-broker-7.0.1,
> qpid-java-broker-7.0.4
>Reporter: Alex Rudyy
>Priority: Critical
>
> There is a weakness in Qpid exception handling when communication with
> external services like LDAP. The Broker should take a more defensive approach
> and handle unexpected exceptions thrown by underlying third-party API in
> addition to exceptions declared in API interfaces. The unexpected exceptions
> thrown by underlying API should not affect the stability of the Broker.
> It was reported that on establishment of connection with LDAP using default
> context factory {{com.sun.jndi.ldap.LdapCtxFactory}} the creation of
> {{InitialDirContext}} can end-up in unexpected exception thrown from
> {{com.sun.jndi.ldap.LdapClient}}. It looks like a defect in
> {{com.sun.jndi.ldap.LdapClient}}, but I could not find any existing open bug
> report raised against JVM with similar behaviour. I think that Broker should
> catch unexpected exception, log it and report authentication failure back to
> the client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8213) [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
[
https://issues.apache.org/jira/browse/QPID-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-8213:
-
Priority: Minor (was: Major)
> [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
> --
>
> Key: QPID-8213
> URL: https://issues.apache.org/jira/browse/QPID-8213
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.1.0
>
>
> A redundant InputStream is opened and not closed in
> {{SSLUtil#readCertificates(URL)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8213) [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
[
https://issues.apache.org/jira/browse/QPID-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall resolved QPID-8213.
--
Resolution: Fixed
Fix Version/s: qpid-java-broker-7.1.0
> [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
> --
>
> Key: QPID-8213
> URL: https://issues.apache.org/jira/browse/QPID-8213
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
>
> A redundant InputStream is opened and not closed in
> {{SSLUtil#readCertificates(URL)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8213) [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
[
https://issues.apache.org/jira/browse/QPID-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524951#comment-16524951
]
Keith Wall commented on QPID-8213:
--
Change looks good to me. I noticed qpid-jms-amqp-0-x had the same code, albeit
unused,I removed it with a NO-JIRA commit
([https://git-wip-us.apache.org/repos/asf?p=qpid-jms-amqp-0-x.git;h=7f67f82ec04a8a346cc64ec1cd824022c9082da0)]
> [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
> --
>
> Key: QPID-8213
> URL: https://issues.apache.org/jira/browse/QPID-8213
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
>
> A redundant InputStream is opened and not closed in
> {{SSLUtil#readCertificates(URL)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Re: InputStream in SSLUtil.java line 449
Hi Jesse, Thanks for letting us know about the defect. I fixed the defect as part of QPID-8213. Kind Regards, Alex [1] https://issues.apache.org/jira/browse/QPID-8213 On 27 June 2018 at 02:27, Jesse wrote: > Hello, > > I noticed that there may be an unclosed resource around line 449 of > org.apache.qpid.server.transport.network.security.ssl.SSLUtil.java > > Let me know what you think or if you need more details. > > Thanks, > > Jesse > > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8213) [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
[
https://issues.apache.org/jira/browse/QPID-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8213:
-
Status: Reviewable (was: In Progress)
> [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
> --
>
> Key: QPID-8213
> URL: https://issues.apache.org/jira/browse/QPID-8213
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
>
> A redundant InputStream is opened and not closed in
> {{SSLUtil#readCertificates(URL)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-1862) Idle timeout not working on Linux
[ https://issues.apache.org/jira/browse/PROTON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524842#comment-16524842 ] Jeremy edited comment on PROTON-1862 at 6/27/18 9:50 AM: - Any updates as to when can this issue be addressed? I can work on a patch, however, I need your validation before, on whether or not this is indeed a regression. was (Author: jeremy.aouad): Any updates as to when can this issue be addressed? I can work on a patch, however, I need your validation before if this is indeed a regression. > Idle timeout not working on Linux > - > > Key: PROTON-1862 > URL: https://issues.apache.org/jira/browse/PROTON-1862 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.22.0 >Reporter: Jeremy >Priority: Critical > Labels: reproducer > Attachments: test_case.cpp > > > We faced an issue with the idle timeout on linux. On windows, it seems to > work. > In our proton feature test suite, we test the idle timeout feature by doing a > sleep in the method on_session_open. > This should trigger a connection timeout. It works on windows, and it used to > work with proton v0.16.0 on windows and linux. > Removing the sleep from the on_session_open and putting it in > on_connection_open, yields the same result. > See attached file to reproduce. > Machines: > * Windows machine > ** OS: Windows 7 > ** Compiler: MSVC 2013 Version 12 Update 5 > * Linux machine > ** OS: Red Hat Enterprise Linux Server release 6.4 (Santiago) > ** Compiler: g++491 (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8213) [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
[
https://issues.apache.org/jira/browse/QPID-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy reassigned QPID-8213:
Assignee: Alex Rudyy
> [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
> --
>
> Key: QPID-8213
> URL: https://issues.apache.org/jira/browse/QPID-8213
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
>
> A redundant InputStream is opened and not closed in
> {{SSLUtil#readCertificates(URL)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8213) [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
[
https://issues.apache.org/jira/browse/QPID-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524841#comment-16524841
]
ASF subversion and git services commented on QPID-8213:
---
Commit c018e1ac9d21e9f5eb38d2ae7a26a31e63c07fdf in qpid-broker-j's branch
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c018e1a ]
QPID-8213: [Broker-J] Do not open redundant InputStream in
SSLUtil#readCertificates
> [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
> --
>
> Key: QPID-8213
> URL: https://issues.apache.org/jira/browse/QPID-8213
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3,
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2,
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1,
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7,
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0,
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Major
>
> A redundant InputStream is opened and not closed in
> {{SSLUtil#readCertificates(URL)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1862) Idle timeout not working on Linux
[ https://issues.apache.org/jira/browse/PROTON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524842#comment-16524842 ] Jeremy commented on PROTON-1862: Any updates as to when can this issue be addressed? I can work on a patch, however, I need your validation before if this is indeed a regression. > Idle timeout not working on Linux > - > > Key: PROTON-1862 > URL: https://issues.apache.org/jira/browse/PROTON-1862 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.22.0 >Reporter: Jeremy >Priority: Critical > Labels: reproducer > Attachments: test_case.cpp > > > We faced an issue with the idle timeout on linux. On windows, it seems to > work. > In our proton feature test suite, we test the idle timeout feature by doing a > sleep in the method on_session_open. > This should trigger a connection timeout. It works on windows, and it used to > work with proton v0.16.0 on windows and linux. > Removing the sleep from the on_session_open and putting it in > on_connection_open, yields the same result. > See attached file to reproduce. > Machines: > * Windows machine > ** OS: Windows 7 > ** Compiler: MSVC 2013 Version 12 Update 5 > * Linux machine > ** OS: Red Hat Enterprise Linux Server release 6.4 (Santiago) > ** Compiler: g++491 (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8213) [Broker-J] InputStream is not closed in SSLUtil#readCertificates(URL)
Alex Rudyy created QPID-8213:
Summary: [Broker-J] InputStream is not closed in
SSLUtil#readCertificates(URL)
Key: QPID-8213
URL: https://issues.apache.org/jira/browse/QPID-8213
Project: Qpid
Issue Type: Bug
Components: Broker-J
Affects Versions: qpid-java-broker-7.0.6, qpid-java-broker-7.0.5,
qpid-java-broker-7.0.4, qpid-java-broker-7.0.1, qpid-java-6.1.5,
qpid-java-broker-7.0.0, qpid-java-6.1.4, qpid-java-6.0.8, qpid-java-6.1.3,
qpid-java-6.0.7, qpid-java-6.1.2, qpid-java-6.1.1, qpid-java-6.0.6,
qpid-java-6.1, qpid-java-6.0.5, qpid-java-6.0.4, qpid-java-6.0.3,
qpid-java-6.0.2, qpid-java-6.0.1, qpid-java-6.0, qpid-java-broker-7.0.2,
qpid-java-broker-7.0.3, qpid-java-6.1.6
Reporter: Alex Rudyy
A redundant InputStream is opened and not closed in
{{SSLUtil#readCertificates(URL)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
