[jira] [Resolved] (PROTON-2027) Proactor connection wake after memory freed when using pn_proactor_disconnect().
[ https://issues.apache.org/jira/browse/PROTON-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cliff Jansen resolved PROTON-2027. -- Resolution: Fixed Test also works now on CentOS 6 > Proactor connection wake after memory freed when using > pn_proactor_disconnect(). > > > Key: PROTON-2027 > URL: https://issues.apache.org/jira/browse/PROTON-2027 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.27.0 >Reporter: Cliff Jansen >Assignee: Cliff Jansen >Priority: Major > Fix For: proton-c-0.28.0 > > > The normal cleanup procedure for epoll and win_iocp proactors waits for all > async activity to complete before freeing memory. > pn_proactor_disconnect can't actually force a close so it launches a separate > async activity piggy-backed on the internal wake mechanism of any connections > to be closed. > If the disconnect is happening at the same time as a separate thread doing a > normal close, a new wake can result after concluding there are none left. > The solution is to mark the connection as "already awake" before entering the > cleanup code so new wakes are no-ops. The libuv proactor doesn't need this > as the disconnect function is managed within libuv and never competes with > the normal close operation. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1283) Router crash when link gets freed before its deliveries are freed
[
https://issues.apache.org/jira/browse/DISPATCH-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chuck Rolke updated DISPATCH-1283:
--
Attachment: ea1.html
> Router crash when link gets freed before its deliveries are freed
> -
>
> Key: DISPATCH-1283
> URL: https://issues.apache.org/jira/browse/DISPATCH-1283
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: ea1.html
>
>
> {noformat}
> (gdb) bt
> #0 0x7ff1db20d060 in qdr_delete_delivery_internal_CT (core=0x1416180,
> delivery=0x7ff1c80d2fe8) at
> /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:613
> #1 0x7ff1db20e9b6 in qdr_delete_delivery_CT (core=0x1416180,
> action=0x7ff1bc33d828, discard=false) at
> /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:1221
> #2 0x7ff1db206ec0 in router_core_thread (arg=0x1416180) at
> /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:148
> #3 0x7ff1db11858e in start_thread () from /lib64/libpthread.so.0
> #4 0x7ff1dabc06a3 in clone () from /lib64/libc.so.6
> (gdb){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1283) Router crash when link gets freed before its deliveries are freed
[
https://issues.apache.org/jira/browse/DISPATCH-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814904#comment-16814904
]
Chuck Rolke commented on DISPATCH-1283:
---
Self test system_tests_edge_router exposes this issue.
In the failed run 'test_11' appears to complete ok but 'test_12' is ERROR.
The problem is that test_11 crashed router EA1.
In RouterTest/setUpClass directory is a core dump. This file shows a back
trace similar to the base jira. The core identifies router EA1 as the
crashed router.
Scraper tool is run on EA1.log and the output is attached as file ea1.html.
In this run:
* edge router EA1 has a long-lived connection A0_1 to interior router INT.A
* edge router EA1 has a client connection to receiver peer_9
Examining the web file ea1.html:
* 2019-04-10 15:48:11.998243 peer_9 closes the receiver link to router EA1.
* EA1 responds by detaching its link to peer_9
* 2019-04-10 15:48:11.998529 Edge EA1 has no open clients so it detaches its
link
[0,7] to interior INT.A
* INT.A hasn't heard about the closed link yet and blasts transfers 1208..1256
to
edge EA1.
* 2019-04-10 15:48:12.007543 INT.A closes link [0,7]
Now the Edge EA1 and interior INT.A behavior gets a little sketchy:
* 2019-04-10 15:48:12.007543 EA1 sends receiver dispositions for 1208..1256
back to INT.A Note that these dispositions have no final state.
* 2019-04-10 15:48:12.009673 INT.A, receiving dispositions with no state sends
_sender_ dispositions back to EA1.
As soon as EA1 starts receiving the sender dispositions it crashes.
===
>From a protocol standpoint both routers would be better off if they didn't
>respond at
all to transfers or dispositions after they sent the detach to close the links.
> Router crash when link gets freed before its deliveries are freed
> -
>
> Key: DISPATCH-1283
> URL: https://issues.apache.org/jira/browse/DISPATCH-1283
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> (gdb) bt
> #0 0x7ff1db20d060 in qdr_delete_delivery_internal_CT (core=0x1416180,
> delivery=0x7ff1c80d2fe8) at
> /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:613
> #1 0x7ff1db20e9b6 in qdr_delete_delivery_CT (core=0x1416180,
> action=0x7ff1bc33d828, discard=false) at
> /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:1221
> #2 0x7ff1db206ec0 in router_core_thread (arg=0x1416180) at
> /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:148
> #3 0x7ff1db11858e in start_thread () from /lib64/libpthread.so.0
> #4 0x7ff1dabc06a3 in clone () from /lib64/libc.so.6
> (gdb){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1270) Inapropriate use of CLOCK_REALTIME for periodic timer
[
https://issues.apache.org/jira/browse/DISPATCH-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-1270:
-
Fix Version/s: 1.7.0
> Inapropriate use of CLOCK_REALTIME for periodic timer
> -
>
> Key: DISPATCH-1270
> URL: https://issues.apache.org/jira/browse/DISPATCH-1270
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Trivial
> Fix For: 1.7.0
>
>
> Similarly to Qpid Cpp broker (QPID-5865, QPID-6698), Qpid Dispatch router
> currently uses CLOCK_REALTIME where CLOCK_MONOTONIC would be more appropriate.
> This wrong usage was highlighted by PROTON-985 which clarified that
> {{pn_transport_tick}} should be given monotonic timestamp.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1270) Inapropriate use of CLOCK_REALTIME for periodic timer
[
https://issues.apache.org/jira/browse/DISPATCH-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved DISPATCH-1270.
--
Resolution: Fixed
> Inapropriate use of CLOCK_REALTIME for periodic timer
> -
>
> Key: DISPATCH-1270
> URL: https://issues.apache.org/jira/browse/DISPATCH-1270
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Trivial
> Fix For: 1.7.0
>
>
> Similarly to Qpid Cpp broker (QPID-5865, QPID-6698), Qpid Dispatch router
> currently uses CLOCK_REALTIME where CLOCK_MONOTONIC would be more appropriate.
> This wrong usage was highlighted by PROTON-985 which clarified that
> {{pn_transport_tick}} should be given monotonic timestamp.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1270) Inapropriate use of CLOCK_REALTIME for periodic timer
[
https://issues.apache.org/jira/browse/DISPATCH-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk reassigned DISPATCH-1270:
Assignee: Jiri Daněk
> Inapropriate use of CLOCK_REALTIME for periodic timer
> -
>
> Key: DISPATCH-1270
> URL: https://issues.apache.org/jira/browse/DISPATCH-1270
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Trivial
>
> Similarly to Qpid Cpp broker (QPID-5865, QPID-6698), Qpid Dispatch router
> currently uses CLOCK_REALTIME where CLOCK_MONOTONIC would be more appropriate.
> This wrong usage was highlighted by PROTON-985 which clarified that
> {{pn_transport_tick}} should be given monotonic timestamp.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1270) Inapropriate use of CLOCK_REALTIME for periodic timer
[
https://issues.apache.org/jira/browse/DISPATCH-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814854#comment-16814854
]
ASF GitHub Bot commented on DISPATCH-1270:
--
jdanekrh commented on pull request #450: DISPATCH-1270 - Use CLOCK_MONOTONIC
for purpose of calling pn_transport_tick
URL: https://github.com/apache/qpid-dispatch/pull/450
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inapropriate use of CLOCK_REALTIME for periodic timer
> -
>
> Key: DISPATCH-1270
> URL: https://issues.apache.org/jira/browse/DISPATCH-1270
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Jiri Daněk
>Priority: Trivial
>
> Similarly to Qpid Cpp broker (QPID-5865, QPID-6698), Qpid Dispatch router
> currently uses CLOCK_REALTIME where CLOCK_MONOTONIC would be more appropriate.
> This wrong usage was highlighted by PROTON-985 which clarified that
> {{pn_transport_tick}} should be given monotonic timestamp.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1270) Inapropriate use of CLOCK_REALTIME for periodic timer
[
https://issues.apache.org/jira/browse/DISPATCH-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814855#comment-16814855
]
ASF subversion and git services commented on DISPATCH-1270:
---
Commit 9bb06620c63ab47441d2e4c68c81f66fe0aff050 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=9bb0662 ]
DISPATCH-1270 - Use CLOCK_MONOTONIC for purpose of calling pn_transport_tick
> Inapropriate use of CLOCK_REALTIME for periodic timer
> -
>
> Key: DISPATCH-1270
> URL: https://issues.apache.org/jira/browse/DISPATCH-1270
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Jiri Daněk
>Priority: Trivial
>
> Similarly to Qpid Cpp broker (QPID-5865, QPID-6698), Qpid Dispatch router
> currently uses CLOCK_REALTIME where CLOCK_MONOTONIC would be more appropriate.
> This wrong usage was highlighted by PROTON-985 which clarified that
> {{pn_transport_tick}} should be given monotonic timestamp.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh merged pull request #450: DISPATCH-1270 - Use CLOCK_MONOTONIC for purpose of calling pn_transport_tick
jdanekrh merged pull request #450: DISPATCH-1270 - Use CLOCK_MONOTONIC for purpose of calling pn_transport_tick URL: https://github.com/apache/qpid-dispatch/pull/450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1310) Move delivery settlement and disposition propagation out of the core thread
[ https://issues.apache.org/jira/browse/DISPATCH-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814840#comment-16814840 ] ASF GitHub Bot commented on DISPATCH-1310: -- codecov-io commented on issue #488: DISPATCH-1310: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/488#issuecomment-481843884 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=h1) Report > Merging [#488](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/c5f3d9f7ac1181372852f20c406bc217d6dc8f28?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `90.47%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #488 +/- ## == + Coverage87.1% 87.13% +0.03% == Files 85 86 +1 Lines 1923219223 -9 == - Hits1675216750 -2 + Misses 2480 2473 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.5% <ø> (ø)` | :arrow_up: | | [src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j) | `97% <ø> (ø)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.24% <ø> (ø)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `95.13% <ø> (+3.72%)` | :arrow_up: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `91.94% <ø> (ø)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.85% <ø> (-0.25%)` | :arrow_down: | | [src/router\_core/exchange\_bindings.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2V4Y2hhbmdlX2JpbmRpbmdzLmM=) | `91.51% <ø> (ø)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.76% <100%> (-0.12%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `90.37% <90.37%> (ø)` | | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.01% <0%> (-0.52%)` | :arrow_down: | | ... and [4 more](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=footer). Last update [c5f3d9f...d51e41f](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move delivery settlement and disposition propagation out of the core thread > --- > > Key: DISPATCH-1310 > URL: https://issues.apache.org/jira/browse/DISPATCH-1310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >
[GitHub] [qpid-dispatch] codecov-io commented on issue #488: DISPATCH-1310: move qdr_delivery_t API to its own source files
codecov-io commented on issue #488: DISPATCH-1310: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/488#issuecomment-481843884 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=h1) Report > Merging [#488](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/c5f3d9f7ac1181372852f20c406bc217d6dc8f28?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `90.47%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #488 +/- ## == + Coverage87.1% 87.13% +0.03% == Files 85 86 +1 Lines 1923219223 -9 == - Hits1675216750 -2 + Misses 2480 2473 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.5% <ø> (ø)` | :arrow_up: | | [src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j) | `97% <ø> (ø)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.24% <ø> (ø)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `95.13% <ø> (+3.72%)` | :arrow_up: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `91.94% <ø> (ø)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.85% <ø> (-0.25%)` | :arrow_down: | | [src/router\_core/exchange\_bindings.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2V4Y2hhbmdlX2JpbmRpbmdzLmM=) | `91.51% <ø> (ø)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.76% <100%> (-0.12%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `90.37% <90.37%> (ø)` | | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.01% <0%> (-0.52%)` | :arrow_down: | | ... and [4 more](https://codecov.io/gh/apache/qpid-dispatch/pull/488/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=footer). Last update [c5f3d9f...d51e41f](https://codecov.io/gh/apache/qpid-dispatch/pull/488?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1311) Move the qdr_delivery_t code to a dedicated file (reorganization)
[ https://issues.apache.org/jira/browse/DISPATCH-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814836#comment-16814836 ] ASF GitHub Bot commented on DISPATCH-1311: -- kgiusti commented on pull request #489: DISPATCH-1311: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/489 This patch merely moves code and does some renaming of functions. No changes to actual functionality have occurred - it is simply a reorganization of code layout. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the qdr_delivery_t code to a dedicated file (reorganization) > - > > Key: DISPATCH-1311 > URL: https://issues.apache.org/jira/browse/DISPATCH-1311 > Project: Qpid Dispatch > Issue Type: Sub-task > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: delivery-refactor > > Let's start the process of moving delivery settlement and disposition > handling out of the core thread by isolating the qdr_delivery_t handling > code. This code is currently residing in the transfer.c source file which > also contains various link and connection state handling. The qdr_delivery_t > structure definition should also be moved out of the common router core > private header file. > This change will simply move delivery code to its own delivery.c and > delivery.h in the router_core directory (for now). No functional changes > will be made, though some method names may be changed for consistency. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #489: DISPATCH-1311: move qdr_delivery_t API to its own source files
kgiusti opened a new pull request #489: DISPATCH-1311: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/489 This patch merely moves code and does some renaming of functions. No changes to actual functionality have occurred - it is simply a reorganization of code layout. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1310) Move delivery settlement and disposition propagation out of the core thread
[ https://issues.apache.org/jira/browse/DISPATCH-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814830#comment-16814830 ] ASF GitHub Bot commented on DISPATCH-1310: -- kgiusti commented on pull request #488: DISPATCH-1310: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/488 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move delivery settlement and disposition propagation out of the core thread > --- > > Key: DISPATCH-1310 > URL: https://issues.apache.org/jira/browse/DISPATCH-1310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: delivery-refactor > > In the current design all changes to a delivery's disposition and settlement > state has to move through the core thread. > Contrast this with the data associated with a delivery (held in the message > content object) - data is moved between I/O threads without passing through > the core thread. > Moving the disposition and settlement state propagation to the I/O threads > (like delivery data) will simplify its synchronization (2 thread rather than > 3) and will (likely) improve performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1310) Move delivery settlement and disposition propagation out of the core thread
[ https://issues.apache.org/jira/browse/DISPATCH-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814829#comment-16814829 ] ASF GitHub Bot commented on DISPATCH-1310: -- kgiusti commented on issue #488: DISPATCH-1310: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/488#issuecomment-481839483 Ooops wrong branch! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move delivery settlement and disposition propagation out of the core thread > --- > > Key: DISPATCH-1310 > URL: https://issues.apache.org/jira/browse/DISPATCH-1310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: delivery-refactor > > In the current design all changes to a delivery's disposition and settlement > state has to move through the core thread. > Contrast this with the data associated with a delivery (held in the message > content object) - data is moved between I/O threads without passing through > the core thread. > Moving the disposition and settlement state propagation to the I/O threads > (like delivery data) will simplify its synchronization (2 thread rather than > 3) and will (likely) improve performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #488: DISPATCH-1310: move qdr_delivery_t API to its own source files
kgiusti closed pull request #488: DISPATCH-1310: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/488 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on issue #488: DISPATCH-1310: move qdr_delivery_t API to its own source files
kgiusti commented on issue #488: DISPATCH-1310: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/488#issuecomment-481839483 Ooops wrong branch! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1310) Move delivery settlement and disposition propagation out of the core thread
[ https://issues.apache.org/jira/browse/DISPATCH-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814828#comment-16814828 ] ASF GitHub Bot commented on DISPATCH-1310: -- kgiusti commented on pull request #488: DISPATCH-1310: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/488 This patch merely moves delivery-related code and does some renaming of functions to adhere to the "qdr_delivery_*" naming convention. No changes to actual functionality have occurred - it is simply a reorganization of code layout. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move delivery settlement and disposition propagation out of the core thread > --- > > Key: DISPATCH-1310 > URL: https://issues.apache.org/jira/browse/DISPATCH-1310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: delivery-refactor > > In the current design all changes to a delivery's disposition and settlement > state has to move through the core thread. > Contrast this with the data associated with a delivery (held in the message > content object) - data is moved between I/O threads without passing through > the core thread. > Moving the disposition and settlement state propagation to the I/O threads > (like delivery data) will simplify its synchronization (2 thread rather than > 3) and will (likely) improve performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #488: DISPATCH-1310: move qdr_delivery_t API to its own source files
kgiusti opened a new pull request #488: DISPATCH-1310: move qdr_delivery_t API to its own source files URL: https://github.com/apache/qpid-dispatch/pull/488 This patch merely moves delivery-related code and does some renaming of functions to adhere to the "qdr_delivery_*" naming convention. No changes to actual functionality have occurred - it is simply a reorganization of code layout. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8297) [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing until it reaches the limit and crashes
[ https://issues.apache.org/jira/browse/QPID-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8297: - Status: Reviewable (was: In Progress) > [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps > growing until it reaches the limit and crashes > - > > Key: QPID-8297 > URL: https://issues.apache.org/jira/browse/QPID-8297 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Critical > Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.1.3 > > > Under a continuous high load, the Oracle message store crashes because the > reserved space for the table QPID_MESSAGE_CONTENT keeps on growing (even if > the table itself is empty since we consume as fast as we produce). > This only happens for "big" messages (over 4KB) and comes from the way Oracle > handles the LOB types (content column is declared as a BLOB). For LOB values > over 4KB Oracle reserves some space in the table to handle the value but, by > default, it won't actually release it (even if the value is removed) before a > few hours. > So when we have a high load of big messages that lasts a few hours we end up > reaching the max size of the tablespace and the database crashes... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8297) [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing until it reaches the limit and crashes
[ https://issues.apache.org/jira/browse/QPID-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-8297. -- Resolution: Fixed > [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps > growing until it reaches the limit and crashes > - > > Key: QPID-8297 > URL: https://issues.apache.org/jira/browse/QPID-8297 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Critical > Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.1.3 > > > Under a continuous high load, the Oracle message store crashes because the > reserved space for the table QPID_MESSAGE_CONTENT keeps on growing (even if > the table itself is empty since we consume as fast as we produce). > This only happens for "big" messages (over 4KB) and comes from the way Oracle > handles the LOB types (content column is declared as a BLOB). For LOB values > over 4KB Oracle reserves some space in the table to handle the value but, by > default, it won't actually release it (even if the value is removed) before a > few hours. > So when we have a high load of big messages that lasts a few hours we end up > reaching the max size of the tablespace and the database crashes... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8297) [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing until it reaches the limit and crashes
[ https://issues.apache.org/jira/browse/QPID-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814402#comment-16814402 ] ASF subversion and git services commented on QPID-8297: --- Commit 3df0648436ec30e53444c08368828acd2da5b0df in qpid-broker-j's branch refs/heads/7.1.x from overmeulen [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=3df0648 ] QPID-8297: [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing This closes #24 (cherry picked from commit 9eb98551eb923430405e409b239cc52563b32f99) > [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps > growing until it reaches the limit and crashes > - > > Key: QPID-8297 > URL: https://issues.apache.org/jira/browse/QPID-8297 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Critical > Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.1.3 > > > Under a continuous high load, the Oracle message store crashes because the > reserved space for the table QPID_MESSAGE_CONTENT keeps on growing (even if > the table itself is empty since we consume as fast as we produce). > This only happens for "big" messages (over 4KB) and comes from the way Oracle > handles the LOB types (content column is declared as a BLOB). For LOB values > over 4KB Oracle reserves some space in the table to handle the value but, by > default, it won't actually release it (even if the value is removed) before a > few hours. > So when we have a high load of big messages that lasts a few hours we end up > reaching the max size of the tablespace and the database crashes... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8297) [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing until it reaches the limit and crashes
[ https://issues.apache.org/jira/browse/QPID-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8297: - Fix Version/s: qpid-java-broker-7.1.3 qpid-java-broker-8.0.0 > [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps > growing until it reaches the limit and crashes > - > > Key: QPID-8297 > URL: https://issues.apache.org/jira/browse/QPID-8297 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Critical > Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.1.3 > > > Under a continuous high load, the Oracle message store crashes because the > reserved space for the table QPID_MESSAGE_CONTENT keeps on growing (even if > the table itself is empty since we consume as fast as we produce). > This only happens for "big" messages (over 4KB) and comes from the way Oracle > handles the LOB types (content column is declared as a BLOB). For LOB values > over 4KB Oracle reserves some space in the table to handle the value but, by > default, it won't actually release it (even if the value is removed) before a > few hours. > So when we have a high load of big messages that lasts a few hours we end up > reaching the max size of the tablespace and the database crashes... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8297) [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing until it reaches the limit and crashes
[ https://issues.apache.org/jira/browse/QPID-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-8297: Assignee: Alex Rudyy > [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps > growing until it reaches the limit and crashes > - > > Key: QPID-8297 > URL: https://issues.apache.org/jira/browse/QPID-8297 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Critical > > Under a continuous high load, the Oracle message store crashes because the > reserved space for the table QPID_MESSAGE_CONTENT keeps on growing (even if > the table itself is empty since we consume as fast as we produce). > This only happens for "big" messages (over 4KB) and comes from the way Oracle > handles the LOB types (content column is declared as a BLOB). For LOB values > over 4KB Oracle reserves some space in the table to handle the value but, by > default, it won't actually release it (even if the value is removed) before a > few hours. > So when we have a high load of big messages that lasts a few hours we end up > reaching the max size of the tablespace and the database crashes... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8297) [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing until it reaches the limit and crashes
[ https://issues.apache.org/jira/browse/QPID-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814391#comment-16814391 ] ASF subversion and git services commented on QPID-8297: --- Commit 9eb98551eb923430405e409b239cc52563b32f99 in qpid-broker-j's branch refs/heads/master from overmeulen [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=9eb9855 ] QPID-8297: [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing This closes #24 > [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps > growing until it reaches the limit and crashes > - > > Key: QPID-8297 > URL: https://issues.apache.org/jira/browse/QPID-8297 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Olivier VERMEULEN >Priority: Critical > > Under a continuous high load, the Oracle message store crashes because the > reserved space for the table QPID_MESSAGE_CONTENT keeps on growing (even if > the table itself is empty since we consume as fast as we produce). > This only happens for "big" messages (over 4KB) and comes from the way Oracle > handles the LOB types (content column is declared as a BLOB). For LOB values > over 4KB Oracle reserves some space in the table to handle the value but, by > default, it won't actually release it (even if the value is removed) before a > few hours. > So when we have a high load of big messages that lasts a few hours we end up > reaching the max size of the tablespace and the database crashes... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8297) [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing until it reaches the limit and crashes
[ https://issues.apache.org/jira/browse/QPID-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814390#comment-16814390 ] ASF GitHub Bot commented on QPID-8297: -- asfgit commented on pull request #24: QPID-8297: [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing URL: https://github.com/apache/qpid-broker-j/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps > growing until it reaches the limit and crashes > - > > Key: QPID-8297 > URL: https://issues.apache.org/jira/browse/QPID-8297 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Olivier VERMEULEN >Priority: Critical > > Under a continuous high load, the Oracle message store crashes because the > reserved space for the table QPID_MESSAGE_CONTENT keeps on growing (even if > the table itself is empty since we consume as fast as we produce). > This only happens for "big" messages (over 4KB) and comes from the way Oracle > handles the LOB types (content column is declared as a BLOB). For LOB values > over 4KB Oracle reserves some space in the table to handle the value but, by > default, it won't actually release it (even if the value is removed) before a > few hours. > So when we have a high load of big messages that lasts a few hours we end up > reaching the max size of the tablespace and the database crashes... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] asfgit closed pull request #24: QPID-8297: [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing
asfgit closed pull request #24: QPID-8297: [Broker-J][Oracle Message Store] QPID_MESSAGE_CONTENT reserved space keeps growing URL: https://github.com/apache/qpid-broker-j/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[ https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814211#comment-16814211 ] Jiri Daněk commented on PROTON-2030: I've tried to fix this (I have patch currently in progress) and I've sent e-mail to the mailing list about this. https://www.mail-archive.com/dev@qpid.apache.org/msg79203.html > Use CLOCK_MONOTONIC in proactors for pn_transport_tick > -- > > Key: PROTON-2030 > URL: https://issues.apache.org/jira/browse/PROTON-2030 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.27.0 >Reporter: Jiri Daněk >Priority: Major > > IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I > tested (with epoll) that changing system clock breaks heartbeating. > The libuv proactor does use monotonic already. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
Jiri Daněk created PROTON-2030: -- Summary: Use CLOCK_MONOTONIC in proactors for pn_transport_tick Key: PROTON-2030 URL: https://issues.apache.org/jira/browse/PROTON-2030 Project: Qpid Proton Issue Type: Improvement Components: proton-c Affects Versions: proton-c-0.27.0 Reporter: Jiri Daněk IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I tested (with epoll) that changing system clock breaks heartbeating. The libuv proactor does use monotonic already. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
