[jira] [Commented] (QPID-8301) [Broker-J] Expose information about keystore certificate details

2019-04-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827356#comment-16827356
 ] 

ASF GitHub Bot commented on QPID-8301:
--

alex-rufous commented on pull request #26: QPID-8301: [Broker-J] Expose 
information about keystore certificates
URL: https://github.com/apache/qpid-broker-j/pull/26
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Broker-J] Expose information about keystore certificate details
> 
>
> Key: QPID-8301
> URL: https://issues.apache.org/jira/browse/QPID-8301
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.1.3
>
>
> Keystore certificate details like issue, serial number and validity period 
> need to be exposed via management API and UI (similar the certificate details 
> available for trust stores). This should help to get the information about 
> intermediate certificates without the need to access broker configuration. It 
> could useful, when broker configuration is not accessible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-broker-j] alex-rufous opened a new pull request #26: QPID-8301: [Broker-J] Expose information about keystore certificates

2019-04-26 Thread GitBox
alex-rufous opened a new pull request #26: QPID-8301: [Broker-J] Expose 
information about keystore certificates
URL: https://github.com/apache/qpid-broker-j/pull/26
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-8301) [Broker-J] Expose information about keystore certificate details

2019-04-26 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-8301:


Assignee: Alex Rudyy

> [Broker-J] Expose information about keystore certificate details
> 
>
> Key: QPID-8301
> URL: https://issues.apache.org/jira/browse/QPID-8301
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.1.3
>
>
> Keystore certificate details like issue, serial number and validity period 
> need to be exposed via management API and UI (similar the certificate details 
> available for trust stores). This should help to get the information about 
> intermediate certificates without the need to access broker configuration. It 
> could useful, when broker configuration is not accessible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-8301) [Broker-J] Expose information about keystore certificate details

2019-04-26 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-8301:


 Summary: [Broker-J] Expose information about keystore certificate 
details
 Key: QPID-8301
 URL: https://issues.apache.org/jira/browse/QPID-8301
 Project: Qpid
  Issue Type: Improvement
  Components: Broker-J
Reporter: Alex Rudyy
 Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.1.3


Keystore certificate details like issue, serial number and validity period need 
to be exposed via management API and UI (similar the certificate details 
available for trust stores). This should help to get the information about 
intermediate certificates without the need to access broker configuration. It 
could useful, when broker configuration is not accessible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1327) Router stops forwarding multicast deliveries (large messages) to connected receivers after a receiver closes its connection

2019-04-26 Thread Chuck Rolke (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827310#comment-16827310
 ] 

Chuck Rolke commented on DISPATCH-1327:
---

Test this again after master commit 39309ea3 which fixed a similar issue in 
DISPATCH-1322

 

> Router stops forwarding multicast deliveries (large messages) to connected 
> receivers after a receiver closes its connection
> ---
>
> Key: DISPATCH-1327
> URL: https://issues.apache.org/jira/browse/DISPATCH-1327
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.7.0
>Reporter: Fernando Giorgetti
>Priority: Major
>
> The problem can be observed running 
> *test_40_drop_rx_client_multicast_large_message*** from 
> *system_tests_edge_router*.
> It does not happen all the time, but after some attempts it will fail and we 
> can observe receivers won't get all sent messages and then test times out.
> Further info to be attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2033) qpid-proton changes 0.27.x to master(9ff0a) break qpid-dispatch self test

2019-04-26 Thread Chuck Rolke (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827294#comment-16827294
 ] 

Chuck Rolke commented on PROTON-2033:
-

Working out the analysis proves that post-0.27 proton did not 'break dispatch 
self tests'.
 * Dispatch had a latent bug and some (presumably) proton timing changes 
exposed that bug.
 * Dispatch self tests were unprepared for the python receiver to get 
on_settled callbacks.

That said, before dismissing this issue a discussion of the timing change and 
the on_settled callbacks is in order.
h3. Test Overview

 For review, how did the test work?
{code:java}
     +-+  ++
     |   INT.A    |  | EA1 |
  +---+   +---+   +---+  edge |   +---+   +---+
  | receiver |<--+ 21001 |   | 21000 |<* | 21002 |<--+ sender |
  +---+   +---+   +---+   |   +---+   +---+
     |  interior  |  |    edge |
     +-+  ++
   ^  ^ ^
    CONN1  CONN2 CONN3
{code}
 
  
 From a single reactor container a proton python sender and receiver connect to 
two routers respectively.
 * The test injects some number of messages at the sender and verifies that 
they are all accepted.
 * Then the receiver is closed (connection stays open) and 50 messages are 
injected by the sender.
 * The expectation is that all the 50 messages are released.

h3. Timing Change

A significant change was measured between when the receiver client called 
receiver.close() and when the corresponding detach was received by INT.A port 
21001.
||Time mS||0.27.x||master||
|run 1|3.2|14.5|
|run 2|3.3|17.3|

These timings are reflected in the self test behavior:
 * The 0.27.x code is "so fast" that it detaches the receiver before any of the 
messages in the 50-message storm get through INT.A. All of the messages are 
released by the router network. No messages were released or modified by the 
receiver.
 * The master branch is "so slow" that one or possibly up to a dozen messages 
are sent to the receiver by INT.A. Now the receiver is dealing with a receiver 
close in the face of incoming messages. Now some messages are seen as 
'modified' by the sender and not just released.

Is there an explanation for why the client response to the receiver.close() is 
so slow compared to 0.27.x?
h3. Receiver on_settled callbacks

These appear when the receiver is closing in the face of incoming messages. 
This may not be a new issue as dispatch self tests never had to deal with them 
before. If it *is* an new issue some consideration must be given for how 
existing clients (like dispatch self tests) must be modified to deal with them.

 

> qpid-proton changes 0.27.x to master(9ff0a) break qpid-dispatch self test
> -
>
> Key: PROTON-2033
> URL: https://issues.apache.org/jira/browse/PROTON-2033
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c, python-binding
>Affects Versions: proton-c-0.28.0
> Environment: Fedora 29, python 3.7, proton and dispatch debug builds
>Reporter: Chuck Rolke
>Priority: Major
>
> While cleaning up qpid-dispatch for a 1.6 follow-on release an intermittent 
> failure in one of the tests was exposed. Analysis of the failure is in 
> https://issues.apache.org/jira/browse/DISPATCH-1322 in an attached text 
> document 
> https://issues.apache.org/jira/secure/attachment/12965891/DISPATCH-1322-analysis.txt
> Another part of the cleanup was fixing the failing test to better report what 
> went wrong. See https://issues.apache.org/jira/browse/DISPATCH-1318
> These issues happened using qpid-proton master @9ff0a. Temporarily the 
> qpid-proton version was reverted to branch 0.27.x @560ba. Using proton 0.27.x 
> branch the qpid-dispatch self test does not fail. It passed several thousand 
> times in a loop. Moving proton back to the master branch brought the dispatch 
> failures back.
> From the qpid-dispatch perspective this issue is serious. If a receiver 
> detaches a link while a sender is sending to it then the sender may lose a 
> disposition.
> No attempt yet has been made to bisect proton to see where the different 
> behavior starts showing up. That may be the next best avenue of research.
> Another theory for the error is that qpid-dispatch has been mishandling links 
> all along.
> To help expose the problem one may clone 
> [https://github.com/ChugR/qpid-dispatch] , or add it as a remote, and then 
> check out branch DISPATCH-1318-cwip. Test system_tests_edge_router has been 
> gutted to run only test_12 in a loop and to 

[jira] [Created] (DISPATCH-1327) Router stops forwarding multicast deliveries (large messages) to connected receivers after a receiver closes its connection

2019-04-26 Thread Fernando Giorgetti (JIRA)
Fernando Giorgetti created DISPATCH-1327:


 Summary: Router stops forwarding multicast deliveries (large 
messages) to connected receivers after a receiver closes its connection
 Key: DISPATCH-1327
 URL: https://issues.apache.org/jira/browse/DISPATCH-1327
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Routing Engine
Affects Versions: 1.7.0
Reporter: Fernando Giorgetti


The problem can be observed running 
*test_40_drop_rx_client_multicast_large_message*** from 
*system_tests_edge_router*.

It does not happen all the time, but after some attempts it will fail and we 
can observe receivers won't get all sent messages and then test times out.

Further info to be attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1322) Edge router drops disposition when remote receiver closes

2019-04-26 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-1322.

Resolution: Fixed

> Edge router drops disposition when remote receiver closes
> -
>
> Key: DISPATCH-1322
> URL: https://issues.apache.org/jira/browse/DISPATCH-1322
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.6.0
>Reporter: Chuck Rolke
>Assignee: Ted Ross
>Priority: Major
> Attachments: DISPATCH-1322-analysis.txt
>
>
> The test is available in system_tests_edge_router.
> The analysis is attached as a file.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1322) Edge router drops disposition when remote receiver closes

2019-04-26 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross updated DISPATCH-1322:
---
Fix Version/s: 1.8.0

> Edge router drops disposition when remote receiver closes
> -
>
> Key: DISPATCH-1322
> URL: https://issues.apache.org/jira/browse/DISPATCH-1322
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.6.0
>Reporter: Chuck Rolke
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.8.0
>
> Attachments: DISPATCH-1322-analysis.txt
>
>
> The test is available in system_tests_edge_router.
> The analysis is attached as a file.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1322) Edge router drops disposition when remote receiver closes

2019-04-26 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross updated DISPATCH-1322:
---
Affects Version/s: (was: 1.6.0)
   1.7.0

> Edge router drops disposition when remote receiver closes
> -
>
> Key: DISPATCH-1322
> URL: https://issues.apache.org/jira/browse/DISPATCH-1322
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.7.0
>Reporter: Chuck Rolke
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.8.0
>
> Attachments: DISPATCH-1322-analysis.txt
>
>
> The test is available in system_tests_edge_router.
> The analysis is attached as a file.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (DISPATCH-1322) Edge router drops disposition when remote receiver closes

2019-04-26 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross reassigned DISPATCH-1322:
--

Assignee: Ted Ross

> Edge router drops disposition when remote receiver closes
> -
>
> Key: DISPATCH-1322
> URL: https://issues.apache.org/jira/browse/DISPATCH-1322
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.6.0
>Reporter: Chuck Rolke
>Assignee: Ted Ross
>Priority: Major
> Attachments: DISPATCH-1322-analysis.txt
>
>
> The test is available in system_tests_edge_router.
> The analysis is attached as a file.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1322) Edge router drops disposition when remote receiver closes

2019-04-26 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827245#comment-16827245
 ] 

ASF subversion and git services commented on DISPATCH-1322:
---

Commit 39309ea3b1606e1a0382ee4177b5df984eea536a in qpid-dispatch's branch 
refs/heads/master from Ted Ross
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=39309ea ]

DISPATCH-1322 - Prevent credit starvation in router-to-router links.
Added protection for deliveries held in link processing outside the lock.
This closes #493


> Edge router drops disposition when remote receiver closes
> -
>
> Key: DISPATCH-1322
> URL: https://issues.apache.org/jira/browse/DISPATCH-1322
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.6.0
>Reporter: Chuck Rolke
>Priority: Major
> Attachments: DISPATCH-1322-analysis.txt
>
>
> The test is available in system_tests_edge_router.
> The analysis is attached as a file.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1322) Edge router drops disposition when remote receiver closes

2019-04-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827246#comment-16827246
 ] 

ASF GitHub Bot commented on DISPATCH-1322:
--

asfgit commented on pull request #493: DISPATCH-1322 - Prevent credit 
starvation in router-to-router links.
URL: https://github.com/apache/qpid-dispatch/pull/493
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Edge router drops disposition when remote receiver closes
> -
>
> Key: DISPATCH-1322
> URL: https://issues.apache.org/jira/browse/DISPATCH-1322
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.6.0
>Reporter: Chuck Rolke
>Priority: Major
> Attachments: DISPATCH-1322-analysis.txt
>
>
> The test is available in system_tests_edge_router.
> The analysis is attached as a file.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] asfgit closed pull request #493: DISPATCH-1322 - Prevent credit starvation in router-to-router links.

2019-04-26 Thread GitBox
asfgit closed pull request #493: DISPATCH-1322 - Prevent credit starvation in 
router-to-router links.
URL: https://github.com/apache/qpid-dispatch/pull/493
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1326) Anonymous messages are released by edge router even if there is a receiver for the messages

2019-04-26 Thread Ganesh Murthy (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1326:

Attachment: E1.conf
I1.conf

> Anonymous messages are released by edge router even if there is a receiver 
> for the messages
> ---
>
> Key: DISPATCH-1326
> URL: https://issues.apache.org/jira/browse/DISPATCH-1326
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: E1.conf, I1.conf, simple_send_anon.py
>
>
> Steps to reproduce
>  # Start one interior router and one edge router using the attached config 
> files
>  # Start a receiver using simple_recv.py and connect it to the interior router
>  ## 
> {noformat}
> python simple_recv.py -m1 --address 0.0.0.0:8/examples{noformat}
>  # Use the attached sender to send an anonymous message to the edge router
>  ## 
> {noformat}
> python simple_send_anon.py --address 0.0.0.0:5672 -m1{noformat}
>  # The message must travel from the edge router to the interior router which 
> in turn must forward it to the receiver. Instead the message is released as 
> seen in the below frame trace.
>  
> {noformat}
> [0x5603df87eb20]:  -> SASL
> [0x5603df87eb20]:  <- SASL
> [0x5603df87eb20]:0 <- @sasl-mechanisms(64) 
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> [0x5603df87eb20]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, 
> initial-response=b"anonymous@localhost.localdomain"]
> [0x5603df87eb20]:0 <- @sasl-outcome(68) [code=0]
> [0x5603df87eb20]:  -> AMQP
> [0x5603df87eb20]:0 -> @open(16) 
> [container-id="c99c4867-447c-424a-8b4f-e8a406c71a57", hostname="0.0.0.0", 
> channel-max=32767]
> [0x5603df87eb20]:0 -> @begin(17) [next-outgoing-id=0, 
> incoming-window=2147483647, outgoing-window=2147483647]
> [0x5603df87eb20]:0 -> @attach(18) 
> [name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
>  handle=0, role=false, snd-settle-mode=2, rcv-settle-mode=0, 
> source=@source(40) [durable=0, timeout=0, dynamic=false], target=@target(41) 
> [durable=0, timeout=0, dynamic=false], initial-delivery-count=0, 
> max-message-size=0]
> [0x5603df87eb20]:  <- AMQP
> [0x5603df87eb20]:0 <- @open(16) [container-id="Edge_66t2+y4DnWql1Vx", 
> max-frame-size=16384, channel-max=32767, idle-time-out=8000, 
> offered-capabilities=:"ANONYMOUS-RELAY", 
> properties={:product="qpid-dispatch-router", :version="1.8.0-SNAPSHOT", 
> :"qd.conn-id"=7}]
> [0x5603df87eb20]:0 <- @begin(17) [remote-channel=0, next-outgoing-id=0, 
> incoming-window=2147483647, outgoing-window=2147483647]
> [0x5603df87eb20]:0 <- @attach(18) 
> [name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
>  handle=0, role=true, snd-settle-mode=2, rcv-settle-mode=0, 
> source=@source(40) [durable=0, expiry-policy=:"session-end", timeout=0, 
> dynamic=false], target=@target(41) [durable=0, expiry-policy=:"session-end", 
> timeout=0, dynamic=false], initial-delivery-count=0, max-message-size=0]
> [0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=0, 
> incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647, 
> handle=0, delivery-count=0, link-credit=250, drain=false]
> [0x5603df87eb20]:0 -> @transfer(20) [handle=0, delivery-id=0, 
> delivery-tag=b"1", message-format=0] (53) 
> "\x00SpE\x00Ss\xd0\x00\x00\x00\x11\x00\x00\x00\x03S\x01@\xa1\x08examples\x00Sw\xd1\x00\x00\x00\x10\x00\x00\x00\x02\xa1\x08sequenceT\x01"
> [0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=1, 
> incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647, 
> handle=0, delivery-count=1, link-credit=250, drain=false]
> [0x5603df87eb20]:0 <- @disposition(21) [role=true, first=0, settled=true, 
> state=@released(38) []]
> [0x5603df87eb20]:0 -> (EMPTY FRAME)
> [0x5603df87eb20]:0 -> (EMPTY FRAME)
> ^C[gmurthy@localhost examples]$
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1326) Anonymous messages are released by edge router even if there is a receiver for the messages

2019-04-26 Thread Ganesh Murthy (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1326:

Summary: Anonymous messages are released by edge router even if there is a 
receiver for the messages  (was: Anonymous messages are released even if there 
is a receiver for the messages)

> Anonymous messages are released by edge router even if there is a receiver 
> for the messages
> ---
>
> Key: DISPATCH-1326
> URL: https://issues.apache.org/jira/browse/DISPATCH-1326
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: simple_send_anon.py
>
>
> Steps to reproduce
>  # Start one interior router and one edge router using the attached config 
> files
>  # Start a receiver using simple_recv.py and connect it to the interior router
>  ## 
> {noformat}
> python simple_recv.py -m1 --address 0.0.0.0:8/examples{noformat}
>  # Use the attached sender to send an anonymous message to the edge router
>  ## 
> {noformat}
> python simple_send_anon.py --address 0.0.0.0:5672 -m1{noformat}
>  # The message must travel from the edge router to the interior router which 
> in turn must forward it to the receiver. Instead the message is released as 
> seen in the below frame trace.
>  
> {noformat}
> [0x5603df87eb20]:  -> SASL
> [0x5603df87eb20]:  <- SASL
> [0x5603df87eb20]:0 <- @sasl-mechanisms(64) 
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> [0x5603df87eb20]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, 
> initial-response=b"anonymous@localhost.localdomain"]
> [0x5603df87eb20]:0 <- @sasl-outcome(68) [code=0]
> [0x5603df87eb20]:  -> AMQP
> [0x5603df87eb20]:0 -> @open(16) 
> [container-id="c99c4867-447c-424a-8b4f-e8a406c71a57", hostname="0.0.0.0", 
> channel-max=32767]
> [0x5603df87eb20]:0 -> @begin(17) [next-outgoing-id=0, 
> incoming-window=2147483647, outgoing-window=2147483647]
> [0x5603df87eb20]:0 -> @attach(18) 
> [name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
>  handle=0, role=false, snd-settle-mode=2, rcv-settle-mode=0, 
> source=@source(40) [durable=0, timeout=0, dynamic=false], target=@target(41) 
> [durable=0, timeout=0, dynamic=false], initial-delivery-count=0, 
> max-message-size=0]
> [0x5603df87eb20]:  <- AMQP
> [0x5603df87eb20]:0 <- @open(16) [container-id="Edge_66t2+y4DnWql1Vx", 
> max-frame-size=16384, channel-max=32767, idle-time-out=8000, 
> offered-capabilities=:"ANONYMOUS-RELAY", 
> properties={:product="qpid-dispatch-router", :version="1.8.0-SNAPSHOT", 
> :"qd.conn-id"=7}]
> [0x5603df87eb20]:0 <- @begin(17) [remote-channel=0, next-outgoing-id=0, 
> incoming-window=2147483647, outgoing-window=2147483647]
> [0x5603df87eb20]:0 <- @attach(18) 
> [name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
>  handle=0, role=true, snd-settle-mode=2, rcv-settle-mode=0, 
> source=@source(40) [durable=0, expiry-policy=:"session-end", timeout=0, 
> dynamic=false], target=@target(41) [durable=0, expiry-policy=:"session-end", 
> timeout=0, dynamic=false], initial-delivery-count=0, max-message-size=0]
> [0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=0, 
> incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647, 
> handle=0, delivery-count=0, link-credit=250, drain=false]
> [0x5603df87eb20]:0 -> @transfer(20) [handle=0, delivery-id=0, 
> delivery-tag=b"1", message-format=0] (53) 
> "\x00SpE\x00Ss\xd0\x00\x00\x00\x11\x00\x00\x00\x03S\x01@\xa1\x08examples\x00Sw\xd1\x00\x00\x00\x10\x00\x00\x00\x02\xa1\x08sequenceT\x01"
> [0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=1, 
> incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647, 
> handle=0, delivery-count=1, link-credit=250, drain=false]
> [0x5603df87eb20]:0 <- @disposition(21) [role=true, first=0, settled=true, 
> state=@released(38) []]
> [0x5603df87eb20]:0 -> (EMPTY FRAME)
> [0x5603df87eb20]:0 -> (EMPTY FRAME)
> ^C[gmurthy@localhost examples]$
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1326) Anonymous messages are released even if there is a receiver for the messages

2019-04-26 Thread Ganesh Murthy (JIRA)
Ganesh Murthy created DISPATCH-1326:
---

 Summary: Anonymous messages are released even if there is a 
receiver for the messages
 Key: DISPATCH-1326
 URL: https://issues.apache.org/jira/browse/DISPATCH-1326
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Container
Affects Versions: 1.5.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
 Attachments: simple_send_anon.py

Steps to reproduce
 # Start one interior router and one edge router using the attached config files
 # Start a receiver using simple_recv.py and connect it to the interior router
 ## 
{noformat}
python simple_recv.py -m1 --address 0.0.0.0:8/examples{noformat}

 # Use the attached sender to send an anonymous message to the edge router
 ## 
{noformat}
python simple_send_anon.py --address 0.0.0.0:5672 -m1{noformat}

 # The message must travel from the edge router to the interior router which in 
turn must forward it to the receiver. Instead the message is released as seen 
in the below frame trace.

 
{noformat}
[0x5603df87eb20]:  -> SASL
[0x5603df87eb20]:  <- SASL
[0x5603df87eb20]:0 <- @sasl-mechanisms(64) 
[sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
[0x5603df87eb20]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, 
initial-response=b"anonymous@localhost.localdomain"]
[0x5603df87eb20]:0 <- @sasl-outcome(68) [code=0]
[0x5603df87eb20]:  -> AMQP
[0x5603df87eb20]:0 -> @open(16) 
[container-id="c99c4867-447c-424a-8b4f-e8a406c71a57", hostname="0.0.0.0", 
channel-max=32767]
[0x5603df87eb20]:0 -> @begin(17) [next-outgoing-id=0, 
incoming-window=2147483647, outgoing-window=2147483647]
[0x5603df87eb20]:0 -> @attach(18) 
[name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
 handle=0, role=false, snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) 
[durable=0, timeout=0, dynamic=false], target=@target(41) [durable=0, 
timeout=0, dynamic=false], initial-delivery-count=0, max-message-size=0]
[0x5603df87eb20]:  <- AMQP
[0x5603df87eb20]:0 <- @open(16) [container-id="Edge_66t2+y4DnWql1Vx", 
max-frame-size=16384, channel-max=32767, idle-time-out=8000, 
offered-capabilities=:"ANONYMOUS-RELAY", 
properties={:product="qpid-dispatch-router", :version="1.8.0-SNAPSHOT", 
:"qd.conn-id"=7}]
[0x5603df87eb20]:0 <- @begin(17) [remote-channel=0, next-outgoing-id=0, 
incoming-window=2147483647, outgoing-window=2147483647]
[0x5603df87eb20]:0 <- @attach(18) 
[name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
 handle=0, role=true, snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) 
[durable=0, expiry-policy=:"session-end", timeout=0, dynamic=false], 
target=@target(41) [durable=0, expiry-policy=:"session-end", timeout=0, 
dynamic=false], initial-delivery-count=0, max-message-size=0]
[0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=0, 
incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647, 
handle=0, delivery-count=0, link-credit=250, drain=false]
[0x5603df87eb20]:0 -> @transfer(20) [handle=0, delivery-id=0, 
delivery-tag=b"1", message-format=0] (53) 
"\x00SpE\x00Ss\xd0\x00\x00\x00\x11\x00\x00\x00\x03S\x01@\xa1\x08examples\x00Sw\xd1\x00\x00\x00\x10\x00\x00\x00\x02\xa1\x08sequenceT\x01"
[0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=1, 
incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647, 
handle=0, delivery-count=1, link-credit=250, drain=false]
[0x5603df87eb20]:0 <- @disposition(21) [role=true, first=0, settled=true, 
state=@released(38) []]
[0x5603df87eb20]:0 -> (EMPTY FRAME)
[0x5603df87eb20]:0 -> (EMPTY FRAME)
^C[gmurthy@localhost examples]$
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1326) Anonymous messages are released by edge router even if there is a receiver for the messages

2019-04-26 Thread Ganesh Murthy (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1326:

Attachment: simple_send_anon.py

> Anonymous messages are released by edge router even if there is a receiver 
> for the messages
> ---
>
> Key: DISPATCH-1326
> URL: https://issues.apache.org/jira/browse/DISPATCH-1326
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: simple_send_anon.py
>
>
> Steps to reproduce
>  # Start one interior router and one edge router using the attached config 
> files
>  # Start a receiver using simple_recv.py and connect it to the interior router
>  ## 
> {noformat}
> python simple_recv.py -m1 --address 0.0.0.0:8/examples{noformat}
>  # Use the attached sender to send an anonymous message to the edge router
>  ## 
> {noformat}
> python simple_send_anon.py --address 0.0.0.0:5672 -m1{noformat}
>  # The message must travel from the edge router to the interior router which 
> in turn must forward it to the receiver. Instead the message is released as 
> seen in the below frame trace.
>  
> {noformat}
> [0x5603df87eb20]:  -> SASL
> [0x5603df87eb20]:  <- SASL
> [0x5603df87eb20]:0 <- @sasl-mechanisms(64) 
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> [0x5603df87eb20]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, 
> initial-response=b"anonymous@localhost.localdomain"]
> [0x5603df87eb20]:0 <- @sasl-outcome(68) [code=0]
> [0x5603df87eb20]:  -> AMQP
> [0x5603df87eb20]:0 -> @open(16) 
> [container-id="c99c4867-447c-424a-8b4f-e8a406c71a57", hostname="0.0.0.0", 
> channel-max=32767]
> [0x5603df87eb20]:0 -> @begin(17) [next-outgoing-id=0, 
> incoming-window=2147483647, outgoing-window=2147483647]
> [0x5603df87eb20]:0 -> @attach(18) 
> [name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
>  handle=0, role=false, snd-settle-mode=2, rcv-settle-mode=0, 
> source=@source(40) [durable=0, timeout=0, dynamic=false], target=@target(41) 
> [durable=0, timeout=0, dynamic=false], initial-delivery-count=0, 
> max-message-size=0]
> [0x5603df87eb20]:  <- AMQP
> [0x5603df87eb20]:0 <- @open(16) [container-id="Edge_66t2+y4DnWql1Vx", 
> max-frame-size=16384, channel-max=32767, idle-time-out=8000, 
> offered-capabilities=:"ANONYMOUS-RELAY", 
> properties={:product="qpid-dispatch-router", :version="1.8.0-SNAPSHOT", 
> :"qd.conn-id"=7}]
> [0x5603df87eb20]:0 <- @begin(17) [remote-channel=0, next-outgoing-id=0, 
> incoming-window=2147483647, outgoing-window=2147483647]
> [0x5603df87eb20]:0 <- @attach(18) 
> [name="c99c4867-447c-424a-8b4f-e8a406c71a57-8db0b3b7-ffde-4c99-9d99-ee8f3c0d9efd",
>  handle=0, role=true, snd-settle-mode=2, rcv-settle-mode=0, 
> source=@source(40) [durable=0, expiry-policy=:"session-end", timeout=0, 
> dynamic=false], target=@target(41) [durable=0, expiry-policy=:"session-end", 
> timeout=0, dynamic=false], initial-delivery-count=0, max-message-size=0]
> [0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=0, 
> incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647, 
> handle=0, delivery-count=0, link-credit=250, drain=false]
> [0x5603df87eb20]:0 -> @transfer(20) [handle=0, delivery-id=0, 
> delivery-tag=b"1", message-format=0] (53) 
> "\x00SpE\x00Ss\xd0\x00\x00\x00\x11\x00\x00\x00\x03S\x01@\xa1\x08examples\x00Sw\xd1\x00\x00\x00\x10\x00\x00\x00\x02\xa1\x08sequenceT\x01"
> [0x5603df87eb20]:0 <- @flow(19) [next-incoming-id=1, 
> incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647, 
> handle=0, delivery-count=1, link-credit=250, drain=false]
> [0x5603df87eb20]:0 <- @disposition(21) [role=true, first=0, settled=true, 
> state=@released(38) []]
> [0x5603df87eb20]:0 -> (EMPTY FRAME)
> [0x5603df87eb20]:0 -> (EMPTY FRAME)
> ^C[gmurthy@localhost examples]$
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1322) Edge router drops disposition when remote receiver closes

2019-04-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827235#comment-16827235
 ] 

ASF GitHub Bot commented on DISPATCH-1322:
--

ChugR commented on issue #493: DISPATCH-1322 - Prevent credit starvation in 
router-to-router links.
URL: https://github.com/apache/qpid-dispatch/pull/493#issuecomment-487168881
 
 
   +1
   Passes self test and thousands of passes of my stand-alone test case.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Edge router drops disposition when remote receiver closes
> -
>
> Key: DISPATCH-1322
> URL: https://issues.apache.org/jira/browse/DISPATCH-1322
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.6.0
>Reporter: Chuck Rolke
>Priority: Major
> Attachments: DISPATCH-1322-analysis.txt
>
>
> The test is available in system_tests_edge_router.
> The analysis is attached as a file.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] ChugR commented on issue #493: DISPATCH-1322 - Prevent credit starvation in router-to-router links.

2019-04-26 Thread GitBox
ChugR commented on issue #493: DISPATCH-1322 - Prevent credit starvation in 
router-to-router links.
URL: https://github.com/apache/qpid-dispatch/pull/493#issuecomment-487168881
 
 
   +1
   Passes self test and thousands of passes of my stand-alone test case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1322) Edge router drops disposition when remote receiver closes

2019-04-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827197#comment-16827197
 ] 

ASF GitHub Bot commented on DISPATCH-1322:
--

codecov-io commented on issue #493: DISPATCH-1322 - Prevent credit starvation 
in router-to-router links.
URL: https://github.com/apache/qpid-dispatch/pull/493#issuecomment-487154841
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=h1) 
Report
   > Merging 
[#493](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/783830026582fe7645442d564574d605e155e030?src=pr=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `90%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/493/graphs/tree.svg?width=650=rk2Cgd27pP=150=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #493  +/-   ##
   ==
   - Coverage   86.95%   86.91%   -0.04% 
   ==
 Files  87   87  
 Lines   1924619250   +4 
   ==
   - Hits1673516731   -4 
   - Misses   2511 2519   +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
 | `88.37% <100%> (-0.52%)` | :arrow_down: |
   | 
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
 | `93.8% <88.88%> (-0.21%)` | :arrow_down: |
   | 
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j)
 | `79.08% <0%> (-0.92%)` | :arrow_down: |
   | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `94.11% <0%> (-0.13%)` | :arrow_down: |
   | 
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=)
 | `88.13% <0%> (-0.03%)` | :arrow_down: |
   | 
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
 | `87.06% <0%> (+0.21%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=footer).
 Last update 
[7838300...71c8d39](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Edge router drops disposition when remote receiver closes
> -
>
> Key: DISPATCH-1322
> URL: https://issues.apache.org/jira/browse/DISPATCH-1322
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.6.0
>Reporter: Chuck Rolke
>Priority: Major
> Attachments: DISPATCH-1322-analysis.txt
>
>
> The test is available in system_tests_edge_router.
> The analysis is attached as a file.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] codecov-io commented on issue #493: DISPATCH-1322 - Prevent credit starvation in router-to-router links.

2019-04-26 Thread GitBox
codecov-io commented on issue #493: DISPATCH-1322 - Prevent credit starvation 
in router-to-router links.
URL: https://github.com/apache/qpid-dispatch/pull/493#issuecomment-487154841
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=h1) 
Report
   > Merging 
[#493](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/783830026582fe7645442d564574d605e155e030?src=pr=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `90%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/493/graphs/tree.svg?width=650=rk2Cgd27pP=150=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #493  +/-   ##
   ==
   - Coverage   86.95%   86.91%   -0.04% 
   ==
 Files  87   87  
 Lines   1924619250   +4 
   ==
   - Hits1673516731   -4 
   - Misses   2511 2519   +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
 | `88.37% <100%> (-0.52%)` | :arrow_down: |
   | 
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
 | `93.8% <88.88%> (-0.21%)` | :arrow_down: |
   | 
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j)
 | `79.08% <0%> (-0.92%)` | :arrow_down: |
   | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `94.11% <0%> (-0.13%)` | :arrow_down: |
   | 
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=)
 | `88.13% <0%> (-0.03%)` | :arrow_down: |
   | 
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/493/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
 | `87.06% <0%> (+0.21%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=footer).
 Last update 
[7838300...71c8d39](https://codecov.io/gh/apache/qpid-dispatch/pull/493?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1322) Edge router drops disposition when remote receiver closes

2019-04-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827169#comment-16827169
 ] 

ASF GitHub Bot commented on DISPATCH-1322:
--

ted-ross commented on pull request #493: DISPATCH-1322 - Prevent credit 
starvation in router-to-router links.
URL: https://github.com/apache/qpid-dispatch/pull/493
 
 
   Added protection for deliveries held in link processing outside the lock.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Edge router drops disposition when remote receiver closes
> -
>
> Key: DISPATCH-1322
> URL: https://issues.apache.org/jira/browse/DISPATCH-1322
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 1.6.0
>Reporter: Chuck Rolke
>Priority: Major
> Attachments: DISPATCH-1322-analysis.txt
>
>
> The test is available in system_tests_edge_router.
> The analysis is attached as a file.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] ted-ross opened a new pull request #493: DISPATCH-1322 - Prevent credit starvation in router-to-router links.

2019-04-26 Thread GitBox
ted-ross opened a new pull request #493: DISPATCH-1322 - Prevent credit 
starvation in router-to-router links.
URL: https://github.com/apache/qpid-dispatch/pull/493
 
 
   Added protection for deliveries held in link processing outside the lock.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1325) Sender connections to edge router that connect 'too soon' never get credit

2019-04-26 Thread Chuck Rolke (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke updated DISPATCH-1325:
--
Attachment: DISPATCH-1325-test-hang.html

> Sender connections to edge router that connect 'too soon' never get credit
> --
>
> Key: DISPATCH-1325
> URL: https://issues.apache.org/jira/browse/DISPATCH-1325
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: Fedora 29, python 3.7
> Dispatch master of today.
> Proton 0.27.x branch
> Source code in repository [https://github.com/ChugR/qpid-dispatch]
> branch crolke-DISPATCH-1322
> directory tools/DISPATCH-1322
>  
>Reporter: Chuck Rolke
>Priority: Major
> Attachments: DISPATCH-1325-test-hang.html
>
>
> A stand-alone self test was extracted from system_tests_edge_router. Running 
> the test involves starting the routers and then running the client. If this 
> is repeated in a script then there must be a fairly long delay between 
> starting the routers and running the client.
> If the delay is 6 seconds then the client sender seems to run fine every time.
> If the delay is 4 seconds then the client sender routinely (half the time?) 
> fails to get an on_sendable event as no credit is ever issued by the edge 
> router. A protocol trace to be attached.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1325) Sender connections to edge router that connect 'too soon' never get credit

2019-04-26 Thread Chuck Rolke (JIRA)
Chuck Rolke created DISPATCH-1325:
-

 Summary: Sender connections to edge router that connect 'too soon' 
never get credit
 Key: DISPATCH-1325
 URL: https://issues.apache.org/jira/browse/DISPATCH-1325
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 1.7.0
 Environment: Fedora 29, python 3.7

Dispatch master of today.

Proton 0.27.x branch

Source code in repository [https://github.com/ChugR/qpid-dispatch]

branch crolke-DISPATCH-1322

directory tools/DISPATCH-1322

 
Reporter: Chuck Rolke


A stand-alone self test was extracted from system_tests_edge_router. Running 
the test involves starting the routers and then running the client. If this is 
repeated in a script then there must be a fairly long delay between starting 
the routers and running the client.

If the delay is 6 seconds then the client sender seems to run fine every time.

If the delay is 4 seconds then the client sender routinely (half the time?) 
fails to get an on_sendable event as no credit is ever issued by the edge 
router. A protocol trace to be attached.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org