[GitHub] qpid-jms pull request #:
Github user addoula88 commented on the pull request: https://github.com/apache/qpid-jms/commit/368dce70b8625b27e57137e71153554ff58fc384#commitcomment-20469819 In qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnectionFactory.java: In qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnectionFactory.java on line 125: I think this is redundant. If it is already null, there is no need to reset it to null, no? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-jms pull request #:
Github user addoula88 commented on the pull request: https://github.com/apache/qpid-jms/commit/368dce70b8625b27e57137e71153554ff58fc384#commitcomment-20469817 In qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnectionFactory.java: In qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnectionFactory.java on line 119: I think this is redundant. If it is already null, there is no need to reset it to null, no? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
