[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-20 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/qpid-jms/pull/10 [QPIDJMS-303] implement sasl gssapi (kerberos) mechanism Using the current username or configured url prams the current kerberos credential is propagated via sasl gssapi mechanism. the default

[GitHub] qpid-jms issue #10: [QPIDJMS-303] implement sasl gssapi (kerberos) mechanism

2017-07-20 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/qpid-jms/pull/10 I see mechanism verifyComplete from: https://github.com/apache/qpid-jms/pull/9/commits/e0d87347bf283df7a1a295e889641fac65c5 I could use that to destroy the saslclient which would be good

[GitHub] qpid-jms issue #10: [QPIDJMS-303] implement sasl gssapi (kerberos) mechanism

2017-07-21 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/qpid-jms/pull/10 rebased and added negative test to validate client side sasl exceptions percolate up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128785321 --- Diff: qpid-jms-client/src/main/resources/login.config --- @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128775727 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128774185 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java --- @@ -137,7 +142,9 @@ private void handleSaslStep

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128775211 --- Diff: qpid-jms-client/pom.xml --- @@ -93,6 +93,19 @@ hamcrest-all test + + org.apache.hadoop

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128775254 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-25 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r129354263 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128788568 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SaslGssApiIntegrationTest.java --- @@ -0,0 +1,185

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128801781 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128788434 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SaslGssApiIntegrationTest.java --- @@ -0,0 +1,185

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128803960 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128800956 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run