[GitHub] qpid-dispatch pull request #:

Github user dskarbek commented on the pull request: https://github.com/apache/qpid-dispatch/commit/611e7d6d078d1078d8e53b711285539506e536ea#commitcomment-20189919 In src/router_core/connections.c: In src/router_core/connections.c on line 497: So, then, what reference from

[GitHub] qpid-dispatch pull request #:

Github user dskarbek commented on the pull request: https://github.com/apache/qpid-dispatch/commit/611e7d6d078d1078d8e53b711285539506e536ea#commitcomment-20189814 In src/router_core/connections.c: In src/router_core/connections.c on line 497: why can't proton do the decref

[GitHub] qpid-dispatch issue #124: Allow passing the password via env variable

Github user dskarbek commented on the issue: https://github.com/apache/qpid-dispatch/pull/124 Ok, that makes sense. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] qpid-dispatch pull request #124: Allow passing the password via env variable

Github user dskarbek commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/124#discussion_r92076465 --- Diff: src/connection_manager.c --- @@ -176,6 +176,46 @@ static void set_config_host(qd_server_config_t *config, qd_entity_t* entity

[GitHub] qpid-dispatch pull request #124: Allow passing the password via env variable

Github user dskarbek commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/124#discussion_r91815078 --- Diff: src/connection_manager.c --- @@ -176,6 +176,46 @@ static void set_config_host(qd_server_config_t *config, qd_entity_t* entity

[GitHub] qpid-dispatch pull request #124: Allow passing the password via env variable

Github user dskarbek commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/124#discussion_r91815006 --- Diff: src/connection_manager.c --- @@ -176,6 +176,46 @@ static void set_config_host(qd_server_config_t *config, qd_entity_t* entity

[GitHub] qpid-dispatch pull request #124: Allow passing the password via env variable

Github user dskarbek commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/124#discussion_r91814838 --- Diff: src/connection_manager.c --- @@ -176,6 +176,46 @@ static void set_config_host(qd_server_config_t *config, qd_entity_t* entity

[GitHub] qpid-dispatch pull request #124: Allow passing the password via env variable

GitHub user dskarbek opened a pull request: https://github.com/apache/qpid-dispatch/pull/124 Allow passing the password via env variable Allows for the password in the config to actually be the name of the environment variable that contains the password. This is indicated

[GitHub] qpid-dispatch issue #108: Fix memory leaks

Github user dskarbek commented on the issue: https://github.com/apache/qpid-dispatch/pull/108 Hmm… I wonder how it compiled on my machine? -Dan Skarbek From: Ganesh Murthy <notificati...@github.com> Reply-To: apache/qpid-dispatch <re...@reply.g

[GitHub] qpid-dispatch issue #108: Fix memory leaks

Github user dskarbek commented on the issue: https://github.com/apache/qpid-dispatch/pull/108 @ganeshmurthy Ted had mentioned that he pulled my commits and was getting a seg-fault on exit. I haven't been able to reproduce that, and can't see any change that would be causing

[GitHub] qpid-dispatch pull request #108: Fix memory leaks

Github user dskarbek commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/108#discussion_r87630081 --- Diff: src/router_config.c --- @@ -26,6 +26,27 @@ #include "entity_cache.h" #include "schema_enum.h"

[GitHub] qpid-dispatch pull request #108: Fix memory leaks

Github user dskarbek commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/108#discussion_r87629907 --- Diff: src/dispatch_private.h --- @@ -141,4 +141,16 @@ void qd_dispatch_unregister_entity(qd_dispatch_t *qd, void *impl); /** Set the agent

[GitHub] qpid-dispatch pull request #108: Fix memory leaks

Github user dskarbek commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/108#discussion_r86644159 --- Diff: src/router_config.c --- @@ -26,6 +26,27 @@ #include "entity_cache.h" #include "schema_enum.h"

[GitHub] qpid-dispatch pull request #108: Fix memory leaks

Github user dskarbek commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/108#discussion_r86455403 --- Diff: src/router_config.c --- @@ -26,6 +26,27 @@ #include "entity_cache.h" #include "schema_enum.h"

[GitHub] qpid-dispatch pull request #108: Fix memory leaks

Github user dskarbek commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/108#discussion_r86036444 --- Diff: src/router_core/router_core.c --- @@ -106,29 +106,31 @@ void qdr_core_free(qdr_core_t *core) sys_mutex_free(core->work_l

[GitHub] qpid-dispatch pull request #108: Fix memory leaks

GitHub user dskarbek opened a pull request: https://github.com/apache/qpid-dispatch/pull/108 Fix memory leaks Just getting my feet wet really. Fix a few little things. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dskarbek