[GitHub] qpid-dispatch issue #420: DISPATCH-1177 - Added new option -e to qdstat. Thi...

2018-11-14 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/420
  
@ganeshmurthy I have executed qdstat with -e on a formed network here and I 
see the "edge" routers from an interior router, and the "interior" router when 
executed against edge. It makes sense.
What about the message when we run "qdstat -n" on an edge router, which 
shows:
"Router is Standalone - No Router List".
Is it changing?
Thanks.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #414: DISPATCH-1170 - Fix for system tests execut...

2018-11-05 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/414

DISPATCH-1170 - Fix for system tests execution on python3 only machines



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1170

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #414


commit dec3416e09a8501411193b89727ba263c933f105
Author: Fernando Giorgetti 
Date:   2018-11-05T13:16:50Z

DISPATCH-1170 - Fix for system tests execution on python3 only machines




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #412: DISPATCH-1164 - Modified config.sh to work ...

2018-10-31 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/412

DISPATCH-1164 - Modified config.sh to work with python3 only



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1164

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #412


commit 9af66023d1e17a9591fcb4a5ecdd471117399831
Author: Fernando Giorgetti 
Date:   2018-10-31T20:48:06Z

DISPATCH-1164 - Modified config.sh to work with python3 only




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #369: DISPATCH-1112 - Detach takes a higher prior...

2018-08-31 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/369

DISPATCH-1112 - Detach takes a higher priority when processing link work



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1112

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/369.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #369


commit fb4fd9fe473942c4d209cd47d060d0a4b1c12634
Author: Fernando Giorgetti 
Date:   2018-08-31T02:40:47Z

DISPATCH-1112 - Detach takes a higher priority when processing link work




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #352: DISPATCH-1095 - Only adding SASL listener w...

2018-08-03 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/352

DISPATCH-1095 - Only adding SASL listener when SASL available

This might resolve the tearDown issue when SASL is not available.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1095-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #352


commit 2c8adb848cdc965bc13104c471ec2c8d51d2a45a
Author: Fernando Giorgetti 
Date:   2018-08-03T12:47:28Z

DISPATCH-1095 - Only adding SASL listener when SASL available




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #351: DISPATCH-1095 - Improved SkipIfNeeded decor...

2018-08-02 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/351

DISPATCH-1095 - Improved SkipIfNeeded decorator and added it to metho…

…ds using SASL when it is not installed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1095

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #351


commit 81504e94502807f8434c28715d9b2aab0845df47
Author: Fernando Giorgetti 
Date:   2018-08-02T19:29:23Z

DISPATCH-1095 - Improved SkipIfNeeded decorator and added it to methods 
using SASL when it is not installed




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #343: DISPATCH-1067 - updates to policy doc (upda...

2018-07-16 Thread fgiorgetti
Github user fgiorgetti commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/343#discussion_r202810977
  
--- Diff: docs/books/user-guide/configuration-security.adoc ---
@@ -442,290 +442,367 @@ For more information about these attributes, see 
xref:adding-sasl-authentication
 
 == Authorizing Access to Messaging Resources
 
-You can restrict the number of user connections, and control access to 
AMQP messaging resources by configuring _policies_.
+You can configure _policies_ to secure messaging resources in your 
messaging environment. Policies ensure that only authorized users can access 
messaging endpoints through the router network, and that the resources on those 
endpoints are used in an authorized way.
 
-=== Types of Policies
-
-You can configure two different types of policies: _global policies_ and 
_vhost policies_.
+{RouterName} provides the following types of policies:
 
 Global policies::
-Settings for the router. A global policy defines the maximum number of 
incoming user connections for the router (across all vhost policies), and 
defines how the router should use vhost policies.
+Settings for the router. A global policy defines the maximum number of 
incoming user connections for the router (across all messaging endpoints), and 
defines how the router should use vhost policies.
 
 Vhost policies::
-Connection and AMQP resource limits for a messaging endpoint (called an 
AMQP virtual host, or _vhost_). A vhost policy defines what a client can access 
on a messaging endpoint over a particular connection.
-+
-[NOTE]
-
-A vhost is typically the name of the host to which the client connection 
is directed. For example, if a client application opens a connection to the 
`amqp://mybroker.example.com:5672/queue01` URL, the vhost would be 
`mybroker.example.com`.
-
+Connection and AMQP resource limits for a messaging endpoint (called an 
AMQP virtual host, or vhost). A vhost policy defines what a client can access 
on a messaging endpoint over a particular connection.
 
 The resource limits defined in global and vhost policies are applied to 
user connections only. The limits do not affect inter-router connections or 
router connections that are outbound to waypoints.
 
-=== How {RouterName} Applies Policies
+=== How {RouterName} Enforces Connection and Resource Limits
 
-{RouterName} uses both global and vhost policies to determine whether to 
permit a connection, and if it is permitted, to apply the appropriate resource 
limits.
+{RouterName} uses policies to determine whether to permit a connection, 
and if it is permitted, to apply the appropriate resource limits.
 
 When a client creates a connection to the router, the router first 
determines whether to allow or deny the connection. This decision is based on 
the following criteria:
 
-* Whether the connection will exceed the router's global connection limit 
(defined in the global policy)
-* Whether the connection will exceed the vhost's connection limits 
(defined in the vhost policy that matches the host to which the connection is 
directed)
+* Whether the connection will exceed the router’s global connection 
limit (defined in the global policy)
 
-If the connection is allowed, the router assigns the user (the 
authenticated user name from the connection) to a user group, and enforces the 
user group's resource limits for the lifetime of the connection.
+* Whether the connection will exceed the vhost’s connection limits 
(defined in the vhost policy that matches the host to which the connection is 
directed)
 
-=== Configuring Global Policies
+If the connection is allowed, the router assigns the user (the 
authenticated user name from the connection) to a user group, and enforces the 
user group’s resource limits for the lifetime of the connection.
 
-You can set the incoming connection limit for the router and define how it 
should use vhost policies by configuring a global policy.
+=== Setting Global Connection Limits
+
+You can set the incoming connection limit for the router. This limit 
defines the total number of concurrent client connections that can be open for 
this router.
 
 .Procedure
 
-* In the router configuration file, add a `policy` section.
+* In the router configuration file, add a `policy` section and set the 
`maxConnections`.
 +
 --
 [options="nowrap",subs="+quotes"]
 
-policy = {
-maxConnections: 1  // <1>
-enableVhostPolicy: true  // <2>
-policyDir: /etc/qpid-dispatch/policies/  // <3>
-defaultVhost: $default  // <4>
+policy {
+maxConnections: 1
 }
 
-<1> The maximum number of concurrent client connecti

[GitHub] qpid-dispatch pull request #343: DISPATCH-1067 - updates to policy doc (upda...

2018-07-16 Thread fgiorgetti
Github user fgiorgetti commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/343#discussion_r202826844
  
--- Diff: docs/books/user-guide/configuration-security.adoc ---
@@ -734,57 +811,57 @@ vhost {
 
 <3> Any user can connect to this vhost. Users that are not part of the 
`admin` group are assigned to the `$default` group.
 
-<4> If the `admin-01` or `admin-02` user connects to the vhost, they are 
assigned to the `admin` user group.
+<4> If the `admin1` or `admin2` user connects to the vhost, they are 
assigned to the `admin` user group.
 
 <5> Users in the `admin` user group must connect from localhost. If the 
admin user attempts to connect from any other host, the connection will be 
denied.
 
-<6> Users in the admin user group can send and receive from any address 
offered by the vhost.
+<6> Users in the admin user group can send to any address offered by the 
vhost.
 
-<7> Any non-admin user is permitted to connect from any host.
+<7> Users in the admin user group can receive from any address offered by 
the vhost.
--- End diff --

s/receive from/send to


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #343: DISPATCH-1067 - updates to policy doc (upda...

2018-07-16 Thread fgiorgetti
Github user fgiorgetti commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/343#discussion_r202826788
  
--- Diff: docs/books/user-guide/configuration-security.adoc ---
@@ -734,57 +811,57 @@ vhost {
 
 <3> Any user can connect to this vhost. Users that are not part of the 
`admin` group are assigned to the `$default` group.
 
-<4> If the `admin-01` or `admin-02` user connects to the vhost, they are 
assigned to the `admin` user group.
+<4> If the `admin1` or `admin2` user connects to the vhost, they are 
assigned to the `admin` user group.
 
 <5> Users in the `admin` user group must connect from localhost. If the 
admin user attempts to connect from any other host, the connection will be 
denied.
 
-<6> Users in the admin user group can send and receive from any address 
offered by the vhost.
+<6> Users in the admin user group can send to any address offered by the 
vhost.
--- End diff --

s/send to/receive from


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...

2018-06-25 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/327
  
It covers everything now!


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...

2018-06-22 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/327
  
@ganeshmurthy it looks great to me. One thing I noticed is that the only 
new metric that is not present in this test is: "acceptedDeliveries". But I see 
it being used in system_tests_one_router.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #324: DISPATCH-976 - Fixed issue with policy vali...

2018-06-13 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/324


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #324: DISPATCH-976 - Fixed issue with policy validation ...

2018-06-13 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/324
  
Done. Seems to be working fine.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #324: DISPATCH-976 - Fixed issue with policy validation ...

2018-06-12 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/324
  
@ganeshmurthy and @ChugR after debugging it a little bit more, I noticed 
that the first if statement that checks for an absent user key in the iterating 
allowed address, was also checking the "need_check_nosubst" boolean, enforcing 
that only one address with "absent" user key is defined.
So with this boolean flag, in case more than one address is defined in the 
tree (without the user key), it  causes the last "else" statement to be 
processed and then executing the "assert(false);" which was crashing the router.
In this PR I have removed the need_check_nosubst flag which seems to 
resolve the issue reported in DISPATCH-1026 as well.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #324: DISPATCH-976 - Fixed issue with policy vali...

2018-06-12 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/324

DISPATCH-976 - Fixed issue with policy validation of allowed addresses



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-976-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #324


commit 1892f5dc68296e5b5ec107f6212e0e24f4b852e3
Author: Fernando Giorgetti 
Date:   2018-06-13T01:57:17Z

DISPATCH-976 - Fixed issue with policy validation of allowed addresses




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #323: DISPATCH-976 - Commenting last assert which...

2018-06-12 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/323


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #323: DISPATCH-976 - Commenting last assert which is cau...

2018-06-12 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/323
  
I believe I found the reason for the failure. I will provide a new PR and 
ask Chuck to review it.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #323: DISPATCH-976 - Commenting last assert which...

2018-06-12 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/323

DISPATCH-976 - Commenting last assert which is causing router to crash



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-976-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/323.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #323


commit fd7eda39c245b57596841222c5db1d7c8581c86f
Author: Fernando Giorgetti 
Date:   2018-06-12T20:35:33Z

DISPATCH-976 - Commenting last assert which is causing router to crash




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #320: DISPATCH-976 - System test to validate vhos...

2018-06-08 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/320

DISPATCH-976 - System test to validate vhost policies on source and t…

…arget addresses

NOTE: If this gets merged before PR#319 and before DISPATCH-1026 is fixed 
(no PR available yet), then tests will not pass. This test ensures that router 
is properly handling vhost policies applied to addresses.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-976

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #320


commit 655ec6e0db3197f4ca859675c052cd833540222f
Author: Fernando Giorgetti 
Date:   2018-06-08T20:43:27Z

DISPATCH-976 - System test to validate vhost policies on source and target 
addresses




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #319: DISPATCH-1025 - Fixes user token replacemen...

2018-06-07 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/319

DISPATCH-1025 - Fixes user token replacement used in prefix or suffix



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1025

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #319


commit 812fd0014f69c31a1f9e76be48c273e52fa91fb2
Author: Fernando Giorgetti 
Date:   2018-06-07T22:16:19Z

DISPATCH-1025 - Fixes user token replacement used in prefix or suffix




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #317: DISPATCH-1024 - Fix for system_tests_policy...

2018-06-05 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/317

DISPATCH-1024 - Fix for system_tests_policy urls using user and password



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1024

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #317


commit 85a581394f6c57ba9f8a201a2e1769f4887b5824
Author: Fernando Giorgetti 
Date:   2018-06-05T20:32:38Z

DISPATCH-1024 - Fix for system_tests_policy urls using user and password




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #315: DISPATCH-1013 - Enable vhost policies to be...

2018-06-05 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/315

DISPATCH-1013 - Enable vhost policies to be defined on router config



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1013

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #315


commit a62be32f143054ad2b10573abc2004b9752a3fe0
Author: Fernando Giorgetti 
Date:   2018-05-25T20:02:52Z

DISPATCH-1013 - Enable vhost policies to be defined on router config




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #309: DISPATCH-1013 - Enable vhost policies to be...

2018-06-05 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/309


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #309: DISPATCH-1013 - Enable vhost policies to be...

2018-05-25 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/309

DISPATCH-1013 - Enable vhost policies to be defined on router config



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1013

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #309


commit 389e23eb3e8f3af8f4e710c1d9bc81de5ceb6b75
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-05-25T20:02:52Z

DISPATCH-1013 - Enable vhost policies to be defined on router config




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #308: DISPATCH-1005 - Fixed system_tests_ssl.py t...

2018-05-22 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/308

DISPATCH-1005 - Fixed system_tests_ssl.py to work on rhel6 and other …

…distros

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1005

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #308


commit 21728c133d4e63b2666de3bdbde438ef702c6755
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-05-22T20:44:14Z

DISPATCH-1005 - Fixed system_tests_ssl.py to work on rhel6 and other distros




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #307: DISPATCH-1005 - New system test to validate...

2018-05-22 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/307

DISPATCH-1005 - New system test to validate restriction of TLS protocols



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1005

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #307


commit 5d5db890716b87499f40bb16d4e9dbd3700f6f45
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-05-18T17:26:51Z

DISPATCH-1005 - New system test to validate restriction of TLS protocols




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #306: DISPATCH-1005 - New system test to validate...

2018-05-22 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/306


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #306: DISPATCH-1005 - New system test to validate...

2018-05-18 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/306

DISPATCH-1005 - New system test to validate restriction of TLS protocols



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-1005

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #306


commit 042ddafe58cfb6c8861feecc3a06c53833fc6fb9
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-05-18T17:26:51Z

DISPATCH-1005 - New system test to validate restriction of TLS protocols




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #293: DISPATCH-977: Add transaction coordinator step to ...

2018-05-09 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/293
  
Looks good to me. I have created a simple scenario to validate the 
coordinator, as described in the doc, and it worked just fine. The final doc 
looks good as well.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #302: DISPATCH-992: Fix for system_tests_delivery...

2018-05-08 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/302

DISPATCH-992: Fix for system_tests_delivery_abort.py



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-992

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #302


commit 95d1ba5e1d8882dd624b451072837396f201baa5
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-05-08T21:43:21Z

DISPATCH-992: Fix for system_tests_delivery_abort.py




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #301: DISPATCH-927 - System test for fix. Makes s...

2018-05-07 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/301

DISPATCH-927 - System test for fix. Makes sure both detaches are echo…

…ed back

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-927

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #301


commit 7e4dfd7334ea994719e178cba78998c1933f60dc
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-05-08T01:31:36Z

DISPATCH-927 - System test for fix. Makes sure both detaches are echoed back




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #300: DISPATCH-927 - System test for fix. Makes s...

2018-05-07 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/300


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #300: DISPATCH-927 - System test for fix. Makes s...

2018-05-07 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/300

DISPATCH-927 - System test for fix. Makes sure both detaches are echo…

…ed back

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-927

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #300


commit 4a7cd80ab63c17b2801d0623a7f3f4244104720a
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-05-08T01:31:36Z

DISPATCH-927 - System test for fix. Makes sure both detaches are echoed back




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #298: DISPATCH-963 - Added decorator class that c...

2018-05-03 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/298

DISPATCH-963 - Added decorator class that can be used to skip test methods, 
as unittest2 does not support skipping feature on python 2.6.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-963

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #298


commit 21b7e664f085ed56ec423020b8352f500d8ede9e
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-05-03T21:54:29Z

DISPATCH-963 - Added decorator class that can be used to skip test methods, 
as unittest2 does not support skipping feature on python 2.6.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #294: DISPATCH-960 - Resolving service port when using h...

2018-04-27 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/294
  
Removed as suggested. It seems to be working just fine for me.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #294: DISPATCH-960 - Resolving service port when ...

2018-04-27 Thread fgiorgetti
Github user fgiorgetti commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/294#discussion_r184743211
  
--- Diff: src/amqp.c ---
@@ -73,11 +76,30 @@ const char * const QD_AMQP_COND_FRAME_SIZE_TOO_SMALL = 
"amqp:frame-size-too-smal
 const char * const QD_AMQP_PORT_STR = "5672";
 const char * const QD_AMQPS_PORT_STR = "5671";
 
+const char * const QD_AMQP_DFLT_PROTO = "tcp";
+
 int qd_port_int(const char* port_str) {
 if (!strcmp(port_str, QD_AMQP_PORT_STR)) return QD_AMQP_PORT_INT;
--- End diff --

You're right. Maybe I should submit a new PR without the strcmp, as service 
name is now being resolved when strtoul returns 0. And also, using static 
values for amqp/amqps can also be a problem, in case someone changes the 
default values at /etc/services (no supposed to happen, but it is possible).


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #294: DISPATCH-960 - Resolving service port when ...

2018-04-25 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/294

DISPATCH-960 - Resolving service port when using http listener

As suggested by @ted-ross, I am re-submitting this PR again now using 
getservbyname_r which is multi-thread safe.

If you find any other possible issue, please let me know. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-960

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #294


commit 1fbfb14dee43f00113002d308e1862213edb2f7e
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-04-10T19:39:27Z

DISPATCH-960 - Resolving service port when using http listener




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #284: DISPATCH-960 - Resolving service port when ...

2018-04-25 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/284


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #268: DISPATCH-154 - Added new test case to ensur...

2018-04-11 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/268


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #268: DISPATCH-154 - Added new test case to ensure route...

2018-04-11 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/268
  
Submitting a new PR for this new test following recommendations.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #285: DISPATCH-154 - Added new tests to validate ...

2018-04-11 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/285


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #285: DISPATCH-154 - Added new tests to validate unresol...

2018-04-11 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/285
  
Yes I see that as well, but it happens before the connection is 
established. Right after that I am seeing the error below:

2018-04-11 08:47:15.086037 -0300 CONN_MGR (info) Configured Connector: 
unresolvable.host.name:amqp proto=any, role=normal 
(/home/fgiorget/git/qpid-dispatch-fgiorgetti/src/connection_manager.c:623)
2018-04-11 08:47:15.194168 -0300 SERVER (info) Connection to 
unresolvable.host.name:amqp failed: **proton:io Name or service not known** - 
connect to  unresolvable.host.name:5672 
(/home/fgiorget/git/qpid-dispatch-fgiorgetti/src/server.c:921)

I will investigate further and report back if in case I find something new.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #285: DISPATCH-154 - Added new tests to validate ...

2018-04-10 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/285

DISPATCH-154 - Added new tests to validate unresolvable hostname



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-154

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #285


commit fc1bdc820980807f9c64e89e9688309668214187
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-04-10T20:37:05Z

DISPATCH-154 - Added new tests to validate unresolvable hostname




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #284: DISPATCH-960 - Resolving service port when ...

2018-04-10 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/284

DISPATCH-960 - Resolving service port when using http listener



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-960

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #284


commit 818594ee1fa0e7e0472bad783c8927a560661df2
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-04-10T19:39:27Z

DISPATCH-960 - Resolving service port when using http listener




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #283: DISPATCH-960 - Resolving service port when ...

2018-04-10 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/283


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #283: DISPATCH-960 - Resolving service port when ...

2018-04-10 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/283

DISPATCH-960 - Resolving service port when using http listener



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-960

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #283


commit e23eae438ecfa0e2845c47f87b6e671875cfd35d
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-04-10T19:26:26Z

DISPATCH-960 - Resolving service port when using http listener




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #282: DISPATCH-911 - Added explicit validation fo...

2018-04-10 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/282


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #282: DISPATCH-911 - Added explicit validation fo...

2018-04-10 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/282

DISPATCH-911 - Added explicit validation for new metric presettledDeliveries

All new metrics are being validated by the system tests except for this one.
So I have modified one of the tests to ensure it is also being validated.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-911

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #282


commit f8efa23f8dec1f7f45aca5a7bf42b185f49f8212
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-04-10T13:52:14Z

DISPATCH-911 - Added explicit validation for new metric presettledDeliveries




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #277: DISPATCH-954 - Fixed issue suggested by cov...

2018-04-02 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/277

DISPATCH-954 - Fixed issue suggested by coverity scan tool



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-954

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #277


commit 39a60bd5f7e0d1a125ef81f7195d9292fae6a348
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-04-02T19:15:19Z

DISPATCH-954 - Fixed issue suggested by coverity scan tool




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #276: DISPATCH-954 - Fixed issue suggested by cov...

2018-04-02 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/276


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #276: DISPATCH-954 - Fixed issue suggested by cov...

2018-04-02 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/276

DISPATCH-954 - Fixed issue suggested by coverity scan tool



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-DISPATCH-954

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #276


commit 710b6da05d8d8e2e4f0b8fbbed18c7947c4949e9
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-08T17:51:52Z

DISPATCH-940 - Allow configuration file to be used from relative path when 
running as a daemon

commit a0b280a207027dd0b27469b59b93cbbe3ff5adfa
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-09T05:26:36Z

DISPATCH-940 - Created unit test to validate command line parsing

commit 43d21a0df4c564d9eed6796e766149031d0feff3
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-09T12:49:56Z

DISPATCH-940 - Improved code quality using pylint recommendations

commit 5afc09a26ef0a73ca897ca8dd6ad8b5e8bfd5b7b
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-09T16:53:40Z

DISPATCH-940 - Implemented recommended coding standards

commit b202509425838643b9c7f0f553521210a5a484e8
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-04-02T16:40:55Z

Merge branch 'master' of github.com:apache/qpid-dispatch

Conflicts:
router/src/main.c
tests/CMakeLists.txt
tests/system_tests_cmdline_parsing.py

commit f09a8ee8e923d1ad56fd3a8679ac575e5c7092b1
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-04-02T16:45:54Z

DISPATCH-954 - Fixed issue suggested by coverity scan tool




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #269: DISPATCH-938: Remove config ref and add links to q...

2018-03-28 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/269
  
Can you mark us as reviewers here?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #269: DISPATCH-938: Remove config ref and add links to q...

2018-03-21 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/269
  
Thanks @bhardesty. We will start with this one.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #268: DISPATCH-154 - Added new test case to ensur...

2018-03-09 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/268

DISPATCH-154 - Added new test case to ensure router recovers from 
unresolvable hosts

Created a new system test class to run validations on a router that has a 
connector with an unresolvable host, and it expects that the router wont crash 
and instead will log an error message accordingly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch 
fgiorgetti-dispatch-154

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #268


commit 616e2926980d6132a8a659470e0e49314fd770b2
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-09T14:55:32Z

DISPATCH-154 - Added new test case as part of system tests list

commit addd4e39c03673a0b3330f0cb05fd3d1639c83bb
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-09T19:22:10Z

DISPATCH-154 - Added new test to validate unresolvable hostname




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #267: DISPATCH-154 - Added unit test

2018-03-09 Thread fgiorgetti
Github user fgiorgetti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/267


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #267: DISPATCH-154 - Added unit test

2018-03-09 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/267
  
I will recreate this pull request. This one mistakenly included changes 
from other PR.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #267: Dispatch 154 test

2018-03-09 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/267

Dispatch 154 test

Added a unit test to validate the issue, previously reported through 
DISPATCH-154.
It ensures the router is able to react to the problem and remains up and 
running.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch dispatch-154-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #267


commit 710b6da05d8d8e2e4f0b8fbbed18c7947c4949e9
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-08T17:51:52Z

DISPATCH-940 - Allow configuration file to be used from relative path when 
running as a daemon

commit a0b280a207027dd0b27469b59b93cbbe3ff5adfa
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-09T05:26:36Z

DISPATCH-940 - Created unit test to validate command line parsing

commit 43d21a0df4c564d9eed6796e766149031d0feff3
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-09T12:49:56Z

DISPATCH-940 - Improved code quality using pylint recommendations

commit 3943f29fc13b6b3191aa918503fb7c75e235002c
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-09T14:13:21Z

DISPATCH-154 - Added unit test to ensure router is able to recover from 
unresolvable hostname




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #266: DISPATCH-940 - Allow configuration file to be used...

2018-03-08 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/266
  
Unit test has been created.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #266: DISPATCH-940 - Allow configuration file to be used...

2018-03-08 Thread fgiorgetti
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/266
  
I will create a unit test for it. Thanks for the advise on the branch in 
use.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #266: DISPATCH-940 - Allow configuration file to ...

2018-03-08 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/266

DISPATCH-940 - Allow configuration file to be used from relative path…

DISPATCH-940 - Allow configuration file to be used from relative path when 
running as a daemon.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fgiorgetti/qpid-dispatch master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #266


commit 710b6da05d8d8e2e4f0b8fbbed18c7947c4949e9
Author: Fernando Giorgetti <fgiorget@...>
Date:   2018-03-08T17:51:52Z

DISPATCH-940 - Allow configuration file to be used from relative path when 
running as a daemon




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org