[jira] [Commented] (DISPATCH-1213) Sender link sending pre-settled multi-frame deliveries can stall if receiver drops
[
https://issues.apache.org/jira/browse/DISPATCH-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725235#comment-16725235
]
ASF subversion and git services commented on DISPATCH-1213:
---
Commit 6631c2ad270b6fc27ab504a6f7585f1e8ac56475 in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=6631c2a ]
DISPATCH-1213 - Do not increment the released count for presettled deliveries.
This fixes a regression introduced in an earlier commit
> Sender link sending pre-settled multi-frame deliveries can stall if
> receiver drops
> ---
>
> Key: DISPATCH-1213
> URL: https://issues.apache.org/jira/browse/DISPATCH-1213
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.4.1
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Steps to reproduce -
> # Start the router
> # Start a receiver and receive 10 messages.
> {noformat}
> python simple_recv.py --address 0.0.0.0/examples -m10{noformat}
> # Send 200 large presettled messages
> {noformat}
> python big_send_settled.py --address 0.0.0.0/examples -m200{noformat}
> # Look at the output of qdstat -g
> {noformat}
> [gmurthy@localhost ~]$ qdstat -g
> Router Statistics
> attr value
> =
> Version 1.5.0-SNAPSHOT
> Mode standalone
> Router Id Standalone_lPF38hMqjGI_iAO
> Area 0
> Link Routes 0
> Auto Links 0
> Links 3
> Nodes 0
> Addresses 5
> Connections 2
> Presettled Count 17
> Dropped Presettled Count 2
> Accepted Count 1
> Rejected Count 0
> Released Count 0
> Modified Count 0
> Ingress Count 19
> Egress Count 17
> Transit Count 0
> Deliveries from Route Container 0
> Deliveries to Route Container 0
> {noformat}
> The Ingress Count should be more than 200. We had all the credit we need to
> send 200 messages.
> # The messages are stuck inside the proton buffer. The router stopped
> fetching the messages from the proton buffer as soon as the q2_holdoff limit
> was hit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1213) Sender link sending pre-settled multi-frame deliveries can stall if receiver drops
[
https://issues.apache.org/jira/browse/DISPATCH-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711987#comment-16711987
]
ASF GitHub Bot commented on DISPATCH-1213:
--
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/425
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr=h1)
Report
> Merging
[#425](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/2dde7030fb032a54fdefe5b7c5c4a39a4f1bfd6e?src=pr=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr=tree)
```diff
@@Coverage Diff @@
## master #425 +/- ##
==
- Coverage 87.93% 87.92% -0.01%
==
Files 85 85
Lines 1823618243 +7
==
+ Hits1603516041 +6
- Misses 2201 2202 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `91.28% <100%> (+0.38%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `94.21% <100%> (ø)` | :arrow_up: |
|
[src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==)
| `94.64% <0%> (-1.79%)` | :arrow_down: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `77.01% <0%> (-0.77%)` | :arrow_down: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `63.27% <0%> (-0.57%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=)
| `88.04% <0%> (-0.26%)` | :arrow_down: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `76.36% <0%> (-0.25%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `95.2% <0%> (-0.13%)` | :arrow_down: |
|
[src/router\_core/modules/edge\_router/addr\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvYWRkcl9wcm94eS5j)
| `94.36% <0%> (+0.7%)` | :arrow_up: |
| ... and [2
more](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr=tree-more)
| |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr=footer).
Last update
[2dde703...e8124dc](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Sender link sending pre-settled multi-frame deliveries can stall if
> receiver drops
> ---
>
> Key: DISPATCH-1213
> URL: https://issues.apache.org/jira/browse/DISPATCH-1213
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.4.1
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.5.0
>
>
> Steps to reproduce -
> # Start the router
> # Start a receiver and receive 10 messages.
> {noformat}
> python simple_recv.py --address 0.0.0.0/examples -m10{noformat}
> # Send 200 large presettled messages
> {noformat}
> python big_send_settled.py --address 0.0.0.0/examples -m200{noformat}
> # Look at the output of qdstat -g
> {noformat}
> [gmurthy@localhost ~]$ qdstat -g
> Router Statistics
> attr value
>
[jira] [Commented] (DISPATCH-1213) Sender link sending pre-settled multi-frame deliveries can stall if receiver drops
[
https://issues.apache.org/jira/browse/DISPATCH-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711970#comment-16711970
]
ASF GitHub Bot commented on DISPATCH-1213:
--
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/425
DISPATCH-1213 - Prevent stalling of presettled large message senders …
…by calling the AMQP_rx_handler which start emptying proton buffers again
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1213
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #425
commit e8124dced7a70f6126f643959cac4603dcae0fbb
Author: Ganesh Murthy
Date: 2018-12-06T20:00:30Z
DISPATCH-1213 - Prevent stalling of presettled large message senders by
calling the AMQP_rx_handler which start emptying proton buffers again
> Sender link sending pre-settled multi-frame deliveries can stall if
> receiver drops
> ---
>
> Key: DISPATCH-1213
> URL: https://issues.apache.org/jira/browse/DISPATCH-1213
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.4.1
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.5.0
>
>
> Steps to reproduce -
> # Start the router
> # Start a receiver and receive 10 messages.
> {noformat}
> python simple_recv.py --address 0.0.0.0/examples -m10{noformat}
> # Send 200 large presettled messages
> {noformat}
> python big_send_settled.py --address 0.0.0.0/examples -m200{noformat}
> # Look at the output of qdstat -g
> {noformat}
> [gmurthy@localhost ~]$ qdstat -g
> Router Statistics
> attr value
> =
> Version 1.5.0-SNAPSHOT
> Mode standalone
> Router Id Standalone_lPF38hMqjGI_iAO
> Area 0
> Link Routes 0
> Auto Links 0
> Links 3
> Nodes 0
> Addresses 5
> Connections 2
> Presettled Count 17
> Dropped Presettled Count 2
> Accepted Count 1
> Rejected Count 0
> Released Count 0
> Modified Count 0
> Ingress Count 19
> Egress Count 17
> Transit Count 0
> Deliveries from Route Container 0
> Deliveries to Route Container 0
> {noformat}
> The Ingress Count should be more than 200. We had all the credit we need to
> send 200 messages.
> # The messages are stuck inside the proton buffer. The router stopped
> fetching the messages from the proton buffer as soon as the q2_holdoff limit
> was hit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
