[jira] [Commented] (DISPATCH-339) The change from 'routerId' to 'id' and 'addr' to 'host' configuration option is not backwards compatible

2016-05-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299987#comment-15299987
 ] 

ASF GitHub Bot commented on DISPATCH-339:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/78


> The change from 'routerId' to 'id' and 'addr' to 'host' configuration option 
> is not backwards compatible
> 
>
> Key: DISPATCH-339
> URL: https://issues.apache.org/jira/browse/DISPATCH-339
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.0
>Reporter: Jiri Danek
>Assignee: Ganesh Murthy
> Fix For: 0.6.0
>
> Attachments: ra.conf, ra_.conf, ra_local.conf, rb.conf, rb_.conf, 
> rb_local.conf
>
>
> I started qdrouterd with the following configuration
> {noformat}
> router {
> mode: interior
> routerId: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> {noformat}
> Running qdstat then prints that Router id is None.
> {code:title=qdstat -g|borderStyle=solid}
> Router Statistics
>   attr   value
>   =
>   Mode   interior
>   Area   0
>   Router Id  None
>   Address Count  0
>   Link Count 0
>   Node Count 0
> {code}
> Other commands, for example
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> work correctly in this respect.
> If I update my config and use {{id}} instead of {{routerId}}, then qdstat 
> prints correct information.
> I'd expect that the config that worked before the routerId/id change would 
> continue working.
> If I use {{addr}} in my connectors, then my router does not connect to other 
> routers. I had to update the config to using {{host}} and only then it worked 
> for me.
> {noformat}
> router {
> mode: interior
> id: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> connector {
> name: to.r.b
> addr: {{ rb_ip }}
> port: 50001
> role: inter-router
> }
> {noformat}
> {noformat}
> router {
> mode: interior
> id: r.b
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> listener {
> role: inter-router
> addr: 0.0.0.0
> port: 50001
> authenticatePeer: no
> }
> {noformat}
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> After I change addr to host and restart both routers,
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)-
>   r.b- 1
> {code}
> NOTE: I noticed that if I use routerId or addr, no deprecation warning is 
> shown in qdrouterd output with the default log level. As far as I can 
> remember, there are deprecation warnings for some features like fixedAddress, 
> I think.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-339) The change from 'routerId' to 'id' and 'addr' to 'host' configuration option is not backwards compatible

2016-05-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299986#comment-15299986
 ] 

ASF subversion and git services commented on DISPATCH-339:
--

Commit 87d0a406c64e6b4a94c009064c8526f1932fd846 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=87d0a40 ]

DISPATCH-339 - [From Ganesh Murthy] Properly handle default values for 
host/addr.
This closes #78


> The change from 'routerId' to 'id' and 'addr' to 'host' configuration option 
> is not backwards compatible
> 
>
> Key: DISPATCH-339
> URL: https://issues.apache.org/jira/browse/DISPATCH-339
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.0
>Reporter: Jiri Danek
>Assignee: Ganesh Murthy
> Fix For: 0.6.0
>
> Attachments: ra.conf, ra_.conf, ra_local.conf, rb.conf, rb_.conf, 
> rb_local.conf
>
>
> I started qdrouterd with the following configuration
> {noformat}
> router {
> mode: interior
> routerId: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> {noformat}
> Running qdstat then prints that Router id is None.
> {code:title=qdstat -g|borderStyle=solid}
> Router Statistics
>   attr   value
>   =
>   Mode   interior
>   Area   0
>   Router Id  None
>   Address Count  0
>   Link Count 0
>   Node Count 0
> {code}
> Other commands, for example
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> work correctly in this respect.
> If I update my config and use {{id}} instead of {{routerId}}, then qdstat 
> prints correct information.
> I'd expect that the config that worked before the routerId/id change would 
> continue working.
> If I use {{addr}} in my connectors, then my router does not connect to other 
> routers. I had to update the config to using {{host}} and only then it worked 
> for me.
> {noformat}
> router {
> mode: interior
> id: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> connector {
> name: to.r.b
> addr: {{ rb_ip }}
> port: 50001
> role: inter-router
> }
> {noformat}
> {noformat}
> router {
> mode: interior
> id: r.b
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> listener {
> role: inter-router
> addr: 0.0.0.0
> port: 50001
> authenticatePeer: no
> }
> {noformat}
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> After I change addr to host and restart both routers,
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)-
>   r.b- 1
> {code}
> NOTE: I noticed that if I use routerId or addr, no deprecation warning is 
> shown in qdrouterd output with the default log level. As far as I can 
> remember, there are deprecation warnings for some features like fixedAddress, 
> I think.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-339) The change from 'routerId' to 'id' and 'addr' to 'host' configuration option is not backwards compatible

2016-05-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296397#comment-15296397
 ] 

ASF GitHub Bot commented on DISPATCH-339:
-

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/78

DISPATCH-339 - Set the correct value of config->host from the values …

…in host/addr

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-339

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit 56058f04dc9adb157aa4df5efe650ebbb09df69b
Author: Ganesh Murthy 
Date:   2016-05-23T14:03:47Z

DISPATCH-339 - Set the correct value of config->host from the values in 
host/addr




> The change from 'routerId' to 'id' and 'addr' to 'host' configuration option 
> is not backwards compatible
> 
>
> Key: DISPATCH-339
> URL: https://issues.apache.org/jira/browse/DISPATCH-339
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.0
>Reporter: Jiri Danek
>Assignee: Ganesh Murthy
> Fix For: 0.6.0
>
> Attachments: ra.conf, ra_.conf, ra_local.conf, rb.conf, rb_.conf, 
> rb_local.conf
>
>
> I started qdrouterd with the following configuration
> {noformat}
> router {
> mode: interior
> routerId: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> {noformat}
> Running qdstat then prints that Router id is None.
> {code:title=qdstat -g|borderStyle=solid}
> Router Statistics
>   attr   value
>   =
>   Mode   interior
>   Area   0
>   Router Id  None
>   Address Count  0
>   Link Count 0
>   Node Count 0
> {code}
> Other commands, for example
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> work correctly in this respect.
> If I update my config and use {{id}} instead of {{routerId}}, then qdstat 
> prints correct information.
> I'd expect that the config that worked before the routerId/id change would 
> continue working.
> If I use {{addr}} in my connectors, then my router does not connect to other 
> routers. I had to update the config to using {{host}} and only then it worked 
> for me.
> {noformat}
> router {
> mode: interior
> id: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> connector {
> name: to.r.b
> addr: {{ rb_ip }}
> port: 50001
> role: inter-router
> }
> {noformat}
> {noformat}
> router {
> mode: interior
> id: r.b
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> listener {
> role: inter-router
> addr: 0.0.0.0
> port: 50001
> authenticatePeer: no
> }
> {noformat}
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> After I change addr to host and restart both routers,
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)-
>   r.b- 1
> {code}
> NOTE: I noticed that if I use routerId or addr, no deprecation warning is 
> shown in qdrouterd output with the default log level. As far as I can 
> remember, there are deprecation warnings for some features like fixedAddress, 
> I think.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-339) The change from 'routerId' to 'id' and 'addr' to 'host' configuration option is not backwards compatible

2016-05-18 Thread Ganesh Murthy (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289174#comment-15289174
 ] 

Ganesh Murthy commented on DISPATCH-339:


At this time, we are unable to add log warning messages if addr is used instead 
of host. But the rest of this issue has been fixed.

> The change from 'routerId' to 'id' and 'addr' to 'host' configuration option 
> is not backwards compatible
> 
>
> Key: DISPATCH-339
> URL: https://issues.apache.org/jira/browse/DISPATCH-339
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.0
>Reporter: Jiri Danek
>Assignee: Ganesh Murthy
> Fix For: 0.6.0
>
> Attachments: ra.conf, ra_.conf, rb.conf, rb_.conf
>
>
> I started qdrouterd with the following configuration
> {noformat}
> router {
> mode: interior
> routerId: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> {noformat}
> Running qdstat then prints that Router id is None.
> {code:title=qdstat -g|borderStyle=solid}
> Router Statistics
>   attr   value
>   =
>   Mode   interior
>   Area   0
>   Router Id  None
>   Address Count  0
>   Link Count 0
>   Node Count 0
> {code}
> Other commands, for example
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> work correctly in this respect.
> If I update my config and use {{id}} instead of {{routerId}}, then qdstat 
> prints correct information.
> I'd expect that the config that worked before the routerId/id change would 
> continue working.
> If I use {{addr}} in my connectors, then my router does not connect to other 
> routers. I had to update the config to using {{host}} and only then it worked 
> for me.
> {noformat}
> router {
> mode: interior
> id: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> connector {
> name: to.r.b
> addr: {{ rb_ip }}
> port: 50001
> role: inter-router
> }
> {noformat}
> {noformat}
> router {
> mode: interior
> id: r.b
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> listener {
> role: inter-router
> addr: 0.0.0.0
> port: 50001
> authenticatePeer: no
> }
> {noformat}
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> After I change addr to host and restart both routers,
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)-
>   r.b- 1
> {code}
> NOTE: I noticed that if I use routerId or addr, no deprecation warning is 
> shown in qdrouterd output with the default log level. As far as I can 
> remember, there are deprecation warnings for some features like fixedAddress, 
> I think.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-339) The change from 'routerId' to 'id' and 'addr' to 'host' configuration option is not backwards compatible

2016-05-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289171#comment-15289171
 ] 

ASF subversion and git services commented on DISPATCH-339:
--

Commit 0cc6b2ca6701e24161781c01a33c92ab9ef16aa7 in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=0cc6b2c ]

DISPATCH-339 - Modified tools/qdstat to display proper router_id. Added warning 
log message if routerId is used


> The change from 'routerId' to 'id' and 'addr' to 'host' configuration option 
> is not backwards compatible
> 
>
> Key: DISPATCH-339
> URL: https://issues.apache.org/jira/browse/DISPATCH-339
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.0
>Reporter: Jiri Danek
>Assignee: Ganesh Murthy
> Fix For: 0.6.0
>
> Attachments: ra.conf, ra_.conf, rb.conf, rb_.conf
>
>
> I started qdrouterd with the following configuration
> {noformat}
> router {
> mode: interior
> routerId: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> {noformat}
> Running qdstat then prints that Router id is None.
> {code:title=qdstat -g|borderStyle=solid}
> Router Statistics
>   attr   value
>   =
>   Mode   interior
>   Area   0
>   Router Id  None
>   Address Count  0
>   Link Count 0
>   Node Count 0
> {code}
> Other commands, for example
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> work correctly in this respect.
> If I update my config and use {{id}} instead of {{routerId}}, then qdstat 
> prints correct information.
> I'd expect that the config that worked before the routerId/id change would 
> continue working.
> If I use {{addr}} in my connectors, then my router does not connect to other 
> routers. I had to update the config to using {{host}} and only then it worked 
> for me.
> {noformat}
> router {
> mode: interior
> id: r.a
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> connector {
> name: to.r.b
> addr: {{ rb_ip }}
> port: 50001
> role: inter-router
> }
> {noformat}
> {noformat}
> router {
> mode: interior
> id: r.b
> }
> listener {
> addr: 0.0.0.0
> port: amqp
> authenticatePeer: no
> }
> listener {
> role: inter-router
> addr: 0.0.0.0
> port: 50001
> authenticatePeer: no
> }
> {noformat}
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)
> {code}
> After I change addr to host and restart both routers,
> {code:title=qdstat -n|borderStyle=solid}
> Routers in the Network
>   router-id  next-hop  link
>   ===
>   r.a(self)-
>   r.b- 1
> {code}
> NOTE: I noticed that if I use routerId or addr, no deprecation warning is 
> shown in qdrouterd output with the default log level. As far as I can 
> remember, there are deprecation warnings for some features like fixedAddress, 
> I think.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org