[jira] Commented: (QPID-976) Add wider SASL support to c++ client

[Gordon Sim (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661949#action_12661949
 ] 

Gordon Sim commented on QPID-976:
-

Ted, thats an excellent patch! I hadn't realised the library worked like that. 
I've applied your patch as r732691; thanks for that!

 Add wider SASL support to c++ client
 

 Key: QPID-976
 URL: https://issues.apache.org/jira/browse/QPID-976
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Client
Affects Versions: M3
Reporter: Gordon Sim
Assignee: Gordon Sim
 Attachments: sasl.diff




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (QPID-976) Add wider SASL support to c++ client

[Ted Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661727#action_12661727
 ] 

Ted Ross commented on QPID-976:
---

Gordon,

I've attached a patch to this issue for your review.

It removes the handling of empty usernames and leaves that up to the SASL 
library.  It turns out that if you leave off the user/authorize callbacks, SASL 
will do the right default thing based on the context.

For PLAIN, it will use the results of get_login (like your code did).

For GSSAPI, it will use the current Kerberos principal (i.e. the current kinit).

-Ted


 Add wider SASL support to c++ client
 

 Key: QPID-976
 URL: https://issues.apache.org/jira/browse/QPID-976
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Client
Affects Versions: M3
Reporter: Gordon Sim
Assignee: Gordon Sim
 Attachments: sasl.diff




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.