Re: [C++] Getting rid of file:line in QPID_MSG

2014-01-30 Thread Alan Conway
it leaving the rest alone? Yes, that is probably the right thing to do. Thanks for the input. - Original Message - From: Alan Conway acon...@redhat.com To: dev dev@qpid.apache.org Sent: Wednesday, January 29, 2014 11:45:33 AM Subject: [C++] Getting rid of file:line in QPID_MSG

Re: [C++] Getting rid of file:line in QPID_MSG

2014-01-30 Thread Alan Conway
On Wed, 2014-01-29 at 11:10 -0600, Kerry Bonin wrote: FWIW, I've been bit in the past when I tried this, when a small subset of our messages were generic enough that we got multiple hits, and the developer performing the search guessed incorrectly which was the actual source location. OK,

[C++] Getting rid of file:line in QPID_MSG

2014-01-29 Thread Alan Conway
There's a convenience macro QPID_MSG in qpid/cpp/src/qpid/Msg.h that is used to format exception messages all over the place. The current implementation includes the filename:line source location where the macro is used. I propose to take the filename:line out. It is not necessary for

Re: [C++] Getting rid of file:line in QPID_MSG

2014-01-29 Thread Kerry Bonin
FWIW, I've been bit in the past when I tried this, when a small subset of our messages were generic enough that we got multiple hits, and the developer performing the search guessed incorrectly which was the actual source location. On Wed, Jan 29, 2014 at 10:45 AM, Alan Conway acon...@redhat.com

RE: [C++] Getting rid of file:line in QPID_MSG

2014-01-29 Thread Steve Huston
I prefer to have the information. It's pretty easy to specify nothing more than the exception text which is hard to grep for. -Original Message- From: Alan Conway [mailto:acon...@redhat.com] Sent: Wednesday, January 29, 2014 11:46 AM To: dev Subject: [C++] Getting rid of file:line

Re: [C++] Getting rid of file:line in QPID_MSG

2014-01-29 Thread Michael Goulish
Oh, but I love that feature! And isn't it anyway off by default if we do not set --log-source ? - Original Message - There's a convenience macro QPID_MSG in qpid/cpp/src/qpid/Msg.h that is used to format exception messages all over the place. The current implementation includes the

Re: [C++] Getting rid of file:line in QPID_MSG

2014-01-29 Thread Chuck Rolke
acon...@redhat.com To: dev dev@qpid.apache.org Sent: Wednesday, January 29, 2014 11:45:33 AM Subject: [C++] Getting rid of file:line in QPID_MSG There's a convenience macro QPID_MSG in qpid/cpp/src/qpid/Msg.h that is used to format exception messages all over the place. The current