[GitHub] astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr

2019-02-20 Thread GitBox
astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr URL: https://github.com/apache/qpid-proton/pull/176#issuecomment-465784333 How about something like (compiles and passes tests with valgrind, but not tested with sanitisers or

[GitHub] astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr

2019-02-20 Thread GitBox
astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr URL: https://github.com/apache/qpid-proton/pull/176#issuecomment-465646443 Thinking more... > I don't think this is the correct fix. There is no problem using strncat that

[GitHub] astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr

2019-02-20 Thread GitBox
astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr URL: https://github.com/apache/qpid-proton/pull/176#issuecomment-465636973 I don't think this is the correct fix. There is no problem using strncat that requires inventing a new (and