[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...

2018-06-25 Thread fgiorgetti 
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/327
  
It covers everything now!


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...

2018-06-22 Thread ganeshmurthy 
Github user ganeshmurthy commented on the issue:

https://github.com/apache/qpid-dispatch/pull/327
  
Good catch. Not sure how I missed that. I will add anew test for 
acceptedDeliveries and will let you know


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...

2018-06-22 Thread fgiorgetti 
Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/327
  
@ganeshmurthy it looks great to me. One thing I noticed is that the only 
new metric that is not present in this test is: "acceptedDeliveries". But I see 
it being used in system_tests_one_router.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...

2018-06-22 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/qpid-dispatch/pull/327
  
# 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr=h1) 
Report
> Merging 
[#327](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/2e766f35cf2b3a172aaa58cef6c996376e69f1c9?src=pr=desc)
 will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/327/graphs/tree.svg?width=650=150=pr=rk2Cgd27pP)](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #327  +/-   ##
==
+ Coverage   86.52%   86.54%   +0.01% 
==
  Files  69   69  
  Lines   1547915479  
==
+ Hits1339313396   +3 
+ Misses   2086 2083   -3
```


| [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/327/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `94.57% <0%> (+0.14%)` | :arrow_up: |
| 
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/327/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
 | `99.25% <0%> (+0.37%)` | :arrow_up: |
| 
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/327/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
 | `63.79% <0%> (+0.57%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr=footer).
 Last update 
[2e766f3...4c9e6d9](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org