Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/20
For later reference, a related further change was made via
b3a66b741c34b40b059fc023b3c7650720dfc001 to apply the optimisation in more
cases.
---
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/20
I've pushed an updated version of the change with a fix for the offset
issue I noticed yesterday, which Tim added a test to cover.
---
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/20
Can you unwind the 'revert' of my currentPos -> origPos variable name
change from earlier? :)
---
-
To unsubscribe,
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/20
Checked in with infra who looked into it and found the issue, mirror is now
back up to date.
---
-
To unsubscribe,
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/20
It seems the github mirror is not up to date, and I've since prodded a
re-sync and it still isn't up to date. I'll possibly need to ask infra about it
after lunch.
---
Github user franz1981 commented on the issue:
https://github.com/apache/qpid-proton-j/pull/20
@gemmellr np Robbie! I believe that's better to have it handled separately
:+1:
---
-
To unsubscribe, e-mail:
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/20
The reset is a good catch. Its a noteworthy bug in its own right and so
should be fixed separately, and also tested. I have done that now via
PROTON-1966. Sorry for the hassle @franz1981 but
Github user tabish121 commented on the issue:
https://github.com/apache/qpid-proton-j/pull/20
@franz1981 Looks good so far, would like to see the formatting changed to
match the remainder of the code. The reset is a good catch, that is a bug in
the current code.
---
