[GitHub] qpid-proton issue #81: PROTON-1303: Replace go binding URL parser with versi...
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/81 You're right, godoc takes a host:port not a URL. Ship It. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #81: PROTON-1303: Replace go binding URL parser with versi...
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/81 ":1234" is not allowed by the go URL parser - that is what is rejecting it. It gets rejected before our code has anything to do with it. [That is because it is invalid as a URL - you can't have a leading ":" without a scheme. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #81: PROTON-1303: Replace go binding URL parser with versi...
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/81 OOps no: I don't like that this is not allowed ":1234" becase it *is* allowed by the go URL parser and is correctly interpreted as "listen on all interfaces" or "connect to localhost" by the go runtimes. It is commonly used in go documentation, e.g .the standard way to start the godoc webserver is godoc -http :6060 I'm starting to feel that there isn't much/any need for a special URL parser if we simply provide the Update function to fill in defaults. Then we don't have to do anything to mess with parsing/what is acceptable as a URL, we just provide AMQP info - which is our job --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #81: PROTON-1303: Replace go binding URL parser with versi...
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/81 @alanconway Did you note the change in meaning for a few URLs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
