[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

[astitcher]

Github user astitcher commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/115#discussion_r132225370
  
--- Diff: proton-c/bindings/php/CMakeLists.txt ---
@@ -34,7 +34,7 @@ list(APPEND SWIG_MODULE_cproton_EXTRA_DEPS
 ${CMAKE_SOURCE_DIR}/proton-c/include/proton/cproton.i
 ${PROTON_HEADERS}
 )
-swig_add_module(cproton php ${CMAKE_CURRENT_SOURCE_DIR}/php.i)
+swig_add_library(cproton LANGUAGE php SOURCES 
${CMAKE_CURRENT_SOURCE_DIR}/php.i)
--- End diff --

Not directly related to your change, but I think the 
${CMAKE_CURRENT_SOURCE_DIR} is extraneous here and is different from all the 
other uses of swig_add_library in the other bindings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #115: PROTON-1533: Fix swig deprecation warnings

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/115

PROTON-1533: Fix swig deprecation warnings

For review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #115


commit 7fa4bf7be0f7e5cf6e43683a3294675df908f46c
Author: Justin Ross 
Date:   2017-08-08T23:49:31Z

Use swig_add_library instead of the now deprecated swig_add_module; provide 
a fallback impl

commit 5c2b1529e610171172565eb802cec8102a9e48be
Author: Justin Ross 
Date:   2017-08-09T00:07:42Z

Correct a cmake test expression

commit 04c07670a445ceb7188a56070c5141e8bded56a0
Author: Justin Ross 
Date:   2017-08-09T12:02:24Z

Remove extraneous macro definition




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org