[ https://issues.apache.org/jira/browse/QPID-8102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373108#comment-16373108 ]
Keith Wall edited comment on QPID-8102 at 2/22/18 5:26 PM: ----------------------------------------------------------- Alex - here are my review comments: # In the new Node Auto Creation Policy table on the virtualhost tab, the rendering of attributes does not escape the content, so I am able to inject markup/script into the browser. # Node Auto Creation Policy dialogue ## When editing an existing policy it is possible to create a new one by changing its name. Perhaps we should make the name immutable? ## Pattern field - missing promptMessage. We should explain that new nodes with names matching this pattern will be created automatically. ## Pattern field - the placeholder text is misleading ## Node type field - missing promptMessage. ## Attributes - nothing explains to the user what these attributes are used for (or what attributes would be understood) ## The select all checkbox does not work was (Author: k-wall): # In the new Node Auto Creation Policy table on the virtualhost tab, the rendering of attributes does not escape the content, so I am able to inject markup/script into the browser. # Node Auto Creation Policy dialogue ## When editing an existing policy it is possible to create a new one by changing its name. Perhaps we should make the name immutable? ## Pattern field - missing promptMessage. We should explain that new nodes with names matching this pattern will be created automatically. ## Pattern field - the placeholder text is misleading ## Node type field - missing promptMessage. ## Attributes - nothing explains to the user what these attributes are used for (or what attributes would be understood) ## The select all checkbox does not work > [Broker-j][Web Management Console] Add UI for virtual host node auto-creation > policies > -------------------------------------------------------------------------------------- > > Key: QPID-8102 > URL: https://issues.apache.org/jira/browse/QPID-8102 > Project: Qpid > Issue Type: Improvement > Components: Broker-J > Reporter: Alex Rudyy > Assignee: Keith Wall > Priority: Major > Fix For: qpid-java-broker-7.0.2, qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8102-Broker-J-Add-UI-for-virtual-host-node-auto.patch > > > Add UI to view/create/delete/modify virtual host node auto-creation policies -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org