[jira] [Commented] (QPID-2720) Qpid broker can not run inside an OSGi container
[
https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091700#comment-13091700
]
Keith Wall commented on QPID-2720:
--
I think this commit is causing a NPE stack trace to be logged when running some
tests (during tearDown). It is not causing test failure as the exception is
being swallowed. I'm seeing it when running ServerConfigurationTest, but I'm
sure I see it elsewhere too.
{code}
main 2011-08-26 11:12:59,056 ERROR [qpid.server.registry.ApplicationRegistry]
Error thrown whilst closing PluginManager
java.lang.NullPointerException
at
org.apache.qpid.server.plugins.PluginManager.close(PluginManager.java:356)
at
org.apache.qpid.server.registry.ApplicationRegistry.close(ApplicationRegistry.java:443)
at
org.apache.qpid.server.registry.ApplicationRegistry.close(ApplicationRegistry.java:478)
at
org.apache.qpid.server.registry.ApplicationRegistry.remove(ApplicationRegistry.java:203)
at
org.apache.qpid.server.configuration.ServerConfigurationTest.tearDown(ServerConfigurationTest.java:58)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:132)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518)
at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052)
at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906)
{code}
Qpid broker can not run inside an OSGi container
Key: QPID-2720
URL: https://issues.apache.org/jira/browse/QPID-2720
Project: Qpid
Issue Type: Bug
Components: Java Broker
Reporter: Danushka Menikkumbura
Assignee: Danushka Menikkumbura
Fix For: 0.13
Attachments: QPID-2720-V2.patch, QPID-2720-V3.patch, QPID-2720.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-2720) Qpid broker can not run inside an OSGi container
[ https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091800#comment-13091800 ] Robbie Gemmell commented on QPID-2720: -- That could happen if the PluginManager wasn't fully initialized when it was shut down (as would probably happen in some of the tests). I have checked in a fix to prevent the NPE by iterating a list of the ServiceTrackers, which would be empty in that case. Qpid broker can not run inside an OSGi container Key: QPID-2720 URL: https://issues.apache.org/jira/browse/QPID-2720 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Danushka Menikkumbura Assignee: Danushka Menikkumbura Fix For: 0.13 Attachments: QPID-2720-V2.patch, QPID-2720-V3.patch, QPID-2720.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-2720) Qpid broker can not run inside an OSGi container
[ https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063902#comment-13063902 ] Robbie Gemmell commented on QPID-2720: -- Hi Danushka, The work I have referenced in some of your other JIRAs, refactoring of the broker startup via QPID-2815, would seem to offer a way to resolve the above issue with your patch. Instead of using a static method to manipulate the PluginManager directly, you could add a method on the BrokerOptions object to pass the context, or alternatively an instance method to the Broker object that could be used to set the BundleContext before starting the instance, which could then be provided to/sourced by the PluginManager for that Broker instance. This would allow leveraging the new Broker + BrokerOptions combination as a singluar front end for starting the broker and configuring it to function as desired. Regards, Robbie Qpid broker can not run inside an OSGi container Key: QPID-2720 URL: https://issues.apache.org/jira/browse/QPID-2720 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Danushka Menikkumbura Assignee: Robbie Gemmell Fix For: 0.13 Attachments: QPID-2720-V2.patch, QPID-2720-V3.patch, QPID-2720.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-2720) Qpid broker can not run inside an OSGi container
[ https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055679#comment-13055679 ] Danushka Menikkumbura commented on QPID-2720: - Hi Sorin, In fact having our own bundle activator is not really necessary. It is up to the bundle writer to decide on the shape of bundle activator (declarative service vs. bundle activator for an example). I am attaching a patch (rev. 1138752) without the activator. Thanks, Danushka Qpid broker can not run inside an OSGi container Key: QPID-2720 URL: https://issues.apache.org/jira/browse/QPID-2720 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Danushka Menikkumbura Assignee: Andrew Kennedy Fix For: 0.11 Attachments: QPID-2720-V2.patch, QPID-2720.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-2720) Qpid broker can not run inside an OSGi container
[ https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055682#comment-13055682 ] Danushka Menikkumbura commented on QPID-2720: - Patch name - QPID-2720-V3.patch Qpid broker can not run inside an OSGi container Key: QPID-2720 URL: https://issues.apache.org/jira/browse/QPID-2720 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Danushka Menikkumbura Assignee: Andrew Kennedy Fix For: 0.11 Attachments: QPID-2720-V2.patch, QPID-2720-V3.patch, QPID-2720.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2720) Qpid broker can not run inside an OSGi container
[ https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12890767#action_12890767 ] Sorin Suciu commented on QPID-2720: --- Hi Danushka, We already have an org.apache.qpid.server.virtualhost.plugin.Activator which would be called by OSGI. Could we implement the same logic like you have in QpidActivator (eg detect whether we are embedded in an OSGI framework and proceed accordingly)? This would avoid duplication and make things clearer and cleaner. We could possibly move it to a different package in the future to eliminate any confusion. How do you plan to start the broker and process the configuration? Lets have a chat on the list on this topic. Thanks, Sorin Qpid broker can not run inside an OSGi container Key: QPID-2720 URL: https://issues.apache.org/jira/browse/QPID-2720 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Danushka Menikkumbura Assignee: Danushka Menikkumbura Attachments: QPID-2720-V2.patch, QPID-2720.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2720) Qpid broker can not run inside an OSGi container
[ https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12885523#action_12885523 ] Danushka Menikkumbura commented on QPID-2720: - How to make Qpid broker run inside an OSGi container? Use newly added QpidActivator as the bundle activator when bundling Qpid. Thanks, Danushka Qpid broker can not run inside an OSGi container Key: QPID-2720 URL: https://issues.apache.org/jira/browse/QPID-2720 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Danushka Menikkumbura Assignee: Danushka Menikkumbura Attachments: QPID-2720.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
