[GitHub] incubator-quickstep pull request #170: Add unit test for CatalogRelationStat...

2017-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #170: Add unit test for CatalogRelationStat...

2017-01-29 Thread jianqiao
Github user jianqiao closed the pull request at: https://github.com/apache/incubator-quickstep/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep issue #170: Add unit test for CatalogRelationStatistics

2017-01-29 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/170 Updated. Now closing and reopening the PR to restart travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-quickstep pull request #170: Add unit test for CatalogRelationStat...

2017-01-29 Thread jianqiao
GitHub user jianqiao reopened a pull request: https://github.com/apache/incubator-quickstep/pull/170 Add unit test for CatalogRelationStatistics This PR adds unit tests for CatalogRelationStatistics. It tests that the `\analyze` command can produce correct stats, and that the

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98383705 --- Diff: query_optimizer/rules/ReorderColumns.cpp --- @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98385758 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -20,6 +20,7 @@ #include "relational_operators/HashJoinOperator.hpp"

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98384243 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -63,6 +65,9 @@ namespace quickstep { namespace { +typedef

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98385208 --- Diff: query_optimizer/rules/ReorderColumns.cpp --- @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98384533 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -484,7 +565,38 @@ void HashInnerJoinWorkOrder::execute() { const relation_id

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98384815 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -504,123 +616,61 @@ void HashInnerJoinWorkOrder::execute() { // hash join is

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98385945 --- Diff: relational_operators/HashJoinOperator.cpp --- @@ -504,123 +616,61 @@ void HashInnerJoinWorkOrder::execute() { // hash join is

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98385665 --- Diff: query_optimizer/rules/ReorderColumns.hpp --- @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98383321 --- Diff: query_optimizer/rules/ReorderColumns.cpp --- @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/171#discussion_r98383388 --- Diff: query_optimizer/PhysicalGenerator.cpp --- @@ -109,6 +114,13 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() { } else {

[GitHub] incubator-quickstep pull request #170: Add unit test for CatalogRelationStat...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/170#discussion_r98382386 --- Diff: catalog/tests/CatalogRelationStatistics_unittest.cpp --- @@ -0,0 +1,214 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] incubator-quickstep pull request #170: Add unit test for CatalogRelationStat...

2017-01-29 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/170#discussion_r98371746 --- Diff: catalog/tests/CatalogRelationStatistics_unittest.cpp --- @@ -0,0 +1,214 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] incubator-quickstep pull request #169: Documentation update after third part...

2017-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread jianqiao
GitHub user jianqiao reopened a pull request: https://github.com/apache/incubator-quickstep/pull/171 QUICKSTEP-68 Reorder intermediate relations' attributes to improve copy performance. Currently, all the intermediate relations (i.e. temporary relations created during query

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread jianqiao
Github user jianqiao closed the pull request at: https://github.com/apache/incubator-quickstep/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #172: Query optimization with ExactFilter

2017-01-29 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/172 Query optimization with ExactFilter This is a follow-up optimization based on the facility provided by LIPFilters. Note that LIP (lookahead information passing) is an optimization

[GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...

2017-01-29 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/171 QUICKSTEP-68 Reorder intermediate relations' attributes to improve copy performance. Currently, all the intermediate relations (i.e. temporary relations created during query

[GitHub] incubator-quickstep issue #170: Add unit test for CatalogRelationStatistics

2017-01-29 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/170 Assigned to @zuyu. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #170: Add unit test for CatalogRelationStat...

2017-01-29 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/170 Add unit test for CatalogRelationStatistics This PR adds unit tests for CatalogRelationStatistics. It tests that the `\analyze` command can produce correct stats, and that the