Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/355
Hi @jianqiao
I have rebased and addressed style concerns by @zuyu. Thanks!
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/355
@hbdeshmukh Hi Harshad, can you rebase the branch so I can help merge this
PR.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/355
LGTM!
---
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/355
Hi @zuyu I have made the changes. The code in this PR will be invoked only
with a compile time flag ENABLE_NETWORK_CLI. Earlier it was dependent on
ENABLE_DISTRIBUTED, which was not c
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/355
Right now, the new code is included only in the distributed version. It
need not be the case, as the only dependency for Data Provider Thread is for
GRPC and Networked TMB.
---
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/355
We do not test the distributed version in CI due to previous time-out issue
while installing `grpc` by source code.
---
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/355
@zuyu Question: How do you run tests for distributed quickstep on Travis?
---
