Github user hakanmemisoglu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/98
I will close this PR since an issue in the compression code should be
handled first.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/98
> For the efficiency part:
1-) Using new comparison operators obviously are faster than old
counterparts using if else statements. (Of course the overall effect might not
be fast as we
Github user hakanmemisoglu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/98
@zuyu This will be merged after @hbdeshmukh's changes. Since we are use
rebasing, I don't think it will be a problem.
For the efficiency part:
1-) Using new comparison
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/98
@hbdeshmukh I guess the possible performance improvements come from a)
using `DateLit` instead of `DatetimeLit`, b) a better implementation of
`Extract` function, but not the internal
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/98
@hakanmemisoglu My 2 cents:
1. IMHO, such `DateLit` encode is not necessary, as inside `TypedValue` it
stores in a 64-byte `union` space.
2. This PR shares many changes with
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/98
Nice observation and enhancement @hakanmemisoglu!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
