Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/239#discussion_r113015464
--- Diff: storage/AggregationOperationState.cpp ---
@@ -715,7 +719,18 @@ void AggregationOperationState::finalizeHashTable(
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/239#discussion_r112991169
--- Diff: storage/ThreadPrivateCompactKeyHashTable.cpp ---
@@ -0,0 +1,422 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/239#discussion_r112884563
--- Diff: storage/ThreadPrivateCompactKeyHashTable.cpp ---
@@ -0,0 +1,422 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/239#discussion_r112882425
--- Diff: storage/ThreadPrivateCompactKeyHashTable.cpp ---
@@ -0,0 +1,422 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/239#discussion_r112881164
--- Diff: storage/HashTablePool.hpp ---
@@ -75,6 +75,10 @@ class HashTablePool {
handles_(handles),
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/239
Add ThreadPrivateCompactKeyHashTable for aggregation.
This PR implements a new specialized aggregation hash table that is
preferable for two-phase (i.e. aggregate locally and then
