[GitHub] incubator-quickstep issue #131: Unified WorkOrderCompletionMessage proto.

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/131 Yes, and if there is a new field dedicated to one case, say `RebuildWorkOrder`, we would create the new protobuf message extending `WorkOrderCompletionMessage` as following: ```

[GitHub] incubator-quickstep issue #131: Unified WorkOrderCompletionMessage proto.

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/131 @hbdeshmukh Note that beside your quote, there is also another related quote after: > // TODO(harshad) : If there are different fields in the two message types below, //

[GitHub] incubator-quickstep issue #131: Unified WorkOrderCompletionMessage proto.

Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/131 Because lot of branches got merged meanwhile, can you please rebase with master and let me know? I will merge this branch after that. --- If your project is set up for it, you can

[GitHub] incubator-quickstep issue #141: Refactor WorkOrderFactory for a better debug...

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/141 I guess by `warrant` you mean whether it affects others and its correctness. It is only related to the distributed version and `glog` output. --- If your project is set up for it,

[GitHub] incubator-quickstep issue #141: Refactor WorkOrderFactory for a better debug...

Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/141 LGTM. I image debugging the distributed version is difficult and I am guessing that is what this is related to. Was this change warranted by anything specific? --- If your

[GitHub] incubator-quickstep issue #129: Partial inserts

Github user navsan commented on the issue: https://github.com/apache/incubator-quickstep/pull/129 That’s usually an out-of-memory error. > On Nov 18, 2016, at 12:35, Marc S wrote: > > Has this error happened to anyone before on Travis

[GitHub] incubator-quickstep issue #140: Refactor Shiftboss for better debug info.

Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/140 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-quickstep pull request #138: Ethernet data exchanger.

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/138#discussion_r88716447 --- Diff: utility/NetworkUtil.cpp --- @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] incubator-quickstep issue #129: Partial inserts

Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/129 Has this error happened to anyone before on Travis @hbdeshmukh @hakanmemisoglu @zuyu ? ``` [ 64%] Building CXX object

[GitHub] incubator-quickstep pull request #141: Refactor WorkOrderFactory for a bette...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #140: Refactor Shiftboss for better debug i...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep issue #129: Partial inserts

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/129 Hi @cramja, Since @hbdeshmukh has signed off for this PR, and the CI has only the system failures, not related to your changes, it should be good to merge. Before doing

[GitHub] incubator-quickstep issue #141: Refactor WorkOrderFactory for a better debug...

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/141 Yes, it helped me debug the distributed query execution for queries with hash-joins and aggregations so that I know which `WorkOrder` executes on which `Shiftboss`. --- If your project

[GitHub] incubator-quickstep issue #129: Partial inserts

Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/129 It's happening in #140 as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-quickstep issue #131: Unified WorkOrderCompletionMessage proto.

Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/131 Hi Zuyu, We had a discussion about this design earlier and we came up to the conclusion that it serves us better in the future to have different types for normal work order

[GitHub] incubator-quickstep pull request #143: Refactor regarding the profile flag.

GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/143 Refactor regarding the profile flag. Assigned to @jianqiao. This PR simplifies the way to assign the enable_profile flag. You can merge this pull request into a Git repository by

[GitHub] incubator-quickstep issue #129: Partial inserts

Github user hakanmemisoglu commented on the issue: https://github.com/apache/incubator-quickstep/pull/129 @cramja I had the same problem, you are probably trying to push to the read-only Github repo. [Here is the link for the

[GitHub] incubator-quickstep pull request #144: Refactored printWorkOrderProfilingRes...

GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/144 Refactored printWorkOrderProfilingResults in Foreman. Assigned to @hbdeshmukh. This PR allows both `Foreman` implementations would do profiling. You can merge this pull request

[GitHub] incubator-quickstep pull request #145: Used the move semantics in constructi...

GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/145 Used the move semantics in constructing QueryProcessor. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-quickstep

[GitHub] incubator-quickstep issue #129: Partial inserts

Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/129 @hbdeshmukh What is the site you use with directions to merge? I have the following error when I try to push to apache's master: ```