[GitHub] incubator-quickstep pull request #295: Printed out the partition info in Que...

2017-09-14 Thread hbdeshmukh 
Github user hbdeshmukh commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/295#discussion_r138950122
  
--- Diff: query_optimizer/tests/logical_generator/Create.test ---
@@ -63,6 +67,15 @@ PARTITION BY HASH(attr1, attr2, attr3, attr4, attr5, 
attr6) PARTITIONS 4;
 --
 TopLevelPlan
 +-plan=CreateTable[relation=foo]
+| +-partition_scheme_header=ProtoDescription
+| | +-Property=ProtoProperty[Property=partition_type,Value=hash]
+| | +-Property=ProtoProperty[Property=num_partitions,Value=4]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=0]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=1]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=2]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=3]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=4]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=5]
--- End diff --

Is it feasible to get the attribute names instead of their value? That 
might be easier to understand and read. 


---

[GitHub] incubator-quickstep issue #295: Printed out the partition info in QueryPlan.

2017-09-14 Thread hbdeshmukh 
Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/295
  
I have one minor comment, otherwise looks good. 


---

[GitHub] incubator-quickstep issue #271: QUICKSTEP-95: Fixed the exception due to zer...

2017-09-14 Thread jianqiao 
Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/271
  
LGTM. Merging.


---

[GitHub] incubator-quickstep pull request #271: QUICKSTEP-95: Fixed the exception due...

2017-09-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/271


---

[GitHub] incubator-quickstep issue #297: Fixed a bug in partitioned NLJ.

2017-09-14 Thread jianqiao 
Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/297
  
LGTM. Merging.


---

[GitHub] incubator-quickstep pull request #295: Printed out the partition info in Que...

2017-09-14 Thread zuyu 
Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/295#discussion_r138971636
  
--- Diff: query_optimizer/tests/logical_generator/Create.test ---
@@ -63,6 +67,15 @@ PARTITION BY HASH(attr1, attr2, attr3, attr4, attr5, 
attr6) PARTITIONS 4;
 --
 TopLevelPlan
 +-plan=CreateTable[relation=foo]
+| +-partition_scheme_header=ProtoDescription
+| | +-Property=ProtoProperty[Property=partition_type,Value=hash]
+| | +-Property=ProtoProperty[Property=num_partitions,Value=4]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=0]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=1]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=2]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=3]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=4]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=5]
--- End diff --

Here we just print out the internal states.


---

[GitHub] incubator-quickstep issue #295: Printed out the partition info in QueryPlan.

2017-09-14 Thread hbdeshmukh 
Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/295
  
Looks good. 


---

[GitHub] incubator-quickstep pull request #297: Fixed a bug in partitioned NLJ.

2017-09-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/297


---