[GitHub] incubator-quickstep issue #51: Minor changes in profiling work order output.

[hbdeshmukh]

Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/51
  
Fixed the typo. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #51: Minor changes in profiling work order output.

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/51
  
LGTM except for one minor typo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #51: Minor changes in profiling work order ...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/51#discussion_r69846306
  
--- Diff: query_execution/Foreman.cpp ---
@@ -238,16 +238,17 @@ void Foreman::printWorkOrderProfilingResults(const 
std::size_t query_id,
   const std::vector<
   std::tuple>
   _times = policy_enforcer_->getProfilingResults(query_id);
-  fputs("Worker ID, NUMA Socket, Operator ID, Time (microseconds)\n", out);
+  fputs("Query ID,Worker ID,NUMA Socket,Operator ID,Time 
(microseconds)\n", out);
   for (auto workorder_entry : recorded_times) {
 // Note: Index of the "worker thread index" in the tuple is 0.
 const std::size_t worker_id = std::get<0>(workorder_entry);
 fprintf(out,
-"%lu, %d, %lu, %lu\n",
+"%lu,%lu,%d,%lu,%lu\n",
+query_id,
 worker_id,
 worker_directory_->getNUMANode(worker_id),
-std::get<1>(workorder_entry),
-std::get<2>(workorder_entry));
+std::get<1>(workorder_entry),  // Oeprator ID.
--- End diff --

Probably the comment should be `// Operator ID.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #51: Minor changes in profiling work order output.

[hbdeshmukh]

Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/51
  
@jianqiao Can you please review this PR? It's a minor change. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---