[GitHub] incubator-quickstep issue #100: Refactor bulk insert for SplitRowStore

Github user navsan commented on the issue: https://github.com/apache/incubator-quickstep/pull/100 Sounds good! Thanks. On Tue, Sep 20, 2016, 17:22 Marc S wrote: > @navsan love the comments, very thorough. >

[GitHub] incubator-quickstep issue #100: Refactor bulk insert for SplitRowStore

Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/100 @navsan love the comments, very thorough. I updated the header of this PR to include benchmarks/testing info and will keep this in mind in the future. **Changes queued

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79723597 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79723161 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79723030 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79722961 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79722671 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79721010 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep issue #98: QUICKSTEP-53 DateLit improvements

Github user hakanmemisoglu commented on the issue: https://github.com/apache/incubator-quickstep/pull/98 I will close this PR since an issue in the compression code should be handled first. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-quickstep pull request #98: QUICKSTEP-53 DateLit improvements

Github user hakanmemisoglu closed the pull request at: https://github.com/apache/incubator-quickstep/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-quickstep pull request #90: Quickstep 28 29

Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user navsan commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79701889 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user navsan commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79702587 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user navsan commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79702952 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep issue #100: Refactor bulk insert for SplitRowStore

Github user navsan commented on the issue: https://github.com/apache/incubator-quickstep/pull/100 Finally, can you also add support for partialBulkInsert functions? See the commits in my branch for reference. It'll help us improve the join result materialization cost, as well as a

[GitHub] incubator-quickstep issue #100: Refactor bulk insert for SplitRowStore

Github user navsan commented on the issue: https://github.com/apache/incubator-quickstep/pull/100 Please address the comments: mostly to do with performance improvements. Note that the objective here is not just to make SplitRowStore faster than it is today, but to get it to the

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user navsan commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79693915 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -194,379 +257,125 @@ TupleStorageSubBlock::InsertResult

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

Github user navsan commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/100#discussion_r79695934 --- Diff: storage/SplitRowStoreTupleStorageSubBlock.cpp --- @@ -88,6 +88,67 @@ inline std::size_t CalculateVariableSizeWithRemappedAttributes(