[GitHub] incubator-quickstep issue #358: Fix a bug in HashJoinOperator

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/358
  
Tests added. The problematic code would fail on the added tests.


---

[GitHub] incubator-quickstep pull request #355: QUICKSTEP-127 Data provider thread

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/355


---

[GitHub] incubator-quickstep issue #358: Fix a bug in HashJoinOperator

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/358
  
Hold for adding tests to cover these buggy cases to prevent future bugs.


---

[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

[hbdeshmukh]

Github user hbdeshmukh commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
Hi @jianqiao 

I have rebased and addressed style concerns by @zuyu. Thanks! 


---

[GitHub] incubator-quickstep pull request #357: Fixed the command execution bug in th...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/357


---

[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
@hbdeshmukh Hi Harshad, can you rebase the branch so I can help merge this 
PR.


---

[GitHub] incubator-quickstep issue #357: Fixed the command execution bug in the distr...

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/357
  
LGTM!


---

[GitHub] incubator-quickstep issue #355: QUICKSTEP-127 Data provider thread

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/355
  
LGTM!


---

[GitHub] incubator-quickstep pull request #355: QUICKSTEP-127 Data provider thread

[zuyu]

Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/355#discussion_r192827208
  
--- Diff: storage/CMakeLists.txt ---
@@ -120,6 +120,11 @@ configure_file (
 QS_PROTOBUF_GENERATE_CPP(storage_AggregationOperationState_proto_srcs
  storage_AggregationOperationState_proto_hdrs
  AggregationOperationState.proto)
+if (ENABLE_NETWORK_CLI)
+QS_PROTOBUF_GENERATE_CPP(storage_BlockWire_proto_srcs
--- End diff --

Two whitespace indentation, please.

Similarly below.


---