[GitHub] incubator-quickstep pull request #362: Add virtual destructors where needed ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/362


---

[GitHub] incubator-quickstep issue #362: Add virtual destructors where needed to remo...

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/362
  
LGTM. Squash the commits and once the checks pass, I can merge.


---

[GitHub] incubator-quickstep pull request #362: Add virtual destructors where needed ...

[zuyu]

Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/362#discussion_r224539118
  
--- Diff: third_party/src/tmb/tests/message_bus_unittest_common.h ---
@@ -205,7 +207,7 @@ class ConnectorThread : public Thread {
   }
 
  protected:
-  void Run() {
+  void Run() override {
--- End diff --

Add `override` destructors in this file.


---

[GitHub] incubator-quickstep issue #362: Add virtual destructors where needed to remo...

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/362
  
For completeness, please add `override` for the destructors of derived 
classes of `GeneratorFunctionHandle`, `LIPFilter`, and `BaseClass`. Thanks!


---