[GitHub] incubator-quickstep issue #234: Add protobuf support for UNION ALL operator.

2017-04-20 Thread zuyu 
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/234
  
@Terranlee Unfortunately, I observed some non-deterministic results for the 
following two queries in 
`quickstep_queryoptimizer_tests_executiongenerator_select_distributed`.

So I suggest to create a new test for `union` in the single-node mode only.

```
SELECT int_col AS result FROM test
WHERE int_col < 5
UNION
SELECT int_col + 3 AS result FROM test
WHERE int_col < 5;

SELECT float_col FROM test
WHERE int_col < 5
ORDER BY int_col DESC
LIMIT 5
UNION ALL
SELECT float_col FROM test
WHERE int_col < 5
ORDER BY int_col DESC
LIMIT 10
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #234: Add protobuf support for UNION ALL operator.

2017-04-20 Thread jianqiao 
Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/234
  
LGTM! Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #234: Add protobuf support for UNION ALL operator.

2017-04-19 Thread cramja 
Github user cramja commented on the issue:

https://github.com/apache/incubator-quickstep/pull/234
  
LTM if comments are addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---