Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
@zuyu Currently `HashJoinOperator` performance is sensitive to the _number
of build blocks per probe block_ due to the concurrency bottleneck within LRU
policy enforcer.
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
Merging.
---
Github user dylanpbacon commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
This PR is now consistent with the changes @jianqiao made. It is ready to
be merged, I believe. I do not have rights for this yet I think.
---
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
Hi @jianqiao Could you explain more regarding the suspect reason of the
slowdown in the general case (i.e., w/o the threshold)? Thanks!
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
@dylanpbacon Hi Dylan, I updated the LIP related stuff and put it in this
[branch](https://github.com/apache/incubator-quickstep/tree/Hash-Join-Fuse),
you may just fetch the changes to
Github user dylanpbacon commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
Rebased this with master, this branch is now up to date. LIP Filters still
need to be fixed to work properly with this feature.
---
Github user dylanpbacon commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
I believe all bugs have been fixed except the LIPFilter applying to
modified HashJoins. Jianqiao will be taking care of that I think. Below are the
updated benchmark values.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
We need to fix the performance bugs before merging.
| **TPC-H** | **master** | **this PR** |
| -- | --: | --: |
| 01 | 5,421 | 5,039 |
| 02 | 402 | 3,968
