[GitHub] incubator-quickstep issue #92: Refactor Generators in Optimizer

2016-08-16 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/92 Just squashed and rebased the commits. Will merge it once travis-ci returns green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-quickstep issue #92: Refactor Generators in Optimizer

2016-08-16 Thread zuyu
Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/92 @jianqiao I have added some descriptions as requested. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-quickstep issue #92: Refactor Generators in Optimizer

2016-08-16 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/92 LGTM. Could you add a brief paragraph in this PR's top comment to describe the purpose of this change? --- If your project is set up for it, you can reply to this email and have your re