Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/362
---
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/362#discussion_r224539118
--- Diff: third_party/src/tmb/tests/message_bus_unittest_common.h ---
@@ -205,7 +207,7 @@ class ConnectorThread : public Thread {
}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/362#discussion_r224538733
--- Diff: utility/lip_filter/SingleIdentityHashFilter.hpp ---
@@ -66,6 +66,8 @@ class SingleIdentityHashFilter : public LIPFilter {
DCHECK_
GitHub user johnchronis opened a pull request:
https://github.com/apache/incubator-quickstep/pull/362
Add virtual destructors where needed to remove compile time errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnchronis
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/361
Optimized the common case in pure-memory TMB.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuyu/incubator-quickstep tmb-opt
Altern
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/360
---
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/360
Fix the inclusion guard of ForemanSingleNode.hpp file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hbdeshmukh/incubator-quick
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/359
---
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/359
Fixed the build issues regarding tmb benchmark.
This minor PR fixed some build issues related to the tmb benchmark
directory.
You can merge this pull request into a Git repository by runn
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/358
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/355
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/357
---
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/355#discussion_r192827208
--- Diff: storage/CMakeLists.txt ---
@@ -120,6 +120,11 @@ configure_file (
QS_PROTOBUF_GENERATE_CPP(storage_AggregationOperationState_proto_src
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/358
Fix a bug in HashJoinOperator
This PR fixes a bug in `HashJoinOperator` w.r.t. the swapping of
probe/build sides in a previous PR.
You can merge this pull request into a Git reposito
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/355#discussion_r190785380
--- Diff: storage/DataProviderThread.hpp ---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/355#discussion_r190785209
--- Diff: storage/DataProviderThread.hpp ---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/357
Fixed the command execution bug in the distributed version.
This PR fixed the command execution bugs in the distributed version, and
now it is consistent with the single-node version.
You
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/338#discussion_r189711855
--- Diff: storage/StorageManager.cpp ---
@@ -687,8 +687,13 @@ StorageManager::BlockHandle
StorageManager::loadBlockOrBlob(
#ifdef QUICKSTEP_DI
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/356
DO NOT MERGE: Added the grpc in Travis CI.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuyu/incubator-quickstep travis-grpc-new
A
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/355#discussion_r189664042
--- Diff: storage/DataProviderThread.hpp ---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/355
QUICKSTEP-127 Data provider thread
- Thread used for receiving block requests from clients and sending the
contents of a block back to the client.
You can merge this pull reques
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/347
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/353
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/354
---
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/354
Fixed the union-all elimiation case where some project expression is not an
AttributeReference.
This PR fixed for the case where the only one child of the union-all query
is non-empty, an
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/353
Minor bug fixes and refactors.
This PR contains most work from @jianqiao when working on the datalog
branch, including bug fix and some refactors.
You can merge this pull request into a G
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/351
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/352
---
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/352
QUICKSTEP-125: Fixed the non-determinism in JoinReordering.
This PR fixed the bug in join reordering due to the pointer address-based
comparison. It also added a new rule that prefers the
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r186265132
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -966,7 +975,9 @@ void ExecutionGenerator::convertHashJoin(const
P::HashJoinPtr &physical_pl
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/351
Use Exactness info in Catalog stats.
When we get stats info, we should not ignore the `exactness` flag.
This PR checks the flag before answer whether a stat exists.
You can merge
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/348
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/350
---
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/350
Fixed the bug regarding EliminateEmptyNode and InsertSelection.
This PR fixed a bug regarding `EliminateEmptyNode` and `InsertSelection`
that could be easily reproduced as the following:
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/349
---
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/318
---
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/349
Fixed the bug regarding EliminateEmptyNode and Analyze command.
This PR fixed a bug introduced in #342. The problem was that that rule does
not distinguish between an analyze command and a
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/348
Refactored ScalarCaseExpression.
This PR does the following:
1. Moved the static methods into the cpp file.
1. Added a fast path for `getAllValuesForJoin`, similar to other existi
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/347
DO NOT MERGE: QUICKSTEP-121: Added the self-join support.
This PR added the self-join support by assigning the join side info,
instead of relying on the relation id.
Note that now
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/346
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/346
Add a python script to auto fix CMakeLists files
This PR adds a script that intends to help improve developer productivity
by automatically fixing `CMakeLists.txt` files for the Quicks
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/343
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/344
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/345
---
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/345
Minor code style fix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuyu/incubator-quickstep code-style-fix
Alternatively you can r
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/344
Quickstep-123: Fixed the missing 'has_repartition' in FilterJoin.
Added the missing `has_repartition` in `FilterJoin`.
You can merge this pull request into a Git repository by running:
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/343
Fix all CMakeLists.txt for automated processing
This PR fixes and adjusts the style of all `CMakeLists.txt` so that they
become stable (i.e. well-formatted) to be processed by an autom
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/342
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/341
---
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/342
DO NOT MERGE: Quickstep-119: Added the rule that eliminates a HashJoin to a
Selection if possible.
This PR adds an optimization rule that eliminates a join if at least one
side is empty.
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/341
Used MergeFrom instead of CopyFrom.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuyu/incubator-quickstep use-merge-from
Alternati
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/340
---
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/340#discussion_r182228415
--- Diff: storage/StorageErrors.hpp ---
@@ -61,9 +61,16 @@ class BlockMemoryTooSmall : public std::exception {
**/
class BlockNotFo
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/340#discussion_r182211596
--- Diff: storage/StorageErrors.hpp ---
@@ -61,9 +61,16 @@ class BlockMemoryTooSmall : public std::exception {
**/
class BlockNotFoun
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/340#discussion_r182212888
--- Diff: storage/StorageErrors.hpp ---
@@ -61,9 +61,16 @@ class BlockMemoryTooSmall : public std::exception {
**/
class BlockNotFoun
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/340#discussion_r182210127
--- Diff: storage/StorageErrors.hpp ---
@@ -61,9 +61,16 @@ class BlockMemoryTooSmall : public std::exception {
**/
class BlockNotFoun
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/340
More informative error for BlockNotFound exception for debugging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hbdeshmukh/incu
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/339
---
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/339
Upgrade cmake version.
Upgrading CMake, as is required by glog which is a third party dependency
(discussed in #327).
You can merge this pull request into a Git repository by runni
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/336
---
Github user yuanchenl closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/335
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/338
---
GitHub user yuanchenl opened a pull request:
https://github.com/apache/incubator-quickstep/pull/338
Fixed the gRPC Problem for Data Exchange
Fixed the data exchange problem encountered in distributed quickstep.
It turned out that problem of data exchange is caused by the gRP
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/337
---
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/337
Check File Handle in TextScanWorkOrder to avoid segfault.
This PR avoids the segfault mentioned
[here](https://github.com/apache/incubator-quickstep/pull/336#issuecomment-370674172)
when
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/336
Fixed the bug that Executor / Cli does not create directory for
StorageManager.
Assigned to @jianqiao.
@yuanchenl Please test this PR using Docker. Thanks!
You can merge this pul
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/334
---
GitHub user yuanchenl opened a pull request:
https://github.com/apache/incubator-quickstep/pull/335
Dockerfile Support for Distributed Deployment
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuanchenl/incubator-quickstep maste
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/334
Fix iwyu include path
This PR fixes the third-party library include paths for the iwyu
(include-what-you-use) tool.
You can merge this pull request into a Git repository by running:
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/332
---
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/332#discussion_r170369358
--- Diff: query_optimizer/cost_model/StarSchemaSimpleCostModel.cpp ---
@@ -493,7 +493,7 @@ std::size_t
StarSchemaSimpleCostModel::getNumDistinc
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/333
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/333
Fix SeparateChainingHashTable::resize()
This PR fixes the problem that Quickstep hangs when resizing
`SeparateChainingHashTable` during the execution of `BuildHashOperator`.
H
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/332#discussion_r167114902
--- Diff: query_optimizer/cost_model/StarSchemaSimpleCostModel.cpp ---
@@ -493,7 +493,7 @@ std::size_t
StarSchemaSimpleCostModel::getNumDistinctVal
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/332
Small adjustments in star schema cost model for # distinct values estimation
This PR has a small adjustment in star schema cost model for # of distinct
values estimation, together with
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/331
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/331
Add a cmake option to handle the Travis CI timeout problem.
This PR adds a cmake option `ENABLE_COMPARISON_INLINE_EXPANSION` to allow
disabling of method specialization in various `Com
Github user dylanpbacon closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/322
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/329
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/330
---
GitHub user hbdeshmukh reopened a pull request:
https://github.com/apache/incubator-quickstep/pull/330
Upgraded benchmark third party library.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hbdeshmukh/incubator-quickstep
benchm
Github user hbdeshmukh closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/330
---
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/330
Upgraded benchmark third party library.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hbdeshmukh/incubator-quickstep
benchmar
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/329
IDE Documentation fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hbdeshmukh/incubator-quickstep
ide_documentation_fix
A
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/319
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/328
---
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/328#discussion_r158369912
--- Diff: parser/ParseString.hpp ---
@@ -115,4 +115,4 @@ class ParseString : public ParseTreeNode {
} // namespace quickstep
-
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/328#discussion_r158370165
--- Diff: storage/BasicColumnStoreValueAccessor.hpp ---
@@ -108,25 +109,25 @@ class BasicColumnStoreValueAccessorHelper {
}
temp
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/328
QUICKSTEP-114 Upgrade cpplint
- Added several missing headers.
- Modified the lint_everything file to add the command line flags.
You can merge this pull request into a Git repos
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/327
---
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/327
Remove glog source code from third party
- glog source code is now downloaded through the download script.
- Added patches for glog.
You can merge this pull request into a Git re
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/326
---
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/326#discussion_r154230379
--- Diff: query_optimizer/rules/ReferencedBaseRelations.hpp ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/326#discussion_r154229622
--- Diff: query_optimizer/rules/ReferencedBaseRelations.hpp ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/300
---
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/326
QUICKSTEP-112 Get the list of referenced base relations
- Find the base relations that are referenced in a query.
- The referenced relations are stored in the QueryHandle.
- S
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/325#discussion_r153019903
--- Diff: transaction/AdmissionControl.hpp ---
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/325#discussion_r153019919
--- Diff: transaction/AdmissionControl.hpp ---
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/325#discussion_r153019967
--- Diff: transaction/CMakeLists.txt ---
@@ -125,8 +138,8 @@ target_link_libraries(quickstep_transaction
quickstep_transa
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/325#discussion_r153020128
--- Diff: transaction/CompatibilityChecker.hpp ---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
1 - 100 of 1804 matches
Mail list logo