[GitHub] incubator-quickstep pull request #331: Add a cmake option to handle the Trav...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/331


---

[GitHub] incubator-quickstep pull request #331: Add a cmake option to handle the Trav...

[jianqiao]

GitHub user jianqiao opened a pull request:

https://github.com/apache/incubator-quickstep/pull/331

Add a cmake option to handle the Travis CI timeout problem.

This PR adds a cmake option `ENABLE_COMPARISON_INLINE_EXPANSION` to allow 
disabling of method specialization in various `Comparison`'s.

Turing the flag `OFF` will greatly reduce Quickstep compile time -- thus 
improving development productivity as well as fixing the Travis CI timeout 
problem. Note that the flag is by default `ON`, and will be [turned 
off](https://github.com/apache/incubator-quickstep/blob/539e1ebe09b5d1a2d86069ed1fdc6e9fb38c5ce7/.travis.yml#L80)
 during the Travis test.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-quickstep fix-travis-timeout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #331


commit 539e1ebe09b5d1a2d86069ed1fdc6e9fb38c5ce7
Author: Jianqiao Zhu 
Date:   2018-02-02T23:27:59Z

Add a flag to allow disabling of Comparison inline expansion to enable 
acceleration of Quickstep build.

(for development productivity as well as solving the Travis CI timeout 
problem)




---