Re: [racket-dev] strange performance on regexp-match: proposed patch

2011-05-03 Thread Eli Barzilay
On Wednesday, Danny Yoo wrote: > I've isolated a performance issue on form-urlencoded->alist. On > strings with very long key/values, the code appears to consume an > unusual amount of memory. Does the following look ok? I made a different change that simplifies the code and should be as fast as

Re: [racket-dev] strange performance on regexp-match: proposed patch

2011-04-27 Thread Robby Findler
I've worked on those fns in the past but have no idea if that is a good change. I'd say that the thing to do is to run the tests and then think of a few more tests based on your new code (maybe use random testing to compare te two versions of the fns) and then go ahead and commit. Robby On Wedne

[racket-dev] strange performance on regexp-match: proposed patch

2011-04-27 Thread Danny Yoo
I've isolated a performance issue on form-urlencoded->alist. On strings with very long key/values, the code appears to consume an unusual amount of memory. Does the following look ok? diff --git a/collects/net/uri-codec-unit.rkt b/collects/net/uri-codec-unit.rkt index c992d62..01d4c05 100644 --