I regularly rebase and force-update pull request commits. GitHub even notices when a commit is out of date and hides the comments, if they're made there. So I encourage you to do this.
Sam On Sat, Oct 19, 2013 at 10:56 PM, David T. Pierson <d...@mindstory.com> wrote: > Thank you to everyone who provided feedback on my Guide chapter on > concurrency. I think I've addressed everyone's suggestions in my latest > version [1]. > > My question at this point is whether to rebase before submitting a pull > request. If the initial commit had not been made public I would > obviously want to rebase and squash. But since it was publicized here > and people commented, should I leave it as is? > > Since this is a relatively minor patch, perhaps it doesn't matter so > much for this time. But it would be good to know whether there is a > general rule for when not to rebase/squash. > > David > > [1] https://github.com/davidtpierson/racket/tree/concurrency-docs > _________________________ > Racket Developers list: > http://lists.racket-lang.org/dev _________________________ Racket Developers list: http://lists.racket-lang.org/dev