Re: [racket-dev] [plt] Push #27071: master branch updated

2013-07-05 Thread Sam Tobin-Hochstadt
All of the other tests for the core are in the racket-test package, so
that's where the ones for json belong too.
On Jul 5, 2013 7:28 PM, "Eli Barzilay"  wrote:

> On Tuesday, sa...@racket-lang.org wrote:
> >
> > 37c87ec Sam Tobin-Hochstadt  2013-07-02 12:24
> > :
> > | Move json tests to racket-test pkg.
> > :
> >   R {racket/lib/collects/json/tests =>
> pkgs/racket-pkgs/racket-test/tests/json}/json.rkt (100%)
>
> Why did you do this move?  Having tests bee in the same directory as
> the code makes it much easier to maintain, and I mean "same directory"
> in both the place where the file gets installed and being in the same
> package.
>
> (In case it's not obvious where I'm coming from: when I wanted to test
> the recent commit, I resorted to grepping the tree for the file -- I
> view such grepping as indicators of organizational failures that
> should not be needed even after the repo is split, and commits like
> this make things worse in this regard.)
>
> --
>   ((lambda (x) (x x)) (lambda (x) (x x)))  Eli Barzilay:
> http://barzilay.org/   Maze is Life!
>
_
  Racket Developers list:
  http://lists.racket-lang.org/dev


Re: [racket-dev] [plt] Push #27071: master branch updated

2013-07-05 Thread Eli Barzilay
On Tuesday, sa...@racket-lang.org wrote:
> 
> 37c87ec Sam Tobin-Hochstadt  2013-07-02 12:24
> :
> | Move json tests to racket-test pkg.
> :
>   R {racket/lib/collects/json/tests => 
> pkgs/racket-pkgs/racket-test/tests/json}/json.rkt (100%)

Why did you do this move?  Having tests bee in the same directory as
the code makes it much easier to maintain, and I mean "same directory"
in both the place where the file gets installed and being in the same
package.

(In case it's not obvious where I'm coming from: when I wanted to test
the recent commit, I resorted to grepping the tree for the file -- I
view such grepping as indicators of organizational failures that
should not be needed even after the repo is split, and commits like
this make things worse in this regard.)

-- 
  ((lambda (x) (x x)) (lambda (x) (x x)))  Eli Barzilay:
http://barzilay.org/   Maze is Life!
_
  Racket Developers list:
  http://lists.racket-lang.org/dev