Re: [racket-dev] [racket] Insert Pict Box menu item not found in DrRacket
Yes, I think that would be great. Which string constants specifically were you planning to remove? I should probably check that they aren't used on planet. Robby On Mon, Jul 9, 2012 at 7:53 PM, Asumu Takikawa as...@ccs.neu.edu wrote: On 2012-07-08 15:47:27 +0800, Grecks Grecks wrote: Hi, I post an issue on github 2 month before. [1]https://github.com/plt/racket/issues/101 For devs: while fixing this, I noticed that the code that used to implement this menu item is still around (along with string constants) but are unused. Should I remove that code while I'm at it? Cheers, Asumu _ Racket Developers list: http://lists.racket-lang.org/dev _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] [racket] Insert Pict Box menu item not found in DrRacket
On 2012-07-10 07:20:59 -0500, Robby Findler wrote: Which string constants specifically were you planning to remove? I should probably check that they aren't used on planet. The `slideshow-insert-pict-box` constant doesn't appear to be used. There are also `slideshow-hide-picts, `slideshow-show-picts, `slideshow-cannot-show-picts` as well---I'm not sure whether these are removable or not (I see they're used for a pict-snip%'s popup menu but I can't seem to trigger that menu in DrRacket). Cheers, Asumu _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] [racket] Insert Pict Box menu item not found in DrRacket
Version 1.2 of cdrswift.plt seems to use the slideshow-insert-pict-box string constant, but it is up to version 1.5 now. http://planet.racket-lang.org/display.ss?package=cdrswift.pltowner=dignatof Probably best to just leave them in for now. Robby On Tue, Jul 10, 2012 at 8:48 AM, Asumu Takikawa as...@ccs.neu.edu wrote: On 2012-07-10 07:20:59 -0500, Robby Findler wrote: Which string constants specifically were you planning to remove? I should probably check that they aren't used on planet. The `slideshow-insert-pict-box` constant doesn't appear to be used. There are also `slideshow-hide-picts, `slideshow-show-picts, `slideshow-cannot-show-picts` as well---I'm not sure whether these are removable or not (I see they're used for a pict-snip%'s popup menu but I can't seem to trigger that menu in DrRacket). Cheers, Asumu _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] [racket] Insert Pict Box menu item not found in DrRacket
At Tue, 10 Jul 2012 09:13:24 -0500, Robby Findler wrote: Version 1.2 of cdrswift.plt seems to use the slideshow-insert-pict-box string constant, but it is up to version 1.5 now. http://planet.racket-lang.org/display.ss?package=cdrswift.pltowner=dignatof Probably best to just leave them in for now. Should we deprecate it and put it on a 1 year counter? (like `mzlib/class100') Vincent _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] [racket] Insert Pict Box menu item not found in DrRacket
I was thinking along similar lines. But maybe it would be helpful to do this for all of the unused string-constants in the tree? We could even move them into a planet package now. Robby On Tue, Jul 10, 2012 at 10:54 AM, Vincent St-Amour stamo...@ccs.neu.edu wrote: At Tue, 10 Jul 2012 09:13:24 -0500, Robby Findler wrote: Version 1.2 of cdrswift.plt seems to use the slideshow-insert-pict-box string constant, but it is up to version 1.5 now. http://planet.racket-lang.org/display.ss?package=cdrswift.pltowner=dignatof Probably best to just leave them in for now. Should we deprecate it and put it on a 1 year counter? (like `mzlib/class100') Vincent _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] [racket] Insert Pict Box menu item not found in DrRacket
At Tue, 10 Jul 2012 11:23:04 -0500, Robby Findler wrote: I was thinking along similar lines. But maybe it would be helpful to do this for all of the unused string-constants in the tree? Good idea. Vincent _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] [racket] Insert Pict Box menu item not found in DrRacket
On 2012-07-08 15:47:27 +0800, Grecks Grecks wrote: Hi, I post an issue on github 2 month before. [1]https://github.com/plt/racket/issues/101 For devs: while fixing this, I noticed that the code that used to implement this menu item is still around (along with string constants) but are unused. Should I remove that code while I'm at it? Cheers, Asumu _ Racket Developers list: http://lists.racket-lang.org/dev
