Re: [racket-dev] Typed Racket support for Ephemerons

2011-04-27 Thread Vincent St-Amour
Fixed. Thanks for the report! Vincent At Wed, 27 Apr 2011 11:14:48 +0200, Pierpaolo Bernardi wrote: > > BTW, I think there are a couple of typos in: > > "15.2 Ephemerons > An ephemeron [Hayes97] is a generalization of a weak box (see Weak > Boxes). Instead of just containing one value, an e___

Re: [racket-dev] Typed Racket support for Ephemerons

2011-04-27 Thread Pierpaolo Bernardi
BTW, I think there are a couple of typos in: "15.2 Ephemerons An ephemeron [Hayes97] is a generalization of a weak box (see Weak Boxes). Instead of just containing one value, an e___m___phemeron holds two values: one that is considered the value of the ephemeron and another that is the ephemeron’s

Re: [racket-dev] Typed Racket support for Ephemerons

2011-04-26 Thread Eric Dobson
The tests all pass (for me). -Eric On Tue, Apr 26, 2011 at 2:54 PM, Sam Tobin-Hochstadt wrote: > On Tue, Apr 26, 2011 at 2:19 PM, Eric Dobson wrote: >> I have added support for ephemerons to Typed Racket, and submitted a pull >> request on Github (https://github.com/plt/racket/pull/5). This pa

Re: [racket-dev] Typed Racket support for Ephemerons

2011-04-26 Thread Sam Tobin-Hochstadt
On Tue, Apr 26, 2011 at 2:19 PM, Eric Dobson wrote: > I have added support for ephemerons to Typed Racket, and submitted a pull > request on Github (https://github.com/plt/racket/pull/5). This patch is > supposed to fix PR 11633. All of this looks good, except that `EphemeronTop' is unnecessary

Re: [racket-dev] Typed Racket support for Ephemerons

2011-04-26 Thread Vincent St-Amour
I've had a quick look at your patch, and it looks good to me. Did you make sure that all of TR's tests still pass? I'll pull that and commit it for you. Vincent At Tue, 26 Apr 2011 14:19:38 -0400, Eric Dobson wrote: > > I have added support for ephemerons to Typed Racket, and submitted a pull

[racket-dev] Typed Racket support for Ephemerons

2011-04-26 Thread Eric Dobson
I have added support for ephemerons to Typed Racket, and submitted a pull request on Github (https://github.com/plt/racket/pull/5). This patch is supposed to fix PR 11633. Is there anything else I should do to get this patch integrated? -Eric _