Re: [racket-dev] git rebase/squash my commits before submitting a pull request?

2013-10-20 Thread Sam Tobin-Hochstadt
I regularly rebase and force-update pull request commits. GitHub even notices when a commit is out of date and hides the comments, if they're made there. So I encourage you to do this. Sam On Sat, Oct 19, 2013 at 10:56 PM, David T. Pierson d...@mindstory.com wrote: Thank you to everyone who

[racket-dev] git rebase/squash my commits before submitting a pull request?

2013-10-19 Thread David T. Pierson
Thank you to everyone who provided feedback on my Guide chapter on concurrency. I think I've addressed everyone's suggestions in my latest version [1]. My question at this point is whether to rebase before submitting a pull request. If the initial commit had not been made public I would